drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings V2
Subsystems (2)
PATCH 2/4 drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings V2
With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS will be disabled. However, the buggy code makes this actually not working as expected.
- V2: clear all OD flags excpet DPMTABLE_OD_UPDATE_VDDC
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +4 -5
@@ -2466,11 +2466,6 @@ static void vega10_check_dpm_table_updated(struct pp_hwmgr *hwmgr)return ; } } - -if (data->need_update_dpm_table &DPMTABLE_OD_UPDATE_VDDC ) { - data->need_update_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC ; - data->need_update_dpm_table |=DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_OD_UPDATE_MCLK ; - } }/**
@@ -3683,6 +3678,10 @@ static int vega10_set_power_state_tasks(struct pp_hwmgr *hwmgr,vega10_update_avfs (hwmgr); +/* +* Clear all OD flags except DPMTABLE_OD_UPDATE_VDDC. +* That will help to keep AVFS disabled. +*/ data->need_update_dpm_table &=DPMTABLE_OD_UPDATE_VDDC ;return 0 ;
Signature · 6 lines
2.21.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Alex Deucher
Acked-byQuoted 9 lines · Evan Quan
With user specified
voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS will be disabled. However, the buggy code makes this actually not working as expected.- V2: clear all OD flags excpet
DPMTABLE_OD_UPDATE_VDDCChange-Id Ifa83a6255bb3f6fa4bdb4de616521cb7bab6830aSigned-off-by Evan Quan <[email protected]>
Quoted 34 lines
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +4
-6@@ -2466,11 +2466,6 @@ static void vega10_check_dpm_table_updated(struct pp_hwmgr *hwmgr)return ; } } - -if (data->need_update_dpm_table &DPMTABLE_OD_UPDATE_VDDC ) { - data->need_update_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC ; - data->need_update_dpm_table |=DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_OD_UPDATE_MCLK ; - } }/** @@ -3683,6 +3678,10 @@ static int vega10_set_power_state_tasks(struct pp_hwmgr *hwmgr,vega10_update_avfs (hwmgr); +/* +* Clear all OD flags except DPMTABLE_OD_UPDATE_VDDC. +* That will help to keep AVFS disabled. +*/ data->need_update_dpm_table &=DPMTABLE_OD_UPDATE_VDDC ;return 0 ; --2.21.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx