Add support for Maxim 77663 MFD
Subsystems (4)
v4 cover Add support for Maxim 77663 MFD
Hello,
This series adds support for the Maxim 77663 chip that provides PMIC, RTC, GPIO and watchdog timer functionality. The hardware is very similar to the Maxim 77620/20024 hardware units that are already supported by the kernel, hence we will reuse the existing drivers for 77663. The GPIO, regulator, RTC and watchdog timer functionality was tested on a Nexus 7 tablet that has the Max77663 chip, everything is working perfectly fine. I'm looking at upstreaming support for that tablet device and Max77663 is one of the core components that are currently missing in the upstream kernel.
Changelog:
v4: Addressed review comments from Rob Herring to v3 by making use of
generic "system-power-controller" property and making couple other minor cosmetic changes. Added Mark's Brown a-b to the regulator-patch.
v3: Dropped "Support device-tree properly" patch since turned out that
I2C core takes care of the device-tree matching and I wasn't aware of it.
v2: Added PINCTRL sub-device to Max77663 MFD as it looks compatible with
77620.
Added new "maxim,system-power-controller" OF property.
Patch "Support device-tree properly" now doesn't remove driver's "id_table" since potentially it could have some use in the downstream kernel forks and it doesn't hurt to keep it around.
Dmitry Osipenko (6):
dt-bindings: mfd: max77620: Add compatible for Maxim 77663
dt-bindings: mfd: max77620: Add system-power-controller property
mfd: max77620: Fix swapped FPS_PERIOD_MAX_US values
mfd: max77620: Support Maxim 77663
mfd: max77620: Provide system power-off functionality
regulator: max77620: Support Maxim 77663
.../devicetree/bindings/mfd/max77620.txt | 9 +- drivers/mfd/max77620.c | 87 ++++++++++++++++++- drivers/regulator/max77620-regulator.c | 26 +++++- include/linux/mfd/max77620.h | 5 +- 4 files changed, 122 insertions(+), 5 deletions(-)
Signature · 1 line
2.21.0
PATCH v4 1/6 dt-bindings: mfd: max77620: Add compatible for Maxim 77663
Maxim 77663 has a few minor differences in regards to hardware interface and available capabilities by comparing it with 77620 and 20024 models, hence re-use 77620 device-tree binding for the 77663.
--- Documentation/devicetree/bindings/mfd/max77620.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/max77620.txt +3 -1
@@ -4,7 +4,8 @@ Required properties: ------------------- - compatible: Must be one of "maxim,max77620" - "maxim,max20024". + "maxim,max20024" + "maxim,max77663" - reg: I2C device address. Optional properties:
@@ -105,6 +106,7 @@ Optional properties: Here supported time periods by device in microseconds are as follows: MAX77620 supports 40, 80, 160, 320, 640, 1280, 2560 and 5120 microseconds. MAX20024 supports 20, 40, 80, 160, 320, 640, 1280 and 2540 microseconds. +MAX77663 supports 20, 40, 80, 160, 320, 640, 1280 and 2540 microseconds. -maxim,power-ok-control: configure map power ok bit 1: Enables POK(Power OK) to control nRST_IO and GPIO1
Signature · 1 line
2.21.0
Re: [PATCH v4 1/6] dt-bindings: mfd: max77620: Add compatible for Maxim 77663
Quoted 6 lines · Dmitry Osipenko
Maxim 77663 has a few minor differences in regards to hardware interface and available capabilities by comparing it with 77620 and 20024 models, hence re-use 77620 device-tree binding for the 77663.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Dmitry Osipenko <[email protected]>
For my own reference:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v4 2/6 dt-bindings: mfd: max77620: Add system-power-controller property
In reply to Dmitry OsipenkoDocument new generic property that designates the PMIC as the system's power controller.
--- Documentation/devicetree/bindings/mfd/max77620.txt | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mfd/max77620.txt +5 -0
@@ -18,6 +18,11 @@ Optional properties: IRQ numbers for different interrupt source of MAX77620 are defined at dt-bindings/mfd/max77620.h. +- system-power-controller: Indicates that this PMIC is controlling the + system power, see [1] for more details. + +[1] Documentation/devicetree/bindings/power/power-controller.txt + Optional subnodes and their properties: =======================================
Signature · 1 line
2.21.0
Re: [PATCH v4 2/6] dt-bindings: mfd: max77620: Add system-power-controller property
Quoted 8 lines · Dmitry Osipenko
Document new generic property that designates the PMIC as the system's power controller.
Signed-off-by Dmitry Osipenko <[email protected]>--- Documentation/devicetree/bindings/mfd/max77620.txt | 5 +++++ 1 file changed, 5 insertions(+)
Re: [PATCH v4 2/6] dt-bindings: mfd: max77620: Add system-power-controller property
In reply to Dmitry OsipenkoQuoted 4 lines · Dmitry Osipenko
Document new generic property that designates the PMIC as the system's power controller.
Signed-off-by Dmitry Osipenko <[email protected]>
For my own reference:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v4 3/6 mfd: max77620: Fix swapped FPS_PERIOD_MAX_US values
In reply to Dmitry OsipenkoThe FPS_PERIOD_MAX_US definitions are swapped for MAX20024 and MAX77620, fix it.
--- include/linux/mfd/max77620.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mfd/max77620.h +2 -2
@@ -136,8 +136,8 @@#define MAX77620_FPS_PERIOD_MIN_US 40#define MAX20024_FPS_PERIOD_MIN_US 20 -#define MAX77620_FPS_PERIOD_MAX_US 2560 -#define MAX20024_FPS_PERIOD_MAX_US 5120 +#define MAX20024_FPS_PERIOD_MAX_US 2560 +#define MAX77620_FPS_PERIOD_MAX_US 5120#define MAX77620_REG_FPS_GPIO1 0x54#define MAX77620_REG_FPS_GPIO2 0x55
Signature · 1 line
2.21.0
Re: [PATCH v4 3/6] mfd: max77620: Fix swapped FPS_PERIOD_MAX_US values
Quoted 8 lines · Dmitry Osipenko
The
FPS_PERIOD_MAX_USdefinitions are swapped for MAX20024 and MAX77620, fix it.Cc stable <[email protected]>Signed-off-by Dmitry Osipenko <[email protected]>--- include/linux/mfd/max77620.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
For my own reference:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v4 4/6 mfd: max77620: Support Maxim 77663
In reply to Dmitry OsipenkoAdd support for Maxim 77663 using the Max77620 driver. The hardware is very similar to Max77663/20024, although there are couple minor differences.
--- drivers/mfd/max77620.c | 69 +++++++++++++++++++++++++++++++++++- include/linux/mfd/max77620.h | 1 + 2 files changed, 69 insertions(+), 1 deletion(-)
drivers/mfd/max77620.c +68 -1
@@ -111,6 +111,26 @@ static const struct mfd_cell max20024_children[] = { }, }; +static const struct mfd_cell max77663_children[] = { + { .name ="max77620-pinctrl" , }, + { .name ="max77620-clock" , }, + { .name ="max77663-pmic" , }, + { .name ="max77620-watchdog" , }, + { + .name ="max77620-gpio" , + .resources = gpio_resources, + .num_resources =ARRAY_SIZE (gpio_resources), + }, { + .name ="max77620-rtc" , + .resources = rtc_resources, + .num_resources =ARRAY_SIZE (rtc_resources), + }, { + .name ="max77663-power" , + .resources = power_resources, + .num_resources =ARRAY_SIZE (power_resources), + }, +}; +static const struct regmap_range max77620_readable_ranges[] = {regmap_reg_range (MAX77620_REG_CNFGGLBL1 ,MAX77620_REG_DVSSD4 ), };
@@ -171,6 +191,35 @@ static const struct regmap_config max20024_regmap_config = { .volatile_table = &max77620_volatile_table, }; +static const struct regmap_range max77663_readable_ranges[] = { +regmap_reg_range (MAX77620_REG_CNFGGLBL1 ,MAX77620_REG_CID5 ), +}; + +static const struct regmap_access_table max77663_readable_table = { + .yes_ranges = max77663_readable_ranges, + .n_yes_ranges =ARRAY_SIZE (max77663_readable_ranges), +}; + +static const struct regmap_range max77663_writable_ranges[] = { +regmap_reg_range (MAX77620_REG_CNFGGLBL1 ,MAX77620_REG_CID5 ), +}; + +static const struct regmap_access_table max77663_writable_table = { + .yes_ranges = max77663_writable_ranges, + .n_yes_ranges =ARRAY_SIZE (max77663_writable_ranges), +}; + +static const struct regmap_config max77663_regmap_config = { + .name ="power-slave" , + .reg_bits =8 , + .val_bits =8 , + .max_register =MAX77620_REG_CID5 +1 , + .cache_type =REGCACHE_RBTREE , + .rd_table = &max77663_readable_table, + .wr_table = &max77663_writable_table, + .volatile_table = &max77620_volatile_table, +}; +/* * MAX77620 and MAX20024 has the following steps of the interrupt handling * for TOP interrupts:
@@ -240,6 +289,9 @@ static int max77620_get_fps_period_reg_value(struct max77620_chip *chip,case MAX77620 : fps_min_period =MAX77620_FPS_PERIOD_MIN_US ;break ; +case MAX77663 : + fps_min_period =MAX20024_FPS_PERIOD_MIN_US ; +break ;default :return -EINVAL ; }
@@ -274,6 +326,9 @@ static int max77620_config_fps(struct max77620_chip *chip,case MAX77620 : fps_max_period =MAX77620_FPS_PERIOD_MAX_US ;break ; +case MAX77663 : + fps_max_period =MAX20024_FPS_PERIOD_MAX_US ; +break ;default :return -EINVAL ; }
@@ -375,6 +430,9 @@ static int max77620_initialise_fps(struct max77620_chip *chip) } skip_fps: +if (chip->chip_id ==MAX77663 ) +return 0 ; +/* Enable wake on EN0 pin */ ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
@@ -453,6 +511,11 @@ static int max77620_probe(struct i2c_client *client, n_mfd_cells =ARRAY_SIZE (max20024_children); rmap_config = &max20024_regmap_config;break ; +case MAX77663 : + mfd_cells = max77663_children; + n_mfd_cells =ARRAY_SIZE (max77663_children); + rmap_config = &max77663_regmap_config; +break ;default :dev_err (chip->dev,"ChipID is invalid %d\n" , chip->chip_id);return -EINVAL ;
@@ -546,6 +609,9 @@ static int max77620_i2c_suspend(struct device *dev)return ret; } +if (chip->chip_id ==MAX77663 ) + goto out; +/* Disable WK_EN0 */ ret =regmap_update_bits (chip->rmap,MAX77620_REG_ONOFFCNFG2 ,MAX77620_ONOFFCNFG2_WK_EN0 ,0 );
@@ -581,7 +647,7 @@ static int max77620_i2c_resume(struct device *dev)* For MAX20024: No need to configure WKEN0 on resume as * it is configured on Init. */ -if (chip->chip_id ==MAX20024 ) +if (chip->chip_id ==MAX20024 || chip->chip_id ==MAX77663 ) goto out;/* Enable WK_EN0 */
@@ -603,6 +669,7 @@ static int max77620_i2c_resume(struct device *dev)static const struct i2c_device_id max77620_id[] = { {"max77620" ,MAX77620 }, {"max20024" ,MAX20024 }, + {"max77663" ,MAX77663 }, {}, };
include/linux/mfd/max77620.h +1 -0
@@ -324,6 +324,7 @@ enum max77620_fps_src {enum max77620_chip_id {MAX77620 ,MAX20024 , +MAX77663 , };struct max77620_chip {
Signature · 1 line
2.21.0
Re: [PATCH v4 4/6] mfd: max77620: Support Maxim 77663
Quoted 9 lines · Dmitry Osipenko
Add support for Maxim 77663 using the Max77620 driver. The hardware is very similar to Max77663/20024, although there are couple minor differences.
Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/mfd/max77620.c | 69 +++++++++++++++++++++++++++++++++++- include/linux/mfd/max77620.h | 1 + 2 files changed, 69 insertions(+), 1 deletion(-)
For my own reference:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v4 5/6 mfd: max77620: Provide system power-off functionality
In reply to Dmitry OsipenkoProvide system power-off functionality that allows to turn off machine gracefully.
--- drivers/mfd/max77620.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/mfd/max77620.c +18 -0
@@ -37,6 +37,8 @@#include <linux/regmap.h> #include <linux/slab.h> +static struct max77620_chip *max77620_scratch; +static const struct resource gpio_resources[] = {DEFINE_RES_IRQ (MAX77620_IRQ_TOP_GPIO ), };
@@ -481,6 +483,15 @@ static int max77620_read_es_version(struct max77620_chip *chip)return ret; } +static void max77620_pm_power_off (void ) +{ +struct max77620_chip *chip = max77620_scratch; + +regmap_update_bits (chip->rmap,MAX77620_REG_ONOFFCNFG1 , +MAX77620_ONOFFCNFG1_SFT_RST , +MAX77620_ONOFFCNFG1_SFT_RST ); +} +static int max77620_probe (struct i2c_client *client,const struct i2c_device_id *id) {
@@ -488,6 +499,7 @@ static int max77620_probe(struct i2c_client *client,struct max77620_chip *chip;const struct mfd_cell *mfd_cells;int n_mfd_cells; +bool pm_off;int ret; chip =devm_kzalloc (&client->dev,sizeof (*chip),GFP_KERNEL );
@@ -554,6 +566,12 @@ static int max77620_probe(struct i2c_client *client,return ret; } + pm_off =of_device_is_system_power_controller (client->dev.of_node); +if (pm_off && !pm_power_off) { + max77620_scratch = chip; + pm_power_off = max77620_pm_power_off; + } +return 0 ; }
Signature · 1 line
2.21.0
Re: [PATCH v4 5/6] mfd: max77620: Provide system power-off functionality
Quoted 7 lines · Dmitry Osipenko
Provide system power-off functionality that allows to turn off machine gracefully.
Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/mfd/max77620.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
For my own reference:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v4 6/6 regulator: max77620: Support Maxim 77663
In reply to Dmitry OsipenkoAdd support for Maxim 77663.
--- drivers/regulator/max77620-regulator.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-)
drivers/regulator/max77620-regulator.c +25 -1
@@ -761,6 +761,24 @@ static struct max77620_regulator_info max20024_regs_info[MAX77620_NUM_REGS] = { RAIL_LDO(LDO8, ldo8, "in-ldo7-8", N, 800000, 3950000, 50000), }; +static struct max77620_regulator_info max77663_regs_info[MAX77620_NUM_REGS ] = { +RAIL_SD (SD0 , sd0,"in-sd0" ,SD0 ,600000 ,3387500 ,12500 ,0xFF ,NONE ), +RAIL_SD (SD1 , sd1,"in-sd1" ,SD1 ,800000 ,1587500 ,12500 ,0xFF ,NONE ), +RAIL_SD (SD2 , sd2,"in-sd2" ,SDX ,600000 ,3787500 ,12500 ,0xFF ,NONE ), +RAIL_SD (SD3 , sd3,"in-sd3" ,SDX ,600000 ,3787500 ,12500 ,0xFF ,NONE ), +RAIL_SD (SD4 , sd4,"in-sd4" ,SDX ,600000 ,3787500 ,12500 ,0xFF ,NONE ), + +RAIL_LDO (LDO0 , ldo0,"in-ldo0-1" ,N ,800000 ,2375000 ,25000 ), +RAIL_LDO (LDO1 , ldo1,"in-ldo0-1" ,N ,800000 ,2375000 ,25000 ), +RAIL_LDO (LDO2 , ldo2,"in-ldo2" ,P ,800000 ,3950000 ,50000 ), +RAIL_LDO (LDO3 , ldo3,"in-ldo3-5" ,P ,800000 ,3950000 ,50000 ), +RAIL_LDO (LDO4 , ldo4,"in-ldo4-6" ,P ,800000 ,1587500 ,12500 ), +RAIL_LDO (LDO5 , ldo5,"in-ldo3-5" ,P ,800000 ,3950000 ,50000 ), +RAIL_LDO (LDO6 , ldo6,"in-ldo4-6" ,P ,800000 ,3950000 ,50000 ), +RAIL_LDO (LDO7 , ldo7,"in-ldo7-8" ,N ,800000 ,3950000 ,50000 ), +RAIL_LDO (LDO8 , ldo8,"in-ldo7-8" ,N ,800000 ,3950000 ,50000 ), +}; +static int max77620_regulator_probe (struct platform_device *pdev) {struct max77620_chip *max77620_chip =dev_get_drvdata (pdev->dev.parent);
@@ -785,9 +803,14 @@ static int max77620_regulator_probe(struct platform_device *pdev)case MAX77620 : rinfo = max77620_regs_info;break ; -default : +case MAX20024 : rinfo = max20024_regs_info;break ; +case MAX77663 : + rinfo = max77663_regs_info; +break ; +default : +return -EINVAL ; } config.regmap = pmic->rmap;
@@ -881,6 +904,7 @@ static const struct dev_pm_ops max77620_regulator_pm_ops = {static const struct platform_device_id max77620_regulator_devtype[] = { { .name ="max77620-pmic" , }, { .name ="max20024-pmic" , }, + { .name ="max77663-pmic" , }, {}, };MODULE_DEVICE_TABLE (platform, max77620_regulator_devtype);
Signature · 1 line
2.21.0
Re: [PATCH v4 6/6] regulator: max77620: Support Maxim 77663
05.05.2019 18:43, Dmitry Osipenko пишет:
Quoted 5 lines
Add support for Maxim 77663.
Acked-by Mark Brown <[email protected]>Signed-off-by Dmitry Osipenko <[email protected]>---
Hello Mark,
Just want to get yours attention to that Lee picked up the patches into the MFD tree, excluding this patch. I assume this one will have to go via the regulator's tree.
Mark Brown
maintainerRe: [PATCH v4 6/6] regulator: max77620: Support Maxim 77663
Quoted 3 lines · Dmitry Osipenko
Just want to get yours attention to that Lee picked up the patches into the MFD tree, excluding this patch. I assume this one will have to go via the regulator's tree.
Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
[GIT PULL] Immutable branch between MFD and Regulator due for the v5.2 merge window
In reply to Dmitry OsipenkoEnjoy!
The following changes since commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd:
Linux 5.1 (2019-05-05 17:42:58 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-regulator-v5.2
for you to fetch changes up to 744b13107d0d2ec36c5293d7b59129d3186c9396:
mfd: max77620: Provide system power-off functionality (2019-05-08 12:50:14 +0100)
----------------------------------------------------------------
Immutable branch between MFD and Regulator due for the v5.2 merge window
----------------------------------------------------------------
Dmitry Osipenko (5):
dt-bindings: mfd: max77620: Add compatible for Maxim 77663
dt-bindings: mfd: max77620: Add system-power-controller property
mfd: max77620: Fix swapped FPS_PERIOD_MAX_US values
mfd: max77620: Support Maxim 77663
mfd: max77620: Provide system power-off functionality
Documentation/devicetree/bindings/mfd/max77620.txt | 9 ++- drivers/mfd/max77620.c | 87 +++++++++++++++++++++- include/linux/mfd/max77620.h | 5 +- 3 files changed, 97 insertions(+), 4 deletions(-)
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog