Skip to contentSkip to conversation

dwmac4_prog_mtl_tx_algorithms() missing write operation

PATCH In review Cheng Han 2 participants 2 messages May 9, 2019

Subsystems (4)
lore
Share & tools
lore

Cheng Han

author
#0 lore raw

PATCH 1/1 dwmac4_prog_mtl_tx_algorithms() missing write operation

net: ethernet: stmmac: dwmac4_prog_mtl_tx_algorithms() missing write operation

The value of MTL_OPERATION_MODE is not written back

---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +2 -0
index 7e5d5db..b4bb562 100644
@@ -192,6 +192,8 @@ static void dwmac4_prog_mtl_tx_algorithms(struct mac_device_info *hw,
 	default:
 		break;
 	}
+
+	writel(value, ioaddr + MTL_OPERATION_MODE);
 }
 
 static void dwmac4_set_mtl_tx_queue_weight(struct mac_device_info *hw,
Signature · 1 line
1.9.1
maintainer
#1 lore raw

From: Cheng Han <[email protected]>
Date: Thu, 9 May 2019 11:13:41 +0800

Quoted 5 lines

net: ethernet: stmmac: dwmac4_prog_mtl_tx_algorithms() missing write operation

The value of MTL_OPERATION_MODE is not written back

Good catch, applied, thanks.