Skip to contentSkip to conversation

murata-wireless firmware packages

PATCH Superseded Marcin Niestroj 3 participants 10 messages May 7, 2019 – May 9, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover murata-wireless firmware packages

Hi,

This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE). I've put all three packages into single murata-wireless directory and Kconfig submenu, as they relate to the same hardware and there are plenty of options to choose from. Not sure whether this is the correct approach, so looking forward to get feedback on this.

Marcin Niestroj (3):
package/murata-wireless-cyw-fmac-fw: new package package/murata-wireless-cyw-fmac-nvram: new package package/murata-wireless-cyw-bt-patch: new package

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/murata-wireless/Config.in             |  7 ++
 .../murata-wireless-cyw-bt-patch/Config.in    | 47 ++++++++++
 .../murata-wireless-cyw-bt-patch.hash         |  3 +
 .../murata-wireless-cyw-bt-patch.mk           | 50 ++++++++++
 .../murata-wireless-cyw-fmac-fw/Config.in     | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-fw.hash          |  3 +
 .../murata-wireless-cyw-fmac-fw.mk            | 80 ++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram/Config.in  | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram.hash       |  3 +
 .../murata-wireless-cyw-fmac-nvram.mk         | 75 +++++++++++++++
 package/murata-wireless/murata-wireless.mk    |  9 ++
 13 files changed, 461 insertions(+)
 create mode 100644 package/murata-wireless/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
 create mode 100644 package/murata-wireless/murata-wireless.mk
Signature · 1 line
2.21.0
#1 lore raw

PATCH v2 1/3 package/murata-wireless-cyw-fmac-fw: new package

---
Changes v1 -> v2:
- add myself to DEVELOPERS.

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/murata-wireless/Config.in             |  5 +
 .../murata-wireless-cyw-fmac-fw/Config.in     | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-fw.hash          |  3 +
 .../murata-wireless-cyw-fmac-fw.mk            | 80 ++++++++++++++++
 package/murata-wireless/murata-wireless.mk    |  9 ++
 7 files changed, 190 insertions(+)
 create mode 100644 package/murata-wireless/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
 create mode 100644 package/murata-wireless/murata-wireless.mk
DEVELOPERS +1 -0
index 5bfc4561c0..9a8027663f 100644
@@ -1386,6 +1386,7 @@ F:	package/easydbus/
 F:	package/lua-flu/
 F:	package/lua-stdlib/
 F:	package/luaossl/
+F:	package/murata-wireless/
 F:	package/rs485conf/
 F:	package/turbolua/
 
package/Config.in +1 -0
index f592e74a99..2133ab9100 100644
@@ -382,6 +382,7 @@ menu "Firmware"
 	source "package/armbian-firmware/Config.in"
 	source "package/b43-firmware/Config.in"
 	source "package/linux-firmware/Config.in"
+	source "package/murata-wireless/Config.in"
 	source "package/rpi-bt-firmware/Config.in"
 	source "package/rpi-firmware/Config.in"
 	source "package/rpi-wifi-firmware/Config.in"
package/murata-wireless/Config.in new file +5 -0
new file mode 100644
index 0000000000..93fcb15e46
@@ -0,0 +1,5 @@
+menu "murata-wireless"
+
+source "package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in"
+
+endmenu
package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in new file +91 -0

91 lines not on this page · raw message

package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash new file +3 -0
new file mode 100644
index 0000000000..42ec54e2fa
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 c3ecf357786d6db6f3283c0ea36ec067b1728f801fd8871694aed1502a82e9bc murata-wireless-cyw-fmac-fw-8d87950bfad28c65926695b7357bd8995b60016a.tar.gz
+sha256 3a892759b73e8b459f1a750954b316118b0061fd9d1868d11fa258c104ee7e0c LICENCE.cypress
package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk new file +80 -0

80 lines not on this page · raw message

package/murata-wireless/murata-wireless.mk new file +9 -0
new file mode 100644
index 0000000000..e5434f09f0
@@ -0,0 +1,9 @@
+################################################################################
+#
+# murata-wireless
+#
+################################################################################
+
+murata-wireless-strip-model = $(shell echo -n $(1) | sed 's/\..*\./\./')
+
+include $(sort $(wildcard package/murata-wireless/*/*.mk))
Signature · 1 line
2.21.0
#2 lore raw

PATCH v2 1/3 package/murata-wireless-cyw-fmac-fw: new package

Quoted 15 lines · Marcin Niestroj
package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in new file +15 -0
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4339
+	bool "CYW4339 (1CK/ZP)"
+	help
+	  Murata Wireless FMAC WiFi CYW4339 (1CK/ZP) module
+	  firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
+	bool "CYW43430/CYW4343W/CYW43364 (1DX/1FX/1LN)"
+	help
+	  Murata Wireless FMAC WiFi CYW43430/CYW4343W/CYW43364
+	  (1DX/1FX/1LN) module firmware.
+
+choice
+	prompt "CYW43430/CYW4343W/CYW43364 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
+

package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in line 51

Quoted 10 lines
package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in new file +10 -0
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX
+	bool "1DX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1FX
+	bool "1FX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1LN
+	bool "1LN"
+
+endchoice

I don't understand this. Why is it possible to install firmware for CYW4339 and
CYW43430 1DX at the same time, but not for CYW43430 IDX and CYW43430 1FX?

In other words, why a choice and not just separate options like for the rest?

So I think what you want is that the
BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430 option becomes a blind option and moves out of the choice, and that it gets selected by BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX etc.

package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk line 20

Quoted 3 lines
package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk new file +3 -0
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43340-sdio.bin
+endif

In most of this type of many-simple-options situations, we use something like

MURATA_WIRELESS_CYW_FMAC_FW_FILES_$(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340) += brcmfmac43340-sdio.bin

By the way, I think the package name is way too long. With Yann's idea to merge
the three, I think we could name it e.g. murata-cyw-fw.

Regards,
Arnout

#3 lore raw

PATCH v2 1/3 package/murata-wireless-cyw-fmac-fw: new package

Hi Arnout,

Quoted 21 lines · Arnout Vandecappelle
Quoted 20 lines · Marcin Niestroj
package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in new file +20 -0
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4339
+	bool "CYW4339 (1CK/ZP)"
+	help
+	  Murata Wireless FMAC WiFi CYW4339 (1CK/ZP) module
+	  firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
+	bool "CYW43430/CYW4343W/CYW43364 (1DX/1FX/1LN)"
+	help
+	  Murata Wireless FMAC WiFi CYW43430/CYW4343W/CYW43364
+	  (1DX/1FX/1LN) module firmware.
+
+choice
+	prompt "CYW43430/CYW4343W/CYW43364 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX
+	bool "1DX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1FX
+	bool "1FX"
Quoted 8 lines

package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in line 51

Quoted 5 lines
package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in new file +5 -0
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1LN
+	bool "1LN"
+
+endchoice

I don't understand this. Why is it possible to install firmware for CYW4339 and
CYW43430 1DX at the same time, but not for CYW43430 IDX and CYW43430 1FX?

This is because 'brcmfmac43430-sdio.1DX.clm_blob' is renamed during installation step into 'brcmfmac43430-sdio.clm_blob' (using murata-cyw-fw-strip-model helper). The latter is the firmware name expected by Linux kernel.

Quoted 7 lines

In other words, why a choice and not just separate options like for the rest?

So I think what you want is that the
BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430 option becomes a blind option and moves out of the choice, and that it gets selected by BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX etc.

It would be nice to do it that way. However different modules based on the same chip have conflicting names under /lib/firmware/brcm/ directory.

Quoted 10 lines

package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk line 20

Quoted 5 lines
package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk new file +3 -0
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43340-sdio.bin
+endif

In most of this type of many-simple-options situations, we use something like

MURATA_WIRELESS_CYW_FMAC_FW_FILES_$(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340) += brcmfmac43340-sdio.bin

Thanks for hint!

Quoted 3 lines

By the way, I think the package name is way too long. With Yann's idea to merge
the three, I think we could name it e.g. murata-cyw-fw.

Okay, will use proposed name.

Quoted 3 lines

Regards,
Arnout

--
Marcin Niestr?j

#4 lore raw

PATCH v2 2/3 package/murata-wireless-cyw-fmac-nvram: new package

In reply to Marcin Niestroj

---
Changes v1 -> v2: none

 package/murata-wireless/Config.in             |  1 +
 .../murata-wireless-cyw-fmac-nvram/Config.in  | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram.hash       |  3 +
 .../murata-wireless-cyw-fmac-nvram.mk         | 75 +++++++++++++++
 4 files changed, 170 insertions(+)
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
package/murata-wireless/Config.in +1 -0
index 93fcb15e46..9d2ae8b29a 100644
@@ -1,5 +1,6 @@
 menu "murata-wireless"
 
 source "package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in"
+source "package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in"
 
 endmenu
package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in new file +91 -0

91 lines not on this page · raw message

package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash new file +3 -0
new file mode 100644
index 0000000000..2759180241
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 03c140ae04f9c2036678262d6457b9c4b4a9ebb523c5e681af6d57b97c11da37 murata-wireless-cyw-fmac-nvram-d27f1bf105fa1e5b828e355793b88d4b66188411.tar.gz
+sha256 3a892759b73e8b459f1a750954b316118b0061fd9d1868d11fa258c104ee7e0c LICENCE.cypress
package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk new file +75 -0

75 lines not on this page · raw message

Signature · 1 line
2.21.0
#5 lore raw

PATCH v2 3/3 package/murata-wireless-cyw-bt-patch: new package

In reply to Marcin Niestroj

---
Changes v1 -> v2:
- fix mkdir directory path before installing firmware.

 package/murata-wireless/Config.in             |  1 +
 .../murata-wireless-cyw-bt-patch/Config.in    | 47 +++++++++++++++++
 .../murata-wireless-cyw-bt-patch.hash         |  3 ++
 .../murata-wireless-cyw-bt-patch.mk           | 50 +++++++++++++++++++
 4 files changed, 101 insertions(+)
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
package/murata-wireless/Config.in +1 -0
index 9d2ae8b29a..3f26e2f803 100644
@@ -1,5 +1,6 @@
 menu "murata-wireless"
 
+source "package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in"
 source "package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in"
 source "package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in"
 
package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in new file +47 -0

47 lines not on this page · raw message

package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash new file +3 -0
new file mode 100644
index 0000000000..9b9f8db4d1
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 8f23ebb9a262112b62ace1e1bedcdeb00523d9a45e8d48a829d4ca35db4f0280 murata-wireless-cyw-bt-patch-748462f0b02ec4aeb500bedd60780ac51c37be31.tar.gz
+sha256 3a892759b73e8b459f1a750954b316118b0061fd9d1868d11fa258c104ee7e0c LICENCE.cypress
package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk new file +50 -0

50 lines not on this page · raw message

Signature · 1 line
2.21.0
#6 lore raw

v2 cover murata-wireless firmware packages

In reply to Marcin Niestroj

Marcin, All,

On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:

Quoted 5 lines

This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE). I've put all three packages into single murata-wireless directory and Kconfig submenu, as they relate to the same hardware and there are plenty of options to choose from. Not sure whether this is the correct approach, so looking forward to get feedback on this.

I wonder why we would actually need three packages.

As far as I can see from a cursory look, they are all very tightly coupled; they even have the same choice about the actual variant to use.

So, I would like we look at making that a single package, which downloads multiple tarballs, something like:

    MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
    MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
    MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31

    MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
    MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
        $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
        $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz

    define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
        $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
            $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
            $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
        )
    endef
    MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH

And a similar hook for the installation step (which I leave up to you as an exercise ;-) ).

Regards,
Yann E. MORIN.

Quoted 38 lines

Marcin Niestroj (3):
package/murata-wireless-cyw-fmac-fw: new package package/murata-wireless-cyw-fmac-nvram: new package package/murata-wireless-cyw-bt-patch: new package

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/murata-wireless/Config.in             |  7 ++
 .../murata-wireless-cyw-bt-patch/Config.in    | 47 ++++++++++
 .../murata-wireless-cyw-bt-patch.hash         |  3 +
 .../murata-wireless-cyw-bt-patch.mk           | 50 ++++++++++
 .../murata-wireless-cyw-fmac-fw/Config.in     | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-fw.hash          |  3 +
 .../murata-wireless-cyw-fmac-fw.mk            | 80 ++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram/Config.in  | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram.hash       |  3 +
 .../murata-wireless-cyw-fmac-nvram.mk         | 75 +++++++++++++++
 package/murata-wireless/murata-wireless.mk    |  9 ++
 13 files changed, 461 insertions(+)
 create mode 100644 package/murata-wireless/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
 create mode 100644 package/murata-wireless/murata-wireless.mk
Signature · 6 lines
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

v2 cover murata-wireless firmware packages

Quoted 9 lines · Yann E. MORIN

Marcin, All,

On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:

Quoted 5 lines

This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE). I've put all three packages into single murata-wireless directory and Kconfig submenu, as they relate to the same hardware and there are plenty of options to choose from. Not sure whether this is the correct approach, so looking forward to get feedback on this.

Quoted 4 lines

I wonder why we would actually need three packages.

As far as I can see from a cursory look, they are all very tightly coupled; they even have the same choice about the actual variant to use.

Indeed, I guess you always need all three of them, so this seems to make sense.

Regards,
Arnout

Quoted 66 lines

So, I would like we look at making that a single package, which downloads multiple tarballs, something like:

    MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
    MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
    MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31

    MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
    MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
        $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
        $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz

    define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
        $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
            $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
            $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
        )
    endef
    MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH

And a similar hook for the installation step (which I leave up to you as an exercise ;-) ).

Regards,
Yann E. MORIN.

Quoted 38 lines

Marcin Niestroj (3):
package/murata-wireless-cyw-fmac-fw: new package package/murata-wireless-cyw-fmac-nvram: new package package/murata-wireless-cyw-bt-patch: new package

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/murata-wireless/Config.in             |  7 ++
 .../murata-wireless-cyw-bt-patch/Config.in    | 47 ++++++++++
 .../murata-wireless-cyw-bt-patch.hash         |  3 +
 .../murata-wireless-cyw-bt-patch.mk           | 50 ++++++++++
 .../murata-wireless-cyw-fmac-fw/Config.in     | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-fw.hash          |  3 +
 .../murata-wireless-cyw-fmac-fw.mk            | 80 ++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram/Config.in  | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram.hash       |  3 +
 .../murata-wireless-cyw-fmac-nvram.mk         | 75 +++++++++++++++
 package/murata-wireless/murata-wireless.mk    |  9 ++
 13 files changed, 461 insertions(+)
 create mode 100644 package/murata-wireless/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
 create mode 100644 package/murata-wireless/murata-wireless.mk
Signature · 6 lines
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#8 lore raw

v2 cover murata-wireless firmware packages

In reply to Yann E. MORIN

Hi Yann,

Quoted 34 lines · Yann E. MORIN

Marcin, All,

On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:

Quoted 5 lines

This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE). I've put all three packages into single murata-wireless directory and Kconfig submenu, as they relate to the same hardware and there are plenty of options to choose from. Not sure whether this is the correct approach, so looking forward to get feedback on this.

I wonder why we would actually need three packages.

As far as I can see from a cursory look, they are all very tightly coupled; they even have the same choice about the actual variant to use.

So, I would like we look at making that a single package, which downloads multiple tarballs, something like:

    MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
    MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
    MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31

    MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
    MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
        $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
        $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz

    define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
        $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
            $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
            $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
        )
    endef
    MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
Quoted 2 lines

And a similar hook for the installation step (which I leave up to you as an exercise ;-) ).

Thanks for review and tips on how to use single package here. The only downside that I see is that all three packages will be downloaded, even if (in some cases) one or two are required only. However overall code will be much simpler, so it is a good idea anyway.

Quoted 42 lines

Regards,
Yann E. MORIN.

Quoted 38 lines

Marcin Niestroj (3):
package/murata-wireless-cyw-fmac-fw: new package package/murata-wireless-cyw-fmac-nvram: new package package/murata-wireless-cyw-bt-patch: new package

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/murata-wireless/Config.in             |  7 ++
 .../murata-wireless-cyw-bt-patch/Config.in    | 47 ++++++++++
 .../murata-wireless-cyw-bt-patch.hash         |  3 +
 .../murata-wireless-cyw-bt-patch.mk           | 50 ++++++++++
 .../murata-wireless-cyw-fmac-fw/Config.in     | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-fw.hash          |  3 +
 .../murata-wireless-cyw-fmac-fw.mk            | 80 ++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram/Config.in  | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram.hash       |  3 +
 .../murata-wireless-cyw-fmac-nvram.mk         | 75 +++++++++++++++
 package/murata-wireless/murata-wireless.mk    |  9 ++
 13 files changed, 461 insertions(+)
 create mode 100644 package/murata-wireless/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
 create mode 100644 package/murata-wireless/murata-wireless.mk

--
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
Marcin Niestr?j

#9 lore raw

v2 cover murata-wireless firmware packages

Marcin, All,

On 2019-05-09 09:52 +0200, Marcin Niestr?j spake thusly:

Quoted 33 lines
Quoted 32 lines · Yann E. MORIN

On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:

Quoted 5 lines

This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE). I've put all three packages into single murata-wireless directory and Kconfig submenu, as they relate to the same hardware and there are plenty of options to choose from. Not sure whether this is the correct approach, so looking forward to get feedback on this.

I wonder why we would actually need three packages.

As far as I can see from a cursory look, they are all very tightly coupled; they even have the same choice about the actual variant to use.

So, I would like we look at making that a single package, which downloads multiple tarballs, something like:

    MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
    MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
    MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31

    MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
    MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
        $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
        $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz

    define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
        $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
            $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
            $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
        )
    endef
    MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
Quoted 7 lines
Quoted 2 lines

And a similar hook for the installation step (which I leave up to you as an exercise ;-) ).

Thanks for review and tips on how to use single package here. The only downside that I see is that all three packages will be downloaded, even if (in some cases) one or two are required only. However overall code will be much simpler, so it is a good idea anyway.

Well, you can always do the extra dowenload dance conditionally:

    ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_NVRAM),y)
    MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS += \
        (call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
    endif

    ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_PATCH),y)
    MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS += \
        $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz
    endif

And in Config.in:

config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_NVRAM
bool

config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_PATCH
bool

choice
bool "Variant to use"

config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_FOO
bool "foo"
select BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_PATCH

config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_BAR
bool "bar"
select BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_NVRAM

endchoice

You get the idea...

Regards,
Yann E. MORIN.

Quoted 45 lines
Quoted 41 lines

Regards,
Yann E. MORIN.

Quoted 38 lines

Marcin Niestroj (3):
package/murata-wireless-cyw-fmac-fw: new package package/murata-wireless-cyw-fmac-nvram: new package package/murata-wireless-cyw-bt-patch: new package

 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/murata-wireless/Config.in             |  7 ++
 .../murata-wireless-cyw-bt-patch/Config.in    | 47 ++++++++++
 .../murata-wireless-cyw-bt-patch.hash         |  3 +
 .../murata-wireless-cyw-bt-patch.mk           | 50 ++++++++++
 .../murata-wireless-cyw-fmac-fw/Config.in     | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-fw.hash          |  3 +
 .../murata-wireless-cyw-fmac-fw.mk            | 80 ++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram/Config.in  | 91 +++++++++++++++++++
 .../murata-wireless-cyw-fmac-nvram.hash       |  3 +
 .../murata-wireless-cyw-fmac-nvram.mk         | 75 +++++++++++++++
 package/murata-wireless/murata-wireless.mk    |  9 ++
 13 files changed, 461 insertions(+)
 create mode 100644 package/murata-wireless/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
 create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
 create mode 100644 package/murata-wireless/murata-wireless.mk

--
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
Marcin Niestr?j

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'