Skip to contentSkip to conversation

soc: bcm: brcmstb: biuctrl: Register writes require a barrier

PATCH Applied Florian Fainelli 1 participant 2 messages May 10, 2019 – May 13, 2019 Broadcom BCM7XXX Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: bcm: brcmstb: biuctrl: Register writes require a barrier

The BIUCTRL register writes require that a data barrier be inserted after comitting the write to the register for the block to latch in the recently written values. Reads have no such requirement and are not changed.

Fixes 34642650e5bc ("soc: Move brcmstb to bcm/brcmstb")
---
 drivers/soc/bcm/brcmstb/biuctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/bcm/brcmstb/biuctrl.c +1 -1
index c16273b31b94..20b63bee5b09 100644
@@ -56,7 +56,7 @@ static inline void cbc_writel(u32 val, int reg)
 	if (offset == -1)
 		return;
 
-	writel_relaxed(val,  cpubiuctrl_base + offset);
+	writel(val, cpubiuctrl_base + offset);
 }
 
 enum cpubiuctrl_regs {
Signature · 1 line
2.17.1
author Applied
#1 lore raw
Quoted 7 lines · Florian Fainelli

The BIUCTRL register writes require that a data barrier be inserted after comitting the write to the register for the block to latch in the recently written values. Reads have no such requirement and are not changed.

Fixes 34642650e5bc ("soc: Move brcmstb to bcm/brcmstb")

Applied to drivers/fixes, thanks!

Signature · 1 line
Florian