nvme: add support for Verify command opcode
PATCH 1/1 nvme: add support for Verify command opcode
This allows the Verify command to be sent using the NVME_IOCTL_SUBMIT_IO ioctl.
--- drivers/nvme/host/core.c | 1 + drivers/nvme/host/trace.c | 1 + drivers/nvme/host/trace.h | 1 + include/linux/nvme.h | 1 + 4 files changed, 4 insertions(+)
drivers/nvme/host/core.c +1 -0
@@ -1193,6 +1193,7 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)switch (io.opcode) {case nvme_cmd_write:case nvme_cmd_read: +case nvme_cmd_verify:case nvme_cmd_compare:break ;default :
drivers/nvme/host/trace.c +1 -0
@@ -127,6 +127,7 @@ const char *nvme_trace_parse_nvm_cmd(struct trace_seq *p,case nvme_cmd_read:case nvme_cmd_write:case nvme_cmd_write_zeroes: +case nvme_cmd_verify:return nvme_trace_read_write (p, cdw10);case nvme_cmd_dsm:return nvme_trace_dsm (p, cdw10);
drivers/nvme/host/trace.h +1 -0
@@ -52,6 +52,7 @@nvme_opcode_name (nvme_cmd_compare), \nvme_opcode_name (nvme_cmd_write_zeroes), \nvme_opcode_name (nvme_cmd_dsm), \ +nvme_opcode_name (nvme_cmd_verify), \nvme_opcode_name (nvme_cmd_resv_register), \nvme_opcode_name (nvme_cmd_resv_report), \ nvme_opcode_name(nvme_cmd_resv_acquire), \
include/linux/nvme.h +1 -0
@@ -556,6 +556,7 @@ enum nvme_opcode { nvme_cmd_compare =0x05 , nvme_cmd_write_zeroes =0x08 , nvme_cmd_dsm =0x09 , + nvme_cmd_verify =0x0c , nvme_cmd_resv_register =0x0d , nvme_cmd_resv_report =0x0e , nvme_cmd_resv_acquire = 0x11,
Signature · 1 line
2.17.1
Christoph Hellwig
maintainerPATCH 1/1 nvme: add support for Verify command opcode
Quoted 4 lines · Kenneth Heitke
This allows the Verify command to be sent using the
NVME_IOCTL_SUBMIT_IOioctl.Signed-off-by Kenneth Heitke <kenneth.heitke at intel.com>
I think we've decided that NVME_IOCTL_SUBMIT_IO is deprecated and everyone should be using NVME_IOCTL_IO_CMD instead.
Maybe we need to add an official deprecating warnings (probably just a printk_once, maybe per process name?)
PATCH 1/1 nvme: add support for Verify command opcode
Quoted 4 lines · Christoph Hellwig
Quoted 3 lines · Kenneth Heitke
This allows the Verify command to be sent using the
NVME_IOCTL_SUBMIT_IOioctl.
Quoted 8 lines
Quoted 1 line
Signed-off-by Kenneth Heitke <kenneth.heitke at intel.com>I think we've decided that
NVME_IOCTL_SUBMIT_IOis deprecated and everyone should be usingNVME_IOCTL_IO_CMDinstead.Maybe we need to add an official deprecating warnings (probably just a
printk_once, maybe per process name?)
Thanks! I wasn't sure which was the preferred ioctl to use and didn't realize that SUMBIT_IO was considered deprecated.