Skip to contentSkip to conversation

staging: rtl8723bs: core fix warning Comparison to bool

PATCH In review Hariprasad Kelam 2 participants 2 messages May 12, 2019 – May 13, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: core fix warning Comparison to bool

fix below issue reported by coccicheck

drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison to bool

---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +1 -1
index 5f78f1e..d26d8cf 100644
@@ -1672,7 +1672,7 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
 			roam_target = pmlmepriv->roam_network;
 		}
 
-		if (roam == true) {
+		if (roam) {
 			if (rtw_to_roam(adapter) > 0)
 				rtw_dec_to_roam(adapter); /* this stadel_event is caused by roaming, decrease to_roam */
 			else if (rtw_to_roam(adapter) == 0)
Signature · 1 line
2.7.4
#1 lore raw
Quoted 9 lines · Hariprasad Kelam

fix below issue reported by coccicheck

drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison to bool

---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

You sent 3 patches that do different things, yet have the same subject line :(

Please fix up and send as a numbered patch series, or better yet, fix the same thing in the whole file all at ince.

thanks,

greg k-h