Staging: rtl8192u: ieee80211: Fix coding style warning

PATCH New puranjay12 at gmail.com (Puranjay Mohan) 2 participants 2 messages May 2, 2019 – May 13, 2019 Staging

Share & tools

puranjay12 at gmail.com (Puranjay Mohan)

2019-05-02 18:45 UTC #0 lore raw

PATCH v2 1/1 Staging: rtl8192u: ieee80211: Fix coding style warning

Remove braces around a single if statement to fix following checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>

---
v2- Removed trailing whitespace.

 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +2 -2

index 0e762e559675..bd97531a254f 100644
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
 	spin_unlock_irqrestore(&ieee->lock, flags);
 	if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
 		(ieee->state == IEEE80211_LINKED)) {
-		if (ieee->handle_beacon != NULL) {
+		if (ieee->handle_beacon != NULL)
 			ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
-		}
+
 	}
 
 out:

--
2.21.0

Greg KH

2019-05-13 09:36 UTC #1 lore raw

PATCH v2 1/1 Staging: rtl8192u: ieee80211: Fix coding style warning

Quoted 28 lines · Puranjay Mohan

Remove braces around a single if statement to fix following checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>
---
v2- Removed trailing whitespace.
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +2 -3
index 0e762e559675..bd97531a254f 100644
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
 	spin_unlock_irqrestore(&ieee->lock, flags);
 	if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
 		(ieee->state == IEEE80211_LINKED)) {
-		if (ieee->handle_beacon != NULL) {
+		if (ieee->handle_beacon != NULL)
 			ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
-		}
+
 	}
 
 out:
--

Quoted 2 lines

2.21.0

You sent 5 patches for the same driver, yet no way of providing me the information as to what order to apply them in. I tried to guess, and got it wrong, and so they would not all apply.

Please fix this up and resend all of them, as a numbered patch series, so that I have a chance to get it right.

thanks,

greg k-h