perf vendor events arm64: Add Cortex-A57 and Cortex-A72 events
Subsystems (2)
PATCH v2 1/1 perf vendor events arm64: Add Cortex-A57 and Cortex-A72 events
The Cortex-A57 and Cortex-A72 both support all ARMv8 recommended events up to the RC_ST_SPEC (0x91) event with the exception of:
- L1D_CACHE_REFILL_INNER (0x44)
- L1D_CACHE_REFILL_OUTER (0x45)
- L1D_TLB_RD (0x4E)
- L1D_TLB_WR (0x4F)
- L2D_TLB_REFILL_RD (0x5C)
- L2D_TLB_REFILL_WR (0x5D)
- L2D_TLB_RD (0x5E)
- L2D_TLB_WR (0x5F)
- STREX_SPEC (0x6F)
Create an appropriate JSON file for mapping those events and update the mapfile.csv for matching the Cortex-A57 and Cortex-A72 MIDR to that file.
---
Changes in v2:
- added a shared directory for both Cortex-A57 and A72 (Will)
- removed unsupported ARMv8 v3 events (John)
.../arm/cortex-a57-a72/core-imp-def.json | 179 ++++++++++++++++++ tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 + 2 files changed, 181 insertions(+) create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cortex-a57-a72/core-imp-def.json
tools/perf/pmu-events/arch/arm64/arm/cortex-a57-a72/core-imp-def.json new file +179 -0
@@ -0,0 +1,179 @@ +[ + { + "ArchStdEvent": "L1D_CACHE_RD", + }, + { + "ArchStdEvent": "L1D_CACHE_WR", + }, + { + "ArchStdEvent": "L1D_CACHE_REFILL_RD", + }, + { + "ArchStdEvent": "L1D_CACHE_REFILL_WR", + }, + { + "ArchStdEvent": "L1D_CACHE_WB_VICTIM", + }, + { + "ArchStdEvent": "L1D_CACHE_WB_CLEAN", + }, + { + "ArchStdEvent": "L1D_CACHE_INVAL", + }, + { + "ArchStdEvent": "L1D_TLB_REFILL_RD", + }, + { + "ArchStdEvent": "L1D_TLB_REFILL_WR", + }, + { + "ArchStdEvent": "L2D_CACHE_RD", + }, + { + "ArchStdEvent": "L2D_CACHE_WR", + }, + { + "ArchStdEvent": "L2D_CACHE_REFILL_RD", + }, + { + "ArchStdEvent": "L2D_CACHE_REFILL_WR", + }, + { + "ArchStdEvent": "L2D_CACHE_WB_VICTIM", + }, + { + "ArchStdEvent": "L2D_CACHE_WB_CLEAN", + }, + { + "ArchStdEvent": "L2D_CACHE_INVAL", + }, + { + "ArchStdEvent": "BUS_ACCESS_RD", + }, + { + "ArchStdEvent": "BUS_ACCESS_WR", + }, + { + "ArchStdEvent": "BUS_ACCESS_SHARED", + }, + { + "ArchStdEvent": "BUS_ACCESS_NOT_SHARED", + }, + { + "ArchStdEvent": "BUS_ACCESS_NORMAL", + }, + { + "ArchStdEvent": "BUS_ACCESS_PERIPH", + }, + { + "ArchStdEvent": "MEM_ACCESS_RD", + }, + { + "ArchStdEvent": "MEM_ACCESS_WR", + }, + { + "ArchStdEvent": "UNALIGNED_LD_SPEC", + }, + { + "ArchStdEvent": "UNALIGNED_ST_SPEC", + }, + { + "ArchStdEvent": "UNALIGNED_LDST_SPEC", + }, + { + "ArchStdEvent": "LDREX_SPEC", + }, + { + "ArchStdEvent": "STREX_PASS_SPEC", + }, + { + "ArchStdEvent": "STREX_FAIL_SPEC", + }, + { + "ArchStdEvent": "LD_SPEC", + }, + { + "ArchStdEvent": "ST_SPEC", + }, + { + "ArchStdEvent": "LDST_SPEC", + }, + { + "ArchStdEvent": "DP_SPEC", + }, + { + "ArchStdEvent": "ASE_SPEC", + }, + { + "ArchStdEvent": "VFP_SPEC", + }, + { + "ArchStdEvent": "PC_WRITE_SPEC", + }, + { + "ArchStdEvent": "CRYPTO_SPEC", + }, + { + "ArchStdEvent": "BR_IMMED_SPEC", + }, + { + "ArchStdEvent": "BR_RETURN_SPEC", + }, + { + "ArchStdEvent": "BR_INDIRECT_SPEC", + }, + { + "ArchStdEvent": "ISB_SPEC", + }, + { + "ArchStdEvent": "DSB_SPEC", + }, + { + "ArchStdEvent": "DMB_SPEC", + }, + { + "ArchStdEvent": "EXC_UNDEF", + }, + { + "ArchStdEvent": "EXC_SVC", + }, + { + "ArchStdEvent": "EXC_PABORT", + }, + { + "ArchStdEvent": "EXC_DABORT", + }, + { + "ArchStdEvent": "EXC_IRQ", + }, + { + "ArchStdEvent": "EXC_FIQ", + }, + { + "ArchStdEvent": "EXC_SMC", + }, + { + "ArchStdEvent": "EXC_HVC", + }, + { + "ArchStdEvent": "EXC_TRAP_PABORT", + }, + { + "ArchStdEvent": "EXC_TRAP_DABORT", + }, + { + "ArchStdEvent": "EXC_TRAP_OTHER", + }, + { + "ArchStdEvent": "EXC_TRAP_IRQ", + }, + { + "ArchStdEvent": "EXC_TRAP_FIQ", + }, + { + "ArchStdEvent": "RC_LD_SPEC", + }, + { + "ArchStdEvent": "RC_ST_SPEC", + }, +]
tools/perf/pmu-events/arch/arm64/mapfile.csv +2 -0
@@ -13,6 +13,8 @@ # #Family-model,Version,Filename,EventType 0x00000000410fd03[[:xdigit:]],v1,arm/cortex-a53,core +0x00000000411fd07[[:xdigit:]],v1,arm/cortex-a57-a72,core +0x00000000410fd08[[:xdigit:]],v1,arm/cortex-a57-a72,core 0x00000000420f5160,v1,cavium/thunderx2,core 0x00000000430f0af0,v1,cavium/thunderx2,core 0x00000000480fd010,v1,hisilicon/hip08,core
Signature · 1 line
2.17.1
Quoted 13 lines · Florian Fainelli
The Cortex-A57 and Cortex-A72 both support all ARMv8 recommended events up to the
RC_ST_SPEC(0x91) event with the exception of:-
L1D_CACHE_REFILL_INNER(0x44)
-L1D_CACHE_REFILL_OUTER(0x45)
-L1D_TLB_RD(0x4E)
-L1D_TLB_WR(0x4F)
-L2D_TLB_REFILL_RD(0x5C)
-L2D_TLB_REFILL_WR(0x5D)
-L2D_TLB_RD(0x5E)
-L2D_TLB_WR(0x5F)
-STREX_SPEC(0x6F)
Quoted 3 lines
Create an appropriate JSON file for mapping those events and update the mapfile.csv for matching the Cortex-A57 and Cortex-A72 MIDR to that file.
I suppose you could have also created separate a72 and a57 folders, and used a symbolic link for the json. That would have kept the folder structure consistent and neat.
Quoted 2 lines
Signed-off-by Florian Fainelli <[email protected]>
Apart from the above:
Quoted 12 lines
---
Changes in v2:- added a shared directory for both Cortex-A57 and A72 (Will)
- removed unsupported ARMv8 v3 events (John).../arm/cortex-a57-a72/core-imp-def.json | 179 ++++++++++++++++++ tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 + 2 files changed, 181 insertions(+) create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cortex-a57-a72/core-imp-def.json(quoted diff) +0
-0
Quoted 14 lines · John Garry
Quoted 13 lines · Florian Fainelli
The Cortex-A57 and Cortex-A72 both support all ARMv8 recommended events up to the
RC_ST_SPEC(0x91) event with the exception of:-
L1D_CACHE_REFILL_INNER(0x44)
-L1D_CACHE_REFILL_OUTER(0x45)
-L1D_TLB_RD(0x4E)
-L1D_TLB_WR(0x4F)
-L2D_TLB_REFILL_RD(0x5C)
-L2D_TLB_REFILL_WR(0x5D)
-L2D_TLB_RD(0x5E)
-L2D_TLB_WR(0x5F)
-STREX_SPEC(0x6F)
Quoted 7 lines
Quoted 3 lines
Create an appropriate JSON file for mapping those events and update the mapfile.csv for matching the Cortex-A57 and Cortex-A72 MIDR to that file.
I suppose you could have also created separate a72 and a57 folders, and used a symbolic link for the json. That would have kept the folder structure consistent and neat.
Will, Mark, any preference on that? Either way works fine.
Quoted 6 lines
Quoted 3 lines
Signed-off-by Florian Fainelli <[email protected]>Apart from the above:
Reviewed-by John Garry <[email protected]>
Thanks
Quoted 15 lines
Quoted 14 lines
---
Changes in v2:- added a shared directory for both Cortex-A57 and A72 (Will)
- removed unsupported ARMv8 v3 events (John).../arm/cortex-a57-a72/core-imp-def.json | 179 ++++++++++++++++++ tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 +
2 files changed, 181 insertions(+)create mode 100644
tools/perf/pmu-events/arch/arm64/arm/cortex-a57-a72/core-imp-def.json(quoted diff) +0
-0
Signature · 1 line
Florian
Quoted 19 lines · Florian Fainelli
Quoted 18 lines · John Garry
Quoted 16 lines · Florian Fainelli
The Cortex-A57 and Cortex-A72 both support all ARMv8 recommended events up to the
RC_ST_SPEC(0x91) event with the exception of:-
L1D_CACHE_REFILL_INNER(0x44)
-L1D_CACHE_REFILL_OUTER(0x45)
-L1D_TLB_RD(0x4E)
-L1D_TLB_WR(0x4F)
-L2D_TLB_REFILL_RD(0x5C)
-L2D_TLB_REFILL_WR(0x5D)
-L2D_TLB_RD(0x5E)
-L2D_TLB_WR(0x5F)
-STREX_SPEC(0x6F)Create an appropriate JSON file for mapping those events and update the mapfile.csv for matching the Cortex-A57 and Cortex-A72 MIDR to that file.
Quoted 5 lines
Quoted 3 lines
I suppose you could have also created separate a72 and a57 folders, and used a symbolic link for the json. That would have kept the folder structure consistent and neat.
Will, Mark, any preference on that? Either way works fine.
I'd personally avoid committing symbolic links if possible, so I'm fine with your patch as-is.
Will
tools/perf/pmu-events/arch/arm64/mapfile.csv line 16
Quoted 9 lines · Florian Fainelli
tools/perf/pmu-events/arch/arm64/mapfile.csv +1
-0@@ -13,6 +13,8 @@ # #Family-model,Version,Filename,EventType 0x00000000410fd03[[:xdigit:]],v1,arm/cortex-a53,core +0x00000000411fd07[[:xdigit:]],v1,arm/cortex-a57-a72,core
The 4-bit variant field should be 0x0, not 0x1. In fact, I think we could do the same for the revision field too and use 0x0 instead of [[:xdigit:]] for Cortex-A53, no? Our implementation of get_cpuid_str() masks these out for us.
Am I missing something?
Will
Quoted 15 lines · Will Deacon
tools/perf/pmu-events/arch/arm64/mapfile.csv line 16
Quoted 9 lines · Florian Fainelli
tools/perf/pmu-events/arch/arm64/mapfile.csv +1
-0@@ -13,6 +13,8 @@ # #Family-model,Version,Filename,EventType 0x00000000410fd03[[:xdigit:]],v1,arm/cortex-a53,core +0x00000000411fd07[[:xdigit:]],v1,arm/cortex-a57-a72,coreThe 4-bit variant field should be
0x0, not0x1. In fact, I think we could do the same for the revision field too and use0x0instead of [[:xdigit:]] for Cortex-A53, no? Our implementation ofget_cpuid_str()masks these out for us.
Quoted 1 line
Am I missing something?
I blindly copied from the existing a53 entry without looking at how get_cpuidr_str(), I will resubmit this and add a patch which removes the [[:xdigit:]] for the A53 (and now Brahma-B53 entry) as well.
Thanks!
Signature · 1 line
Florian