sysreset: switch to using SYSRESET_POWER_OFF for poweroff
Subsystems (3)
PATCH 1/3 sysreset: switch to using SYSRESET_POWER_OFF for poweroff
It seems that SYSRESET_POWER_OFF was added recently, and all previous code used SYSRESET_POWER for poweroff. SYSRESET_POWER is supposed to be a PMIC-level power cycle, not a poweroff.
---
Note: I didnt touch the test/dm/sysreset.c code yet, mostly because I wanted to get feedback on this first and that i'd need to understand the tests properly to do that (and i havent used them before at all).
--- arch/arm/mach-stm32mp/cmd_poweroff.c | 2 +- arch/sandbox/cpu/state.c | 2 +- drivers/power/pmic/stpmic1.c | 2 +- drivers/sysreset/sysreset_psci.c | 2 +- drivers/sysreset/sysreset_sandbox.c | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/mach-stm32mp/cmd_poweroff.c +1 -1
@@ -14,7 +14,7 @@ int do_poweroff(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])puts ("poweroff ...\n" );mdelay (100 ); - ret =sysreset_walk (SYSRESET_POWER ); + ret =sysreset_walk (SYSRESET_POWER_OFF );if (ret == -EINPROGRESS )mdelay (1000 );
arch/sandbox/cpu/state.c +1 -1
@@ -355,7 +355,7 @@ void state_reset_for_test(struct sandbox_state *state) {/* No reset yet, so mark it as such. Always allow power reset */ state->last_sysreset =SYSRESET_COUNT ; - state->sysreset_allowed[SYSRESET_POWER ] = true; + state->sysreset_allowed[SYSRESET_POWER_OFF ] = true;memset (&state->wdt,'\0' ,sizeof (state->wdt));memset (state->spi,'\0' ,sizeof (state->spi));
drivers/power/pmic/stpmic1.c +1 -1
@@ -221,7 +221,7 @@ static int stpmic1_sysreset_request(struct udevice *dev, enum sysreset_t type)struct udevice *pmic_dev;int ret; -if (type !=SYSRESET_POWER ) +if (type !=SYSRESET_POWER_OFF )return -EPROTONOSUPPORT ; ret = uclass_get_device_by_driver(UCLASS_PMIC,
drivers/sysreset/sysreset_psci.c +1 -1
@@ -18,7 +18,7 @@ static int psci_sysreset_request(struct udevice *dev, enum sysreset_t type)case SYSRESET_COLD : function_id =PSCI_0_2_FN_SYSTEM_RESET ;break ; -case SYSRESET_POWER : +case SYSRESET_POWER_OFF : function_id =PSCI_0_2_FN_SYSTEM_OFF ;break ;default :
drivers/sysreset/sysreset_sandbox.c +2 -2
@@ -57,13 +57,13 @@ static int sandbox_sysreset_request(struct udevice *dev, enum sysreset_t type)case SYSRESET_COLD : state->last_sysreset = type;break ; -case SYSRESET_POWER : +case SYSRESET_POWER_OFF : state->last_sysreset = type;if (!state->sysreset_allowed[type])return -EACCES ;sandbox_exit ();break ; -case SYSRESET_POWER_OFF : +case SYSRESET_POWER :if (!state->sysreset_allowed[type])return -EACCES ;default :
Signature · 1 line
2.21.0
PATCH 2/3 sysreset: move stm32mp sysreset poweroff implementation to sysreset uclass
This is a generic implementation. Add CONFIG_SYSRESET_CMD_POWEROFF to signal when we need it. Enable it from the STPMIC1 config and in sandbox.
The config flag is transitionary, that is it can be removed after all poweroff implementations use sysreset, and just have CMD_POWEROFF depend on sysreset.
---
Note: I cant test STM32MP, so I would really appreciate if someone could test this series on that.
--- arch/Kconfig | 1 + arch/arm/mach-stm32mp/Makefile | 3 --- arch/arm/mach-stm32mp/cmd_poweroff.c | 24 ------------------------ drivers/power/pmic/Kconfig | 1 + drivers/sysreset/Kconfig | 10 ++++++++++ drivers/sysreset/sysreset-uclass.c | 18 ++++++++++++++++++ 6 files changed, 30 insertions(+), 27 deletions(-) delete mode 100644 arch/arm/mach-stm32mp/cmd_poweroff.c
arch/Kconfig +1 -0
@@ -91,6 +91,7 @@ config SANDBOX select LZO select SPI select SUPPORT_OF_CONTROL + select SYSRESET_CMD_POWEROFF if CMD_POWEROFF imply BITREVERSE select BLOBLIST imply CMD_DM
arch/arm/mach-stm32mp/Makefile +0 -3
@@ -11,9 +11,6 @@ ifdef CONFIG_SPL_BUILD obj-y += spl.o else obj-y += bsec.o -ifndef CONFIG_STM32MP1_TRUSTED -obj-$(CONFIG_SYSRESET) += cmd_poweroff.o -endif endif obj-$(CONFIG_ARMV7_PSCI) += psci.o obj-$(CONFIG_$(SPL_)DM_REGULATOR) += pwr_regulator.o
arch/arm/mach-stm32mp/cmd_poweroff.c deleted +0 -24
@@ -1,24 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause -/* -* Copyright (C) 2019, STMicroelectronics - All Rights Reserved -*/ - -#include <common.h> -#include <command.h> -#include <sysreset.h> - -int do_poweroff (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) -{ -int ret; - -puts ("poweroff ...\n" ); -mdelay (100 ); - - ret =sysreset_walk (SYSRESET_POWER_OFF ); - -if (ret == -EINPROGRESS ) -mdelay (1000 ); - -/*NOTREACHED when power off*/ -return CMD_RET_FAILURE ; -}
drivers/power/pmic/Kconfig +1 -0
@@ -234,6 +234,7 @@ config DM_PMIC_TPS65910 config PMIC_STPMIC1 bool "Enable support for STMicroelectronics STPMIC1 PMIC" depends on DM_PMIC && DM_I2C + select SYSRESET_CMD_POWEROFF if CMD_POWEROFF ---help--- The STPMIC1 PMIC provides 4 BUCKs, 6 LDOs, 1 VREF and 2 power switches. It is accessed via an I2C interface. The device is used with STM32MP1
drivers/sysreset/Kconfig +10 -0
@@ -33,6 +33,16 @@ config TPL_SYSRESET if SYSRESET +if CMD_POWEROFF + +config SYSRESET_CMD_POWEROFF + bool "sysreset implementation of the poweroff command" + help + This should be selected by the appropriate PMIC driver if + the poweroff command is enabled. + +endif + config SYSRESET_GPIO bool "Enable support for GPIO reset driver" select DM_GPIO
drivers/sysreset/sysreset-uclass.c +18 -0
@@ -118,6 +118,24 @@ int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])return 0 ; } +#if IS_ENABLED (CONFIG_SYSRESET_CMD_POWEROFF ) +int do_poweroff (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +{ +int ret; + +puts ("poweroff ...\n" ); +mdelay (100 ); + + ret =sysreset_walk (SYSRESET_POWER_OFF ); + +if (ret == -EINPROGRESS ) +mdelay (1000 ); + +/*NOTREACHED when power off*/ +return CMD_RET_FAILURE ; +} +#endif +static int sysreset_post_bind (struct udevice *dev) {#if defined(CONFIG_NEEDS_MANUAL_RELOC )
Signature · 1 line
2.21.0
PATCH 2/3 sysreset: move stm32mp sysreset poweroff implementation to sysreset uclass
Hi Urja
This patch doesn't compile using the stm32mp15_trusted_defconfig configuration:
...
LD drivers/pinctrl/built-in.o LD drivers/core/built-in.o LD drivers/mmc/built-in.o LD drivers/built-in.o
drivers/sysreset/built-in.o: In function `do_poweroff':
/local/home/nxp11987/projects/community/u-boot.denx/drivers/sysreset/sysreset-uclass.c:123:
multiple definition of `do_poweroff' drivers/firmware/built-in.o:/local/home/nxp11987/projects/community/u-boot.denx/drivers/firmware/psci.c:134:
first defined here
make[1]: *** [drivers/built-in.o] Error 1
make: *** [drivers] Error 2
build error !!
I suggest you to update your patch with :
config PMIC_STPMIC1
bool "Enable support for STMicroelectronics STPMIC1 PMIC" depends on DM_PMIC && DM_I2C
- select SYSRESET_CMD_POWEROFF if CMD_POWEROFF
+ select SYSRESET_CMD_POWEROFF if CMD_POWEROFF && !ARM_PSCI_FW
---help---
The STPMIC1 PMIC provides 4 BUCKs, 6 LDOs, 1 VREF and 2 power switches. It is accessed via an I2C interface. The device is used with STM32MP1 SoCs. This driver implements register read/write operations.
Quoted 141 lines · Urja Rannikko
This is a generic implementation. Add
CONFIG_SYSRESET_CMD_POWEROFFto signal when we need it. Enable it from the STPMIC1 config and in sandbox.The config flag is transitionary, that is it can be removed after all poweroff implementations use sysreset, and just have
CMD_POWEROFFdepend on sysreset.Signed-off-by Urja Rannikko <[email protected]>---
Note: I cant test STM32MP, so I would really appreciate if someone could test this series on that.--- arch/Kconfig | 1 + arch/arm/mach-stm32mp/Makefile | 3 --- arch/arm/mach-stm32mp/cmd_poweroff.c | 24 ------------------------ drivers/power/pmic/Kconfig | 1 + drivers/sysreset/Kconfig | 10 ++++++++++ drivers/sysreset/sysreset-uclass.c | 18 ++++++++++++++++++ 6 files changed, 30 insertions(+), 27 deletions(-) delete mode 100644 arch/arm/mach-stm32mp/cmd_poweroff.carch/Kconfig +1
-0@@ -91,6 +91,7 @@ config SANDBOX select LZO select SPI select SUPPORT_OF_CONTROL + select SYSRESET_CMD_POWEROFF if CMD_POWEROFF imply BITREVERSE select BLOBLIST imply CMD_DMarch/arm/mach-stm32mp/Makefile +0
-3@@ -11,9 +11,6 @@ ifdef CONFIG_SPL_BUILD obj-y += spl.o else obj-y += bsec.o -ifndef CONFIG_STM32MP1_TRUSTED -obj-$(CONFIG_SYSRESET) += cmd_poweroff.o -endif endif obj-$(CONFIG_ARMV7_PSCI) += psci.o obj-$(CONFIG_$(SPL_)DM_REGULATOR) += pwr_regulator.oarch/arm/mach-stm32mp/cmd_poweroff.c deleted +0
-24@@ -1,24 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause -/* -* Copyright (C) 2019, STMicroelectronics - All Rights Reserved -*/ - -#include <common.h> -#include <command.h> -#include <sysreset.h> - -int do_poweroff (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) -{ -int ret; - -puts ("poweroff ...\n" ); -mdelay (100 ); - - ret =sysreset_walk (SYSRESET_POWER_OFF ); - -if (ret == -EINPROGRESS ) -mdelay (1000 ); - -/*NOTREACHED when power off*/ -return CMD_RET_FAILURE ; -}drivers/power/pmic/Kconfig +1
-0@@ -234,6 +234,7 @@ config DM_PMIC_TPS65910 config PMIC_STPMIC1 bool "Enable support for STMicroelectronics STPMIC1 PMIC" depends on DM_PMIC && DM_I2C + select SYSRESET_CMD_POWEROFF if CMD_POWEROFF ---help--- The STPMIC1 PMIC provides 4 BUCKs, 6 LDOs, 1 VREF and 2 power switches. It is accessed via an I2C interface. The device is used with STM32MP1drivers/sysreset/Kconfig +10
-0@@ -33,6 +33,16 @@ config TPL_SYSRESET if SYSRESET +if CMD_POWEROFF + +config SYSRESET_CMD_POWEROFF + bool "sysreset implementation of the poweroff command" + help + This should be selected by the appropriate PMIC driver if + the poweroff command is enabled. + +endif + config SYSRESET_GPIO bool "Enable support for GPIO reset driver" select DM_GPIOdrivers/sysreset/sysreset-uclass.c +18
-0@@ -118,6 +118,24 @@ int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])return 0 ; } +#if IS_ENABLED (CONFIG_SYSRESET_CMD_POWEROFF ) +int do_poweroff (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +{ +int ret; + +puts ("poweroff ...\n" ); +mdelay (100 ); + + ret =sysreset_walk (SYSRESET_POWER_OFF ); + +if (ret == -EINPROGRESS ) +mdelay (1000 ); + +/*NOTREACHED when power off*/ +return CMD_RET_FAILURE ; +} +#endif +static int sysreset_post_bind (struct udevice *dev) {#if defined(CONFIG_NEEDS_MANUAL_RELOC )
PATCH 2/3 sysreset: move stm32mp sysreset poweroff implementation to sysreset uclass
Hi,
Quoted 26 lines · Patrice CHOTARD
Hi Urja
This patch doesn't compile using the
stm32mp15_trusted_defconfigconfiguration:...
LD drivers/pinctrl/built-in.o LD drivers/core/built-in.o LD drivers/mmc/built-in.o LD drivers/built-in.o
drivers/sysreset/built-in.o: In function `do_poweroff':
/local/home/nxp11987/projects/community/u-boot.denx/drivers/sysreset/sysreset-uclass.c:123:
multiple definition of `do_poweroff' drivers/firmware/built-in.o:/local/home/nxp11987/projects/community/u-boot.denx/drivers/firmware/psci.c:134:
first defined here
make[1]: *** [drivers/built-in.o] Error 1
make: *** [drivers] Error 2
build error !!I suggest you to update your patch with :
config
PMIC_STPMIC1
bool "Enable support for STMicroelectronics STPMIC1 PMIC" depends onDM_PMIC&&DM_I2C
drivers/power/pmic/Kconfig config DM_PMIC_TPS65910
Quoted 6 lines
drivers/power/pmic/Kconfig +1
-1- select SYSRESET_CMD_POWEROFF if CMD_POWEROFF + select SYSRESET_CMD_POWEROFF if CMD_POWEROFF && !ARM_PSCI_FW ---help--- The STPMIC1 PMIC provides 4 BUCKs, 6 LDOs, 1 VREF and 2 power switches. It is accessed via an I2C interface. The device is used with STM32MP1 SoCs. This driver implements register read/write operations.
I'll do that in v2, thanks for the test.
Signature · 1 line
Urja Rannikko
PATCH 3/3 rk8xx: add a sysreset driver for poweroff
In reply to Urja RannikkoBased on snooping around the linux kernel rk8xx driver. Tested on an ASUS C201.
--- drivers/power/pmic/Kconfig | 1 + drivers/power/pmic/rk8xx.c | 62 +++++++++++++++++++++++++++++++++++--- include/power/rk8xx_pmic.h | 4 +++ 3 files changed, 63 insertions(+), 4 deletions(-)
drivers/power/pmic/Kconfig +1 -0
@@ -124,6 +124,7 @@ config PMIC_PM8916 config PMIC_RK8XX bool "Enable support for Rockchip PMIC RK8XX" depends on DM_PMIC + select SYSRESET_CMD_POWEROFF if CMD_POWEROFF ---help--- The Rockchip RK808 PMIC provides four buck DC-DC convertors, 8 LDOs, an RTC and two low Rds (resistance (drain to source)) switches. It is
drivers/power/pmic/rk8xx.c +58 -4
93 lines not on this page · raw message
include/power/rk8xx_pmic.h +4 -0
@@ -177,6 +177,10 @@ enum {#define RK8XX_ID_MSK 0xfff0 +/* DEVCTRL bits for poweroff */ +#define DEV_OFF_RST BIT(3) +#define DEV_OFF BIT(0) +struct rk8xx_reg_table {char *name;u8 reg_ctl;
Signature · 1 line
2.21.0
PATCH 3/3 rk8xx: add a sysreset driver for poweroff
Quoted 11 lines · Urja Rannikko
Based on snooping around the linux kernel rk8xx driver. Tested on an ASUS C201.
Signed-off-by Urja Rannikko <[email protected]>--- drivers/power/pmic/Kconfig | 1 + drivers/power/pmic/rk8xx.c | 62 +++++++++++++++++++++++++++++++++++--- include/power/rk8xx_pmic.h | 4 +++ 3 files changed, 63 insertions(+), 4 deletions(-)
PATCH 1/3 sysreset: switch to using SYSRESET_POWER_OFF for poweroff
In reply to Urja RannikkoHi Urja,
Quoted 50 lines
It seems that
SYSRESET_POWER_OFFwas added recently, and all previous code usedSYSRESET_POWERfor poweroff.SYSRESET_POWERis supposed to be a PMIC-level power cycle, not a poweroff.Signed-off-by Urja Rannikko <[email protected]>---
Note: I didnt touch thetest/dm/sysreset.ccode yet, mostly because I wanted to get feedback on this first and that i'd need to understand the tests properly to do that (and i havent used them before at all).--- arch/arm/mach-stm32mp/cmd_poweroff.c | 2 +- arch/sandbox/cpu/state.c | 2 +- drivers/power/pmic/stpmic1.c | 2 +- drivers/sysreset/sysreset_psci.c | 2 +- drivers/sysreset/sysreset_sandbox.c | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-)arch/arm/mach- renamed from arch/arm/mach-stm32mp/cmd_poweroff.c +0
-0
stm32mp/cmd_poweroff.c
indexf54dd1daf2..62347425a0100644arch/arm/mach-stm32mp/cmd_poweroff.c +1
-1@@ -14,7 +14,7 @@ int do_poweroff(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) puts("poweroff ...\n");mdelay (100 ); - ret =sysreset_walk (SYSRESET_POWER ); + ret =sysreset_walk (SYSRESET_POWER_OFF );if (ret == -EINPROGRESS )arch/arm/mach-stm32mp/cmd_poweroff.c +0
-0mdelay (1000 );arch/sandbox/cpu/state.c index renamed from arch/sandbox/cpu/state.c +0
-0
d3b9c05985..dee5fde4f7100644arch/sandbox/cpu/state.c +1
-1@@ -355,7 +355,7 @@ void state_reset_for_test(struct sandbox_state *state) {/* No reset yet, so mark it as such. Always allow power reset */ state->last_sysreset =SYSRESET_COUNT ; - state->sysreset_allowed[SYSRESET_POWER ] = true; + state->sysreset_allowed[SYSRESET_POWER_OFF ] = true;memset (&state->wdt,'\0' ,sizeof (state->wdt)); memset(state->spi, '\0', sizeof(state->spi)); diff --git
a/drivers/power/pmic/stpmic1.cb/drivers/power/pmic/stpmic1.cindex65296c5fc3..eb735f4fe3100644
drivers/power/pmic/stpmic1.c static int stpmic1_sysreset_request(struct udevice *dev, · line 226
Quoted 7 lines
drivers/power/pmic/stpmic1.c +1
-1@@ -221,7 +221,7 @@ static int stpmic1_sysreset_request(struct udevice *dev, enum sysreset_t type)struct udevice *pmic_dev;int ret; -if (type !=SYSRESET_POWER ) +if (type !=SYSRESET_POWER_OFF )return -EPROTONOSUPPORT ;
In fact in the next part of the code, we are supporting only SYSRESET_POWER (reset with PMIC1 switch OFF and restart) and not SYSRESET_POWER_OFF....
because Power Cycle if RREQ_EN=1
I think you need to remove the update on this file for your patch and I will modified this function is to support both mode....
Quoted 36 lines
drivers/power/pmic/stpmic1.c +0
-0ret = uclass_get_device_by_driver(UCLASS_PMIC,drivers/sysreset/sysreset_psci.c +1
-1@@ -18,7 +18,7 @@ static int psci_sysreset_request(struct udevice *dev, enum sysreset_t type)case SYSRESET_COLD : function_id =PSCI_0_2_FN_SYSTEM_RESET ;break ; -case SYSRESET_POWER : +case SYSRESET_POWER_OFF : function_id =PSCI_0_2_FN_SYSTEM_OFF ;break ;drivers/sysreset/sysreset_psci.c +0
-0default :drivers/sysreset/sysreset_sandbox.c +2
-2@@ -57,13 +57,13 @@ static int sandbox_sysreset_request(struct udevice *dev, enum sysreset_t type)case SYSRESET_COLD : state->last_sysreset = type;break ; -case SYSRESET_POWER : +case SYSRESET_POWER_OFF : state->last_sysreset = type;if (!state->sysreset_allowed[type])return -EACCES ;sandbox_exit ();break ; -case SYSRESET_POWER_OFF : +case SYSRESET_POWER :if (!state->sysreset_allowed[type])return -EACCES ;
Quoted 3 lines
default:
--
2.21.0
Regards.
Patrick
PATCH 1/3 sysreset: switch to using SYSRESET_POWER_OFF for poweroff
Hi,
Quoted 7 lines · Patrick DELAUNAY
Hi Urja,
drivers/power/pmic/stpmic1.c static int stpmic1_sysreset_request(struct udevice *dev, enum sysreset_t type) · line 225
Quoted 3 lines
drivers/power/pmic/stpmic1.c +1
-1-if (type !=SYSRESET_POWER ) +if (type !=SYSRESET_POWER_OFF )return -EPROTONOSUPPORT ;
Quoted 8 lines
In fact in the next part of the code, we are supporting only
SYSRESET_POWER(reset with PMIC1 switch OFF and restart) and notSYSRESET_POWER_OFF....because Power Cycle if RREQ_EN=1
I think you need to remove the update on this file for your patch and I will modified this function is to support both mode....
Okay I will drop this part, but just to confirm... this means that currently you have a configuration where using the poweroff command causes a power-cycle? Neat.
Signature · 1 line
Urja Rannikko
PATCH 1/3 sysreset: switch to using SYSRESET_POWER_OFF for poweroff
Hi Urja,
Quoted 16 lines
Hi,
Quoted 11 lines · Patrick DELAUNAY
Hi Urja,
drivers/power/pmic/stpmic1.c static int stpmic1_sysreset_request(struct udevice *dev, enum sysreset_t type) · line 225
Quoted 3 lines
drivers/power/pmic/stpmic1.c +1
-1-if (type !=SYSRESET_POWER ) +if (type !=SYSRESET_POWER_OFF )return -EPROTONOSUPPORT ;In fact in the next part of the code, we are supporting only
SYSRESET_POWER(reset with PMIC1 switch OFF and restart) and notSYSRESET_POWER_OFF....
Quoted 6 lines
Quoted 4 lines
because Power Cycle if RREQ_EN=1
I think you need to remove the update on this file for your patch and I will modified this function is to support both mode....
Okay I will drop this part, but just to confirm... this means that currently you have a configuration where using the poweroff command causes a power-cycle? Neat.
Yes and it was stange.
I choose it at the beginning of the project because for some hardware configuration with STPMIC1, the VDD continue to be provided by the cell even if the power supply is still present in power off mode; HW team ask me to avoid this case, to avoid the cell usage.
But it is more a workaround for the bad HW configuration, and I forget this point when I upstream the driver...
Your patch allow me to correct this point now (with http://patchwork.ozlabs.org/patch/1101856/) and I come back to a normal behavior in the driver : driver execute the requested command.
Regards
Patrick
Quoted 2 lines
--
Urja Rannikko
PATCH 1/3 sysreset: switch to using SYSRESET_POWER_OFF for poweroff
Hi Urja and Simon,
Does this patch still needed? Since this patch delegate to u-boot-rockchip maintainer Philipp now,
I would like to know what should I do for this patch.
Thanks,
- Kever
Quoted 54 lines · Patrick DELAUNAY <[email protected]> 于2019年5月20日周一 下午9:38写道:
Hi Urja,
Quoted 16 lines
Hi,
Quoted 11 lines · Patrick DELAUNAY
Hi Urja,
drivers/power/pmic/stpmic1.c static int stpmic1_sysreset_request(struct udevice *dev, enum sysreset_t type) · line 225
Quoted 3 lines
drivers/power/pmic/stpmic1.c +1
-1-if (type !=SYSRESET_POWER ) +if (type !=SYSRESET_POWER_OFF )return -EPROTONOSUPPORT ;In fact in the next part of the code, we are supporting only
SYSRESET_POWER(reset with PMIC1 switch OFF and restart) and notSYSRESET_POWER_OFF....Quoted 5 lines
Quoted 4 lines
because Power Cycle if RREQ_EN=1
I think you need to remove the update on this file for your patch and I will modified this function is to support both mode....
Okay I will drop this part, but just to confirm... this means that
currently you have
Quoted 1 line
a configuration where using the poweroff command causes a power-cycle?
Neat.
Yes and it was stange.
I choose it at the beginning of the project because for some hardware configuration with STPMIC1, the VDD continue to be provided by the cell even
if the power supply is still present in power off mode; HW team ask me to avoid this case,
to avoid the cell usage.But it is more a workaround for the bad HW configuration, and I forget this point when I upstream the driver...
Your patch allow me to correct this point now (with
http://patchwork.ozlabs.org/patch/1101856/) and
I come back to a normal behavior in the driver : driver execute the requested command.Regards
PatrickQuoted 2 lines
--
Urja Rannikko_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot