Skip to contentSkip to conversation

tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()

PATCH In review Thomas Huth 3 participants 3 messages May 13, 2019 – May 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()

These functions are convenience wrappers of qtest_init() and not of qtest_start().

---
 tests/libqtest.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/libqtest.h +2 -2
index 3f7675fcf0..a98ea15b7d 100644
@@ -29,7 +29,7 @@ extern QTestState *global_qtest;
  * @fmt...: Format for creating other arguments to pass to QEMU, formatted
  * like sprintf().
  *
- * Convenience wrapper around qtest_start().
+ * Convenience wrapper around qtest_init().
  *
  * Returns: #QTestState instance.
  */
@@ -41,7 +41,7 @@ QTestState *qtest_initf(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
  * like vsprintf().
  * @ap: Format arguments.
  *
- * Convenience wrapper around qtest_start().
+ * Convenience wrapper around qtest_init().
  *
  * Returns: #QTestState instance.
  */
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Thomas Huth

These functions are convenience wrappers of qtest_init() and not of qtest_start().

---
 tests/libqtest.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 2 lines · Thomas Huth

These functions are convenience wrappers of qtest_init() and not of qtest_start().

Maybe "The qtest_vinitf() and qtest_initf() functions are convenience wrappers of qtest_init() and not of qtest_start()." as it is easier to read the commit description in some git review tools (gitk i.e.).

Quoted 2 lines
Quoted 27 lines
---
 tests/libqtest.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/libqtest.h +2 -2
index 3f7675fcf0..a98ea15b7d 100644
@@ -29,7 +29,7 @@ extern QTestState *global_qtest;
  * @fmt...: Format for creating other arguments to pass to QEMU, formatted
  * like sprintf().
  *
- * Convenience wrapper around qtest_start().
+ * Convenience wrapper around qtest_init().
  *
  * Returns: #QTestState instance.
  */
@@ -41,7 +41,7 @@ QTestState *qtest_initf(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
  * like vsprintf().
  * @ap: Format arguments.
  *
- * Convenience wrapper around qtest_start().
+ * Convenience wrapper around qtest_init().
  *
  * Returns: #QTestState instance.
  */