drm/i915: Engine relative MMIO
PATCH 1/1 drm/i915: Engine relative MMIO
From: John Harrison <[email protected]>
With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated. This means that the request itself must be engine agnostic - any direct register writes must be relative to the engine and not absolute addresses.
The LRI command has support for engine relative addressing. However, the mechanism is not transparent to the driver. The scheme for Gen11 (MI_LRI_ADD_CS_MMIO_START) requires the LRI address to have no absolute engine base component. The hardware then adds on the correct engine offset at execution time.
Due to the non-trivial and differing schemes on different hardware, it is not possible to simply update the code that creates the LRI commands to set a remap flag and let the hardware get on with it. Instead, this patch adds function wrappers for generating the LRI command itself and then for constructing the correct address to use with the LRI.
v2: Fix build break in GVT. Remove flags parameter [review feedback from Chris W].
v3: Fix build break in selftest. Rebase to newer base tree and fix merge conflict.
v4: More rebasing. Rmoved relative addressing support from Gen7-9 only code paths [review feedback from Chris W].
v5: More rebasing (new 'gt' directory). Fix white space issue. Use COPY class rather than BCS0 id for checking against BCS engine.
--- drivers/gpu/drm/i915/gt/intel_engine.h | 4 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 +++ drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 6 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 79 ++++++++++--------- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 4 +- drivers/gpu/drm/i915/gt/intel_mocs.c | 17 ++-- drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 45 +++++++++-- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 +- .../gpu/drm/i915/gt/selftest_workarounds.c | 13 +-- drivers/gpu/drm/i915/gvt/mmio_context.c | 16 +++- drivers/gpu/drm/i915/i915_cmd_parser.c | 4 +- drivers/gpu/drm/i915/i915_gem_context.c | 12 +-- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 3 +- drivers/gpu/drm/i915/i915_perf.c | 19 +++-- 14 files changed, 156 insertions(+), 81 deletions(-)
drivers/gpu/drm/i915/gt/intel_engine.h +4 -0
@@ -546,4 +546,8 @@ static inline bool inject_preempt_hang(struct intel_engine_execlists *execlists)#endif +bool i915_engine_has_relative_lri (const struct intel_engine_cs *engine); +u32 i915_get_lri_cmd (const struct intel_engine_cs *engine,u32 word_count); +u32 i915_get_lri_reg (const struct intel_engine_cs *engine,i915_reg_t reg); +#endif /* _INTEL_RINGBUFFER_H_ */
drivers/gpu/drm/i915/gt/intel_engine_cs.c +11 -0
@@ -253,6 +253,17 @@ static u32 __engine_mmio_base(struct drm_i915_private *i915,return bases[i].base; } +bool i915_engine_has_relative_lri (const struct intel_engine_cs *engine) +{ +if (INTEL_GEN (engine->i915) <11 ) +return false; + +if (engine->class ==COPY_ENGINE_CLASS ) +return false; + +return true; +} +static void __sprint_engine_name (char *name,const struct engine_info *info) { WARN_ON(snprintf(name, INTEL_ENGINE_CS_MAX_NAME, "%s%u",
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +5 -1
@@ -123,9 +123,13 @@* simply ignores the register load under certain conditions. * - One can actually load arbitrary many arbitrary registers: Simply issue x * address/value pairs. Don't overdue it, though, x <= 2^4 must hold! +* - Newer hardware supports engine relative addresses but older hardware does +* not. So never call MI_LRI directly, always use the i915_get_lri_cmd() +* and i915_get_lri_reg() helper functions. */ -#define MI_LOAD_REGISTER_IMM (x) MI_INSTR(0x22, 2*(x)-1) +#define __MI_LOAD_REGISTER_IMM (x) MI_INSTR(0x22, 2*(x)-1)#define MI_LRI_FORCE_POSTED (1<<12) +#define MI_LRI_ADD_CS_MMIO_START_GEN11 (1<<19)#define MI_STORE_REGISTER_MEM MI_INSTR(0x24, 1)#define MI_STORE_REGISTER_MEM_GEN8 MI_INSTR(0x24, 2)#define MI_SRM_LRM_GLOBAL_GTT (1<<22)
drivers/gpu/drm/i915/gt/intel_lrc.c +43 -36
149 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_lrc_reg.h +2 -2
@@ -39,10 +39,10 @@#define CTX_R_PWR_CLK_STATE 0x42#define CTX_END 0x44 -#define CTX_REG (reg_state, pos, reg, val) do { \ +#define CTX_REG (engine, reg_state, pos, reg, val) do { \ u32 *reg_state__ = (reg_state); \ const u32 pos__ = (pos); \ - (reg_state__)[(pos__) + 0] = i915_mmio_reg_offset(reg); \ + (reg_state__)[(pos__) + 0] = i915_get_lri_reg((engine), (reg)); \ (reg_state__)[(pos__) + 1] = (val); \ } while (0)
drivers/gpu/drm/i915/gt/intel_mocs.c +10 -7
@@ -324,9 +324,6 @@ static u32 get_entry_control(const struct drm_i915_mocs_table *table,/** * intel_mocs_init_engine() - emit the mocs control table * @engine: The engine for whom to emit the registers. -* -* This function simply emits a MI_LOAD_REGISTER_IMM command for the -* given table starting at the given address. */ void intel_mocs_init_engine (struct intel_engine_cs *engine) {
@@ -380,18 +377,20 @@ static int emit_mocs_control_table(struct i915_request *rq,if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (table->n_entries); + *cs++ =i915_get_lri_cmd (rq->engine, table->n_entries);for (index =0 ; index < table->size; index++) {u32 value =get_entry_control (table, index); - *cs++ =i915_mmio_reg_offset (mocs_register (engine, index)); + *cs++ =i915_get_lri_reg (rq->engine, +mocs_register (engine, index)); *cs++ = value; }/* All remaining entries are also unused */ for (; index < table->n_entries; index++) { - *cs++ =i915_mmio_reg_offset (mocs_register (engine, index)); + *cs++ =i915_get_lri_reg (rq->engine, +mocs_register (engine, index)); *cs++ = unused_value; }
@@ -449,7 +448,11 @@ static int emit_mocs_l3cc_table(struct i915_request *rq,if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (table->n_entries /2 ); +/* +* GEN9_LNCFCMOCS is not engine relative, therefore there is no +* need for relative addressing? +*/ + *cs++ =__MI_LOAD_REGISTER_IMM (table->n_entries /2 );for (i =0 ; i < table->size /2 ; i++) {u16 low =get_entry_l3cc (table,2 * i);
drivers/gpu/drm/i915/gt/intel_ringbuffer.c +37 -8
75 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_workarounds.c +2 -2
@@ -625,9 +625,9 @@ int intel_engine_emit_ctx_wa(struct i915_request *rq)if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (wal->count); + *cs++ =i915_get_lri_cmd (rq->engine, wal->count);for (i =0 , wa = wal->list; i < wal->count; i++, wa++) { - *cs++ =i915_mmio_reg_offset (wa->reg); + *cs++ =i915_get_lri_reg (rq->engine, wa->reg); *cs++ = wa->val; } *cs++ =MI_NOOP ;
drivers/gpu/drm/i915/gt/selftest_workarounds.c +7 -6
@@ -442,6 +442,7 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx,for (i =0 ; i < engine->whitelist.count; i++) {u32 reg =i915_mmio_reg_offset (engine->whitelist.list[i].reg); +u32 regLRI =i915_get_lri_reg (engine, engine->whitelist.list[i].reg);u64 addr = scratch->node.start;struct i915_request *rq;u32 srm, lrm, rsvd;
@@ -474,8 +475,8 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx, idx =1 ;for (v =0 ; v <ARRAY_SIZE (values); v++) {/* LRI garbage */ - *cs++ =MI_LOAD_REGISTER_IMM (1 ); - *cs++ = reg; + *cs++ =i915_get_lri_cmd (engine,1 ); + *cs++ = regLRI; *cs++ = values[v];/* SRM result */
@@ -487,8 +488,8 @@ static int check_dirty_whitelist(struct i915_gem_context *ctx, }for (v =0 ; v <ARRAY_SIZE (values); v++) {/* LRI garbage */ - *cs++ =MI_LOAD_REGISTER_IMM (1 ); - *cs++ = reg; + *cs++ =i915_get_lri_cmd (engine,1 ); + *cs++ = regLRI; *cs++ = ~values[v];/* SRM result */
@@ -757,9 +758,9 @@ static int scrub_whitelisted_registers(struct i915_gem_context *ctx, goto err_batch; } - *cs++ =MI_LOAD_REGISTER_IMM (engine->whitelist.count); + *cs++ =i915_get_lri_cmd (engine, engine->whitelist.count);for (i =0 ; i < engine->whitelist.count; i++) { - *cs++ =i915_mmio_reg_offset (engine->whitelist.list[i].reg); + *cs++ =i915_get_lri_reg (engine, engine->whitelist.list[i].reg); *cs++ =0xffffffff ; } *cs++ =MI_BATCH_BUFFER_END ;
drivers/gpu/drm/i915/gvt/mmio_context.c +12 -4
@@ -200,14 +200,14 @@ restore_context_mmio_for_inhibit(struct intel_vgpu *vgpu,if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (count); + *cs++ =i915_get_lri_cmd (req->engine, count);for (mmio = gvt->engine_mmio_list.mmio;i915_mmio_reg_valid (mmio->reg); mmio++) {if (mmio->ring_id != ring_id || !mmio->in_context)continue ; - *cs++ =i915_mmio_reg_offset (mmio->reg); + *cs++ =i915_get_lri_reg (req->engine, mmio->reg); *cs++ =vgpu_vreg_t (vgpu, mmio->reg) | (mmio->mask <<16 ); gvt_dbg_core("add lri reg pair 0x%x:0x%x in inhibit ctx, vgpu:%d, rind_id:%d\n",
@@ -235,7 +235,11 @@ restore_render_mocs_control_for_inhibit(struct intel_vgpu *vgpu,if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (GEN9_MOCS_SIZE ); +/* +* GEN9_GFX_MOCS is not engine relative, therefore there is no +* need for relative addressing. +*/ + *cs++ =__MI_LOAD_REGISTER_IMM (GEN9_MOCS_SIZE );for (index =0 ; index <GEN9_MOCS_SIZE ; index++) { *cs++ =i915_mmio_reg_offset (GEN9_GFX_MOCS (index));
@@ -262,7 +266,11 @@ restore_render_mocs_l3cc_for_inhibit(struct intel_vgpu *vgpu,if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (GEN9_MOCS_SIZE /2 ); +/* +* GEN9_LNCFCMOCS is not engine relative, therefore there is no +* need for relative addressing. +*/ + *cs++ =__MI_LOAD_REGISTER_IMM (GEN9_MOCS_SIZE /2 );for (index =0 ; index <GEN9_MOCS_SIZE /2 ; index++) { *cs++ =i915_mmio_reg_offset (GEN9_LNCFCMOCS (index));
drivers/gpu/drm/i915/i915_cmd_parser.c +2 -2
@@ -221,7 +221,7 @@ static const struct drm_i915_cmd_descriptor common_cmds[] = {CMD (MI_SUSPEND_FLUSH ,SMI ,F ,1 ,S ),CMD (MI_SEMAPHORE_MBOX ,SMI , !F ,0xFF ,R ),CMD (MI_STORE_DWORD_INDEX ,SMI , !F ,0xFF ,R ), -CMD (MI_LOAD_REGISTER_IMM (1 ),SMI , !F ,0xFF ,W , +CMD (__MI_LOAD_REGISTER_IMM (1 ),SMI , !F ,0xFF ,W , .reg = { .offset = 1, .mask = 0x007FFFFC, .step = 2 } ), CMD( MI_STORE_REGISTER_MEM, SMI, F, 3, W | B, .reg = { .offset = 1, .mask = 0x007FFFFC },
@@ -1183,7 +1183,7 @@ static bool check_cmd(const struct intel_engine_cs *engine,return false; } -if (desc->cmd.value ==MI_LOAD_REGISTER_IMM (1 ) && +if (desc->cmd.value ==__MI_LOAD_REGISTER_IMM (1 ) && (offset +2 > length || (cmd[offset +1 ] & reg->mask) != reg->value)) { DRM_DEBUG_DRIVER("CMD: Rejected LRI to masked register 0x%08X\n",
drivers/gpu/drm/i915/i915_gem_context.c +6 -6
@@ -1026,11 +1026,11 @@ static int emit_ppgtt_update(struct i915_request *rq, void *data)if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (2 ); + *cs++ =i915_get_lri_cmd (engine,2 ); - *cs++ =i915_mmio_reg_offset (GEN8_RING_PDP_UDW (base,0 )); + *cs++ =i915_get_lri_reg (engine,GEN8_RING_PDP_UDW (base,0 )); *cs++ =upper_32_bits (pd_daddr); - *cs++ =i915_mmio_reg_offset (GEN8_RING_PDP_LDW (base,0 )); + *cs++ =i915_get_lri_reg (engine,GEN8_RING_PDP_LDW (base,0 )); *cs++ =lower_32_bits (pd_daddr); *cs++ =MI_NOOP ;
@@ -1040,13 +1040,13 @@ static int emit_ppgtt_update(struct i915_request *rq, void *data)if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (2 *GEN8_3LVL_PDPES ); + *cs++ =i915_get_lri_cmd (engine,2 *GEN8_3LVL_PDPES );for (i =GEN8_3LVL_PDPES ; i--; ) {const dma_addr_t pd_daddr =i915_page_dir_dma_addr (ppgtt, i); - *cs++ =i915_mmio_reg_offset (GEN8_RING_PDP_UDW (base, i)); + *cs++ =i915_get_lri_reg (engine,GEN8_RING_PDP_UDW (base, i)); *cs++ =upper_32_bits (pd_daddr); - *cs++ =i915_mmio_reg_offset (GEN8_RING_PDP_LDW (base, i)); + *cs++ =i915_get_lri_reg (engine,GEN8_RING_PDP_LDW (base, i)); *cs++ =lower_32_bits (pd_daddr); } *cs++ =MI_NOOP ;
drivers/gpu/drm/i915/i915_gem_execbuffer.c +2 -1
@@ -1963,7 +1963,8 @@ static int i915_reset_gen7_sol_offsets(struct i915_request *rq)if (IS_ERR (cs))return PTR_ERR (cs); - *cs++ =MI_LOAD_REGISTER_IMM (4 ); +/* Gen7 only so no need to support relative offsets */ + *cs++ =__MI_LOAD_REGISTER_IMM (4 );for (i =0 ; i <4 ; i++) { *cs++ =i915_mmio_reg_offset (GEN7_SO_WRITE_OFFSET (i)); *cs++ =0 ;
drivers/gpu/drm/i915/i915_perf.c +13 -6
@@ -1636,7 +1636,8 @@ static void hsw_disable_metric_set(struct drm_i915_private *dev_priv)* in the case that the OA unit has been disabled. */ static void -gen8_update_reg_state_unlocked (struct intel_context *ce, +gen8_update_reg_state_unlocked (struct intel_engine_cs *engine, +struct intel_context *ce,u32 *reg_state,const struct i915_oa_config *oa_config) {
@@ -1655,7 +1656,12 @@ gen8_update_reg_state_unlocked(struct intel_context *ce, };int i; -CTX_REG (reg_state, ctx_oactxctrl,GEN8_OACTXCONTROL , +/* +* NB: The LRI instruction is generated by the hardware. +* Should we read it in and assert that the offset flag is set? +*/ + +CTX_REG (engine, reg_state, ctx_oactxctrl,GEN8_OACTXCONTROL , (i915->perf.oa.period_exponent <<GEN8_OA_TIMER_PERIOD_SHIFT ) | (i915->perf.oa.periodic ?GEN8_OA_TIMER_ENABLE :0 ) |GEN8_OA_COUNTER_RESUME );
@@ -1682,10 +1688,10 @@ gen8_update_reg_state_unlocked(struct intel_context *ce, } } -CTX_REG (reg_state, state_offset, flex_regs[i], value); +CTX_REG (engine, reg_state, state_offset, flex_regs[i], value); } -CTX_REG (reg_state, +CTX_REG (engine, reg_state,CTX_R_PWR_CLK_STATE ,GEN8_R_PWR_CLK_STATE ,intel_sseu_make_rpcs (i915, &ce->sseu)); }
@@ -1770,7 +1776,7 @@ static int gen8_configure_all_contexts(struct drm_i915_private *dev_priv, ce->state->obj->mm.dirty = true; regs +=LRC_STATE_PN *PAGE_SIZE /sizeof (*regs); -gen8_update_reg_state_unlocked (ce, regs, oa_config); +gen8_update_reg_state_unlocked (dev_priv->engine[RCS0 ], ce, regs, oa_config);i915_gem_object_unpin_map (ce->state->obj); }
@@ -2166,7 +2172,8 @@ void i915_oa_init_reg_state(struct intel_engine_cs *engine, stream = engine->i915->perf.oa.exclusive_stream;if (stream) -gen8_update_reg_state_unlocked (ce, regs, stream->oa_config); +gen8_update_reg_state_unlocked (engine, ce, regs, + stream->oa_config); }/**
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine relative MMIO (rev6)
== Series Details ==
== Series Details ==
Series: drm/i915: Engine relative MMIO (rev6)
URL : https://patchwork.freedesktop.org/series/57117/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1d0e020ea850 drm/i915: Engine relative MMIO
-:90: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#90: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x) MI_INSTR(0x22, 2*(x)-1)
^-:90: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #90: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x) MI_INSTR(0x22, 2*(x)-1)
^
-:92: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #92: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:132:
+#define MI_LRI_ADD_CS_MMIO_START_GEN11 (1<<19)
^
-:379: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #379: FILE: drivers/gpu/drm/i915/gt/intel_ringbuffer.c:1699:
+ *cs++ = i915_get_lri_cmd(rq->engine, GEN7_L3LOG_SIZE/4);
^
-:434: CHECK:CAMELCASE: Avoid CamelCase: <regLRI> #434: FILE: drivers/gpu/drm/i915/gt/selftest_workarounds.c:445:
+ u32 regLRI = i915_get_lri_reg(engine, engine->whitelist.list[i].reg);
-:528: ERROR:SPACING: space prohibited after that open parenthesis '(' #528: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:224:
+ CMD( __MI_LOAD_REGISTER_IMM(1), SMI, !F, 0xFF, W,
-:529: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #529: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:225:
+ CMD( __MI_LOAD_REGISTER_IMM(1), SMI, !F, 0xFF, W,
.reg = { .offset = 1, .mask = 0x007FFFFC, .step = 2 } ),
total: 1 errors, 0 warnings, 6 checks, 514 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Engine relative MMIO (rev6)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915: Engine relative MMIO (rev6)
URL : https://patchwork.freedesktop.org/series/57117/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6077 -> Patchwork_13012
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/
Known issues
------------
Here are the changes found in Patchwork_13012 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6700k2: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108] / [fdo#107773])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/fi-skl-6700k2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/fi-skl-6700k2/igt@[email protected]
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/fi-blb-e6850/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-apl-guc: [PASS][5] -> [DMESG-WARN][6] ([fdo#110512])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/fi-apl-guc/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/fi-apl-guc/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: [DMESG-WARN][7] ([fdo#110512]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/fi-apl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/fi-apl-guc/igt@[email protected]
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#110512]: https://bugs.freedesktop.org/show_bug.cgi?id=110512
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6077 -> Patchwork_13012
CI_DRM_6077: f175074b17cfeb7d64cfcfd6b2641641a10d4deb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4984: 66c887d2f7a92a4a97acd9611d5342afc5d4f815 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13012: 1d0e020ea850dba6e7cf125dc061119eaf48eca6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1d0e020ea850 drm/i915: Engine relative MMIO
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Engine relative MMIO (rev6)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915: Engine relative MMIO (rev6)
URL : https://patchwork.freedesktop.org/series/57117/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6077_full -> Patchwork_13012_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13012_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen}:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl9/igt@[email protected]
* {igt@kms_cursor_crc@pipe-a-cursor-suspend}:
- shard-apl: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-apl5/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_13012_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries_display_off:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([fdo#104108])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl2/igt@debugfs_test@read_all_entries_display_off.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl6/igt@debugfs_test@read_all_entries_display_off.html
* igt@gem_eio@in-flight-suspend:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-apl7/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#108686])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-iclb6/igt@[email protected]
* igt@i915_pm_rpm@pm-tiling:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([fdo#107807])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl4/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [PASS][13] -> [FAIL][14] ([fdo#103355])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-hsw6/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#103184] / [fdo#103232])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl9/igt@[email protected]
* igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-hsw: [PASS][17] -> [DMESG-WARN][18] ([fdo#102614])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw4/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-hsw5/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][19] -> [INCOMPLETE][20] ([fdo#107773] / [fdo#109507])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#103167]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-iclb6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108040])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
#### Possible fixes ####
* igt@i915_pm_rpm@i2c:
- shard-skl: [INCOMPLETE][27] ([fdo#107807]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl1/igt@[email protected]
* igt@i915_pm_rps@waitboost:
- shard-apl: [FAIL][29] ([fdo#102250]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-apl1/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-apl6/igt@[email protected]
* {igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque}:
- shard-skl: [FAIL][33] -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl3/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][35] ([fdo#109507]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl9/igt@[email protected]
* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-skl: [FAIL][37] ([fdo#107931] / [fdo#108303]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][41] ([fdo#108145]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][45] ([fdo#100047]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb3/igt@kms_sysfs_edid_timing.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-iclb7/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-skl: [SKIP][47] ([fdo#109271]) -> [INCOMPLETE][48] ([fdo#107807])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/shard-skl2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6077 -> Patchwork_13012
CI_DRM_6077: f175074b17cfeb7d64cfcfd6b2641641a10d4deb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4984: 66c887d2f7a92a4a97acd9611d5342afc5d4f815 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13012: 1d0e020ea850dba6e7cf125dc061119eaf48eca6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13012/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx