Some new features for the latency tracers
Subsystems (4)
v3 cover Some new features for the latency tracers
Hello all,
Changes in v3:
- [PATCH 1/4]:
* I have generalized this to send the fsnotify() notifications for all tracers that use tracing_max_latency.
* There are large additions of code to prevent queue_work() from being called while we are in __schedule() or do_idle(). This was a bug also in the previous version but had gone unnoticed. It became very visible when I tried to make it work with the wakeup tracers because they are always invoked from the sched_switch tracepoint.
* The fsnotify notification is issued for tracing_max_latency, not trace.
* I got rid of the kernel config option. The facility is always compiled when CONFIG_FSNOTIFY is enabled and any of the latency tracers are enabled.
- [PATCH 2/4]:
* No significant changes.
- [PATCH 3/4]:
* The latency-collector help messages have been tuned to the fact that it can be used also with wakeup and hwlat tracers.
* I increased the size of the buffer for reading from /sys/kernel/debug/tracing/trace.
* Adapted it to monitor tracing_max_latency instead of trace
- [PATCH 4/4]:
* I converted this from a kernel config option to a trace config option that can be changed at runtime.
This series is meant to address two issues with the latency tracing.
The first three patches provide a method to trace latencies that always occurs very close to each other and to differentiate between them, in spite of the fact that the latency tracers always work in overwrite mode.
[PATCH 1/4] This implement fs notification for preempt/irqsoff. It makes it possible for userspace to detect when a new latency has been detected.
[PATCH 2/4] This extends the preemptirq_delay_test module so that it can be used to generate a burst of closely occurring latencies.
[PATCH 3/4] This adds a user space program to the tools directory that utilizes the fs notification feature and a randomized algorithm to print out any of the latencies in a burst with approximately equal probability.
The last patch is not directly connected but doesn't apply cleanly on its own:
[PATCH 4/4] This adds the option console-latency to the trace options.
best regards,
Viktor
Viktor Rosendahl (4):
ftrace: Implement fs notification for tracing_max_latency
preemptirq_delay_test: Add the burst feature and a sysfs trigger Add the latency-collector to tools
ftrace: Add an option for tracing console latencies
include/linux/irqflags.h | 21 + include/trace/events/power.h | 40 + include/trace/events/sched.h | 40 + kernel/printk/printk.c | 6 +- kernel/sched/core.c | 2 + kernel/sched/idle.c | 2 + kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 145 ++- kernel/trace/trace.c | 160 +++- kernel/trace/trace.h | 11 + kernel/trace/trace_hwlat.c | 4 +- kernel/trace/trace_irqsoff.c | 12 + tools/Makefile | 14 +- tools/trace/Makefile | 20 + tools/trace/latency-collector.c | 1211 ++++++++++++++++++++++++++ 15 files changed, 1661 insertions(+), 33 deletions(-) create mode 100644 tools/trace/Makefile create mode 100644 tools/trace/latency-collector.c
Signature · 1 line
2.17.1
PATCH v3 1/4 ftrace: Implement fs notification for tracing_max_latency
This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framework when a new latency is available.
One particularly interesting use of this facility is when enabling threshold tracing, through /sys/kernel/debug/tracing/tracing_thresh, together with the preempt/irqsoff tracers. This makes it possible to implement a user space program that can, with equal probability, obtain traces of latencies that occur immediately after each other in spite of the fact that the preempt/irqsoff tracers operate in overwrite mode.
This facility works with the hwlat, preempt/irqsoff, and wakeup tracers.
This patch also add four new tracepoints, for entering/exiting __schedule() and do_idle(). Those tracepoints are needed to disable and enable the notificaton facility because we cannot wake up the workqueue from these critical sections without risking a deadlock. Similar problems would also arise if we try to schedule a tasklet, raise a softirq, or wake up a kernel thread.
If a notification event would happen in the forbidden sections, we schedule the fsnotify work as soon as we have exited do_idle()/__schedule().
--- include/trace/events/power.h | 40 +++++++++ include/trace/events/sched.h | 40 +++++++++ kernel/sched/core.c | 2 + kernel/sched/idle.c | 2 + kernel/trace/trace.c | 160 ++++++++++++++++++++++++++++++++++- kernel/trace/trace.h | 10 +++ kernel/trace/trace_hwlat.c | 4 +- 7 files changed, 255 insertions(+), 3 deletions(-)
include/trace/events/power.h +40 -0
@@ -40,6 +40,46 @@ DEFINE_EVENT(cpu, cpu_idle,TP_ARGS (state, cpu_id) ); +/* +* Tracepoint for entering do_idle(): +*/ +TRACE_EVENT (do_idle_enter, + + TP_PROTO(int cpu), + +TP_ARGS (cpu), + +TP_STRUCT__entry ( +__field (int, cpu) + ), + +TP_fast_assign ( + __entry->cpu = cpu; + ), + +TP_printk ("cpu=%d" , __entry->cpu) +); + +/* +* Tracepoint for exiting do_idle(): +*/ +TRACE_EVENT (do_idle_exit, + + TP_PROTO(int cpu), + +TP_ARGS (cpu), + +TP_STRUCT__entry ( +__field (int, cpu) + ), + +TP_fast_assign ( + __entry->cpu = cpu; + ), + +TP_printk ("cpu=%d" , __entry->cpu) +); + TRACE_EVENT(powernv_throttle, TP_PROTO(int chip_id, const char *reason, int pmax),
include/trace/events/sched.h +40 -0
@@ -183,6 +183,46 @@ TRACE_EVENT(sched_switch, __entry->next_comm, __entry->next_pid, __entry->next_prio) ); +/* +* Tracepoint for entering __schedule(): +*/ +TRACE_EVENT (sched_schedule_enter, + + TP_PROTO(int cpu), + +TP_ARGS (cpu), + +TP_STRUCT__entry ( +__field (int, cpu) + ), + +TP_fast_assign ( + __entry->cpu = cpu; + ), + +TP_printk ("cpu=%d" , __entry->cpu) +); + +/* +* Tracepoint for exiting __schedule(): +*/ +TRACE_EVENT (sched_schedule_exit, + + TP_PROTO(int cpu), + +TP_ARGS (cpu), + +TP_STRUCT__entry ( +__field (int, cpu) + ), + +TP_fast_assign ( + __entry->cpu = cpu; + ), + +TP_printk ("cpu=%d" , __entry->cpu) +); +/* * Tracepoint for a task being migrated: */
kernel/sched/core.c +2 -0
@@ -3374,6 +3374,7 @@ static void __sched notrace __schedule(bool preempt)int cpu; cpu =smp_processor_id (); +trace_sched_schedule_enter (cpu); rq =cpu_rq (cpu); prev = rq->curr;
@@ -3448,6 +3449,7 @@ static void __sched notrace __schedule(bool preempt) }balance_callback (rq); +trace_sched_schedule_exit (cpu); }void __noreturn do_task_dead (void )
kernel/sched/idle.c +2 -0
@@ -224,6 +224,7 @@ static void cpuidle_idle_call(void)static void do_idle (void ) {int cpu =smp_processor_id (); +trace_do_idle_enter (cpu);/* * If the arch has a polling bit, we maintain an invariant: *
@@ -287,6 +288,7 @@ static void do_idle(void)if (unlikely (klp_patch_pending (current)))klp_update_patch_state (current); +trace_do_idle_exit (cpu); }bool cpu_in_idle (unsigned long pc)
kernel/trace/trace.c +158 -2
190 lines not on this page · raw message
kernel/trace/trace.h +10 -0
@@ -17,6 +17,7 @@#include <linux/compiler.h> #include <linux/trace_seq.h> #include <linux/glob.h> +#include <linux/workqueue.h> #ifdef CONFIG_FTRACE_SYSCALLS #include <asm/unistd.h> /* For NR_SYSCALLS */
@@ -265,6 +266,10 @@ struct trace_array {#endif #if defined(CONFIG_TRACER_MAX_TRACE ) || defined(CONFIG_HWLAT_TRACER )unsigned long max_latency; +#ifdef CONFIG_FSNOTIFY +struct dentry *d_max_latency; +struct work_struct fsnotify_work; +#endif #endif struct trace_pid_list __rcu *filtered_pids;/*
@@ -781,6 +786,11 @@ void update_max_tr_single(struct trace_array *tr, struct task_struct *tsk, int cpu);#endif /* CONFIG_TRACER_MAX_TRACE */ +#if (defined(CONFIG_TRACER_MAX_TRACE ) || defined(CONFIG_HWLAT_TRACER )) && \ + defined(CONFIG_FSNOTIFY ) +void trace_maxlat_fsnotify (struct trace_array *tr); +#endif +#ifdef CONFIG_STACKTRACE void __trace_stack (struct trace_array *tr,unsigned long flags,int skip,int pc);
kernel/trace/trace_hwlat.c +3 -1
@@ -254,8 +254,10 @@ static int get_sample(void)trace_hwlat_sample (&s);/* Keep a running maximum ever recorded hardware latency */ -if (sample > tr->max_latency) +if (sample > tr->max_latency) { tr->max_latency = sample; +trace_maxlat_fsnotify (tr); + } } out:
Signature · 1 line
2.17.1
PATCH v3 2/4 preemptirq_delay_test: Add the burst feature and a sysfs trigger
In reply to Viktor RosendahlThis burst feature enables the user to generate a burst of preempt/irqsoff latencies. This makes it possible to test whether we are able to detect latencies that systematically occur very close to each other.
The maximum burst size is 10. We also create 10 identical test functions, so that we get 10 different backtraces; this is useful when we want to test whether we can detect all the latencies in a burst. Otherwise, there would be no easy way of differentiating between which latency in a burst was captured by the tracer.
In addition, there is a sysfs trigger, so that it's not necessary to reload the module to repeat the test. The trigger will appear as /sys/kernel/preemptirq_delay_test/trigger in sysfs.
--- kernel/trace/Kconfig | 6 +- kernel/trace/preemptirq_delay_test.c | 145 +++++++++++++++++++++++---- 2 files changed, 129 insertions(+), 22 deletions(-)
kernel/trace/Kconfig +3 -3
@@ -740,9 +740,9 @@ config PREEMPTIRQ_DELAY_TEST configurable delay. The module busy waits for the duration of the critical section. - For example, the following invocation forces a one-time irq-disabled - critical section for 500us: - modprobe preemptirq_delay_test test_mode=irq delay=500000 + For example, the following invocation generates a burst of three + irq-disabled critical sections for 500us: + modprobe preemptirq_delay_test test_mode=irq delay=500 burst_size=3 If unsure, say N
kernel/trace/preemptirq_delay_test.c +126 -19
187 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v3 3/4 Add the latency-collector to tools
In reply to Viktor RosendahlThis is a tool that is intended to work around the fact that the preemptoff, irqsoff, and preemptirqsoff tracers only work in overwrite mode. The idea is to act randomly in such a way that we do not systematically lose any latencies, so that if enough testing is done, all latencies will be captured. If the same burst of latencies is repeated, then sooner or later we will have captured all the latencies.
It also works with the wakeup_dl, wakeup_rt, wakeup, and hwlat tracers. However, in that case it is probably not useful to use the random sleep functionality.
The reason why it may be desirable to catch all latencies with a long test campaign is that for some organizations, it's necessary to test the kernel in the field and not practical for developers to work iteratively with field testers. Because of cost and project schedules it is not possible to start a new test campaign every time a latency problem has been fixed.
It uses inotify to detect changes to /sys/kernel/debug/tracing/trace. When a latency is detected, it will either sleep or print immediately, depending on a function that act as an unfair coin toss.
If immediate print is chosen, it means that we open /sys/kernel/debug/tracing/trace and thereby cause a blackout period that will hide any subsequent latencies.
If sleep is chosen, it means that we wait before opening /sys/kernel/debug/tracing/trace, by default for 1000 ms, to see if there is another latency during this period. If there is, then we will lose the previous latency. The coin will be tossed again with a different probability, and we will either print the new latency, or possibly a subsequent one.
The probability for the unfair coin toss is chosen so that there is equal probability to obtain any of the latencies in a burst. However, this assumes that we make an assumption of how many latencies there can be. By default the program assumes that there are no more than 2 latencies in a burst, the probability of immediate printout will be:
1/2 and 1
Thus, the probability of getting each of the two latencies will be 1/2.
If we ever find that there is more than one latency in a series, meaning that we reach the probability of 1, then the table will be expanded to:
1/3, 1/2, and 1
Thus, we assume that there are no more than three latencies and each with a probability of 1/3 of being captured. If the probability of 1 is reached in the new table, that is we see more than two closely occurring latencies, then the table will again be extended, and so on.
On my systems, it seems like this scheme works fairly well, as long as the latencies we trace are long enough, 100 us seems to be enough. This userspace program receive the inotify event at the end of a latency, and it has time until the end of the next latency to react, that is to open /sys/kernel/debug/tracing/trace. Thus, if we trace latencies that are >100 us, then we have at least 100 us to react.
Example output:
root@myhost:~# echo 100 > /sys/kernel/debug/tracing/tracing_thresh root@myhost:~# echo preemptirqsoff > /sys/kernel/debug/tracing/current_tracer root@myhost:~# latency-collector -rvv -a 11 & [1] 4915 root@myhost:~# Running with policy rr and priority 99. Using 3 print threads. /sys/kernel/debug/tracing/trace will be printed with random delay Start size of the probability table: 11 Print a message when prob. table table changes size: true Print a warning when an event has been lost: true Sleep time is: 1000 ms Initializing probability table to 11 Thread 4916 runs with policy rr and priority 99 Thread 4917 runs with policy rr and priority 99 Thread 4918 runs with policy rr and priority 99 Thread 4919 runs with policy rr and priority 99
root@myhost:~# modprobe preemptirq_delay_test delay=105 test_mode=alternate burst_size=10 2850.638308 Latency 1 printout skipped due to random delay 2850.638383 Latency 2 printout skipped due to random delay 2850.638497 Latency 3 immediate print
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
BEGIN <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
alternat-4922 6d... 0us!: execute_preemptirqtest <-preemptirqtest_2 alternat-4922 6d... 106us : execute_preemptirqtest <-preemptirqtest_2 alternat-4922 6d... 106us : tracer_hardirqs_on <-preemptirqtest_2 alternat-4922 6d... 108us : <stack trace>
=> preemptirqtest_2
=> preemptirq_delay_run
=> kthread
=> ret_from_fork
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
END <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
In the example above, we randomly, happened to get the third latency in a burst burst of 10. If the experiment is repeated enough times, we will get all 10.
Sometimes, there will be lost latencies, so that we get:
3054.078294 Latency 44 printout skipped due to inotify loop ..or:
3211.957685 Latency 112 printout skipped due to print loop
In my experience, these are not frequent enough to be a problem.
Also, we do not really lose any latency in these cases, it's more like we get another latency than what was intended by the design.
--- tools/Makefile | 14 +- tools/trace/Makefile | 20 + tools/trace/latency-collector.c | 1212 +++++++++++++++++++++++++++++++ 3 files changed, 1240 insertions(+), 6 deletions(-) create mode 100644 tools/trace/Makefile create mode 100644 tools/trace/latency-collector.c
tools/Makefile +8 -6
@@ -29,6 +29,7 @@ help: @echo ' spi - spi tools' @echo ' objtool - an ELF object analysis tool' @echo ' tmon - thermal monitoring and tuning tool' + @echo ' trace - misc tracing tools' @echo ' turbostat - Intel CPU idle stats and freq reporting tool' @echo ' usb - USB testing tools' @echo ' virtio - vhost test module'
@@ -62,7 +63,7 @@ acpi: FORCE cpupower: FORCE $(call descend,power/$@) -cgroup firewire hv guest spi usb virtio vm bpf iio gpio objtool leds wmi pci firmware debugging: FORCE +cgroup firewire hv guest spi usb virtio vm bpf iio gpio objtool leds wmi pci firmware debugging trace: FORCE $(call descend,$@) liblockdep: FORCE
@@ -98,7 +99,7 @@ all: acpi cgroup cpupower gpio hv firewire liblockdep \ perf selftests spi turbostat usb \ virtio vm bpf x86_energy_perf_policy \ tmon freefall iio objtool kvm_stat wmi \ - pci debugging + pci debugging trace acpi_install: $(call descend,power/$(@:_install=),install)
@@ -106,7 +107,7 @@ acpi_install: cpupower_install: $(call descend,power/$(@:_install=),install) -cgroup_install firewire_install gpio_install hv_install iio_install perf_install spi_install usb_install virtio_install vm_install bpf_install objtool_install wmi_install pci_install debugging_install: +cgroup_install firewire_install gpio_install hv_install iio_install perf_install spi_install usb_install virtio_install vm_install bpf_install objtool_install wmi_install pci_install debugging_install trace_install: $(call descend,$(@:_install=),install) liblockdep_install:
@@ -132,7 +133,7 @@ install: acpi_install cgroup_install cpupower_install gpio_install \ perf_install selftests_install turbostat_install usb_install \ virtio_install vm_install bpf_install x86_energy_perf_policy_install \ tmon_install freefall_install objtool_install kvm_stat_install \ - wmi_install pci_install debugging_install + wmi_install pci_install debugging_install trace_install acpi_clean: $(call descend,power/acpi,clean)
@@ -140,7 +141,7 @@ acpi_clean: cpupower_clean: $(call descend,power/cpupower,clean) -cgroup_clean hv_clean firewire_clean spi_clean usb_clean virtio_clean vm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean: +cgroup_clean hv_clean firewire_clean spi_clean usb_clean virtio_clean vm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean trace_clean: $(call descend,$(@:_clean=),clean) liblockdep_clean:
@@ -178,6 +179,7 @@ clean: acpi_clean cgroup_clean cpupower_clean hv_clean firewire_clean \ perf_clean selftests_clean turbostat_clean spi_clean usb_clean virtio_clean \ vm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \ freefall_clean build_clean libbpf_clean libsubcmd_clean liblockdep_clean \ - gpio_clean objtool_clean leds_clean wmi_clean pci_clean firmware_clean debugging_clean + gpio_clean objtool_clean leds_clean wmi_clean pci_clean firmware_clean \ + debugging_clean trace_clean .PHONY: FORCE
tools/trace/Makefile new file +20 -0
@@ -0,0 +1,20 @@ +# SPDX-License-Identifier: GPL-2.0 +# Makefile for vm tools +# +TARGETS = latency-collector +CFLAGS = -Wall -Wextra -g -O2 +LDFLAGS = -lpthread + +all: $(TARGETS) + +%: %.c + $(CC) $(CFLAGS) -o $@ $< $(LDFLAGS) + +clean: + $(RM) latency-collector + +sbindir ?= /usr/sbin + +install: all + install -d $(DESTDIR)$(sbindir) + install -m 755 -p $(TARGETS) $(DESTDIR)$(sbindir)
tools/trace/latency-collector.c new file +1212 -0
1,212 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v3 4/4 ftrace: Add an option for tracing console latencies
In reply to Viktor RosendahlThis new trace option "console-latency" will enable the latency tracers to trace the console latencies. Previously this has always been implicitely disabled. I guess this is because they are considered to be well known and unavoidable.
However, for some organizations it may nevertheless be desirable to trace them. Basically, we want to be able to tell that there are latencies in the system under test because someone has incorrectly enabled the serial console.
--- include/linux/irqflags.h | 21 +++++++++++++++++++++ kernel/printk/printk.c | 6 ++++-- kernel/trace/trace.h | 1 + kernel/trace/trace_irqsoff.c | 12 ++++++++++++ tools/trace/latency-collector.c | 11 +++++------ 5 files changed, 43 insertions(+), 8 deletions(-)
include/linux/irqflags.h +21 -0
@@ -68,9 +68,30 @@ do { \defined (CONFIG_PREEMPT_TRACER) extern void stop_critical_timings(void);extern void start_critical_timings (void ); +extern bool console_tracing_disabled (void ); + +# define console_stop_critical_timings (flag) \ + do { \ + typecheck(bool, flag); \ + flag = console_tracing_disabled(); \ + if (flag) \ + stop_critical_timings(); \ + } while (0) + +# define console_start_critical_timings (flag) \ + do { \ + typecheck(bool, flag); \ + if (flag) \ + start_critical_timings(); \ + } while (0) +#else # define stop_critical_timings () do { } while (0)# define start_critical_timings () do { } while (0) +# define console_stop_critical_timings (flag) \ + do { typecheck(bool, flag); } while (0) +# define console_start_critical_timings (flag) \ + do { typecheck(bool, flag); } while (0)#endif /*
kernel/printk/printk.c +4 -2
@@ -2348,6 +2348,7 @@ void console_unlock(void)static char ext_text[CONSOLE_EXT_LOG_MAX ];static char text[LOG_LINE_MAX +PREFIX_MAX ];unsigned long flags; +bool cflag;bool do_cond_resched, retry;if (console_suspended) {
@@ -2448,9 +2449,10 @@ void console_unlock(void)*/ console_lock_spinning_enable (); -stop_critical_timings ();/* don't trace print latency */ +/* don't trace print latency if it's disabled */ +console_stop_critical_timings (cflag);call_console_drivers (ext_text, ext_len, text, len); -start_critical_timings (); +console_start_critical_timings (cflag);if (console_lock_spinning_disable_and_check ()) {printk_safe_exit_irqrestore (flags);
kernel/trace/trace.h +1 -0
@@ -1250,6 +1250,7 @@ extern int trace_get_user(struct trace_parser *parser, const char __user *ubuf,C (PRINTK_MSGONLY ,"printk-msg-only" ), \C (CONTEXT_INFO ,"context-info" ),/* Print pid/cpu/time */ \C (LATENCY_FMT ,"latency-format" ), \ +C (CONSOLE_LATENCY ,"console-latency" ), \C (RECORD_CMD ,"record-cmd" ), \C (RECORD_TGID ,"record-tgid" ), \ C(OVERWRITE, "overwrite"), \
kernel/trace/trace_irqsoff.c +12 -0
@@ -456,6 +456,18 @@ void stop_critical_timings(void)EXPORT_SYMBOL_GPL (stop_critical_timings);NOKPROBE_SYMBOL (stop_critical_timings); +bool console_tracing_disabled (void ) +{ +struct trace_array *tr = irqsoff_trace; +int pc =preempt_count (); + +if (!preempt_trace (pc) && !irq_trace ()) +return false; + +return !(tr->trace_flags &TRACE_ITER_CONSOLE_LATENCY ); +} +EXPORT_SYMBOL_GPL (console_tracing_disabled); +#ifdef CONFIG_FUNCTION_TRACER static bool function_enabled;
tools/trace/latency-collector.c +5 -6
@@ -953,10 +953,9 @@ static void show_usage(void)"The following options are supported:\n" "-c, --policy POL\tRun the program with scheduling policy POL. POL can be\n" -"\t\t\tother, batch, idle, rr or fifo. The default is other.\n" -"\t\t\tWhen using rr or fifo, be careful to not configure the\n" -"\t\t\ttracer so that traces are acquired extremely frequently,\n" -"\t\t\tor you may starve your system.\n\n" +"\t\t\tother, batch, idle, rr or fifo. The default is rr. When\n" +"\t\t\tusing rr or fifo, remember that these policies may cause\n" +"\t\t\tother tasks to experience latencies.\n\n" "-p, --priority PRI\tRun the program with priority PRI. The acceptable range\n" "\t\t\tof PRI depends on the scheduling policy.\n\n"
@@ -1132,10 +1131,10 @@ static void scan_arguments(int argc, char *argv[]) }if (!sched_policy_set) { - sched_policy =SCHED_OTHER ; + sched_policy =SCHED_RR ; sched_policy_set = true;if (!sched_pri_set) { - sched_pri =DEFAULT_PRI ; + sched_pri =RT_DEFAULT_PRI ; sched_pri_set = true; } }
Signature · 1 line
2.17.1
Steven Rostedt
maintainerQuoted 1 line · On Mon, 13 May 2019 23:50:04 +0200 Viktor Rosendahl…
Hello all,
Hi Viktor,
Note, as the merge window is open and I'm also currently at a conference, it may be a while before I can take a look at this. If you don't hear something from me in 10 days, feel free to send me a ping.
-- Steve
Quoted 35 lines
Changes in v3:
- [PATCH 1/4]:
* I have generalized this to send thefsnotify()notifications for all tracers that usetracing_max_latency.* There are large additions of code to prevent
queue_work()from being called while we are in__schedule()ordo_idle(). This was a bug also in the previous version but had gone unnoticed. It became very visible when I tried to make it work with the wakeup tracers because they are always invoked from thesched_switchtracepoint.* The fsnotify notification is issued for
tracing_max_latency, not trace.* I got rid of the kernel config option. The facility is always compiled when
CONFIG_FSNOTIFYis enabled and any of the latency tracers are enabled.- [PATCH 2/4]:
* No significant changes.- [PATCH 3/4]:
* The latency-collector help messages have been tuned to the fact that it can be used also with wakeup and hwlat tracers.* I increased the size of the buffer for reading from
/sys/kernel/debug/tracing/trace.* Adapted it to monitor
tracing_max_latencyinstead of trace- [PATCH 4/4]:
* I converted this from a kernel config option to a trace config option that can be changed at runtime.
Quoted 9 lines · Steven Rostedt
Hi Viktor,
Note, as the merge window is open and I'm also currently at a conference, it may be a while before I can take a look at this. If you don't hear something from me in 10 days, feel free to send me a ping.
-- Steve
Hi Steve,
Ok, good to know.
I discovered a couple of annoying issues with this v3 of the series, so I will probably send out v4 soon.
best regards,
Viktor