libxl: make vkbd tunable for HVM guests
PATCH v3 1/1 libxl: make vkbd tunable for HVM guests
Each HVM guest currently gets a vkbd frontend/backend pair (c/s ebbd2561b4c). This consumes host resources unnecessarily for guests that have no use for vkbd. Make this behaviour tunable to allow an administrator to choose. The commit retains the current behaviour -- HVM guests still get vkdb unless specified otherwise.
---
Changes in v2:
- Added a missing hunk / setting vkb_device per config
Changes in v3:
- Added entries in libxl.h and in documentation
--- docs/man/xl.cfg.pod.5.in | 4 ++++ tools/libxl/libxl.h | 9 +++++++++ tools/libxl/libxl_create.c | 9 ++++++--- tools/libxl/libxl_types.idl | 1 + tools/xl/xl_parse.c | 1 + tools/xl/xl_sxp.c | 2 ++ 6 files changed, 23 insertions(+), 3 deletions(-)
docs/man/xl.cfg.pod.5.in +4 -0
@@ -2286,6 +2286,10 @@ devices are defined by the device model configuration, please see the B<qemu(1)> manpage for details. The default is not to export any sound device. +=item B<vkb_device=BOOLEAN> + +Specifies that the HVM guest gets a vkdb. The default is true (1). + =item B<usb=BOOLEAN> Enables or disables an emulated USB bus in the guest.
tools/libxl/libxl.h +9 -0
@@ -616,6 +616,15 @@ typedef struct libxl__ctx libxl_ctx;*/ #define LIBXL_HAVE_BUILDINFO_VCPU_AFFINITY_ARRAYS 1 +/* +* LIBXL_HAVE_BUILDINFO_VKB_DEVICE +* +* If this is defined, then the libxl_domain_build_info structure will +* contain a boolean hvm.vkb_device which instructs libxl whether to include +* a vkbd at build time or not. +*/ +#define LIBXL_HAVE_BUILDINFO_VKB_DEVICE 1 +/* * LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST *
tools/libxl/libxl_create.c +6 -3
@@ -308,6 +308,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,libxl_defbool_setdefault (&b_info->u.hvm.vpt_align, true);libxl_defbool_setdefault (&b_info->u.hvm.altp2m, false);libxl_defbool_setdefault (&b_info->u.hvm.usb, false); +libxl_defbool_setdefault (&b_info->u.hvm.vkb_device, true);libxl_defbool_setdefault (&b_info->u.hvm.xen_platform_pci, true);libxl_defbool_setdefault (&b_info->u.hvm.spice.enable, false);
@@ -1393,9 +1394,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev,libxl__device_console_add (gc, domid, &console, state, &device);libxl__device_console_dispose (&console); -libxl_device_vkb_init (&vkb); -libxl__device_add (gc, domid, &libxl__vkb_devtype, &vkb); -libxl_device_vkb_dispose (&vkb); +if (libxl_defbool_val (d_config->b_info.u.hvm.vkb_device)) { +libxl_device_vkb_init (&vkb); +libxl__device_add (gc, domid, &libxl__vkb_devtype, &vkb); +libxl_device_vkb_dispose (&vkb); + } dcs->sdss.dm.guest_domid = domid;if (libxl_defbool_val (d_config->b_info.device_model_stubdomain))
tools/libxl/libxl_types.idl +1 -0
@@ -571,6 +571,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ # - "tablet" for absolute mouse, # - "mouse" for PS/2 protocol relative mouse ("usbdevice", string), + ("vkb_device", libxl_defbool), ("soundhw", string), ("xen_platform_pci", libxl_defbool), ("usbdevice_list", libxl_string_list),
tools/xl/xl_parse.c +1 -0
@@ -2295,6 +2295,7 @@ skip_usbdev:fprintf (stderr,"xl: Unable to parse usbdevice.\n" );exit (-ERROR_FAIL ); } +xlu_cfg_get_defbool (config,"vkb_device" , &b_info->u.hvm.vkb_device,0 );xlu_cfg_replace_string (config,"soundhw" , &b_info->u.hvm.soundhw,0 );xlu_cfg_get_defbool (config,"xen_platform_pci" , &b_info->u.hvm.xen_platform_pci,0 );
tools/xl/xl_sxp.c +2 -0
@@ -138,6 +138,8 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh)fprintf (fh,"\t\t\t(boot %s)\n" , b_info->u.hvm.boot);fprintf (fh,"\t\t\t(usb %s)\n" ,libxl_defbool_to_string (b_info->u.hvm.usb));fprintf (fh,"\t\t\t(usbdevice %s)\n" , b_info->u.hvm.usbdevice); +fprintf (fh,"\t\t\t(vkb_device %s)\n" , +libxl_defbool_to_string (b_info->u.hvm.vkb_device));fprintf (fh,"\t\t)\n" );break ;case LIBXL_DOMAIN_TYPE_PV :
Signature · 7 lines
2.15.3.AMZN _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Eslam Elnikety
Each HVM guest currently gets a vkbd frontend/backend pair (c/s
ebbd2561b4c). This consumes host resources unnecessarily for guests that have no use for vkbd. Make this behaviour tunable to allow an administrator to choose. The commit retains the current behaviour -- HVM guests still get vkdb unless specified otherwise.Signed-off-by Eslam Elnikety <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Eslam Elnikety
Each HVM guest currently gets a vkbd frontend/backend pair (c/s
ebbd2561b4c). This consumes host resources unnecessarily for guests that have no use for vkbd. Make this behaviour tunable to allow an administrator to choose. The commit retains the current behaviour -- HVM guests still get vkdb unless specified otherwise.Signed-off-by Eslam Elnikety <[email protected]>
Quoted 8 lines
---
Changes in v2:
- Added a missing hunk / settingvkb_deviceper configChanges in v3:
- Added entries inlibxl.hand in documentation--- docs/man/xl.cfg.pod.5.in | 4 ++++
I wonder where you got this file. :p
The correct file name is xl.cfg.5.pod.in.
Anyway, I have fixed up your patch, so no need to resend.
Wei.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 12 lines · Wei Liu
Quoted 11 lines · Eslam Elnikety
Each HVM guest currently gets a vkbd frontend/backend pair (c/s
ebbd2561b4c). This consumes host resources unnecessarily for guests that have no use for vkbd. Make this behaviour tunable to allow an administrator to choose. The commit retains the current behaviour -- HVM guests still get vkdb unless specified otherwise.Signed-off-by Eslam Elnikety <[email protected]>---
Changes in v2:
- Added a missing hunk / settingvkb_deviceper config
Quoted 7 lines
Quoted 4 lines
Changes in v3:
- Added entries inlibxl.hand in documentation--- docs/man/xl.cfg.pod.5.in | 4 ++++I wonder where you got this file. :p
The correct file name is xl.cfg.5.pod.in.
I reversed the .pod and .5 in 8410fcb54ac808c19a030c6f0ec64e760ac64ca5
This is likely a patch against 4.11 or earlier.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 17 lines · Andrew Cooper
Quoted 16 lines · Wei Liu
Quoted 15 lines · Eslam Elnikety
Each HVM guest currently gets a vkbd frontend/backend pair (c/s
ebbd2561b4c). This consumes host resources unnecessarily for guests that have no use for vkbd. Make this behaviour tunable to allow an administrator to choose. The commit retains the current behaviour -- HVM guests still get vkdb unless specified otherwise.Signed-off-by Eslam Elnikety <[email protected]>---
Changes in v2:
- Added a missing hunk / settingvkb_deviceper configChanges in v3:
- Added entries inlibxl.hand in documentation--- docs/man/xl.cfg.pod.5.in | 4 ++++
Quoted 7 lines
Quoted 3 lines
I wonder where you got this file. :p
The correct file name is xl.cfg.5.pod.in.
I reversed the .pod and .5 in
8410fcb54ac808c19a030c6f0ec64e760ac64ca5This is likely a patch against 4.11 or earlier.
Oh, that explains it.
Wei.
Quoted 7 lines
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 15. May 2019, at 11:49, Andrew Cooper <[email protected]<mailto:[email protected]>> wrote:
On 15/05/2019 10:47, Wei Liu wrote:
On Tue, May 14, 2019 at 08:43:25AM +0000, Eslam Elnikety wrote:
Each HVM guest currently gets a vkbd frontend/backend pair (c/s ebbd2561b4c). This consumes host resources unnecessarily for guests that have no use for vkbd. Make this behaviour tunable to allow an administrator to choose. The commit retains the current behaviour -- HVM guests still get vkdb unless specified otherwise.
---
Changes in v2:
- Added a missing hunk / setting vkb_device per config
Changes in v3:
- Added entries in libxl.h and in documentation
---
docs/man/xl.cfg.pod.5.in | 4 ++++
I wonder where you got this file. :p
The correct file name is xl.cfg.5.pod.in.
I reversed the .pod and .5 in 8410fcb54ac808c19a030c6f0ec64e760ac64ca5
This is likely a patch against 4.11 or earlier.
Busted! v1 and v2 were against master. For some reason v3 was a miss in that regard — against stable-4.11.
Thanks for massaging the patch.
Cheers,
Eslam
~Andrew
_______________________________________________
Xen-devel mailing list [email protected]<mailto:[email protected]>
https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel