Skip to contentSkip to conversation

um: Don't hardcode path as it is architecture dependent

PATCH In review Ritesh Raj Sarraf 2 participants 4 messages May 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 um: Don't hardcode path as it is architecture dependent

Dear Stable Team,
Request for inclusion into the stable branches of Linux. This change went into 4.20 but 4.19 is the LTS release that many of the Linux Vendors are rebasing on. Hence, it'd be nice to see this part of the LTS releases, at least 4.19.

The current code fails to run on amd64 because of hardcoded reference to i386

---
 arch/um/drivers/port_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/um/drivers/port_user.c +1 -1
index 9a8e1b64c22e..5f56d11b886f 100644
@@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
 {
 	int new, err;
 	char *argv[] = { "/usr/sbin/in.telnetd", "-L",
-			 "/usr/lib/uml/port-helper", NULL };
+			 OS_LIB_PATH "/uml/port-helper", NULL };
 	struct port_pre_exec_data data;
 
 	new = accept(fd, NULL, 0);
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 7 lines · Ritesh Raj Sarraf

Dear Stable Team,
Request for inclusion into the stable branches of Linux. This change went into 4.20 but 4.19 is the LTS release that many of the Linux Vendors are rebasing on. Hence, it'd be nice to see this part of the LTS releases, at least 4.19.

Quoted 8 lines

The current code fails to run on amd64 because of hardcoded reference to i386

---
 arch/um/drivers/port_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What is the git commit id of this patch in Linus's tree?

thanks,

greg k-h

#2 lore raw

Hello Greg,

Quoted 5 lines · Greg KH
Quoted 4 lines · Ritesh Raj Sarraf

The current code fails to run on amd64 because of hardcoded reference to
i386

Quoted 7 lines
Quoted 5 lines
---
  arch/um/drivers/port_user.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

What is the git commit id of this patch in Linus's tree?

The git commit id should be: 9ca19a3a3e2482916c475b90f3d7fa2a03d8e5ed The web url is:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9ca19a3a3e2482916c475b90f3d7fa2a03d8e5ed

Signature · 2 lines
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
maintainer
#3 lore raw
Quoted 14 lines · Ritesh Raj Sarraf

Hello Greg,

Quoted 11 lines · Greg KH
Quoted 9 lines · Ritesh Raj Sarraf

The current code fails to run on amd64 because of hardcoded reference to
i386

---
  arch/um/drivers/port_user.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 3 lines
Quoted 1 line

What is the git commit id of this patch in Linus's tree?

The git commit id should be: 9ca19a3a3e2482916c475b90f3d7fa2a03d8e5ed

Thanks, now queued up.

greg k-h