Skip to contentSkip to conversation

Misc patches

PATCH In review Wei Liu 3 participants 7 messages May 14, 2019 – May 15, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

v2 cover Misc patches

Wei Liu (3):
gitignore: ignore .vscode directory
README: document requirement about python
INSTALL: remove duplicate sentence

 .gitignore | 1 +
 INSTALL    | 1 -
 README     | 7 +++++++
 3 files changed, 8 insertions(+), 1 deletion(-)
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
author
#1 lore raw

PATCH v2 1/3 gitignore: ignore .vscode directory

The directory is created by Visual Studio Code editor to store its local state.

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)
.gitignore +1 -0
index 26bc583f74..3822bb75ba 100644
@@ -30,6 +30,7 @@ cscope.out
 cscope.po.out
 .config
 .vimrc
+.vscode
 
 dist
 stubdom/*.tar.gz
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
author
#3 lore raw

PATCH v2 2/3 README: document requirement about python

In reply to Wei Liu

Provide information on what is expected from the build system regarding python.

---
 README | 7 +++++++
 1 file changed, 7 insertions(+)
README +7 -0
index 23e4f7c3dc..26d44cf7c1 100644
@@ -181,6 +181,13 @@ Various tools, such as pygrub, have the following runtime dependencies:
           URL:    http://www.python.org/
           Debian: python
 
+Note that the build system expects `python` to be available. If your system
+only has `python2` or `python3` but not `python` (as in Linux From Scratch),
+you will need to create a symlink for it, or specify PYTHON= when invoking
+make, like (note the position of PYTHON= matters):
+
+    # make PYTHON=/usr/bin/python3
+
 Intel(R) Trusted Execution Technology Support
 =============================================
 
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v2 2/3
#4 lore raw

Re: [PATCH v2 2/3] README: document requirement about python

Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 14.05.19 at 16:22, <[email protected]> wrote:

Provide information on what is expected from the build system regarding python.

FWIW

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#5 lore raw

PATCH v2 3/3 INSTALL: remove duplicate sentence

In reply to Wei Liu

The same sentence is repeated in the next paragraph.

---
 INSTALL | 1 -
 1 file changed, 1 deletion(-)
INSTALL +0 -1
index 9aa9ebdddc..1665ddd6a4 100644
@@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
 SMBIOS_REL_DATE=mm/dd/yyyy
 VGABIOS_REL_DATE="dd Mon yyyy"
 
-During tools build external repos will be cloned into the source tree.
 This variable can be used to point to a different git binary to be used.
 GIT=
 
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel