Staging: vc04_services: Fix kernel type 'u32' over 'uint32_t'
Subsystems (3)
PATCH 1/1 Staging: vc04_services: Fix kernel type 'u32' over 'uint32_t'
Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by Madhumitha Prabakaran <[email protected]>
--- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h +2 -2
@@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set {u32 port_handle;/* port */ u32 id;/* Parameter ID */ u32 size;/* Parameter size */ -uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; +u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; };struct mmal_msg_port_parameter_set_reply {
@@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply {u32 status;/* Status of mmal_port_parameter_get call */ u32 id;/* Parameter ID */ u32 size;/* Parameter size */ -uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; +u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; };/* event messages */
Signature · 1 line
2.17.1
Hi Madhumitha,
Quoted 2 lines · Madhumitha Prabakaran
Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'
grepping the sources within vc04_services shows a lot more occurences.
I suggest to fix this style issue at least for the whole camera driver and name the patch like
staging: bcm2835-camera: prefer kernel types
Regards
Stefan
Quoted 28 lines
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h +2
-2@@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set {u32 port_handle;/* port */ u32 id;/* Parameter ID */ u32 size;/* Parameter size */ -uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; +u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; };struct mmal_msg_port_parameter_set_reply {@@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply {u32 status;/* Status of mmal_port_parameter_get call */ u32 id;/* Parameter ID */ u32 size;/* Parameter size */ -uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; +u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE ]; };/* event messages */