Skip to contentSkip to conversation

sun50i: h6: Fix Beelink GS1 board config

PATCH New peron.clem at gmail.com 2 participants 6 messages May 14, 2019 – May 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sun50i: h6: Fix Beelink GS1 board config

From: Clément Péron <[email protected]>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/beelink_gs1_defconfig +2 -1
index ef4dd29549..f16d0fee22 100644
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_SPL_TEXT_BASE=0x20060
 # CONFIG_CMD_FLASH is not set
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_EFI_PARTITION is not set
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 sun50i: h6: Fix Beelink GS1 board config

Quoted 22 lines · On Tue, May 14, 2019 at 11:56 PM <[email protected]> wrote:

From: Clément Péron <[email protected]>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/beelink_gs1_defconfig +0 -0
index ef4dd29549..f16d0fee22 100644

configs/beelink_gs1_defconfig line 8

Quoted 9 lines
configs/beelink_gs1_defconfig +1 -1
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1

Change changes seems different

#2 lore raw

PATCH 1/1 sun50i: h6: Fix Beelink GS1 board config

Hi Jagan,

Quoted 19 lines · Jagan Teki
Quoted 17 lines · On Tue, May 14, 2019 at 11:56 PM <[email protected]> wrote:

From: Clément Péron <[email protected]>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
configs/beelink_gs1_defconfig +0 -0
index ef4dd29549..f16d0fee22 100644

configs/beelink_gs1_defconfig line 8

Quoted 9 lines
configs/beelink_gs1_defconfig +1 -1
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1

Change changes seems different

This happens when I made the "make save_defconfig"

Do you want to split this in two commits ?

Regards,
Clément

#3 lore raw

PATCH 1/1 sun50i: h6: Fix Beelink GS1 board config

Quoted 40 lines · Clément Péron

Hi Jagan,

Quoted 19 lines · Jagan Teki
Quoted 17 lines · On Tue, May 14, 2019 at 11:56 PM <[email protected]> wrote:

From: Clément Péron <[email protected]>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
configs/beelink_gs1_defconfig +0 -0
index ef4dd29549..f16d0fee22 100644

configs/beelink_gs1_defconfig line 8

Quoted 9 lines
configs/beelink_gs1_defconfig +1 -1
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1

Change changes seems different

Quoted 3 lines

This happens when I made the "make save_defconfig"

Do you want to split this in two commits ?

I can drop that while applying, if you agree?

#4 lore raw

PATCH 1/1 sun50i: h6: Fix Beelink GS1 board config

Hi Jagan,

Quoted 42 lines · Jagan Teki
Quoted 40 lines · Clément Péron

Hi Jagan,

Quoted 35 lines · Jagan Teki
Quoted 22 lines · On Tue, May 14, 2019 at 11:56 PM <[email protected]> wrote:

From: Clément Péron <[email protected]>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
configs/beelink_gs1_defconfig +0 -0
index ef4dd29549..f16d0fee22 100644

configs/beelink_gs1_defconfig line 8

Quoted 9 lines
configs/beelink_gs1_defconfig +1 -1
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1

Change changes seems different

Quoted 5 lines
Quoted 3 lines

This happens when I made the "make save_defconfig"

Do you want to split this in two commits ?

I can drop that while applying, if you agree?

Please do so,
Thanks,
Clément

#5 lore raw

PATCH 1/1 sun50i: h6: Fix Beelink GS1 board config

Quoted 52 lines · Clément Péron

Hi Jagan,

Quoted 47 lines · Jagan Teki
Quoted 40 lines · Clément Péron

Hi Jagan,

Quoted 19 lines · Jagan Teki
Quoted 17 lines · On Tue, May 14, 2019 at 11:56 PM <[email protected]> wrote:

From: Clément Péron <[email protected]>

SPL_TEXT_BASE has been moved to Kconfig with commit:
f89d6133ee configs: move CONFIG_SPL_TEXT_BASE to Kconfig

But Beelink GS1 config file has been introduced in the same time without this modification.

Fix this by settings the CONFIG_SPL_TEXT_BASE

---
 configs/beelink_gs1_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines
Quoted 5 lines
configs/beelink_gs1_defconfig +0 -0
index ef4dd29549..f16d0fee22 100644

configs/beelink_gs1_defconfig line 8

Quoted 9 lines
configs/beelink_gs1_defconfig +1 -1
@@ -1,12 +1,13 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_SPL=y
 CONFIG_MACH_SUN50I_H6=y
 CONFIG_MMC0_CD_PIN="PF6"
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_PSCI_RESET is not set
-CONFIG_NR_DRAM_BANKS=1

Change changes seems different

Quoted 3 lines

This happens when I made the "make save_defconfig"

Do you want to split this in two commits ?

I can drop that while applying, if you agree?

Applied to u-boot-sunxi/master