Skip to contentSkip to conversation

libbpf: don't fail when feature probing fails

PATCH In review Stanislav Fomichev 2 participants 2 messages May 15, 2019 – May 16, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libbpf: don't fail when feature probing fails

Otherwise libbpf is unusable from unprivileged process with kernel.kernel.unprivileged_bpf_disabled=1.
All I get is EPERM from the probes, even if I just want to open an ELF object and look at what progs/maps it has.

Instead of dying on probes, let's just pr_debug the error and try to continue.

---
 tools/lib/bpf/libbpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/libbpf.c +1 -1
index 7e3b79d7c25f..3562b6ef5fdc 100644
@@ -1696,7 +1696,7 @@ bpf_object__probe_caps(struct bpf_object *obj)
 	for (i = 0; i < ARRAY_SIZE(probe_fn); i++) {
 		ret = probe_fn[i](obj);
 		if (ret < 0)
-			return ret;
+			pr_debug("Probe #%d failed with %d.\n", i, ret);
 	}
 
 	return 0;
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog
maintainer
#1 lore raw
Quoted 9 lines · Stanislav Fomichev

Otherwise libbpf is unusable from unprivileged process with kernel.kernel.unprivileged_bpf_disabled=1.
All I get is EPERM from the probes, even if I just want to open an ELF object and look at what progs/maps it has.

Instead of dying on probes, let's just pr_debug the error and try to continue.

Good catch, applied, thanks!