simple-bus and rsa-sw with DM_FLAG_PRE_RELOC
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured with qemu_arm64_defconfig plus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note that RSA_SOFTWARE_EXP also declares itself with DM_FLAG_PRE_RELOC.)
By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
commit 3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200
simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus driver
What's wrong with this?
-Takahiro Akashi
Quoted 9 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ make
$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographic
U-Boot 2019.07-rc1-00506-g90176e3 (May 15 2019 - 14:43:21 +0800)
DRAM: 128 MiB Flash: 128 MiB
*** Warning - bad CRC, using default environment
In: pl011 at 9000000 Out: pl011 at 9000000 Err: pl011 at 9000000 Net: No ethernet found. Hit any key to stop autoboot: 0
=>
Regards,
Bin
Quoted 21 lines · Bin Meng
Quoted 9 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
Quoted 7 lines
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ make$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographic
Thank you.
I have used locally-built qemu, so I will check the configuration of my build.
-Takahiro Akashi
Quoted 16 lines
U-Boot 2019.07-rc1-00506-g90176e3 (May 15 2019 - 14:43:21 +0800)
DRAM: 128 MiB Flash: 128 MiB*** Warning - bad CRC, using default environment
In: pl011 at 9000000 Out: pl011 at 9000000 Err: pl011 at 9000000 Net: No ethernet found. Hit any key to stop autoboot: 0=>
Regards,
Bin
Quoted 29 lines · AKASHI Takahiro
Quoted 27 lines · Bin Meng
Quoted 9 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ make
Quoted 5 lines
Quoted 1 line
$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographicThank you.
I have used locally-built qemu, so I will check the configuration of my build.
FYI
$ qemu-system-aarch64 -version QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.36), Copyright (c) 2003-2008 Fabrice Bellard
I was using Ubuntu 16.04 shipped QEMU packages.
Regards,
Bin
Auer
Quoted 37 lines · Bin Meng
Quoted 27 lines · AKASHI Takahiro
Quoted 26 lines · Bin Meng
Quoted 8 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ makeQuoted 5 lines
Quoted 1 line
$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographicThank you.
I have used locally-built qemu, so I will check the configuration of my build.FYI
Quoted 8 lines
$ qemu-system-aarch64 -version QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.36), Copyright (c) 2003-2008 Fabrice BellardI was using Ubuntu 16.04 shipped QEMU packages.
Regards,
Bin
The device tree might be different on your build. With this patch, more drivers are probed during the pre-relocation device model. This increases the size requirements of CONFIG_SYS_MALLOC_F_LEN. qemu-arm64 uses the default value for CONFIG_SYS_MALLOC_F_LEN, which is likely too small. We had similar problems on the i.MX devices, see [1]. Increasing it should fix the issue.
Thanks,
Lukas
Quoted 54 lines · Lukas
Quoted 37 lines · Bin Meng
Quoted 27 lines · AKASHI Takahiro
Quoted 26 lines · Bin Meng
Quoted 8 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ makeQuoted 5 lines
Quoted 1 line
$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographicThank you.
I have used locally-built qemu, so I will check the configuration of my build.FYI
Quoted 8 lines
$ qemu-system-aarch64 -version QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.36), Copyright (c) 2003-2008 Fabrice BellardI was using Ubuntu 16.04 shipped QEMU packages.
Regards,
BinThe device tree might be different on your build. With this patch, more drivers are probed during the pre-relocation device model. This increases the size requirements of
CONFIG_SYS_MALLOC_F_LEN. qemu-arm64 uses the default value forCONFIG_SYS_MALLOC_F_LEN, which is likely too small. We had similar problems on the i.MX devices, see [1]. Increasing it should fix the issue.
Quoted 4 lines
Thanks,
Lukas
Ah, it was a known issue.
But is there any better, or more flexible, way to fix that issue? It was very difficult for me to find out a clue for root cause.
Thanks,
-Takahiro Akashi
Auer
Quoted 58 lines · takahiro.akashi at linaro.org
Quoted 57 lines · Lukas
Quoted 37 lines · Bin Meng
Quoted 27 lines · AKASHI Takahiro
Quoted 26 lines · Bin Meng
Quoted 8 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ makeQuoted 5 lines
Quoted 1 line
$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographicThank you.
I have used locally-built qemu, so I will check the configuration of my build.FYI
Quoted 8 lines
$ qemu-system-aarch64 -version QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.36), Copyright (c) 2003-2008 Fabrice BellardI was using Ubuntu 16.04 shipped QEMU packages.
Regards,
BinThe device tree might be different on your build. With this patch, more drivers are probed during the pre-relocation device model. This increases the size requirements of
CONFIG_SYS_MALLOC_F_LEN. qemu-arm64 uses the default value forCONFIG_SYS_MALLOC_F_LEN, which is likely too small. We had similar problems on the i.MX devices, see [1]. Increasing it should fix the issue.Thanks,
Lukas
Quoted 8 lines
Quoted 1 line
Ah, it was a known issue.
But is there any better, or more flexible, way to fix that issue? It was very difficult for me to find out a clue for root cause.Thanks,
-Takahiro Akashi
One problem is that the serial console is not yet available when the out of memory error occurs. However with DEBUG_UART configured, U-Boot should print an error (I did not test this). We could also increase the default value of CONFIG_SYS_MALLOC_F_LEN, but this might not be possible on all boards.
You are right, it would be good to have a better way of fixing this, but I am not sure what the best way of doing that is.
Thanks,
Lukas
Quoted 43 lines · Lukas
Quoted 41 lines · Bin Meng
Quoted 27 lines · AKASHI Takahiro
Quoted 26 lines · Bin Meng
Quoted 8 lines · AKASHI Takahiro
As of v2019.07-rc1,
u-boot does fail to boot without any messages on qemu-arm64 when configured withqemu_arm64_defconfigplus CONFIG_RSA/RSA_SOFTWARE_EXP. (Note thatRSA_SOFTWARE_EXPalso declares itself withDM_FLAG_PRE_RELOC.)By bisecting between v2019.04 and v2019.07, I found that the following commit triggered this regression:
Quoted 7 lines
commit
3a7c45f6a772
Author: Lukas Auer <[email protected]>
Date: Wed Apr 10 14:46:07 2019 +0200simple-bus: add
DM_FLAG_PRE_RELOCflag to simple-bus driverWhat's wrong with this?
I just tested it and it boots for me.
$ make qemu_arm64_defconfig $ make menuconfig adding CONFIG_RSA via "Library routines" -> "Security support" -> "Use RSA Library" $ makeQuoted 5 lines
Quoted 1 line
$ qemu-system-aarch64 -machine virt -cpu cortex-a57 -bios u-boot.bin -nographicThank you.
I have used locally-built qemu, so I will check the configuration of my build.FYI
$ qemu-system-aarch64 -version QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.36), Copyright (c) 2003-2008 Fabrice Bellard
Quoted 6 lines
Quoted 4 lines
I was using Ubuntu 16.04 shipped QEMU packages.
Regards,
BinThe device tree might be different on your build. With this patch, more
Ah yes! I think the qemu-system-aarch64 I was using is a little bit old but I did not realize that the DT might be different.
Quoted 5 lines
drivers are probed during the pre-relocation device model. This increases the size requirements of
CONFIG_SYS_MALLOC_F_LEN. qemu-arm64 uses the default value forCONFIG_SYS_MALLOC_F_LEN, which is likely too small. We had similar problems on the i.MX devices, see [1]. Increasing it should fix the issue.
I thought it might be due to insufficient CONFIG_SYS_MALLOC_F_LEN but since I can't reproduce it my QEMU I did not suggest :)
Quoted 5 lines
Thanks,
Lukas
Regards,
Bin