Skip to contentSkip to conversation

ARM: dts: r8a779x: Configure PMIC IRQ pinmux

PATCH Applied [email protected] 3 participants 3 messages May 15, 2019 – May 16, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: r8a779x: Configure PMIC IRQ pinmux

From: Marek Vasut <[email protected]>

The PMIC IRQ line pin multiplexing configuration is missing from the DTs. Since the line is configured correctly by default, the system works fine. However, add the IRQ line pin multiplexing configuration for completeness.

Cc Geert Uytterhoeven <[email protected]>
Cc Simon Horman <[email protected]>

To: [email protected]
---
V2: Move the pin control node from iic3 controller to pmic on 7792 Blanche,
since there's only one PMIC on that board.

---
 arch/arm/boot/dts/r8a7790-lager.dts   | 7 +++++++
 arch/arm/boot/dts/r8a7790-stout.dts   | 7 ++++++-
 arch/arm/boot/dts/r8a7791-koelsch.dts | 7 +++++++
 arch/arm/boot/dts/r8a7791-porter.dts  | 7 +++++++
 arch/arm/boot/dts/r8a7792-blanche.dts | 7 +++++++
 arch/arm/boot/dts/r8a7793-gose.dts    | 7 +++++++
 6 files changed, 41 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7790-lager.dts +7 -0
index 7b9508e83d46..d637b9727808 100644
@@ -423,6 +423,8 @@
 	 */
 	i2cpwr: i2c-13 {
 		compatible = "i2c-demux-pinctrl";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pmic_irq_pins>;
 		i2c-parent = <&iic3>, <&i2c3>;
 		i2c-bus-name = "i2c-pwr";
 		#address-cells = <1>;
@@ -615,6 +617,11 @@
 		function = "iic3";
 	};
 
+	pmic_irq_pins: pmicirq {
+		groups = "intc_irq2";
+		function = "intc";
+	};
+
 	hsusb_pins: hsusb {
 		groups = "usb0_ovc_vbus";
 		function = "usb0";
arch/arm/boot/dts/r8a7790-stout.dts +6 -1
index 7a7d3b84d1a6..ad68e6034b43 100644
@@ -179,6 +179,11 @@
 		function = "iic3";
 	};
 
+	pmic_irq_pins: pmicirq {
+		groups = "intc_irq2";
+		function = "intc";
+	};
+
 	usb0_pins: usb0 {
 		groups = "usb0";
 		function = "usb0";
@@ -317,7 +322,7 @@
 
 &iic3 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&iic3_pins>;
+	pinctrl-0 = <&iic3_pins &pmic_irq_pins>;
 	status = "okay";
 
 	pmic@58 {
arch/arm/boot/dts/r8a7791-koelsch.dts +7 -0
index e6580aa0cea3..a116bfc11f0b 100644
@@ -540,6 +540,11 @@
 		function = "intc";
 	};
 
+	pmic_irq_pins: pmicirq {
+		groups = "intc_irq2";
+		function = "intc";
+	};
+
 	sdhi0_pins: sd0 {
 		groups = "sdhi0_data4", "sdhi0_ctrl";
 		function = "sdhi0";
@@ -776,6 +781,8 @@
 };
 
 &i2c6 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pmic_irq_pins>;
 	status = "okay";
 	clock-frequency = <100000>;
 
arch/arm/boot/dts/r8a7791-porter.dts +7 -0
index fefdf8238bbe..e08d257f5d0c 100644
@@ -228,6 +228,11 @@
 		function = "intc";
 	};
 
+	pmic_irq_pins: pmicirq {
+		groups = "intc_irq2";
+		function = "intc";
+	};
+
 	sdhi0_pins: sd0 {
 		groups = "sdhi0_data4", "sdhi0_ctrl";
 		function = "sdhi0";
@@ -373,6 +378,8 @@
 };
 
 &i2c6 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pmic_irq_pins>;
 	status = "okay";
 	clock-frequency = <100000>;
 
arch/arm/boot/dts/r8a7792-blanche.dts +7 -0
index b6fa80c3b07e..b7af14de7c8e 100644
@@ -234,6 +234,11 @@
 		groups = "du1_rgb666", "du1_sync", "du1_disp";
 		function = "du1";
 	};
+
+	pmic_irq_pins: pmicirq {
+		groups = "intc_irq2";
+		function = "intc";
+	};
 };
 
 &rwdt {
@@ -314,6 +319,8 @@
 	pmic@58 {
 		compatible = "dlg,da9063";
 		reg = <0x58>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pmic_irq_pins>;
 		interrupt-parent = <&irqc>;
 		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-controller;
arch/arm/boot/dts/r8a7793-gose.dts +7 -0
index f51601af89a2..9984ebf06695 100644
@@ -514,6 +514,11 @@
 		function = "intc";
 	};
 
+	pmic_irq_pins: pmicirq {
+		groups = "intc_irq2";
+		function = "intc";
+	};
+
 	sdhi0_pins: sd0 {
 		groups = "sdhi0_data4", "sdhi0_ctrl";
 		function = "sdhi0";
@@ -711,6 +716,8 @@
 };
 
 &i2c6 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pmic_irq_pins>;
 	status = "okay";
 	clock-frequency = <100000>;
 
Signature · 1 line
2.20.1
Reviewed-by on v2 1/1
#1 lore raw

Hi Marek,

Quoted 6 lines · On Wed, May 15, 2019 at 10:23 AM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

The PMIC IRQ line pin multiplexing configuration is missing from the DTs. Since the line is configured correctly by default, the system works fine. However, add the IRQ line pin multiplexing configuration for completeness.

Quoted 8 lines
Cc Geert Uytterhoeven <[email protected]>
Cc Simon Horman <[email protected]>

To: [email protected]
---
V2: Move the pin control node from iic3 controller to pmic on 7792 Blanche,
since there's only one PMIC on that board.

Thanks for the update!

As the tag condition from v1 is now fulfilled:

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Applied
#2 lore raw
Quoted 18 lines · Geert Uytterhoeven

Hi Marek,

Quoted 6 lines · On Wed, May 15, 2019 at 10:23 AM <[email protected]> wrote:

From: Marek Vasut <[email protected]>

The PMIC IRQ line pin multiplexing configuration is missing from the DTs. Since the line is configured correctly by default, the system works fine. However, add the IRQ line pin multiplexing configuration for completeness.

Quoted 8 lines
Cc Geert Uytterhoeven <[email protected]>
Cc Simon Horman <[email protected]>

To: [email protected]
---
V2: Move the pin control node from iic3 controller to pmic on 7792 Blanche,
since there's only one PMIC on that board.

Quoted 4 lines

Thanks for the update!

As the tag condition from v1 is now fulfilled:

Thanks, applied for v5.3.