Skip to contentSkip to conversation

powerpc: Remove double free

PATCH Applied Tobin C. Harding 4 participants 4 messages May 15, 2019 – May 18, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Remove double free

kfree() after kobject_put(). Who ever wrote this was on crack.

Fixes 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak")

---

FTR

git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80
7e8039795a80 Tobin C. Harding Tue Apr 30 11:09:23 2019 +1000 powerpc/cacheinfo: Fix kobject memleak

 arch/powerpc/kernel/cacheinfo.c | 1 -
 1 file changed, 1 deletion(-)
arch/powerpc/kernel/cacheinfo.c +0 -1
index f2ed3ef4b129..862e2890bd3d 100644
@@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index,
 				  cache_dir->kobj, "index%d", index);
 	if (rc) {
 		kobject_put(&index_dir->kobj);
-		kfree(index_dir);
 		return;
 	}
 
Signature · 1 line
2.21.0
#1 lore raw

kobject_put() released index_dir->kobj

but who will release 'index' ?

Christophe

Le 15/05/2019 à 11:07, Tobin C. Harding a écrit :

Quoted 27 lines

kfree() after kobject_put(). Who ever wrote this was on crack.

Fixes 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak")

---

FTR

git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80
7e8039795a80 Tobin C. Harding Tue Apr 30 11:09:23 2019 +1000 powerpc/cacheinfo: Fix kobject memleak

  arch/powerpc/kernel/cacheinfo.c | 1 -
  1 file changed, 1 deletion(-)
arch/powerpc/kernel/cacheinfo.c +0 -1
index f2ed3ef4b129..862e2890bd3d 100644
@@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index,
  				  cache_dir->kobj, "index%d", index);
  	if (rc) {
  		kobject_put(&index_dir->kobj);
-		kfree(index_dir);
  		return;
  	}
 
#2 lore raw
Quoted 1 line · Christophe Leroy

kobject_put() released index_dir->kobj

Yes, but what is that kobject enclosed in?

Quoted 1 line

but who will release 'index' ?

The final kobject_put() will do that, see cacheinfo_create_index_dir() for the details.

And please do not top-post, you lost all context.

greg k-h