Add utilization clamping support
Subsystems (6)
v9 cover Add utilization clamping support
Hi all, this is a respin of:
https://lore.kernel.org/lkml/[email protected]/
which includes the following main changes:
- fix "max local update" by moving into uclamp_rq_inc_id()
- use for_each_clamp_id() and uclamp_se_set() to make code less fragile
- rename sysfs node: s/sched_uclamp_util_{min,max}/sched_util_clamp_{min,max}/
- removed not used uclamp_eff_bucket_id()
- move uclamp_bucket_base_value() definition into patch using it
- get rid of not necessary SCHED_POLICY_MAX define
- update sched_setattr() syscall to just force the current policy on SCHED_FLAG_KEEP_POLICY
- return EOPNOTSUPP from uclamp_validate() on !CONFIG_UCLAMP_TASK
- make alloc_uclamp_sched_group() a void function
- simplify bits_per() definition
- add rq's lockdep assert to uclamp_rq_{inc,dec}_id()
With the above, I think we captured all the major inputs from Peter [1]. Thus, this v9 is likely the right version to unlock Tejun's review [2] on the remaining cgroup related bits, i.e. patches [12-16].
Cheers Patrick
Series Organization
===================
The series is organized into these main sections:
- Patches [01-07]: Per task (primary) API
- Patches [08-09]: Schedutil integration for FAIR and RT tasks
- Patches [10-11]: Integration with EAS's energy_compute()
- Patches [12-16]: Per task group (secondary) API
It is based on today's tip/sched/core and the full tree is available here:
git://linux-arm.org/linux-pb.git lkml/utilclamp_v9
http://www.linux-arm.org/git?p=linux-pb.git;a=shortlog;h=refs/heads/lkml/utilclamp_v9
Newcomer's Short Abstract
=========================
The Linux scheduler tracks a "utilization" signal for each scheduling entity (SE), e.g. tasks, to know how much CPU time they use. This signal allows the scheduler to know how "big" a task is and, in principle, it can support advanced task placement strategies by selecting the best CPU to run a task. Some of these strategies are represented by the Energy Aware Scheduler [3].
When the schedutil cpufreq governor is in use, the utilization signal allows the Linux scheduler to also drive frequency selection. The CPU utilization signal, which represents the aggregated utilization of tasks scheduled on that CPU, is used to select the frequency which best fits the workload generated by the tasks.
The current translation of utilization values into a frequency selection is
simple: we go to max for RT tasks or to the minimum frequency which can accommodate the utilization of DL+FAIR tasks.
However, utilization values by themselves cannot convey the desired power/performance behaviors of each task as intended by user-space. As such they are not ideally suited for task placement decisions.
Task placement and frequency selection policies in the kernel can be improved by taking into consideration hints coming from authorized user-space elements, like for example the Android middleware or more generally any "System Management Software" (SMS) framework.
Utilization clamping is a mechanism which allows to "clamp" (i.e. filter) the utilization generated by RT and FAIR tasks within a range defined by user-space. The clamped utilization value can then be used, for example, to enforce a minimum and/or maximum frequency depending on which tasks are active on a CPU.
The main use-cases for utilization clamping are:
- boosting: better interactive response for small tasks which are affecting the user experience.
Consider for example the case of a small control thread for an external accelerator (e.g. GPU, DSP, other devices). Here, from the task utilization the scheduler does not have a complete view of what the task's requirements are and, if it's a small utilization task, it keeps selecting a more energy efficient CPU, with smaller capacity and lower frequency, thus negatively impacting the overall time required to complete task activations.
- capping: increase energy efficiency for background tasks not affecting the user experience.
Since running on a lower capacity CPU at a lower frequency is more energy efficient, when the completion time is not a main goal, then capping the utilization considered for certain (maybe big) tasks can have positive effects, both on energy consumption and thermal headroom. This feature allows also to make RT tasks more energy friendly on mobile systems where running them on high capacity CPUs and at the maximum frequency is not required.
Quoted 1 line
From these two use-cases, it's worth noticing that frequency selection
biasing, introduced by patches 9 and 10 of this series, is just one possible usage of utilization clamping. Another compelling extension of utilization clamping is in helping the scheduler in making tasks placement decisions.
Utilization is (also) a task specific property the scheduler uses to know how much CPU bandwidth a task requires, at least as long as there is idle time. Thus, the utilization clamp values, defined either per-task or per-task_group, can represent tasks to the scheduler as being bigger (or smaller) than what they actually are.
Utilization clamping thus enables interesting additional optimizations, for example on asymmetric capacity systems like Arm big.LITTLE and DynamIQ CPUs, where:
- boosting: try to run small/foreground tasks on higher-capacity CPUs to complete them faster despite being less energy efficient.
- capping: try to run big/background tasks on low-capacity CPUs to save power and thermal headroom for more important tasks
This series does not present this additional usage of utilization clamping but it's an integral part of the EAS feature set, where [4] is one of its main components.
Android kernels use SchedTune, a solution similar to utilization clamping, to bias both 'frequency selection' and 'task placement'. This series provides the foundation to add similar features to mainline while focusing, for the time being, just on schedutil integration.
References
==========
[1] Message-ID: <[email protected]>
https://lore.kernel.org/lkml/[email protected]/
[2] Message-ID: <[email protected]>
https://lore.kernel.org/lkml/[email protected]/
[3] Energy Aware Scheduling
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/scheduler/sched-energy.txt?h=v5.1
[4] Expressing per-task/per-cgroup performance hints Linux Plumbers Conference 2018
https://linuxplumbersconf.org/event/2/contributions/128/
Patrick Bellasi (16):
sched/core: uclamp: Add CPU's clamp buckets refcounting sched/core: uclamp: Add bucket local max tracking sched/core: uclamp: Enforce last task's UCLAMP_MAX sched/core: uclamp: Add system default clamps sched/core: Allow sched_setattr() to use the current policy sched/core: uclamp: Extend sched_setattr() to support utilization
clamping
sched/core: uclamp: Reset uclamp values on RESET_ON_FORK sched/core: uclamp: Set default clamps for RT tasks sched/cpufreq: uclamp: Add clamps for FAIR and RT tasks sched/core: uclamp: Add uclamp_util_with()
sched/fair: uclamp: Add uclamp support to energy_compute() sched/core: uclamp: Extend CPU's cgroup controller sched/core: uclamp: Propagate parent clamps sched/core: uclamp: Propagate system defaults to root group sched/core: uclamp: Use TG's clamps to restrict TASK's clamps sched/core: uclamp: Update CPU's refcount on TG's clamp changes
Documentation/admin-guide/cgroup-v2.rst | 46 ++ include/linux/log2.h | 34 ++ include/linux/sched.h | 58 ++ include/linux/sched/sysctl.h | 11 + include/linux/sched/topology.h | 6 - include/uapi/linux/sched.h | 14 +- include/uapi/linux/sched/types.h | 66 ++- init/Kconfig | 75 +++ kernel/sched/core.c | 754 +++++++++++++++++++++++- kernel/sched/cpufreq_schedutil.c | 22 +- kernel/sched/fair.c | 44 +- kernel/sched/rt.c | 4 + kernel/sched/sched.h | 123 +++- kernel/sysctl.c | 16 + 14 files changed, 1229 insertions(+), 44 deletions(-)
Signature · 1 line
2.21.0
PATCH v9 1/16 sched/core: uclamp: Add CPU's clamp buckets refcounting
Utilization clamping allows to clamp the CPU's utilization within a [util_min, util_max] range, depending on the set of RUNNABLE tasks on that CPU. Each task references two "clamp buckets" defining its minimum and maximum (util_{min,max}) utilization "clamp values". A CPU's clamp bucket is active if there is at least one RUNNABLE tasks enqueued on that CPU and refcounting that bucket.
When a task is {en,de}queued {on,from} a rq, the set of active clamp buckets on that CPU can change. If the set of active clamp buckets changes for a CPU a new "aggregated" clamp value is computed for that CPU. This is because each clamp bucket enforces a different utilization clamp value.
Clamp values are always MAX aggregated for both util_min and util_max. This ensures that no task can affect the performance of other co-scheduled tasks which are more boosted (i.e. with higher util_min clamp) or less capped (i.e. with higher util_max clamp).
A task has:
task_struct::uclamp[clamp_id]::bucket_id
to track the "bucket index" of the CPU's clamp bucket it refcounts while enqueued, for each clamp index (clamp_id).
A runqueue has:
rq::uclamp[clamp_id]::bucket[bucket_id].tasks
to track how many RUNNABLE tasks on that CPU refcount each clamp bucket (bucket_id) of a clamp index (clamp_id).
It also has a:
rq::uclamp[clamp_id]::bucket[bucket_id].value
to track the clamp value of each clamp bucket (bucket_id) of a clamp index (clamp_id).
The rq::uclamp::bucket[clamp_id][] array is scanned every time it's needed to find a new MAX aggregated clamp value for a clamp_id. This operation is required only when it's dequeued the last task of a clamp bucket tracking the current MAX aggregated clamp value. In this case, the CPU is either entering IDLE or going to schedule a less boosted or more clamped task.
The expected number of different clamp values configured at build time is small enough to fit the full unordered array into a single cache line, for configurations of up to 7 buckets.
Add to struct rq the basic data structures required to refcount the number of RUNNABLE tasks for each clamp bucket. Add also the max aggregation required to update the rq's clamp value at each enqueue/dequeue event.
Use a simple linear mapping of clamp values into clamp buckets. Pre-compute and cache bucket_id to avoid integer divisions at enqueue/dequeue time.
---
Changes in v9:
Message-ID: <20190408114908.evij7pqml6ltqtnl@e110439-lin>
- move uclamp_bucket_base_value() into the following patch
- simplify bits_per() definition
Message-ID: <[email protected]>
- use for_each_clamp_id() and uclamp_se_set() to make code less fragile Others:
- add rq's lockdep assert to uclamp_rq_{inc,dec}_id()
--- include/linux/log2.h | 34 +++++++ include/linux/sched.h | 39 ++++++++ include/linux/sched/topology.h | 6 -- init/Kconfig | 53 +++++++++++ kernel/sched/core.c | 166 +++++++++++++++++++++++++++++++++ kernel/sched/sched.h | 51 ++++++++++ 6 files changed, 343 insertions(+), 6 deletions(-)
include/linux/log2.h +34 -0
@@ -224,4 +224,38 @@ int __order_base_2(unsigned long n) ilog2((n) - 1) + 1) : \ __order_base_2(n) \ ) + +static inline __attribute__((const)) +int __bits_per (unsigned long n) +{ +if (n <2 ) +return 1 ; +if (is_power_of_2 (n)) +return order_base_2 (n) +1 ; +return order_base_2 (n); +} + +/** +* bits_per - calculate the number of bits required for the argument +* @n: parameter +* +* This is constant-capable and can be used for compile time +* initializations, e.g bitfields. +* +* The first few values calculated by this routine: +* bf(0) = 1 +* bf(1) = 1 +* bf(2) = 2 +* bf(3) = 2 +* bf(4) = 3 +* ... and so on. +*/ +#define bits_per (n) \ +( \ + __builtin_constant_p(n) ? ( \ + ((n) == 0 || (n) == 1) \ + ? 1 : ilog2(n) + 1 \ + ) : \ + __bits_per(n) \ +)#endif /* _LINUX_LOG2_H */
include/linux/sched.h +39 -0
@@ -282,6 +282,18 @@ struct vtime {u64 gtime; }; +/* +* Utilization clamp constraints. +* @UCLAMP_MIN: Minimum utilization +* @UCLAMP_MAX: Maximum utilization +* @UCLAMP_CNT: Utilization clamp constraints count +*/ +enum uclamp_id { +UCLAMP_MIN =0 , +UCLAMP_MAX , +UCLAMP_CNT +}; +struct sched_info {#ifdef CONFIG_SCHED_INFO /* Cumulative counters: */
@@ -313,6 +325,10 @@ struct sched_info {# define SCHED_FIXEDPOINT_SHIFT 10# define SCHED_FIXEDPOINT_SCALE (1L << SCHED_FIXEDPOINT_SHIFT) +/* Increase resolution of cpu_capacity calculations */ +# define SCHED_CAPACITY_SHIFT SCHED_FIXEDPOINT_SHIFT +# define SCHED_CAPACITY_SCALE (1L << SCHED_CAPACITY_SHIFT) +struct load_weight {unsigned long weight;u32 inv_weight;
@@ -561,6 +577,25 @@ struct sched_dl_entity {struct hrtimer inactive_timer; }; +#ifdef CONFIG_UCLAMP_TASK +/* Number of utilization clamp buckets (shorter alias) */ +#define UCLAMP_BUCKETS CONFIG_UCLAMP_BUCKETS_COUNT + +/* +* Utilization clamp for a scheduling entity +* @value: clamp value "assigned" to a se +* @bucket_id: bucket index corresponding to the "assigned" value +* +* The bucket_id is the index of the clamp bucket matching the clamp value +* which is pre-computed and stored to avoid expensive integer divisions from +* the fast path. +*/ +struct uclamp_se { +unsigned int value :bits_per (SCHED_CAPACITY_SCALE ); +unsigned int bucket_id :bits_per (UCLAMP_BUCKETS ); +}; +#endif /* CONFIG_UCLAMP_TASK */ + union rcu_special { struct { u8 blocked;
@@ -641,6 +676,10 @@ struct task_struct {#endif struct sched_dl_entity dl; +#ifdef CONFIG_UCLAMP_TASK +struct uclamp_se uclamp[UCLAMP_CNT ]; +#endif +#ifdef CONFIG_PREEMPT_NOTIFIERS /* List of struct preempt_notifier: */ struct hlist_head preempt_notifiers;
include/linux/sched/topology.h +0 -6
@@ -6,12 +6,6 @@#include <linux/sched/idle.h> -/* -* Increase resolution of cpu_capacity calculations -*/ -#define SCHED_CAPACITY_SHIFT SCHED_FIXEDPOINT_SHIFT -#define SCHED_CAPACITY_SCALE (1L << SCHED_CAPACITY_SHIFT) -/* * sched-domains (multiprocessor balancing) declarations: */
init/Kconfig +53 -0
59 lines not on this page · raw message
kernel/sched/core.c +166 -0
190 lines not on this page · raw message
kernel/sched/sched.h +51 -0
69 lines not on this page · raw message
Signature · 1 line
2.21.0
PATCH v9 2/16 sched/core: uclamp: Add bucket local max tracking
In reply to Patrick BellasiBecause of bucketization, different task-specific clamp values are tracked in the same bucket. For example, with 20% bucket size and assuming to have:
Task1: util_min=25%
Task2: util_min=35%
both tasks will be refcounted in the [20..39]% bucket and always boosted only up to 20% thus implementing a simple floor aggregation normally used in histograms.
In systems with only few and well-defined clamp values, it would be useful to track the exact clamp value required by a task whenever possible. For example, if a system requires only 23% and 47% boost values then it's possible to track the exact boost required by each task using only 3 buckets of ~33% size each.
Introduce a mechanism to max aggregate the requested clamp values of RUNNABLE tasks in the same bucket. Keep it simple by resetting the bucket value to its base value only when a bucket becomes inactive. Allow a limited and controlled overboosting margin for tasks recounted in the same bucket.
In systems where the boost values are not known in advance, it is still possible to control the maximum acceptable overboosting margin by tuning the number of clamp groups. For example, 20 groups ensure a 5% maximum overboost.
Remove the rq bucket initialization code since a correct bucket value is now computed when a task is refcounted into a CPU's rq.
---
Changes in v9
Message-ID: <20190415144930.pntid6evu6r67l4o@e110439-lin>
- fix "max local update" by moving into uclamp_rq_inc_id()
--- kernel/sched/core.c | 43 +++++++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 18 deletions(-)
kernel/sched/core.c +25 -18
@@ -773,6 +773,11 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)return clamp_value /UCLAMP_BUCKET_DELTA ; } +static inline unsigned int uclamp_bucket_base_value (unsigned int clamp_value) +{ +return UCLAMP_BUCKET_DELTA *uclamp_bucket_id (clamp_value); +} +static inline unsigned int uclamp_none (int clamp_id) {if (clamp_id ==UCLAMP_MIN )
@@ -810,6 +815,11 @@ unsigned int uclamp_rq_max_value(struct rq *rq, unsigned int clamp_id)* When a task is enqueued on a rq, the clamp bucket currently defined by the * task's uclamp::bucket_id is refcounted on that rq. This also immediately * updates the rq's clamp value if required. +* +* Tasks can have a task-specific value requested from user-space, track +* within each bucket the maximum value for tasks refcounted in it. +* This "local max aggregation" allows to track the exact "requested" value +* for each bucket when all its RUNNABLE tasks require the same clamp. */ static inline void uclamp_rq_inc_id (struct rq *rq,struct task_struct *p,unsigned int clamp_id)
@@ -823,8 +833,15 @@ static inline void uclamp_rq_inc_id(struct rq *rq, struct task_struct *p, bucket = &uc_rq->bucket[uc_se->bucket_id]; bucket->tasks++; +/* +* Local max aggregation: rq buckets always track the max +* "requested" clamp value of its RUNNABLE tasks. +*/ +if (bucket->tasks ==1 || uc_se->value > bucket->value) + bucket->value = uc_se->value; +if (uc_se->value >READ_ONCE (uc_rq->value)) -WRITE_ONCE (uc_rq->value, bucket->value); +WRITE_ONCE (uc_rq->value, uc_se->value); }/*
@@ -851,6 +868,12 @@ static inline void uclamp_rq_dec_id(struct rq *rq, struct task_struct *p,if (likely (bucket->tasks)) bucket->tasks--; +/* +* Keep "local max aggregation" simple and accept to (possibly) +* overboost some RUNNABLE tasks in the same bucket. +* The rq clamp bucket value is reset to its base value whenever +* there are no more RUNNABLE tasks refcounting it. +*/ if (likely (bucket->tasks))return ;
@@ -891,25 +914,9 @@ static void __init init_uclamp(void)unsigned int clamp_id;int cpu; -for_each_possible_cpu (cpu) { -struct uclamp_bucket *bucket; -struct uclamp_rq *uc_rq; -unsigned int bucket_id; - +for_each_possible_cpu (cpu)memset (&cpu_rq (cpu)->uclamp,0 ,sizeof (struct uclamp_rq )); -for_each_clamp_id (clamp_id) { - uc_rq = &cpu_rq (cpu)->uclamp[clamp_id]; - - bucket_id =1 ; -while (bucket_id <UCLAMP_BUCKETS ) { - bucket = &uc_rq->bucket[bucket_id]; - bucket->value = bucket_id *UCLAMP_BUCKET_DELTA ; - ++bucket_id; - } - } - } -for_each_clamp_id (clamp_id) {uclamp_se_set (&init_task.uclamp[clamp_id],uclamp_none (clamp_id));
Signature · 1 line
2.21.0
PATCH v9 3/16 sched/core: uclamp: Enforce last task's UCLAMP_MAX
In reply to Patrick BellasiWhen a task sleeps it removes its max utilization clamp from its CPU. However, the blocked utilization on that CPU can be higher than the max clamp value enforced while the task was running. This allows undesired CPU frequency increases while a CPU is idle, for example, when another CPU on the same frequency domain triggers a frequency update, since schedutil can now see the full not clamped blocked utilization of the idle CPU.
Fix this by using
uclamp_rq_dec_id(p, rq, UCLAMP_MAX)
uclamp_rq_max_value(rq, UCLAMP_MAX, clamp_value)
to detect when a CPU has no more RUNNABLE clamped tasks and to flag this condition.
Don't track any minimum utilization clamps since an idle CPU never requires a minimum frequency. The decay of the blocked utilization is good enough to reduce the CPU frequency.
--- kernel/sched/core.c | 49 +++++++++++++++++++++++++++++++++++++++----- kernel/sched/sched.h | 2 ++ 2 files changed, 46 insertions(+), 5 deletions(-)
kernel/sched/core.c +44 -5
@@ -791,8 +791,36 @@ static inline void uclamp_se_set(struct uclamp_se *uc_se, unsigned int value) uc_se->bucket_id =uclamp_bucket_id (value); } +static inline unsigned int +uclamp_idle_value (struct rq *rq,unsigned int clamp_id, +unsigned int clamp_value) +{ +/* +* Avoid blocked utilization pushing up the frequency when we go +* idle (which drops the max-clamp) by retaining the last known +* max-clamp. +*/ +if (clamp_id ==UCLAMP_MAX ) { + rq->uclamp_flags |=UCLAMP_FLAG_IDLE ; +return clamp_value; + } + +return uclamp_none (UCLAMP_MIN ); +} + +static inline void uclamp_idle_reset (struct rq *rq,unsigned int clamp_id, +unsigned int clamp_value) +{ +/* Reset max-clamp retention only on idle exit */ +if (!(rq->uclamp_flags &UCLAMP_FLAG_IDLE )) +return ; + +WRITE_ONCE (rq->uclamp[clamp_id].value, clamp_value); +} +static inline -unsigned int uclamp_rq_max_value (struct rq *rq,unsigned int clamp_id) +unsigned int uclamp_rq_max_value (struct rq *rq,unsigned int clamp_id, +unsigned int clamp_value) {struct uclamp_bucket *bucket = rq->uclamp[clamp_id].bucket;int bucket_id =UCLAMP_BUCKETS -1 ;
@@ -808,7 +836,7 @@ unsigned int uclamp_rq_max_value(struct rq *rq, unsigned int clamp_id) }/* No tasks -- default clamp values */ -return uclamp_none (clamp_id); +return uclamp_idle_value (rq, clamp_id, clamp_value); }/*
@@ -833,6 +861,8 @@ static inline void uclamp_rq_inc_id(struct rq *rq, struct task_struct *p, bucket = &uc_rq->bucket[uc_se->bucket_id]; bucket->tasks++; +uclamp_idle_reset (rq, clamp_id, uc_se->value); +/* * Local max aggregation: rq buckets always track the max * "requested" clamp value of its RUNNABLE tasks.
@@ -859,6 +889,7 @@ static inline void uclamp_rq_dec_id(struct rq *rq, struct task_struct *p,struct uclamp_rq *uc_rq = &rq->uclamp[clamp_id];struct uclamp_se *uc_se = &p->uclamp[clamp_id];struct uclamp_bucket *bucket; +unsigned int bkt_clamp;unsigned int rq_clamp;lockdep_assert_held (&rq->lock);
@@ -883,8 +914,10 @@ static inline void uclamp_rq_dec_id(struct rq *rq, struct task_struct *p,* e.g. due to future modification, warn and fixup the expected value. */ SCHED_WARN_ON (bucket->value > rq_clamp); -if (bucket->value >= rq_clamp) -WRITE_ONCE (uc_rq->value,uclamp_rq_max_value (rq, clamp_id)); +if (bucket->value >= rq_clamp) { + bkt_clamp =uclamp_rq_max_value (rq, clamp_id, uc_se->value); +WRITE_ONCE (uc_rq->value, bkt_clamp); + } }static inline void uclamp_rq_inc (struct rq *rq,struct task_struct *p)
@@ -896,6 +929,10 @@ static inline void uclamp_rq_inc(struct rq *rq, struct task_struct *p)for_each_clamp_id (clamp_id)uclamp_rq_inc_id (rq, p, clamp_id); + +/* Reset clamp idle holding when there is one RUNNABLE task */ +if (rq->uclamp_flags &UCLAMP_FLAG_IDLE ) + rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE ; }static inline void uclamp_rq_dec (struct rq *rq,struct task_struct *p)
@@ -914,8 +951,10 @@ static void __init init_uclamp(void)unsigned int clamp_id;int cpu; -for_each_possible_cpu (cpu) +for_each_possible_cpu (cpu) {memset (&cpu_rq (cpu)->uclamp,0 ,sizeof (struct uclamp_rq )); +cpu_rq (cpu)->uclamp_flags =0 ; + }for_each_clamp_id (clamp_id) { uclamp_se_set(&init_task.uclamp[clamp_id],
kernel/sched/sched.h +2 -0
@@ -880,6 +880,8 @@ struct rq {#ifdef CONFIG_UCLAMP_TASK /* Utilization clamp values based on CPU's RUNNABLE tasks */ struct uclamp_rq uclamp[UCLAMP_CNT ]____cacheline_aligned ; +unsigned int uclamp_flags; +#define UCLAMP_FLAG_IDLE 0x01#endif struct cfs_rq cfs;
Signature · 1 line
2.21.0
PATCH v9 4/16 sched/core: uclamp: Add system default clamps
In reply to Patrick BellasiTasks without a user-defined clamp value are considered not clamped and by default their utilization can have any value in the [0..SCHED_CAPACITY_SCALE] range.
Tasks with a user-defined clamp value are allowed to request any value in that range, and the required clamp is unconditionally enforced. However, a "System Management Software" could be interested in limiting the range of clamp values allowed for all tasks.
Add a privileged interface to define a system default configuration via:
/proc/sys/kernel/sched_uclamp_util_{min,max}
which works as an unconditional clamp range restriction for all tasks.
With the default configuration, the full SCHED_CAPACITY_SCALE range of values is allowed for each clamp index. Otherwise, the task-specific clamp is capped by the corresponding system default value.
Do that by tracking, for each task, the "effective" clamp value and bucket the task has been refcounted in at enqueue time. This allows to lazy aggregate "requested" and "system default" values at enqueue time and simplifies refcounting updates at dequeue time.
The cached bucket ids are used to avoid (relatively) more expensive integer divisions every time a task is enqueued.
An active flag is used to report when the "effective" value is valid and thus the task is actually refcounted in the corresponding rq's bucket.
---
Changes in v9:
Message-ID: <[email protected]>:
- use for_each_clamp_id() and uclamp_se_set() to make code less fragile
- s/sched_uclamp_util_{min,max}/sched_util_clamp_{min,max}/
Message-ID: <20190507103845.tejg55wfsu3l3jwh@e110439-lin>
- removed uclamp_eff_bucket_id() because not used
- removed uclamp_eff_value() and moved to a following patch
--- include/linux/sched.h | 10 ++++ include/linux/sched/sysctl.h | 11 ++++ kernel/sched/core.c | 99 +++++++++++++++++++++++++++++++++++- kernel/sysctl.c | 16 ++++++ 4 files changed, 135 insertions(+), 1 deletion(-)
include/linux/sched.h +10 -0
@@ -585,14 +585,21 @@ struct sched_dl_entity {* Utilization clamp for a scheduling entity * @value: clamp value "assigned" to a se * @bucket_id: bucket index corresponding to the "assigned" value +* @active: the se is currently refcounted in a rq's bucket * * The bucket_id is the index of the clamp bucket matching the clamp value * which is pre-computed and stored to avoid expensive integer divisions from * the fast path. +* +* The active bit is set whenever a task has got an "effective" value assigned, +* which can be different from the clamp value "requested" from user-space. +* This allows to know a task is refcounted in the rq's bucket corresponding +* to the "effective" bucket_id. */ struct uclamp_se {unsigned int value :bits_per (SCHED_CAPACITY_SCALE );unsigned int bucket_id :bits_per (UCLAMP_BUCKETS ); +unsigned int active :1 ; };#endif /* CONFIG_UCLAMP_TASK */
@@ -677,6 +684,9 @@ struct task_struct {struct sched_dl_entity dl;#ifdef CONFIG_UCLAMP_TASK +/* Clamp values requested for a scheduling entity */ +struct uclamp_se uclamp_req[UCLAMP_CNT ]; +/* Effective clamp values used for a scheduling entity */ struct uclamp_se uclamp[UCLAMP_CNT ];#endif
include/linux/sched/sysctl.h +11 -0
@@ -56,6 +56,11 @@ int sched_proc_update_handler(struct ctl_table *table, int write,extern unsigned int sysctl_sched_rt_period;extern int sysctl_sched_rt_runtime; +#ifdef CONFIG_UCLAMP_TASK +extern unsigned int sysctl_sched_uclamp_util_min; +extern unsigned int sysctl_sched_uclamp_util_max; +#endif +#ifdef CONFIG_CFS_BANDWIDTH extern unsigned int sysctl_sched_cfs_bandwidth_slice;#endif
@@ -75,6 +80,12 @@ extern int sched_rt_handler(struct ctl_table *table, int write, void __user *buffer, size_t *lenp, loff_t *ppos); +#ifdef CONFIG_UCLAMP_TASK +extern int sysctl_sched_uclamp_handler (struct ctl_table *table,int write, +void __user *buffer,size_t *lenp, +loff_t *ppos); +#endif +extern int sysctl_numa_balancing (struct ctl_table *table,int write,void __user *buffer,size_t *lenp,loff_t *ppos);
kernel/sched/core.c +98 -1
152 lines not on this page · raw message
kernel/sysctl.c +16 -0
@@ -455,6 +455,22 @@ static struct ctl_table kern_table[] = { .mode = 0644, .proc_handler = sched_rr_handler, }, +#ifdef CONFIG_UCLAMP_TASK + { + .procname = "sched_util_clamp_min", + .data = &sysctl_sched_uclamp_util_min, + .maxlen = sizeof(unsigned int), + .mode = 0644, + .proc_handler = sysctl_sched_uclamp_handler, + }, + { + .procname = "sched_util_clamp_max", + .data = &sysctl_sched_uclamp_util_max, + .maxlen = sizeof(unsigned int), + .mode = 0644, + .proc_handler = sysctl_sched_uclamp_handler, + }, +#endif #ifdef CONFIG_SCHED_AUTOGROUP { .procname = "sched_autogroup_enabled",
Signature · 1 line
2.21.0
PATCH v9 5/16 sched/core: Allow sched_setattr() to use the current policy
In reply to Patrick BellasiThe sched_setattr() syscall mandates that a policy is always specified. This requires to always know which policy a task will have when attributes are configured and this makes it impossible to add more generic task attributes valid across different scheduling policies. Reading the policy before setting generic tasks attributes is racy since we cannot be sure it is not changed concurrently.
Introduce the required support to change generic task attributes without affecting the current task policy. This is done by adding an attribute flag (SCHED_FLAG_KEEP_POLICY) to enforce the usage of the current policy.
Add support for the SETPARAM_POLICY policy, which is already used by the sched_setparam() POSIX syscall, to the sched_setattr() non-POSIX syscall.
---
Changes in v9:
Message-ID: <20190509145901.um7rrsslg7de4blf@e110439-lin>
- get rid of not necessary SCHED_POLICY_MAX define
- update sched_setattr() syscall to just force the current policy on SCHED_FLAG_KEEP_POLICY
--- include/uapi/linux/sched.h | 4 +++- kernel/sched/core.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-)
include/uapi/linux/sched.h +3 -1
@@ -50,9 +50,11 @@#define SCHED_FLAG_RESET_ON_FORK 0x01#define SCHED_FLAG_RECLAIM 0x02#define SCHED_FLAG_DL_OVERRUN 0x04 +#define SCHED_FLAG_KEEP_POLICY 0x08#define SCHED_FLAG_ALL (SCHED_FLAG_RESET_ON_FORK | \ SCHED_FLAG_RECLAIM | \ - SCHED_FLAG_DL_OVERRUN) + SCHED_FLAG_DL_OVERRUN | \ + SCHED_FLAG_KEEP_POLICY)#endif /* _UAPI_LINUX_SCHED_H */
kernel/sched/core.c +2 -0
@@ -4863,6 +4863,8 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr,if ((int )attr.sched_policy <0 )return -EINVAL ; +if (attr.sched_flags &SCHED_FLAG_KEEP_POLICY ) + attr.sched_policy =SETPARAM_POLICY ;rcu_read_lock (); retval = -ESRCH ;
Signature · 1 line
2.21.0
PATCH v9 6/16 sched/core: uclamp: Extend sched_setattr() to support utilization clamping
In reply to Patrick BellasiThe SCHED_DEADLINE scheduling class provides an advanced and formal model to define tasks requirements that can translate into proper decisions for both task placements and frequencies selections. Other classes have a more simplified model based on the POSIX concept of priorities.
Such a simple priority based model however does not allow to exploit most advanced features of the Linux scheduler like, for example, driving frequencies selection via the schedutil cpufreq governor. However, also for non SCHED_DEADLINE tasks, it's still interesting to define tasks properties to support scheduler decisions.
Utilization clamping exposes to user-space a new set of per-task attributes the scheduler can use as hints about the expected/required utilization for a task. This allows to implement a "proactive" per-task frequency control policy, a more advanced policy than the current one based just on "passive" measured task utilization. For example, it's possible to boost interactive tasks (e.g. to get better performance) or cap background tasks (e.g. to be more energy/thermal efficient).
Introduce a new API to set utilization clamping values for a specified task by extending sched_setattr(), a syscall which already allows to define task specific properties for different scheduling classes. A new pair of attributes allows to specify a minimum and maximum utilization the scheduler can consider for a task.
Do that by validating the required clamp values before and then applying the required changes using _the_ same pattern already in use for __setscheduler(). This ensures that the task is re-enqueued with the new clamp values.
---
Changes in v9:
Message-ID: <20190507111347.4ivnjwbymsf7i3e6@e110439-lin>
- return EOPNOTSUPP from uclamp_validate() on !CONFIG_UCLAMP_TASK
- update commit message
--- include/linux/sched.h | 9 ++++ include/uapi/linux/sched.h | 12 ++++- include/uapi/linux/sched/types.h | 66 +++++++++++++++++++---- kernel/sched/core.c | 91 +++++++++++++++++++++++++++++--- 4 files changed, 161 insertions(+), 17 deletions(-)
include/linux/sched.h +9 -0
@@ -586,6 +586,7 @@ struct sched_dl_entity {* @value: clamp value "assigned" to a se * @bucket_id: bucket index corresponding to the "assigned" value * @active: the se is currently refcounted in a rq's bucket +* @user_defined: the requested clamp value comes from user-space * * The bucket_id is the index of the clamp bucket matching the clamp value * which is pre-computed and stored to avoid expensive integer divisions from
@@ -595,11 +596,19 @@ struct sched_dl_entity {* which can be different from the clamp value "requested" from user-space. * This allows to know a task is refcounted in the rq's bucket corresponding * to the "effective" bucket_id. +* +* The user_defined bit is set whenever a task has got a task-specific clamp +* value requested from userspace, i.e. the system defaults apply to this task +* just as a restriction. This allows to relax default clamps when a less +* restrictive task-specific value has been requested, thus allowing to +* implement a "nice" semantic. For example, a task running with a 20% +* default boost can still drop its own boosting to 0%. */ struct uclamp_se {unsigned int value :bits_per (SCHED_CAPACITY_SCALE );unsigned int bucket_id :bits_per (UCLAMP_BUCKETS );unsigned int active :1 ; +unsigned int user_defined :1 ; };#endif /* CONFIG_UCLAMP_TASK */
include/uapi/linux/sched.h +11 -1
@@ -51,10 +51,20 @@#define SCHED_FLAG_RECLAIM 0x02#define SCHED_FLAG_DL_OVERRUN 0x04#define SCHED_FLAG_KEEP_POLICY 0x08 +#define SCHED_FLAG_KEEP_PARAMS 0x10 +#define SCHED_FLAG_UTIL_CLAMP_MIN 0x20 +#define SCHED_FLAG_UTIL_CLAMP_MAX 0x40 + +#define SCHED_FLAG_KEEP_ALL (SCHED_FLAG_KEEP_POLICY | \ + SCHED_FLAG_KEEP_PARAMS) + +#define SCHED_FLAG_UTIL_CLAMP (SCHED_FLAG_UTIL_CLAMP_MIN | \ + SCHED_FLAG_UTIL_CLAMP_MAX)#define SCHED_FLAG_ALL (SCHED_FLAG_RESET_ON_FORK | \ SCHED_FLAG_RECLAIM | \ SCHED_FLAG_DL_OVERRUN | \ - SCHED_FLAG_KEEP_POLICY) + SCHED_FLAG_KEEP_ALL | \ + SCHED_FLAG_UTIL_CLAMP)#endif /* _UAPI_LINUX_SCHED_H */
include/uapi/linux/sched/types.h +57 -9
97 lines not on this page · raw message
kernel/sched/core.c +84 -7
175 lines not on this page · raw message
Signature · 1 line
2.21.0
PATCH v9 7/16 sched/core: uclamp: Reset uclamp values on RESET_ON_FORK
In reply to Patrick BellasiA forked tasks gets the same clamp values of its parent however, when the RESET_ON_FORK flag is set on parent, e.g. via:
sys_sched_setattr()
sched_setattr()
__sched_setscheduler(attr::SCHED_FLAG_RESET_ON_FORK)
the new forked task is expected to start with all attributes reset to default values.
Do that for utilization clamp values too by checking the reset request from the existing uclamp_fork() call which already provides the required initialization for other uclamp related bits.
--- kernel/sched/core.c | 8 ++++++++ 1 file changed, 8 insertions(+)
kernel/sched/core.c +8 -0
@@ -1070,6 +1070,14 @@ static void uclamp_fork(struct task_struct *p)for_each_clamp_id (clamp_id) p->uclamp[clamp_id].active = false; + +if (likely (!p->sched_reset_on_fork)) +return ; + +for_each_clamp_id (clamp_id) { +uclamp_se_set (&p->uclamp_req[clamp_id], +uclamp_none (clamp_id), false); + } }static void __init init_uclamp (void )
Signature · 1 line
2.21.0
PATCH v9 8/16 sched/core: uclamp: Set default clamps for RT tasks
In reply to Patrick BellasiBy default FAIR tasks start without clamps, i.e. neither boosted nor capped, and they run at the best frequency matching their utilization demand. This default behavior does not fit RT tasks which instead are expected to run at the maximum available frequency, if not otherwise required by explicitly capping them.
Enforce the correct behavior for RT tasks by setting util_min to max whenever:
1. the task is switched to the RT class and it does not already have a user-defined clamp value assigned.
2. an RT task is forked from a parent with RESET_ON_FORK set.
NOTE: utilization clamp values are cross scheduling class attributes and thus they are never changed/reset once a value has been explicitly defined from user-space.
--- kernel/sched/core.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
kernel/sched/core.c +28 -2
@@ -1050,6 +1050,27 @@ static int uclamp_validate(struct task_struct *p,static void __setscheduler_uclamp (struct task_struct *p,const struct sched_attr *attr) { +unsigned int clamp_id; + +/* +* On scheduling class change, reset to default clamps for tasks +* without a task-specific value. +*/ +for_each_clamp_id (clamp_id) { +struct uclamp_se *uc_se = &p->uclamp_req[clamp_id]; +unsigned int clamp_value =uclamp_none (clamp_id); + +/* Keep using defined clamps across class changes */ +if (uc_se->user_defined) +continue ; + +/* By default, RT tasks always get 100% boost */ +if (unlikely (rt_task (p) && clamp_id ==UCLAMP_MIN )) + clamp_value =uclamp_none (UCLAMP_MAX ); + +uclamp_se_set (uc_se, clamp_value, false); + } +if (likely (!(attr->sched_flags &SCHED_FLAG_UTIL_CLAMP )))return ;
@@ -1075,8 +1096,13 @@ static void uclamp_fork(struct task_struct *p)return ;for_each_clamp_id (clamp_id) { -uclamp_se_set (&p->uclamp_req[clamp_id], -uclamp_none (clamp_id), false); +unsigned int clamp_value =uclamp_none (clamp_id); + +/* By default, RT tasks always get 100% boost */ +if (unlikely (rt_task (p) && clamp_id ==UCLAMP_MIN )) + clamp_value =uclamp_none (UCLAMP_MAX ); + +uclamp_se_set (&p->uclamp_req[clamp_id], clamp_value, false); } }
Signature · 1 line
2.21.0
PATCH v9 9/16 sched/cpufreq: uclamp: Add clamps for FAIR and RT tasks
In reply to Patrick BellasiEach time a frequency update is required via schedutil, a frequency is selected to (possibly) satisfy the utilization reported by each scheduling class and irqs. However, when utilization clamping is in use, the frequency selection should consider userspace utilization clamping hints. This will allow, for example, to:
- boost tasks which are directly affecting the user experience by running them at least at a minimum "requested" frequency
- cap low priority tasks not directly affecting the user experience by running them only up to a maximum "allowed" frequency
These constraints are meant to support a per-task based tuning of the frequency selection thus supporting a fine grained definition of performance boosting vs energy saving strategies in kernel space.
Add support to clamp the utilization of RUNNABLE FAIR and RT tasks within the boundaries defined by their aggregated utilization clamp constraints.
Do that by considering the max(min_util, max_util) to give boosted tasks the performance they need even when they happen to be co-scheduled with other capped tasks.
--- kernel/sched/cpufreq_schedutil.c | 15 ++++++++++++--- kernel/sched/fair.c | 4 ++++ kernel/sched/rt.c | 4 ++++ kernel/sched/sched.h | 23 +++++++++++++++++++++++ 4 files changed, 43 insertions(+), 3 deletions(-)
kernel/sched/cpufreq_schedutil.c +12 -3
@@ -201,8 +201,10 @@ unsigned long schedutil_freq_util(int cpu, unsigned long util_cfs,unsigned long dl_util, util, irq;struct rq *rq =cpu_rq (cpu); -if (type ==FREQUENCY_UTIL &&rt_rq_is_runnable (&rq->rt)) +if (!IS_BUILTIN (CONFIG_UCLAMP_TASK ) && + type ==FREQUENCY_UTIL &&rt_rq_is_runnable (&rq->rt)) {return max; + }/* * Early check to see if IRQ/steal time saturates the CPU, can be
@@ -218,9 +220,16 @@ unsigned long schedutil_freq_util(int cpu, unsigned long util_cfs,* CFS tasks and we use the same metric to track the effective * utilization (PELT windows are synchronized) we can directly add them * to obtain the CPU's actual utilization. +* +* CFS and RT utilization can be boosted or capped, depending on +* utilization clamp constraints requested by currently RUNNABLE +* tasks. +* When there are no CFS RUNNABLE tasks, clamps are released and +* frequency will be gracefully reduced with the utilization decay. */ - util = util_cfs; - util +=cpu_util_rt (rq); + util = util_cfs +cpu_util_rt (rq); +if (type ==FREQUENCY_UTIL ) + util =uclamp_util (rq, util); dl_util =cpu_util_dl (rq);
kernel/sched/fair.c +4 -0
@@ -10690,6 +10690,10 @@ const struct sched_class fair_sched_class = {#ifdef CONFIG_FAIR_GROUP_SCHED .task_change_group = task_change_group_fair,#endif + +#ifdef CONFIG_UCLAMP_TASK + .uclamp_enabled = 1, +#endif };#ifdef CONFIG_SCHED_DEBUG
kernel/sched/rt.c +4 -0
@@ -2400,6 +2400,10 @@ const struct sched_class rt_sched_class = { .switched_to = switched_to_rt, .update_curr = update_curr_rt, + +#ifdef CONFIG_UCLAMP_TASK + .uclamp_enabled = 1, +#endif };#ifdef CONFIG_RT_GROUP_SCHED
kernel/sched/sched.h +23 -0
@@ -2275,6 +2275,29 @@ static inline void cpufreq_update_util(struct rq *rq, unsigned int flags)static inline void cpufreq_update_util (struct rq *rq,unsigned int flags) {}#endif /* CONFIG_CPU_FREQ */ +#ifdef CONFIG_UCLAMP_TASK +static inline unsigned int uclamp_util (struct rq *rq,unsigned int util) +{ +unsigned int min_util =READ_ONCE (rq->uclamp[UCLAMP_MIN ].value); +unsigned int max_util =READ_ONCE (rq->uclamp[UCLAMP_MAX ].value); + +/* +* Since CPU's {min,max}_util clamps are MAX aggregated considering +* RUNNABLE tasks with _different_ clamps, we can end up with an +* inversion. Fix it now when the clamps are applied. +*/ +if (unlikely (min_util >= max_util)) +return min_util; + +return clamp (util, min_util, max_util); +} +#else /* CONFIG_UCLAMP_TASK */ +static inline unsigned int uclamp_util (struct rq *rq,unsigned int util) +{ +return util; +} +#endif /* CONFIG_UCLAMP_TASK */ +#ifdef arch_scale_freq_capacity# ifndef arch_scale_freq_invariant# define arch_scale_freq_invariant () true
Signature · 1 line
2.21.0
PATCH v9 10/16 sched/core: uclamp: Add uclamp_util_with()
In reply to Patrick BellasiSo far uclamp_util() allows to clamp a specified utilization considering the clamp values requested by RUNNABLE tasks in a CPU. For the Energy Aware Scheduler (EAS) it is interesting to test how clamp values will change when a task is becoming RUNNABLE on a given CPU.
For example, EAS is interested in comparing the energy impact of different scheduling decisions and the clamp values can play a role on that.
Add uclamp_util_with() which allows to clamp a given utilization by considering the possible impact on CPU clamp values of a specified task.
---
Changes in v9:
Message-ID: <20190507103845.tejg55wfsu3l3jwh@e110439-lin>
- moved here the definition of uclamp_eff_value() from a previous patch
--- kernel/sched/core.c | 13 +++++++++++++ kernel/sched/sched.h | 21 ++++++++++++++++++++- 2 files changed, 33 insertions(+), 1 deletion(-)
kernel/sched/core.c +13 -0
@@ -868,6 +868,19 @@ uclamp_eff_get(struct task_struct *p, unsigned int clamp_id)return uc_req; } +unsigned int uclamp_eff_value (struct task_struct *p,unsigned int clamp_id) +{ +struct uclamp_se uc_eff; + +/* Task currently refcounted: use back-annotated (effective) value */ +if (p->uclamp[clamp_id].active) +return p->uclamp[clamp_id].value; + + uc_eff =uclamp_eff_get (p, clamp_id); + +return uc_eff.value; +} +/* * When a task is enqueued on a rq, the clamp bucket currently defined by the * task's uclamp::bucket_id is refcounted on that rq. This also immediately
kernel/sched/sched.h +20 -1
@@ -2276,11 +2276,20 @@ static inline void cpufreq_update_util(struct rq *rq, unsigned int flags) {}#endif /* CONFIG_CPU_FREQ */ #ifdef CONFIG_UCLAMP_TASK -static inline unsigned int uclamp_util (struct rq *rq,unsigned int util) +unsigned int uclamp_eff_value (struct task_struct *p,unsigned int clamp_id); + +static __always_inline +unsigned int uclamp_util_with(struct rq *rq, unsigned int util, +struct task_struct *p) {unsigned int min_util =READ_ONCE (rq->uclamp[UCLAMP_MIN ].value);unsigned int max_util =READ_ONCE (rq->uclamp[UCLAMP_MAX ].value); +if (p) { + min_util =max (min_util,uclamp_eff_value (p,UCLAMP_MIN )); + max_util =max (max_util,uclamp_eff_value (p,UCLAMP_MAX )); + } +/* * Since CPU's {min,max}_util clamps are MAX aggregated considering * RUNNABLE tasks with _different_ clamps, we can end up with an
@@ -2291,7 +2300,17 @@ static inline unsigned int uclamp_util(struct rq *rq, unsigned int util) return clamp(util, min_util, max_util); } + +static inline unsigned int uclamp_util (struct rq *rq,unsigned int util) +{ +return uclamp_util_with (rq, util,NULL ); +}#else /* CONFIG_UCLAMP_TASK */ +static inline unsigned int uclamp_util_with (struct rq *rq,unsigned int util, +struct task_struct *p) +{ +return util; +}static inline unsigned int uclamp_util (struct rq *rq,unsigned int util) {return util;
Signature · 1 line
2.21.0
PATCH v9 11/16 sched/fair: uclamp: Add uclamp support to energy_compute()
In reply to Patrick BellasiThe Energy Aware Scheduler (EAS) estimates the energy impact of waking up a task on a given CPU. This estimation is based on:
a) an (active) power consumption defined for each CPU frequency
b) an estimation of which frequency will be used on each CPU
c) an estimation of the busy time (utilization) of each CPU
Utilization clamping can affect both b) and c).
A CPU is expected to run:
- on an higher than required frequency, but for a shorter time, in case its estimated utilization will be smaller than the minimum utilization enforced by uclamp
- on a smaller than required frequency, but for a longer time, in case its estimated utilization is bigger than the maximum utilization enforced by uclamp
While compute_energy() already accounts clamping effects on busy time, the clamping effects on frequency selection are currently ignored.
Fix it by considering how CPU clamp values will be affected by a task waking up and being RUNNABLE on that CPU.
Do that by refactoring schedutil_freq_util() to take an additional task_struct* which allows EAS to evaluate the impact on clamp values of a task being eventually queued in a CPU. Clamp values are applied to the RT+CFS utilization only when a FREQUENCY_UTIL is required by compute_energy().
Do note that switching from ENERGY_UTIL to FREQUENCY_UTIL in the computation of the cpu_util signal implies that we are more likely to estimate the highest OPP when a RT task is running in another CPU of the same performance domain. This can have an impact on energy estimation but:
- it's not easy to say which approach is better, since it depends on the use case
- the original approach could still be obtained by setting a smaller task-specific util_min whenever required
Since we are at that:
- rename schedutil_freq_util() into schedutil_cpu_util(), since it's not only used for frequency selection.
--- kernel/sched/cpufreq_schedutil.c | 9 +++---- kernel/sched/fair.c | 40 +++++++++++++++++++++++++++----- kernel/sched/sched.h | 20 +++++----------- 3 files changed, 45 insertions(+), 24 deletions(-)
kernel/sched/cpufreq_schedutil.c +5 -4
@@ -195,8 +195,9 @@ static unsigned int get_next_freq(struct sugov_policy *sg_policy,* based on the task model parameters and gives the minimal utilization * required to meet deadlines. */ -unsigned long schedutil_freq_util (int cpu,unsigned long util_cfs, -unsigned long max,enum schedutil_type type) +unsigned long schedutil_cpu_util (int cpu,unsigned long util_cfs, +unsigned long max,enum schedutil_type type, +struct task_struct *p) {unsigned long dl_util, util, irq;struct rq *rq =cpu_rq (cpu);
@@ -229,7 +230,7 @@ unsigned long schedutil_freq_util(int cpu, unsigned long util_cfs,*/ util = util_cfs +cpu_util_rt (rq);if (type ==FREQUENCY_UTIL ) - util =uclamp_util (rq, util); + util =uclamp_util_with (rq, util, p); dl_util =cpu_util_dl (rq);
@@ -289,7 +290,7 @@ static unsigned long sugov_get_util(struct sugov_cpu *sg_cpu) sg_cpu->max = max; sg_cpu->bw_dl =cpu_bw_dl (rq); -return schedutil_freq_util (sg_cpu->cpu, util, max,FREQUENCY_UTIL ); +return schedutil_cpu_util (sg_cpu->cpu, util, max,FREQUENCY_UTIL ,NULL ); }/**
kernel/sched/fair.c +34 -6
@@ -6498,11 +6498,21 @@ static unsigned long cpu_util_next(int cpu, struct task_struct *p, int dst_cpu)static long compute_energy (struct task_struct *p,int dst_cpu,struct perf_domain *pd) { -long util, max_util, sum_util, energy =0 ; +unsigned int max_util, util_cfs, cpu_util, cpu_cap; +unsigned long sum_util, energy =0 ; +struct task_struct *tsk;int cpu;for (; pd; pd = pd->next) { +struct cpumask *pd_mask =perf_domain_span (pd); + +/* +* The energy model mandates all the CPUs of a performance +* domain have the same capacity. +*/ + cpu_cap =arch_scale_cpu_capacity (NULL ,cpumask_first (pd_mask)); max_util = sum_util =0 ; +/* * The capacity state of CPUs of the current rd can be driven by * CPUs of another rd if they belong to the same performance
@@ -6513,11 +6523,29 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)* it will not appear in its pd list and will not be accounted * by compute_energy(). */ -for_each_cpu_and (cpu,perf_domain_span (pd), cpu_online_mask) { - util =cpu_util_next (cpu, p, dst_cpu); - util =schedutil_energy_util (cpu, util); - max_util =max (util, max_util); - sum_util += util; +for_each_cpu_and (cpu, pd_mask, cpu_online_mask) { + util_cfs =cpu_util_next (cpu, p, dst_cpu); + +/* +* Busy time computation: utilization clamping is not +* required since the ratio (sum_util / cpu_capacity) +* is already enough to scale the EM reported power +* consumption at the (eventually clamped) cpu_capacity. +*/ + sum_util +=schedutil_cpu_util (cpu, util_cfs, cpu_cap, +ENERGY_UTIL ,NULL ); + +/* +* Performance domain frequency: utilization clamping +* must be considered since it affects the selection +* of the performance domain frequency. +* NOTE: in case RT tasks are running, by default the +* FREQUENCY_UTIL's utilization can be max OPP. +*/ + tsk = cpu == dst_cpu ? p :NULL ; + cpu_util =schedutil_cpu_util (cpu, util_cfs, cpu_cap, +FREQUENCY_UTIL , tsk); + max_util =max (max_util, cpu_util); } energy +=em_pd_energy (pd->em_pd, max_util, sum_util);
kernel/sched/sched.h +6 -14
@@ -2332,7 +2332,6 @@ static inline unsigned long capacity_orig_of(int cpu) }#endif -#ifdef CONFIG_CPU_FREQ_GOV_SCHEDUTIL /** * enum schedutil_type - CPU utilization type * @FREQUENCY_UTIL: Utilization used to select frequency
@@ -2348,15 +2347,11 @@ enum schedutil_type { ENERGY_UTIL, }; -unsigned long schedutil_freq_util (int cpu,unsigned long util_cfs, -unsigned long max,enum schedutil_type type); - -static inline unsigned long schedutil_energy_util (int cpu,unsigned long cfs) -{ -unsigned long max =arch_scale_cpu_capacity (NULL , cpu); +#ifdef CONFIG_CPU_FREQ_GOV_SCHEDUTIL -return schedutil_freq_util (cpu, cfs, max,ENERGY_UTIL ); -} +unsigned long schedutil_cpu_util (int cpu,unsigned long util_cfs, +unsigned long max,enum schedutil_type type, +struct task_struct *p);static inline unsigned long cpu_bw_dl (struct rq *rq) {
@@ -2385,11 +2380,8 @@ static inline unsigned long cpu_util_rt(struct rq *rq) return READ_ONCE(rq->avg_rt.util_avg); }#else /* CONFIG_CPU_FREQ_GOV_SCHEDUTIL */ -static inline unsigned long schedutil_energy_util (int cpu,unsigned long cfs) -{ -return cfs; -} -#endif +#define schedutil_cpu_util (cpu, util_cfs, max, type, p) 0 +#endif /* CONFIG_CPU_FREQ_GOV_SCHEDUTIL */ #ifdef CONFIG_HAVE_SCHED_AVG_IRQ static inline unsigned long cpu_util_irq (struct rq *rq)
Signature · 1 line
2.21.0
PATCH v9 12/16 sched/core: uclamp: Extend CPU's cgroup controller
In reply to Patrick BellasiThe cgroup CPU bandwidth controller allows to assign a specified (maximum) bandwidth to the tasks of a group. However this bandwidth is defined and enforced only on a temporal base, without considering the actual frequency a CPU is running on. Thus, the amount of computation completed by a task within an allocated bandwidth can be very different depending on the actual frequency the CPU is running that task. The amount of computation can be affected also by the specific CPU a task is running on, especially when running on asymmetric capacity systems like Arm's big.LITTLE.
With the availability of schedutil, the scheduler is now able to drive frequency selections based on actual task utilization. Moreover, the utilization clamping support provides a mechanism to bias the frequency selection operated by schedutil depending on constraints assigned to the tasks currently RUNNABLE on a CPU.
Giving the mechanisms described above, it is now possible to extend the cpu controller to specify the minimum (or maximum) utilization which should be considered for tasks RUNNABLE on a cpu.
This makes it possible to better defined the actual computational power assigned to task groups, thus improving the cgroup CPU bandwidth controller which is currently based just on time constraints.
Extend the CPU controller with a couple of new attributes util.{min,max} which allows to enforce utilization boosting and capping for all the tasks in a group. Specifically:
- util.min: defines the minimum utilization which should be considered i.e. the RUNNABLE tasks of this group will run at least at a minimum frequency which corresponds to the util.min utilization
- util.max: defines the maximum utilization which should be considered i.e. the RUNNABLE tasks of this group will run up to a maximum frequency which corresponds to the util.max utilization
These attributes:
a) are available only for non-root nodes, both on default and legacy hierarchies, while system wide clamps are defined by a generic interface which does not depends on cgroups. This system wide interface enforces constraints on tasks in the root node.
b) enforce effective constraints at each level of the hierarchy which are a restriction of the group requests considering its parent's effective constraints. Root group effective constraints are defined by the system wide interface.
This mechanism allows each (non-root) level of the hierarchy to:
- request whatever clamp values it would like to get
- effectively get only up to the maximum amount allowed by its parent
c) have higher priority than task-specific clamps, defined via sched_setattr(), thus allowing to control and restrict task requests
Add two new attributes to the cpu controller to collect "requested" clamp values. Allow that at each non-root level of the hierarchy. Validate local consistency by enforcing util.min < util.max. Keep it simple by do not caring now about "effective" values computation and propagation along the hierarchy.
---
Changes in v9
Message-ID: <20190507114232.npsvba4itex5qpvl@e110439-lin>
- make alloc_uclamp_sched_group() a void function
Message-ID: <[email protected]>:
- use for_each_clamp_id() and uclamp_se_set() to make code less fragile
--- Documentation/admin-guide/cgroup-v2.rst | 27 +++++ init/Kconfig | 22 ++++ kernel/sched/core.c | 135 +++++++++++++++++++++++- kernel/sched/sched.h | 6 ++ 4 files changed, 189 insertions(+), 1 deletion(-)
Documentation/admin-guide/cgroup-v2.rst +27 -0
@@ -909,6 +909,12 @@ controller implements weight and absolute bandwidth limit models for normal scheduling policy and absolute bandwidth allocation model for realtime scheduling policy. +Cycles distribution is based, by default, on a temporal base and it +does not account for the frequency at which tasks are executed. +The (optional) utilization clamping support allows to enforce a minimum +bandwidth, which should always be provided by a CPU, and a maximum bandwidth, +which should never be exceeded by a CPU. + WARNING: cgroup2 doesn't yet support control of realtime processes and the cpu controller can only be enabled when all RT processes are in the root cgroup. Be aware that system management software may already
@@ -974,6 +980,27 @@ All time durations are in microseconds. Shows pressure stall information for CPU. See Documentation/accounting/psi.txt for details. + cpu.util.min + A read-write single value file which exists on non-root cgroups. + The default is "0", i.e. no utilization boosting. + + The requested minimum utilization in the range [0, 1024]. + + This interface allows reading and setting minimum utilization clamp + values similar to the sched_setattr(2). This minimum utilization + value is used to clamp the task specific minimum utilization clamp. + + cpu.util.max + A read-write single value file which exists on non-root cgroups. + The default is "1024". i.e. no utilization capping + + The requested maximum utilization in the range [0, 1024]. + + This interface allows reading and setting maximum utilization clamp + values similar to the sched_setattr(2). This maximum utilization + value is used to clamp the task specific maximum utilization clamp. + + Memory ------
init/Kconfig +22 -0
@@ -894,6 +894,28 @@ config RT_GROUP_SCHED endif #CGROUP_SCHED +config UCLAMP_TASK_GROUP + bool "Utilization clamping per group of tasks" + depends on CGROUP_SCHED + depends on UCLAMP_TASK + default n + help + This feature enables the scheduler to track the clamped utilization + of each CPU based on RUNNABLE tasks currently scheduled on that CPU. + + When this option is enabled, the user can specify a min and max + CPU bandwidth which is allowed for each single task in a group. + The max bandwidth allows to clamp the maximum frequency a task + can use, while the min bandwidth allows to define a minimum + frequency a task will always use. + + When task group based utilization clamping is enabled, an eventually + specified task-specific clamp value is constrained by the cgroup + specified clamp value. Both minimum and maximum task clamping cannot + be bigger than the corresponding clamping defined at task group level. + + If in doubt, say N. + config CGROUP_PIDS bool "PIDs controller" help
kernel/sched/core.c +134 -1
172 lines not on this page · raw message
kernel/sched/sched.h +6 -0
@@ -399,6 +399,12 @@ struct task_group {#endif struct cfs_bandwidth cfs_bandwidth; + +#ifdef CONFIG_UCLAMP_TASK_GROUP +/* Clamp values requested for a task group */ +struct uclamp_se uclamp_req[UCLAMP_CNT ]; +#endif + };#ifdef CONFIG_FAIR_GROUP_SCHED
Signature · 1 line
2.21.0
Tejun Heo
maintainerRe: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Hello, Patrick.
Quoted 9 lines · Patrick Bellasi
Extend the CPU controller with a couple of new attributes util.{min,max} which allows to enforce utilization boosting and capping for all the tasks in a group. Specifically:
- util.min: defines the minimum utilization which should be considered i.e. the RUNNABLE tasks of this group will run at least at a minimum frequency which corresponds to the util.min utilization
Quoted 4 lines
- util.max: defines the maximum utilization which should be considered i.e. the RUNNABLE tasks of this group will run up to a maximum frequency which corresponds to the util.max utilization
Let's please use a prefix which is more specific. It's clamping the utilization estimates of the member tasks which in turn affect scheduling / frequency decisions but cpu.util.max reads like it's gonna limit the cpu utilization directly. Maybe just use uclamp?
Quoted 6 lines
These attributes:
a) are available only for non-root nodes, both on default and legacy hierarchies, while system wide clamps are defined by a generic interface which does not depends on cgroups. This system wide interface enforces constraints on tasks in the root node.
I'd much prefer if they weren't entangled this way. The system wide limits should work the same regardless of cgroup's existence. cgroup can put further restriction on top but mere creation of cgroups with cpu controller enabled shouldn't take them out of the system-wide limits.
Quoted 7 lines
b) enforce effective constraints at each level of the hierarchy which are a restriction of the group requests considering its parent's effective constraints. Root group effective constraints are defined by the system wide interface.
This mechanism allows each (non-root) level of the hierarchy to:
- request whatever clamp values it would like to get
- effectively get only up to the maximum amount allowed by its parent
I'll come back to this later.
Quoted 2 lines
c) have higher priority than task-specific clamps, defined via
sched_setattr(), thus allowing to control and restrict task requests
This sounds good.
Quoted 5 lines
Add two new attributes to the cpu controller to collect "requested" clamp values. Allow that at each non-root level of the hierarchy. Validate local consistency by enforcing util.min < util.max. Keep it simple by do not caring now about "effective" values computation and propagation along the hierarchy.
So, the followings are what we're doing for hierarchical protection and limit propgations.
* Limits (high / max) default to max. Protections (low / min) 0. A new cgroup by default doesn't constrain itself further and doesn't have any protection.
* A limit defines the upper ceiling for the subtree. If an ancestor has a limit of X, none of its descendants can have more than X.
* A protection defines the upper ceiling of protections for the subtree. If an andester has a protection of X, none of its descendants can have more protection than X.
Note that there's no way for an ancestor to enforce protection its descendants. It can only allow them to claim some. This is intentional as the other end of the spectrum is either descendants losing the ability to further distribute protections as they see fit.
For proportions (as opposed to weights), we use percentage rational numbers - e.g. 38.44 for 38.44%. I have parser and doc update commits pending. I'll put them on cgroup/for-5.3.
Thanks.
Signature · 1 line
tejun
Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Quoted 1 line · Tejun Heo
Hello, Patrick.
Hi Tejun!
Quoted 15 lines · Patrick Bellasi
Quoted 9 lines
Extend the CPU controller with a couple of new attributes util.{min,max} which allows to enforce utilization boosting and capping for all the tasks in a group. Specifically:
- util.min: defines the minimum utilization which should be considered i.e. the RUNNABLE tasks of this group will run at least at a minimum frequency which corresponds to the util.min utilization
Quoted 4 lines
- util.max: defines the maximum utilization which should be considered i.e. the RUNNABLE tasks of this group will run up to a maximum frequency which corresponds to the util.max utilization
Quoted 4 lines
Let's please use a prefix which is more specific. It's clamping the utilization estimates of the member tasks which in turn affect scheduling / frequency decisions but cpu.util.max reads like it's gonna limit the cpu utilization directly. Maybe just use uclamp?
Being too specific does not risk to expose implementation details?
If that's not a problem and Peter likes:
cpu.uclamp.{min,max}
that's ok with me.
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi
Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
In reply to Tejun HeoOn 31-May 08:35, Tejun Heo wrote:
[...]
Quoted 7 lines
Quoted 6 lines
These attributes:
a) are available only for non-root nodes, both on default and legacy hierarchies, while system wide clamps are defined by a generic interface which does not depends on cgroups. This system wide interface enforces constraints on tasks in the root node.
Quoted 5 lines
I'd much prefer if they weren't entangled this way. The system wide limits should work the same regardless of cgroup's existence. cgroup can put further restriction on top but mere creation of cgroups with cpu controller enabled shouldn't take them out of the system-wide limits.
That's correct and what you describe matches, at least on its intents, the current implementation provided in:
[PATCH v9 14/16] sched/core: uclamp: Propagate system defaults to root group
https://lore.kernel.org/lkml/[email protected]/
System clamps always work the same way, independently from cgroups:
they define the upper bound for both min and max clamps.
When cgroups are not available, tasks specific clamps are always capped by system clamps.
When cgroups are available, the root task group clamps are capped by the system clamps, which affects its "effective" clamps and propagate them down the hierarchy to child's "effective" clamps. That's done in:
[PATCH v9 13/16] sched/core: uclamp: Propagate parent clamps
https://lore.kernel.org/lkml/[email protected]/
Example 1
---------
Here is an example of system and groups clamps aggregation:
min max
system defaults 400 600
cg_name min min.effective max max.effective /uclamp 1024 400 500 500 /uclamp/app 512 400 512 500 /uclamp/app/pid_smalls 100 100 200 200 /uclamp/app/pid_bigs 500 400 700 500
The ".effective" clamps are used to define the actual clamp value to apply to tasks, according to the aggregation rules defined in:
[PATCH v9 15/16] sched/core: uclamp: Use TG's clamps to restrict TASK's clamps
https://lore.kernel.org/lkml/[email protected]/
All the above, to me it means that:
- cgroups are always capped by system clamps
- cgroups can further restrict system clamps
Does that match with your view?
Quoted 21 lines
Quoted 7 lines
b) enforce effective constraints at each level of the hierarchy which are a restriction of the group requests considering its parent's effective constraints. Root group effective constraints are defined by the system wide interface.
This mechanism allows each (non-root) level of the hierarchy to:
- request whatever clamp values it would like to get
- effectively get only up to the maximum amount allowed by its parentI'll come back to this later.
Quoted 2 lines
c) have higher priority than task-specific clamps, defined via
sched_setattr(), thus allowing to control and restrict task requestsThis sounds good.
Quoted 5 lines
Add two new attributes to the cpu controller to collect "requested" clamp values. Allow that at each non-root level of the hierarchy. Validate local consistency by enforcing util.min < util.max. Keep it simple by do not caring now about "effective" values computation and propagation along the hierarchy.
Quoted 6 lines
So, the followings are what we're doing for hierarchical protection and limit propgations.
* Limits (high / max) default to max. Protections (low / min) 0. A new cgroup by default doesn't constrain itself further and doesn't have any protection.
Example 2
---------
Let say we have:
/tg1:
util_min=200 (as a protection)
util_max=800 (as a limit)
the moment we create a subgroup /tg1/tg11, in v9 it is initialized with the same limits _and protections_ of its father:
/tg1/tg11:
util_min=200 (protection inherited from /tg1) util_max=800 (limit inherited from /tg1)
Do you mean that we should have instead:
/tg1/tg11:
util_min=0 (no protection by default at creation time)
util_max=800 (limit inherited from /tg1)
i.e. we need to reset the protection of a newly created subgroup?
Quoted 2 lines
* A limit defines the upper ceiling for the subtree. If an ancestor has a limit of X, none of its descendants can have more than X.
That's correct, however we distinguish between "requested" and "effective" values.
Example 3
---------
We can have:
cg_name max max.effective
/uclamp/app 400 400
/uclamp/app/pid_bigs 500 400
Which means that a subgroup can "request" a limit (max=500) higher then its father (max=400), while still getting only up to what its father allows (max.effective = 400).
Example 4
---------
Tracking the actual requested limit (max=500) it's useful to enforce it once the father limit should be relaxed, for example we will have:
cg_name max max.effective
/uclamp/app 600 600
/uclamp/app/pid_bigs 500 500
where a subgroup gets not more than what it has been configured for.
This is the logic implemented by cpu_util_update_eff() in:
[PATCH v9 13/16] sched/core: uclamp: Propagate parent clamps
https://lore.kernel.org/lkml/[email protected]/
Quoted 3 lines
* A protection defines the upper ceiling of protections for the subtree. If an andester has a protection of X, none of its descendants can have more protection than X.
Right, that's the current behavior in v9.
Quoted 4 lines
Note that there's no way for an ancestor to enforce protection its descendants. It can only allow them to claim some. This is intentional as the other end of the spectrum is either descendants losing the ability to further distribute protections as they see fit.
Ok, that means I need to update in v10 the initialization of subgroups min clamps to be none by default as discussed in the above Example 2, right?
[...]
Cheers,
Patrick
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi
Tejun Heo
maintainerRe: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Hello,
Quoted 5 lines · Patrick Bellasi
All the above, to me it means that:
- cgroups are always capped by system clamps
- cgroups can further restrict system clampsDoes that match with your view?
Yeah, as long as what's defined at system level clamps everything in the system whether they're in cgroups or not, it's all good.
Quoted 20 lines
Quoted 3 lines
* Limits (high / max) default to max. Protections (low / min) 0. A new cgroup by default doesn't constrain itself further and doesn't have any protection.
Example 2
---------Let say we have:
/tg1:
util_min=200 (as a protection)
util_max=800 (as a limit)the moment we create a subgroup /tg1/tg11, in v9 it is initialized with the same limits
_andprotections_of its father:/tg1/tg11:
util_min=200 (protection inherited from /tg1) util_max=800 (limit inherited from /tg1)
Quoted 8 lines
Do you mean that we should have instead:
/tg1/tg11:
util_min=0 (no protection by default at creation time)
util_max=800 (limit inherited from /tg1)i.e. we need to reset the protection of a newly created subgroup?
The default value for limits should be max, protections 0. Don't inherit config values from the parent. That gets confusing super fast because when the parent config is set and each child is created plays into the overall configuration. Hierarchical confinements should always be enforced and a new cgroup should always start afresh in terms of its own configuration.
Quoted 5 lines
Quoted 2 lines
* A limit defines the upper ceiling for the subtree. If an ancestor has a limit of X, none of its descendants can have more than X.
That's correct, however we distinguish between "requested" and "effective" values.
Sure, all property propagating controllers should.
Quoted 8 lines
Quoted 4 lines
Note that there's no way for an ancestor to enforce protection its descendants. It can only allow them to claim some. This is intentional as the other end of the spectrum is either descendants losing the ability to further distribute protections as they see fit.
Ok, that means I need to update in v10 the initialization of subgroups min clamps to be none by default as discussed in the above Example 2, right?
Yeah and max to max.
Thanks.
Signature · 1 line
tejun
Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Quoted 1 line · Tejun Heo
Hello,
Hi!
Quoted 9 lines · Patrick Bellasi
Quoted 5 lines
All the above, to me it means that:
- cgroups are always capped by system clamps
- cgroups can further restrict system clampsDoes that match with your view?
Yeah, as long as what's defined at system level clamps everything in the system whether they're in cgroups or not, it's all good.
Right, then we are good with v9 on this point.
Quoted 27 lines
Quoted 27 lines
Quoted 3 lines
* Limits (high / max) default to max. Protections (low / min) 0. A new cgroup by default doesn't constrain itself further and doesn't have any protection.
Example 2
---------Let say we have:
/tg1:
util_min=200 (as a protection)
util_max=800 (as a limit)the moment we create a subgroup /tg1/tg11, in v9 it is initialized with the same limits
_andprotections_of its father:/tg1/tg11:
util_min=200 (protection inherited from /tg1) util_max=800 (limit inherited from /tg1)Do you mean that we should have instead:
/tg1/tg11:
util_min=0 (no protection by default at creation time)
util_max=800 (limit inherited from /tg1)
Quoted 8 lines
Quoted 1 line
i.e. we need to reset the protection of a newly created subgroup?
The default value for limits should be max, protections 0. Don't inherit config values from the parent. That gets confusing super fast because when the parent config is set and each child is created plays into the overall configuration. Hierarchical confinements should always be enforced and a new cgroup should always start afresh in terms of its own configuration.
Got it, so in the example above we will create:
/tg1/tg11:
util_min=0 (no requested protection by default at creation time)
util_max=1024 (no requests limit by default at creation time)
That's it for the "requested" values side, while the "effective" values are enforced by the hierarchical confinement rules since creation time.
Which means we will enforce the effective values as:
/tg1/tg11:
util_min.effective=0
i.e. keep the child protection since smaller than parent
util_max.effective=800
i.e. keep parent limit since stricter than child
Please shout if I got it wrong, otherwise I'll update v10 to implement the above logic.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
* A limit defines the upper ceiling for the subtree. If an ancestor has a limit of X, none of its descendants can have more than X.
That's correct, however we distinguish between "requested" and "effective" values.
Sure, all property propagating controllers should.
Right.
Quoted 10 lines
Quoted 8 lines
Quoted 4 lines
Note that there's no way for an ancestor to enforce protection its descendants. It can only allow them to claim some. This is intentional as the other end of the spectrum is either descendants losing the ability to further distribute protections as they see fit.
Ok, that means I need to update in v10 the initialization of subgroups min clamps to be none by default as discussed in the above Example 2, right?
Yeah and max to max.
Right, I've got it now.
Quoted 1 line
Thanks.
Cheers,
Patrick
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi
Tejun Heo
maintainerRe: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Hello,
Quoted 4 lines · Patrick Bellasi
Which means we will enforce the effective values as:
/tg1/tg11:
Quoted 8 lines
util_min.effective=0
i.e. keep the child protection since smaller than parentutil_max.effective=800
i.e. keep parent limit since stricter than childPlease shout if I got it wrong, otherwise I'll update v10 to implement the above logic.
Everything sounds good to me. Please note that cgroup interface files actually use literal "max" for limit/protection max settings so that 0 and "max" mean the same things for all limit/protection knobs.
Thanks.
Signature · 1 line
tejun
Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Quoted 1 line · Tejun Heo
Hello,
Hi,
Quoted 11 lines · Patrick Bellasi
Quoted 10 lines
Which means we will enforce the effective values as:
/tg1/tg11:
util_min.effective=0
i.e. keep the child protection since smaller than parentutil_max.effective=800
i.e. keep parent limit since stricter than child
Quoted 6 lines
Quoted 2 lines
Please shout if I got it wrong, otherwise I'll update v10 to implement the above logic.
Everything sounds good to me. Please note that cgroup interface files actually use literal "max" for limit/protection max settings so that 0 and "max" mean the same things for all limit/protection knobs.
Lemme see if I've got it right, do you mean that we can:
1) write the _string_ "max" into a cgroup attribute to:
- set 0 for util_max, since it's a protection
- set 1024 for util_min, since it's a limit
2) write the _string_ "0" into a cgroup attribute to:
- set 1024 for util_max, since it's a protection
- set 0 for util_min, since it's a limit
Is that correct or it's just me totally confused?
Quoted 4 lines
Thanks.
--
tejun
Cheers,
Patrick
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi
Tejun Heo
maintainerRe: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Hello, Patrick.
Quoted 11 lines · Patrick Bellasi
Quoted 3 lines
Everything sounds good to me. Please note that cgroup interface files actually use literal "max" for limit/protection max settings so that 0 and "max" mean the same things for all limit/protection knobs.
Lemme see if I've got it right, do you mean that we can:
1) write the _string_ "max" into a cgroup attribute to:
- set 0 for
util_max, since it's a protection
- set 1024 forutil_min, since it's a limit
Quoted 6 lines
2) write the _string_ "0" into a cgroup attribute to:
- set 1024 for
util_max, since it's a protection
- set 0 forutil_min, since it's a limitIs that correct or it's just me totally confused?
Heh, sorry about not being clearer. "max" just means numerically highest possible config for the config knob, so in your case, "max" would always map to 1024.
Thanks.
Signature · 1 line
tejun
Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
In reply to Tejun HeoQuoted 3 lines · Tejun Heo
Hello, Patrick.
On Wed, May 15, 2019 at 10:44:55AM +0100, Patrick Bellasi wrote:
[...]
Quoted 3 lines
For proportions (as opposed to weights), we use percentage rational numbers - e.g. 38.44 for 38.44%. I have parser and doc update commits pending. I'll put them on cgroup/for-5.3.
That's a point worth discussing with Peter, we already changed one time from percentages to 1024 scale.
Utilization clamps are expressed as percentages by definition, they are just expressed in a convenient 1024 scale which should not be alien to people using those knobs.
If we wanna use a "more specific" name like uclamp.{min,max} then we should probably also accept to use a "more specific" metric, don't we?
I personally like the [0..1024] range, but I guess that's really up to you and Peter to agree upon.
Quoted 4 lines
Thanks.
--
tejun
Cheers,
Patrick
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi
Tejun Heo
maintainerRe: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Hello,
Quoted 5 lines · Patrick Bellasi
Quoted 3 lines · Tejun Heo
Hello, Patrick.
On Wed, May 15, 2019 at 10:44:55AM +0100, Patrick Bellasi wrote:
Quoted 8 lines
[...]
Quoted 3 lines
For proportions (as opposed to weights), we use percentage rational numbers - e.g. 38.44 for 38.44%. I have parser and doc update commits pending. I'll put them on cgroup/for-5.3.
That's a point worth discussing with Peter, we already changed one time from percentages to 1024 scale.
cgroup tries to uss uniform units for its interface files as much as possible even when that deviates from non-cgroup interface. We can bikeshed the pros and cons for that design choice for sure but I don't think it makes sense to deviate from that at this point unless there are really strong reasons to do so.
Quoted 6 lines
Utilization clamps are expressed as percentages by definition, they are just expressed in a convenient 1024 scale which should not be alien to people using those knobs.
If we wanna use a "more specific" name like uclamp.{min,max} then we should probably also accept to use a "more specific" metric, don't we?
Heh, this actually made me chuckle. It's an interesting bargaining take but I don't think that same word being in two different places makes them tradable entities. We can go into the weeds with the semantics but how about us using an alternative adjective "misleading" for the cpu.util.min/max names to short-circuit that?
Thanks.
Signature · 1 line
tejun
Re: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Quoted 1 line · Tejun Heo
Hello,
Hi,
Quoted 12 lines · Patrick Bellasi
Quoted 11 lines · Tejun Heo
Quoted 3 lines
Hello, Patrick.
On Wed, May 15, 2019 at 10:44:55AM +0100, Patrick Bellasi wrote:
[...]
Quoted 3 lines
For proportions (as opposed to weights), we use percentage rational numbers - e.g. 38.44 for 38.44%. I have parser and doc update commits pending. I'll put them on cgroup/for-5.3.
Quoted 8 lines
Quoted 2 lines
That's a point worth discussing with Peter, we already changed one time from percentages to 1024 scale.
cgroup tries to uss uniform units for its interface files as much as possible even when that deviates from non-cgroup interface. We can bikeshed the pros and cons for that design choice for sure but I don't think it makes sense to deviate from that at this point unless there are really strong reasons to do so.
that makes sense to me, having a uniform interface has certainly a value.
The only additional point I can think about as a (slightly) stronger reason is that I guess we would like to have the same API for cgroups as well as for the task specific and the system wide settings.
The task specific values comes in via the sched_setattr() syscall:
[PATCH v9 06/16] sched/core: uclamp: Extend sched_setattr() to support utilization clamping
https://lore.kernel.org/lkml/[email protected]/
where we need to encode each clamp into a __u32 value.
System wide settings are expose similarly to these:
grep '' /proc/sys/kernel/sched_*
where we have always integer numbers.
AFAIU your proposal will require to use a "scaled percentage" - e.g. 3844 for 38.44% which however it's still not quite the same as writing the string "38.44".
Not sure that's a strong enough argument, is it?
Quoted 8 lines
Quoted 6 lines
Utilization clamps are expressed as percentages by definition, they are just expressed in a convenient 1024 scale which should not be alien to people using those knobs.
If we wanna use a "more specific" name like uclamp.{min,max} then we should probably also accept to use a "more specific" metric, don't we?
Heh, this actually made me chuckle.
:)
Quoted 2 lines
It's an interesting bargaining take but I don't think that same word being in two different places makes them tradable entities.
Sure, that was not my intention.
I was just trying to see if the need to be more specific could be an argument for having also a more specific value.
Quoted 3 lines
We can go into the weeds with the semantics but how about us using an alternative adjective "misleading" for the cpu.util.min/max names to short-circuit that?
Not quite sure to get what you mean here. Are you pointing out that with clamps we don't strictly enforce a bandwidth but we just set a bias?
Cheers,
Patrick
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi
Tejun Heo
maintainerRe: [PATCH v9 12/16] sched/core: uclamp: Extend CPU's cgroup controller
Hello, Patrick.
Quoted 15 lines · Patrick Bellasi
The only additional point I can think about as a (slightly) stronger reason is that I guess we would like to have the same API for cgroups as well as for the task specific and the system wide settings.
The task specific values comes in via the
sched_setattr()syscall:[PATCH v9 06/16] sched/core: uclamp: Extend
sched_setattr()to support utilization clamping
https://lore.kernel.org/lkml/[email protected]/where we need to encode each clamp into a
__u32value.System wide settings are expose similarly to these:
grep ''
/proc/sys/kernel/sched_*
Quoted 7 lines
where we have always integer numbers.
AFAIU your proposal will require to use a "scaled percentage" - e.g. 3844 for 38.44% which however it's still not quite the same as writing the string "38.44".
Not sure that's a strong enough argument, is it?
It definitely is an argument but the thing is that the units we use in kernel API are all over the place anyway. Even for something as simple as sizes, we use bytes, 512 byte sectors, kilobytes and pages all over the place. Some for good reasons (as you mentioned above) and others for historical / random ones.
So, I'm generally not too concerned about units differing between cgroup interface and, say, syscall interface. That ship has sailed a long while ago and we have to deal with it everywhere anyway (in many cases there isn't even a good unit to pick for compatibility because the existing interfaces are already mixing units heavily). As long as the translation is trivial, it isn't a big issue. Note that some translations are not trivial. For example, the sched nice value mapping to weight has a separate unit matching knob for that reason.
Quoted 7 lines
Quoted 3 lines
We can go into the weeds with the semantics but how about us using an alternative adjective "misleading" for the cpu.util.min/max names to short-circuit that?
Not quite sure to get what you mean here. Are you pointing out that with clamps we don't strictly enforce a bandwidth but we just set a bias?
It's just that "util" is already used a lot and cpu.util.max reads like it should cap cpu utilization (wallclock based) to 80% and it's likely that it'd read seem way to many other folks too. A more distinctive name signals that it isn't something that obvious.
Thanks.
Signature · 1 line
tejun
PATCH v9 13/16 sched/core: uclamp: Propagate parent clamps
In reply to Patrick BellasiIn order to properly support hierarchical resources control, the cgroup delegation model requires that attribute writes from a child group never fail but still are (potentially) constrained based on parent's assigned resources. This requires to properly propagate and aggregate parent attributes down to its descendants.
Let's implement this mechanism by adding a new "effective" clamp value for each task group. The effective clamp value is defined as the smaller value between the clamp value of a group and the effective clamp value of its parent. This is the actual clamp value enforced on tasks in a task group.
Since it can be interesting for userspace, e.g. system management software, to know exactly what the currently propagated/enforced configuration is, the effective clamp values are exposed to user-space by means of a new pair of read-only attributes cpu.util.{min,max}.effective.
--- Documentation/admin-guide/cgroup-v2.rst | 19 +++++ kernel/sched/core.c | 108 ++++++++++++++++++++++-- kernel/sched/sched.h | 2 + 3 files changed, 124 insertions(+), 5 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +19 -0
@@ -990,6 +990,16 @@ All time durations are in microseconds. values similar to the sched_setattr(2). This minimum utilization value is used to clamp the task specific minimum utilization clamp. + cpu.util.min.effective + A read-only single value file which exists on non-root cgroups and + reports minimum utilization clamp value currently enforced on a task + group. + + The actual minimum utilization in the range [0, 1024]. + + This value can be lower then cpu.util.min in case a parent cgroup + allows only smaller minimum utilization values. + cpu.util.max A read-write single value file which exists on non-root cgroups. The default is "1024". i.e. no utilization capping
@@ -1000,6 +1010,15 @@ All time durations are in microseconds. values similar to the sched_setattr(2). This maximum utilization value is used to clamp the task specific maximum utilization clamp. + cpu.util.max.effective + A read-only single value file which exists on non-root cgroups and + reports maximum utilization clamp value currently enforced on a task + group. + + The actual maximum utilization in the range [0, 1024]. + + This value can be lower then cpu.util.max in case a parent cgroup + is enforcing a more restrictive clamping on max utilization. Memory
kernel/sched/core.c +103 -5
212 lines not on this page · raw message
kernel/sched/sched.h +2 -0
@@ -403,6 +403,8 @@ struct task_group {#ifdef CONFIG_UCLAMP_TASK_GROUP /* Clamp values requested for a task group */ struct uclamp_se uclamp_req[UCLAMP_CNT ]; +/* Effective clamp values used for a task group */ +struct uclamp_se uclamp[UCLAMP_CNT ];#endif };
Signature · 1 line
2.21.0
PATCH v9 14/16 sched/core: uclamp: Propagate system defaults to root group
In reply to Patrick BellasiThe clamp values are not tunable at the level of the root task group. That's for two main reasons:
- the root group represents "system resources" which are always entirely available from the cgroup standpoint.
- when tuning/restricting "system resources" makes sense, tuning must be done using a system wide API which should also be available when control groups are not.
When a system wide restriction is available, cgroups should be aware of its value in order to know exactly how much "system resources" are available for the subgroups.
Utilization clamping supports already the concepts of:
- system defaults: which define the maximum possible clamp values usable by tasks.
- effective clamps: which allows a parent cgroup to constraint (maybe temporarily) its descendants without losing the information related to the values "requested" from them.
Exploit these two concepts and bind them together in such a way that, whenever system default are tuned, the new values are propagated to (possibly) restrict or relax the "effective" value of nested cgroups.
--- kernel/sched/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
kernel/sched/core.c +10 -0
@@ -1005,6 +1005,13 @@ static inline void uclamp_rq_dec(struct rq *rq, struct task_struct *p)uclamp_rq_dec_id (rq, p, clamp_id); } +#ifdef CONFIG_UCLAMP_TASK_GROUP +static void cpu_util_update_eff (struct cgroup_subsys_state *css, +unsigned int clamp_id); +#else +#define cpu_util_update_eff (...) +#endif +int sysctl_sched_uclamp_handler (struct ctl_table *table,int write,void __user *buffer,size_t *lenp,loff_t *ppos)
@@ -1038,6 +1045,9 @@ int sysctl_sched_uclamp_handler(struct ctl_table *table, int write, sysctl_sched_uclamp_util_max, false); } +cpu_util_update_eff (&root_task_group.css,UCLAMP_MIN ); +cpu_util_update_eff (&root_task_group.css,UCLAMP_MAX ); +/* * Updating all the RUNNABLE task is expensive, keep it simple and do * just a lazy update at each next enqueue time.
Signature · 1 line
2.21.0
PATCH v9 15/16 sched/core: uclamp: Use TG's clamps to restrict TASK's clamps
In reply to Patrick BellasiWhen a task specific clamp value is configured via sched_setattr(2), this value is accounted in the corresponding clamp bucket every time the task is {en,de}qeued. However, when cgroups are also in use, the task specific clamp values could be restricted by the task_group (TG) clamp values.
Update uclamp_cpu_inc() to aggregate task and TG clamp values. Every time a task is enqueued, it's accounted in the clamp_bucket defining the smaller clamp between the task specific value and its TG effective value. This allows to:
1. ensure cgroup clamps are always used to restrict task specific requests, i.e. boosted only up to the effective granted value or clamped at least to a certain value
2. implement a "nice-like" policy, where tasks are still allowed to request less then what enforced by their current TG
This mimics what already happens for a task's CPU affinity mask when the task is also in a cpuset, i.e. cgroup attributes are always used to restrict per-task attributes.
Do this by exploiting the concept of "effective" clamp, which is already used by a TG to track parent enforced restrictions.
Apply task group clamp restrictions only to tasks belonging to a child group. While, for tasks in the root group or in an autogroup, only system defaults are enforced.
--- kernel/sched/core.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
kernel/sched/core.c +27 -1
@@ -861,16 +861,42 @@ unsigned int uclamp_rq_max_value(struct rq *rq, unsigned int clamp_id,return uclamp_idle_value (rq, clamp_id, clamp_value); } +static inline struct uclamp_se +uclamp_tg_restrict (struct task_struct *p,unsigned int clamp_id) +{ +struct uclamp_se uc_req = p->uclamp_req[clamp_id]; +#ifdef CONFIG_UCLAMP_TASK_GROUP +struct uclamp_se uc_max; + +/* +* Tasks in autogroups or root task group will be +* restricted by system defaults. +*/ +if (task_group_is_autogroup (task_group (p))) +return uc_req; +if (task_group (p) == &root_task_group) +return uc_req; + + uc_max =task_group (p)->uclamp[clamp_id]; +if (uc_req.value > uc_max.value || !uc_req.user_defined) +return uc_max; +#endif + +return uc_req; +} +/* * The effective clamp bucket index of a task depends on, by increasing * priority: * - the task specific clamp value, when explicitly requested from userspace +* - the task group effective clamp value, for tasks not either in the root +* group or in an autogroup * - the system default clamp value, defined by the sysadmin */ static inline struct uclamp_se uclamp_eff_get (struct task_struct *p,unsigned int clamp_id) { -struct uclamp_se uc_req = p->uclamp_req[clamp_id]; +struct uclamp_se uc_req =uclamp_tg_restrict (p, clamp_id);struct uclamp_se uc_max = uclamp_default[clamp_id];/* System default restrictions always apply */
Signature · 1 line
2.21.0
PATCH v9 16/16 sched/core: uclamp: Update CPU's refcount on TG's clamp changes
In reply to Patrick BellasiOn updates of task group (TG) clamp values, ensure that these new values are enforced on all RUNNABLE tasks of the task group, i.e. all RUNNABLE tasks are immediately boosted and/or clamped as requested.
Do that by slightly refactoring uclamp_bucket_inc(). An additional parameter *cgroup_subsys_state (css) is used to walk the list of tasks in the TGs and update the RUNNABLE ones. Do that by taking the rq lock for each task, the same mechanism used for cpu affinity masks updates.
--- kernel/sched/core.c | 48 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+)
kernel/sched/core.c +48 -0
@@ -1031,6 +1031,51 @@ static inline void uclamp_rq_dec(struct rq *rq, struct task_struct *p)uclamp_rq_dec_id (rq, p, clamp_id); } +static inline void +uclamp_update_active (struct task_struct *p,unsigned int clamp_id) +{ +struct rq_flags rf; +struct rq *rq; + +/* +* Lock the task and the rq where the task is (or was) queued. +* +* We might lock the (previous) rq of a !RUNNABLE task, but that's the +* price to pay to safely serialize util_{min,max} updates with +* enqueues, dequeues and migration operations. +* This is the same locking schema used by __set_cpus_allowed_ptr(). +*/ + rq =task_rq_lock (p, &rf); + +/* +* Setting the clamp bucket is serialized by task_rq_lock(). +* If the task is not yet RUNNABLE and its task_struct is not +* affecting a valid clamp bucket, the next time it's enqueued, +* it will already see the updated clamp bucket value. +*/ +if (!p->uclamp[clamp_id].active) + goto done; + +uclamp_rq_dec_id (rq, p, clamp_id); +uclamp_rq_inc_id (rq, p, clamp_id); + +done: + +task_rq_unlock (rq, p, &rf); +} + +static inline void +uclamp_update_active_tasks (struct cgroup_subsys_state *css,int clamp_id) +{ +struct css_task_iter it; +struct task_struct *p; + +css_task_iter_start (css,0 , &it); +while ((p =css_task_iter_next (&it))) +uclamp_update_active (p, clamp_id); +css_task_iter_end (&it); +} +#ifdef CONFIG_UCLAMP_TASK_GROUP static void cpu_util_update_eff (struct cgroup_subsys_state *css,unsigned int clamp_id);
@@ -7044,6 +7089,9 @@ static void cpu_util_update_eff(struct cgroup_subsys_state *css, uc_se->value = value; uc_se->bucket_id =uclamp_bucket_id (value); + +/* Immediately update descendants RUNNABLE tasks */ +uclamp_update_active_tasks (css, clamp_id); } }
Signature · 1 line
2.21.0
Hi Tejun,
this is just a gentle ping.
I had a chance to speak with Peter and Rafael at the last OSPM and they both seems to be reasonably happy with the current status of the core bits.
Thus, it would be very useful if you can jump into the discussion and start the review of the cgroups integration bits.
You can find them in the last 5 patches of this series.
Luckily on the CGroup side, we don't start from ground zero. Many aspects and pain points have been already discussed in the past and have been addressed by the current version.
For you benefit, here is a list of previously discussed items:
- A child can never obtain more than its ancestors
https://lore.kernel.org/lkml/[email protected]/
- Enforcing consistency rules among parent-child groups
https://lore.kernel.org/lkml/[email protected]/
- Use "effective" attributes to enforce restrictions:
https://lore.kernel.org/lkml/[email protected]
https://lore.kernel.org/lkml/[email protected]
- Tasks on a subgroup can only be more boosted and/or capped, i.e. parent always set an upper bound on both max and min clamps
https://lore.kernel.org/lkml/[email protected]
https://lore.kernel.org/lkml/[email protected]
- Put everything at system level outside of the cgroup interface, i.e. no root group tunable attributes
https://lore.kernel.org/lkml/[email protected]/
- CGroups don't need any hierarchical behaviors on their own
https://lore.kernel.org/lkml/[email protected]/
Looking forward to get some more feedbacks from you.
Cheers,
Patrick
Quoted 183 lines · Patrick Bellasi
Hi all, this is a respin of:
https://lore.kernel.org/lkml/[email protected]/
which includes the following main changes:
- fix "max local update" by moving into
uclamp_rq_inc_id()
- usefor_each_clamp_id()anduclamp_se_set()to make code less fragile
- rename sysfs node: s/sched_uclamp_util_{min,max}/sched_util_clamp_{min,max}/
- removed not useduclamp_eff_bucket_id()
- moveuclamp_bucket_base_value()definition into patch using it
- get rid of not necessarySCHED_POLICY_MAXdefine
- updatesched_setattr()syscall to just force the current policy onSCHED_FLAG_KEEP_POLICY
- return EOPNOTSUPP fromuclamp_validate()on !CONFIG_UCLAMP_TASK
- makealloc_uclamp_sched_group()a void function
- simplifybits_per()definition
- add rq's lockdep assert to uclamp_rq_{inc,dec}_id()With the above, I think we captured all the major inputs from Peter [1]. Thus, this v9 is likely the right version to unlock Tejun's review [2] on the remaining cgroup related bits, i.e. patches [12-16].
Cheers Patrick
Series Organization
===================The series is organized into these main sections:
- Patches [01-07]: Per task (primary) API
- Patches [08-09]: Schedutil integration for FAIR and RT tasks
- Patches [10-11]: Integration with EAS'senergy_compute()
- Patches [12-16]: Per task group (secondary) APIIt is based on today's tip/sched/core and the full tree is available here:
git://linux-arm.org/linux-pb.gitlkml/utilclamp_v9
http://www.linux-arm.org/git?p=linux-pb.git;a=shortlog;h=refs/heads/lkml/utilclamp_v9Newcomer's Short Abstract
=========================The Linux scheduler tracks a "utilization" signal for each scheduling entity (SE), e.g. tasks, to know how much CPU time they use. This signal allows the scheduler to know how "big" a task is and, in principle, it can support advanced task placement strategies by selecting the best CPU to run a task. Some of these strategies are represented by the Energy Aware Scheduler [3].
When the schedutil cpufreq governor is in use, the utilization signal allows the Linux scheduler to also drive frequency selection. The CPU utilization signal, which represents the aggregated utilization of tasks scheduled on that CPU, is used to select the frequency which best fits the workload generated by the tasks.
The current translation of utilization values into a frequency selection is
simple: we go to max for RT tasks or to the minimum frequency which can accommodate the utilization of DL+FAIR tasks.
However, utilization values by themselves cannot convey the desired power/performance behaviors of each task as intended by user-space. As such they are not ideally suited for task placement decisions.Task placement and frequency selection policies in the kernel can be improved by taking into consideration hints coming from authorized user-space elements, like for example the Android middleware or more generally any "System Management Software" (SMS) framework.
Utilization clamping is a mechanism which allows to "clamp" (i.e. filter) the utilization generated by RT and FAIR tasks within a range defined by user-space. The clamped utilization value can then be used, for example, to enforce a minimum and/or maximum frequency depending on which tasks are active on a CPU.
The main use-cases for utilization clamping are:
- boosting: better interactive response for small tasks which are affecting the user experience.
Consider for example the case of a small control thread for an external accelerator (e.g. GPU, DSP, other devices). Here, from the task utilization the scheduler does not have a complete view of what the task's requirements are and, if it's a small utilization task, it keeps selecting a more energy efficient CPU, with smaller capacity and lower frequency, thus negatively impacting the overall time required to complete task activations.
- capping: increase energy efficiency for background tasks not affecting the user experience.
Since running on a lower capacity CPU at a lower frequency is more energy efficient, when the completion time is not a main goal, then capping the utilization considered for certain (maybe big) tasks can have positive effects, both on energy consumption and thermal headroom. This feature allows also to make RT tasks more energy friendly on mobile systems where running them on high capacity CPUs and at the maximum frequency is not required.
From these two use-cases, it's worth noticing that frequency selection biasing, introduced by patches 9 and 10 of this series, is just one possible usage of utilization clamping. Another compelling extension of utilization clamping is in helping the scheduler in making tasks placement decisions.
Utilization is (also) a task specific property the scheduler uses to know how much CPU bandwidth a task requires, at least as long as there is idle time. Thus, the utilization clamp values, defined either per-task or per-task_group, can represent tasks to the scheduler as being bigger (or smaller) than what they actually are.
Utilization clamping thus enables interesting additional optimizations, for example on asymmetric capacity systems like Arm big.LITTLE and DynamIQ CPUs, where:
- boosting: try to run small/foreground tasks on higher-capacity CPUs to complete them faster despite being less energy efficient.
- capping: try to run big/background tasks on low-capacity CPUs to save power and thermal headroom for more important tasks
This series does not present this additional usage of utilization clamping but it's an integral part of the EAS feature set, where [4] is one of its main components.
Android kernels use SchedTune, a solution similar to utilization clamping, to bias both 'frequency selection' and 'task placement'. This series provides the foundation to add similar features to mainline while focusing, for the time being, just on schedutil integration.
References
==========[1] Message-ID: <[email protected]>
https://lore.kernel.org/lkml/[email protected]/[2] Message-ID: <[email protected]>
https://lore.kernel.org/lkml/[email protected]/[3] Energy Aware Scheduling
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/scheduler/sched-energy.txt?h=v5.1[4] Expressing per-task/per-cgroup performance hints Linux Plumbers Conference 2018
https://linuxplumbersconf.org/event/2/contributions/128/Patrick Bellasi (16):
sched/core: uclamp: Add CPU's clamp buckets refcounting sched/core: uclamp: Add bucket local max tracking sched/core: uclamp: Enforce last task'sUCLAMP_MAXsched/core: uclamp: Add system default clamps sched/core: Allowsched_setattr()to use the current policy sched/core: uclamp: Extendsched_setattr()to support utilization
clamping
sched/core: uclamp: Reset uclamp values onRESET_ON_FORKsched/core: uclamp: Set default clamps for RT tasks sched/cpufreq: uclamp: Add clamps for FAIR and RT tasks sched/core: uclamp: Adduclamp_util_with()
sched/fair: uclamp: Add uclamp support toenergy_compute()sched/core: uclamp: Extend CPU's cgroup controller sched/core: uclamp: Propagate parent clamps sched/core: uclamp: Propagate system defaults to root group sched/core: uclamp: Use TG's clamps to restrict TASK's clamps sched/core: uclamp: Update CPU's refcount on TG's clamp changesDocumentation/admin-guide/cgroup-v2.rst | 46 ++ include/linux/log2.h | 34 ++ include/linux/sched.h | 58 ++ include/linux/sched/sysctl.h | 11 + include/linux/sched/topology.h | 6 - include/uapi/linux/sched.h | 14 +- include/uapi/linux/sched/types.h | 66 ++- init/Kconfig | 75 +++ kernel/sched/core.c | 754 +++++++++++++++++++++++- kernel/sched/cpufreq_schedutil.c | 22 +- kernel/sched/fair.c | 44 +- kernel/sched/rt.c | 4 + kernel/sched/sched.h | 123 +++- kernel/sysctl.c | 16 + 14 files changed, 1229 insertions(+), 44 deletions(-)Signature · 1 line
2.21.0
Signature · 3 lines
#include <best/regards.h> Patrick Bellasi