mt76: mt7603: add debugfs knob to enable/disable edcca

PATCH Superseded Lorenzo Bianconi 3 participants 16 messages May 11, 2019 – May 15, 2019 1 message not in the archive

Subsystems (2)

Arm MediaTek MediaTek MT76 wireless LAN driver

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Lorenzo Bianconi

author maintainer

2019-05-11 16:39 UTC #1 lore raw

PATCH 1/1 mt76: mt7603: add debugfs knob to enable/disable edcca

Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing

Signed-off-by Lorenzo Bianconi <[email protected]>

---
 .../wireless/mediatek/mt76/mt7603/debugfs.c   | 30 +++++++++++++++++++
 .../net/wireless/mediatek/mt76/mt7603/init.c  |  4 ++-
 .../net/wireless/mediatek/mt76/mt7603/main.c  |  3 +-
 .../wireless/mediatek/mt76/mt7603/mt7603.h    |  6 +++-
 4 files changed, 39 insertions(+), 4 deletions(-)

drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c +30 -0

index f8b3b6ab6297..efc1cf5ae870 100644
@@ -40,6 +40,35 @@ mt7603_radio_read(struct seq_file *s, void *data)
 	return 0;
 }
 
+static int
+mt7603_edcca_set(void *data, u64 val)
+{
+	struct mt7603_dev *dev = data;
+
+	mutex_lock(&dev->mt76.mutex);
+
+	dev->ed_monitor_enabled = !!val;
+	dev->ed_monitor = dev->ed_monitor_enabled &&
+			  dev->region == NL80211_DFS_ETSI;
+	mt7603_init_edcca(dev);
+
+	mutex_unlock(&dev->mt76.mutex);
+
+	return 0;
+}
+
+static int
+mt7603_edcca_get(void *data, u64 *val)
+{
+	struct mt7603_dev *dev = data;
+
+	*val = dev->ed_monitor_enabled;
+	return 0;
+}
+
+DEFINE_DEBUGFS_ATTRIBUTE(fops_edcca, mt7603_edcca_get,
+			 mt7603_edcca_set, "%lld\n");
+
 void mt7603_init_debugfs(struct mt7603_dev *dev)
 {
 	struct dentry *dir;

@@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev)
 	if (!dir)
 		return;
 
+	debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca);
 	debugfs_create_u32("reset_test", 0600, dir, &dev->reset_test);
 	debugfs_create_devm_seqfile(dev->mt76.dev, "reset", dir,
 				    mt7603_reset_read);

drivers/net/wireless/mediatek/mt76/mt7603/init.c +3 -1

index 78cdbb70e178..4e269044f8a4 100644
@@ -437,7 +437,9 @@ mt7603_regd_notifier(struct wiphy *wiphy,
 	struct ieee80211_hw *hw = wiphy_to_ieee80211_hw(wiphy);
 	struct mt7603_dev *dev = hw->priv;
 
-	dev->ed_monitor = request->dfs_region == NL80211_DFS_ETSI;
+	dev->region = request->dfs_region;
+	dev->ed_monitor = dev->ed_monitor_enabled &&
+			  dev->region == NL80211_DFS_ETSI;
 }
 
 static int

drivers/net/wireless/mediatek/mt76/mt7603/main.c +1 -2

index 0a0334dc40d5..e931af92af43 100644
@@ -103,8 +103,7 @@ mt7603_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 	mutex_unlock(&dev->mt76.mutex);
 }
 
-static void
-mt7603_init_edcca(struct mt7603_dev *dev)
+void mt7603_init_edcca(struct mt7603_dev *dev)
 {
 	/* Set lower signal level to -65dBm */
 	mt76_rmw_field(dev, MT_RXTD(8), MT_RXTD_8_LOWER_SIGNAL, 0x23);

drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h +5 -1

index fa64bbaab0d2..944dc9a11a15 100644
@@ -117,8 +117,11 @@ struct mt7603_dev {
 	u8 mac_work_count;
 
 	u8 mcu_running;
-	u8 ed_monitor;
 
+	enum nl80211_dfs_regions region;
+
+	u8 ed_monitor_enabled;
+	u8 ed_monitor;
 	s8 ed_trigger;
 	u8 ed_strict_mode;
 	u8 ed_strong_signal;

@@ -241,4 +244,5 @@ void mt7603_update_channel(struct mt76_dev *mdev);
 void mt7603_edcca_set_strict(struct mt7603_dev *dev, bool val);
 void mt7603_cca_stats_reset(struct mt7603_dev *dev);
 
+void mt7603_init_edcca(struct mt7603_dev *dev);
 #endif

Signature · 1 line

2.20.1

Kalle Valo

2019-05-13 04:26 UTC #2 lore raw

Quoted 4 lines · Lorenzo Bianconi

Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>

It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.

drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c void mt7603_init_debugfs(struct mt7603_dev *dev) · line 80

Quoted 5 lines

drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c +1 -0

@@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev)
 	if (!dir)
 		return;
 
+	debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca);

Why 0400 and not 0600?

Signature · 1 line

Kalle Valo

Lorenzo Bianconi

author maintainer

2019-05-13 08:41 UTC #3 lore raw

Quoted 9 lines

Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.

Hi Kalle,

edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.

Quoted 8 lines

drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c void mt7603_init_debugfs(struct mt7603_dev *dev) · line 80
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c +1 -0
@@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev)
 	if (!dir)
 		return;
 
+	debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca);
Why 0400 and not 0600?

yes, right. There is the same issue in mt76x02 code, I will fix both of them. Thx.

Regards,
Lorenzo

Quoted 3 lines

Signature · 2 lines
-- 
Kalle Valo

Stanislaw Gruszka

2019-05-13 09:48 UTC #4 lore raw

Quoted 7 lines · Lorenzo Bianconi

Quoted 7 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>

Quoted 7 lines

Quoted 2 lines
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.

What for it is needed ?

Stanislaw

Stanislaw Gruszka

2019-05-15 09:33 UTC #5 lore raw

Quoted 11 lines · Stanislaw Gruszka

Quoted 10 lines · Lorenzo Bianconi
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.

Quoted 6 lines

Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?

Care to comment why EDCCA is needed at all ?

Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.

Stanislaw

Lorenzo Bianconi

author maintainer

2019-05-15 09:44 UTC #6 lore raw

Quoted 17 lines · Stanislaw Gruszka

Quoted 16 lines · Lorenzo Bianconi
Quoted 14 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.

Quoted 6 lines

Quoted 1 line
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.

already fixed in v2
https://patchwork.kernel.org/patch/10940645/

Lorenzo

Quoted 2 lines

Stanislaw

Stanislaw Gruszka

2019-05-15 09:56 UTC #7 lore raw

Quoted 19 lines · Lorenzo Bianconi

Quoted 19 lines · Stanislaw Gruszka
Quoted 17 lines · Lorenzo Bianconi
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
Quoted 7 lines
Quoted 2 lines
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?

Quoted 7 lines

Quoted 4 lines
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.
already fixed in v2
https://patchwork.kernel.org/patch/10940645/

I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?

Stanislaw

Lorenzo Bianconi

author maintainer

2019-05-15 10:03 UTC #8 lore raw

Quoted 25 lines · Lorenzo Bianconi

Quoted 24 lines
Quoted 23 lines · Stanislaw Gruszka
Quoted 11 lines · Lorenzo Bianconi
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Quoted 6 lines
Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.

Quoted 7 lines

Quoted 2 lines
already fixed in v2
https://patchwork.kernel.org/patch/10940645/
I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?

As I have already written in a previous email, ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row). I guess it is required by ETSI regulatory.
Regarding file permission for mt76x02 debugfs edcca node is a typo.

Lorenzo

Quoted 2 lines

Stanislaw

Stanislaw Gruszka

2019-05-15 10:33 UTC #9 lore raw

Quoted 33 lines · Lorenzo Bianconi

Quoted 25 lines · Lorenzo Bianconi
Quoted 24 lines
Quoted 23 lines · Stanislaw Gruszka
Quoted 11 lines · Lorenzo Bianconi
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Quoted 6 lines
Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.
Quoted 7 lines
Quoted 2 lines
already fixed in v2
https://patchwork.kernel.org/patch/10940645/
I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?

Quoted 4 lines

As I have already written in a previous email, ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row). I guess it is required by ETSI regulatory.

But what is user case for that, i.e. who need this (it wasn't implemented in mt76x2 since you added it on Dec 2018). What will happen if it will be removed?

Quoted 1 line

Regarding file permission for mt76x02 debugfs edcca node is a typo.

Typo or not, effectively disable the feature and show nobody is testing it.

The reason I'm asking is that seems EDCCA is the main reason to implement watchod for mt76x2, it wasn't necessary to have a watchdog as seems devices did not hung before EDCCA was added.

Stanislaw

Lorenzo Bianconi

author maintainer

2019-05-15 12:01 UTC #10 lore raw

Quoted 41 lines · Lorenzo Bianconi

Quoted 33 lines
Quoted 25 lines · Lorenzo Bianconi
Quoted 24 lines
Quoted 23 lines · Stanislaw Gruszka
Quoted 11 lines · Lorenzo Bianconi
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Quoted 6 lines
Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.
Quoted 7 lines
Quoted 2 lines
already fixed in v2
https://patchwork.kernel.org/patch/10940645/
I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?
Quoted 4 lines
As I have already written in a previous email, ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row). I guess it is required by ETSI regulatory.
But what is user case for that, i.e. who need this (it wasn't implemented in mt76x2 since you added it on Dec 2018). What will happen if it will be removed?

Quoted 7 lines

Quoted 1 line
Regarding file permission for mt76x02 debugfs edcca node is a typo.
Typo or not, effectively disable the feature and show nobody is testing it.
The reason I'm asking is that seems EDCCA is the main reason to implement watchod for mt76x2, it wasn't necessary to have a watchdog as seems devices did not hung before EDCCA was added.

IIRC I added the first watchdog implementation to fix tx hangs that occur under heavy load even using FCC regulatory (so when EDCCA processing is disabled)

Regards,
Lorenzo

Quoted 2 lines

Stanislaw

Stanislaw Gruszka

2019-05-15 11:46 UTC #11 lore raw

Quoted 45 lines · Lorenzo Bianconi

Quoted 45 lines · Lorenzo Bianconi
Quoted 33 lines
Quoted 25 lines · Lorenzo Bianconi
Quoted 24 lines
Quoted 23 lines · Stanislaw Gruszka
Quoted 11 lines · Lorenzo Bianconi
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Quoted 6 lines
Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.
Quoted 7 lines
Quoted 2 lines
already fixed in v2
https://patchwork.kernel.org/patch/10940645/
I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?
Quoted 4 lines
As I have already written in a previous email, ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row). I guess it is required by ETSI regulatory.
But what is user case for that, i.e. who need this (it wasn't implemented in mt76x2 since you added it on Dec 2018). What will happen if it will be removed?
Quoted 1 line
Regarding file permission for mt76x02 debugfs edcca node is a typo.
Typo or not, effectively disable the feature and show nobody is testing it.

Quoted 7 lines

Quoted 3 lines
The reason I'm asking is that seems EDCCA is the main reason to implement watchod for mt76x2, it wasn't necessary to have a watchdog as seems devices did not hung before EDCCA was added.
IIRC I added the first watchdog implementation to fix tx hangs that occur under heavy load even using FCC regulatory (so when EDCCA processing is disabled)

There was changes in various registers programming introduced by EDCCA support, even with EDCCA disabled. It's rally not convenient that watchdog and EDCCA are not related, since you added tx hung watchdog 2 weeks after adding EDCCA.

You can look at this report:
https://github.com/openwrt/mt76/issues/246
Before mt76x2e worked without hungs & watchodg. Now, even with EDCCA disabled watchdog and HW restarts are required to fix hungs on runtime.

Stanislaw

Lorenzo Bianconi

author maintainer

2019-05-15 12:07 UTC #12 lore raw

Quoted 59 lines · Lorenzo Bianconi

Quoted 45 lines
Quoted 45 lines · Lorenzo Bianconi
Quoted 33 lines
Quoted 25 lines · Lorenzo Bianconi
Quoted 24 lines
Quoted 23 lines · Stanislaw Gruszka
Quoted 11 lines · Lorenzo Bianconi
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Quoted 6 lines
Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.
Quoted 7 lines
Quoted 2 lines
already fixed in v2
https://patchwork.kernel.org/patch/10940645/
I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?
Quoted 4 lines
As I have already written in a previous email, ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row). I guess it is required by ETSI regulatory.
But what is user case for that, i.e. who need this (it wasn't implemented in mt76x2 since you added it on Dec 2018). What will happen if it will be removed?
Quoted 1 line
Regarding file permission for mt76x02 debugfs edcca node is a typo.
Typo or not, effectively disable the feature and show nobody is testing it.
Quoted 7 lines
Quoted 3 lines
The reason I'm asking is that seems EDCCA is the main reason to implement watchod for mt76x2, it wasn't necessary to have a watchdog as seems devices did not hung before EDCCA was added.
IIRC I added the first watchdog implementation to fix tx hangs that occur under heavy load even using FCC regulatory (so when EDCCA processing is disabled)
There was changes in various registers programming introduced by EDCCA support, even with EDCCA disabled. It's rally not convenient that watchdog and EDCCA are not related, since you added tx hung watchdog 2 weeks after adding EDCCA.

Quoted 4 lines

You can look at this report:
https://github.com/openwrt/mt76/issues/246
Before mt76x2e worked without hungs & watchodg. Now, even with EDCCA disabled watchdog and HW restarts are required to fix hungs on runtime.

Tx hangs occur in very particular conditions (e.g 200Mbps bidirectional traffic) and moreover they do not always occur so I am not convinced they are always EDCCA related and so I am not confident to remove the watchdog

Lorenzo

Quoted 2 lines

Stanislaw

Stanislaw Gruszka

2019-05-15 13:48 UTC #13 lore raw

Quoted 59 lines · Lorenzo Bianconi

Quoted 59 lines · Lorenzo Bianconi
Quoted 45 lines
Quoted 45 lines · Lorenzo Bianconi
Quoted 33 lines
Quoted 25 lines · Lorenzo Bianconi
Quoted 24 lines
Quoted 23 lines · Stanislaw Gruszka
Quoted 11 lines · Lorenzo Bianconi
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Quoted 6 lines
Quoted 4 lines
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
What for it is needed ?
Care to comment why EDCCA is needed at all ?
Taking that debugfs file that enable it is read-only, it looks like feature that nobody needs nor tests.
Quoted 7 lines
Quoted 2 lines
already fixed in v2
https://patchwork.kernel.org/patch/10940645/
I'm aware of this patch and other one for mt76x02. But so far in the sources EDCCA is disabled for mt76x02 without possibility to enable it (and this permission file issue was pointed by Kalle during review, not by someone who want to test EDCCA). So again, what for EDCCA is needed ?
Quoted 4 lines
As I have already written in a previous email, ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row). I guess it is required by ETSI regulatory.
But what is user case for that, i.e. who need this (it wasn't implemented in mt76x2 since you added it on Dec 2018). What will happen if it will be removed?
Quoted 1 line
Regarding file permission for mt76x02 debugfs edcca node is a typo.
Typo or not, effectively disable the feature and show nobody is testing it.
Quoted 7 lines
Quoted 3 lines
The reason I'm asking is that seems EDCCA is the main reason to implement watchod for mt76x2, it wasn't necessary to have a watchdog as seems devices did not hung before EDCCA was added.
IIRC I added the first watchdog implementation to fix tx hangs that occur under heavy load even using FCC regulatory (so when EDCCA processing is disabled)
There was changes in various registers programming introduced by EDCCA support, even with EDCCA disabled. It's rally not convenient that watchdog and EDCCA are not related, since you added tx hung watchdog 2 weeks after adding EDCCA.

Quoted 8 lines

Quoted 4 lines
You can look at this report:
https://github.com/openwrt/mt76/issues/246
Before mt76x2e worked without hungs & watchodg. Now, even with EDCCA disabled watchdog and HW restarts are required to fix hungs on runtime.
Tx hangs occur in very particular conditions (e.g 200Mbps bidirectional traffic) and moreover they do not always occur so I am not convinced they are always EDCCA related and so I am not confident to remove the watchdog

I'm not opting for watchdog removal, but for full EDCCA removal. Apparently nobody cares, if it can be enabled or not.

Stanislaw

Stanislaw Gruszka

2019-05-15 13:59 UTC #14 lore raw

Quoted 5 lines · Stanislaw Gruszka

Quoted 3 lines
Tx hangs occur in very particular conditions (e.g 200Mbps bidirectional traffic) and moreover they do not always occur so I am not convinced they are always EDCCA related and so I am not confident to remove the watchdog
I'm not opting for watchdog removal, but for full EDCCA removal.

On mt76x02, on other chips/firmwares it can work just fine.

Stanislaw

Kalle Valo

2019-05-13 12:37 UTC #15 lore raw

In reply to Lorenzo Bianconi

Quoted 7 lines · Lorenzo Bianconi

Quoted 7 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>

Quoted 7 lines

Quoted 2 lines
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.

A lot of people read commit logs but not everyone (myself included) are familiar with mt76 internals so please try to explain the acronyms and the background of the patch. Also you should explain in the commit log _why_ you are adding the debugfs file, how it helps the user and how to use it.

Signature · 1 line

Kalle Valo

Lorenzo Bianconi

author maintainer

2019-05-13 15:41 UTC #16 lore raw

Quoted 14 lines

Quoted 12 lines · Lorenzo Bianconi
Quoted 9 lines
Quoted 4 lines · Lorenzo Bianconi
Introduce a knob in mt7603 debugfs in order to enable/disable edcca processing
Signed-off-by Lorenzo Bianconi <[email protected]>
It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user.
Hi Kalle,

Quoted 8 lines

Quoted 2 lines
edcca is used for adjusting energy detect based on CCA thresholds. The code was already there so I just reported the acronym.
A lot of people read commit logs but not everyone (myself included) are familiar with mt76 internals so please try to explain the acronyms and the background of the patch. Also you should explain in the commit log _why_ you are adding the debugfs file, how it helps the user and how to use it.

sorry for not been so clear.
ED/CCA is used to control tx power according to the CCA MIB counters (e.g do not transmit if the channel busy time is higher than 90% for given amount of time in a row).
As already done in commit 643749d4a82b ("mt76: mt76x02: disable ED/CCA by default"), this patch adds the possibility to enable/disable the processing according to an entry in the debugfs. The reason behind this patch is ED/CCA caused instability in the past so it could be useful to disable it.

Regards,
Lorenzo

Quoted 3 lines

Signature · 2 lines
-- 
Kalle Valo