Skip to contentSkip to conversation

display: panel: Add KOE tx14d24vm1bpa display support (320x240)

PATCH Superseded Lukasz Majewski 5 participants 27 messages Apr 12, 2018 – May 25, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 display: panel: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +42 -0
new file mode 100644
index 000000000000..be7ac666807b
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
drivers/gpu/drm/panel/panel-simple.c +26 -0
index 62314085b635..45e61af936e0 100644
@@ -1245,6 +1245,29 @@ static const struct panel_desc innolux_zj070na_01p = {
 	},
 };
 
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing kyo_tcg121xglp_timing = {
 	.pixelclock = { 52000000, 65000000, 71000000 },
 	.hactive = { 1024, 1024, 1024 },
@@ -2155,6 +2178,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "kyo,tcg121xglp",
 		.data = &kyo_tcg121xglp,
 	}, {
Signature · 1 line
2.11.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Lukasz Majewski

This commit adds support for KOE's 5.7" display.

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

Hi Rob,

Quoted 11 lines · Lukasz Majewski
Quoted 9 lines

This commit adds support for KOE's 5.7" display.

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

Quoted 2 lines

Gentle ping on this - as I don't know if this patch been applied.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

maintainer
#3 lore raw
Quoted 13 lines · Lukasz Majewski

Hi Rob,

Quoted 11 lines · Lukasz Majewski
Quoted 9 lines

This commit adds support for KOE's 5.7" display.

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

Quoted 4 lines
Quoted 2 lines

Gentle ping on this - as I don't know if this patch been applied.

This should go thru DRM tree via Thierry.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Hi Rob, Thierry

Quoted 15 lines · Lukasz Majewski
Quoted 14 lines

Hi Rob,

Quoted 12 lines · Lukasz Majewski
Quoted 10 lines

This commit adds support for KOE's 5.7" display.

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Gentle ping on this - as I don't know if this patch been applied.

This should go thru DRM tree via Thierry.

Would it be possible to pull this patch along with:
[PATCH v3] display: panel: Add AUO g070vvn01 display support (800x480)

To your -next tree (as we are now with -rc4) ?

Quoted 2 lines

Rob

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#5 lore raw

PATCH RESEND 1/1 display: panel: Add KOE tx14d24vm1bpa display support (320x240)

In reply to Lukasz Majewski

This commit adds support for KOE's 5.7" display.

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +42 -0
new file mode 100644
index 000000000000..be7ac666807b
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
drivers/gpu/drm/panel/panel-simple.c +26 -0
index d9984bdb5bb5..103b43ce7dee 100644
@@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = {
 	},
 };
 
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2204,6 +2227,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {
Signature · 1 line
2.11.0
#7 lore raw
In reply to Lukasz Majewski

Hi Thierry,

Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Best regards,
Łukasz

Quoted 91 lines
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

(quoted diff) +0 -0
@@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x

240) TFT LCD panel +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +9 -0
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is

conntrolled +via PWM signal.

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +30 -0
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index d9984bdb5bb5..103b43ce7dee 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = { },
};

drivers/gpu/drm/panel/panel-simple.c +23 -0
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2235

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2204,6 +2227,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#8 lore raw

Hi,

Quoted 7 lines

Hi Thierry,

Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch?

Quoted 109 lines

Best regards,
Łukasz

Quoted 92 lines
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

(quoted diff) +0 -0
@@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x

240) TFT LCD panel +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +9 -0
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is

conntrolled +via PWM signal.

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +14 -0
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint =

<&lcd_display_out>;

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +16 -0
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index d9984bdb5bb5..103b43ce7dee 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = { },
};

drivers/gpu/drm/panel/panel-simple.c +23 -0
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2235

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2204,6 +2227,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {  

Best regards,

Quoted 7 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#9 lore raw
Quoted 4 lines · Lukasz Majewski

Hi,

Quoted 2 lines

Hi Thierry,

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch?

Please use the proper prefix for the commit subject to increase the chances of this being noticed.

This is also still missing a Reviewed-by or Acked-by from Rob.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw

Hi Thierry,

Quoted 8 lines · Lukasz Majewski
Quoted 7 lines

Hi,

Quoted 5 lines

Hi Thierry,

Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch?

Please use the proper prefix for the commit subject to increase the chances of this being noticed.

Ok. Is there any list of prefixes in the kernel repository, so I could look for them (like get_prefix.py - similar to get_maintainer script)?

I've used "display: panel" prefix, but I should have used "drm/panel"

Quoted 2 lines

This is also still missing a Reviewed-by or Acked-by from Rob.

Rob has already reviewed this patch. I will send v2 with Rob's Reviewed-by tag.

Quoted 2 lines

Thierry

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#11 lore raw
Quoted 13 lines · Lukasz Majewski

Hi Thierry,

Quoted 11 lines · Lukasz Majewski
Quoted 10 lines

Hi,

Quoted 7 lines

Hi Thierry,

Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch?

Please use the proper prefix for the commit subject to increase the chances of this being noticed.

Ok. Is there any list of prefixes in the kernel repository, so I could look for them (like get_prefix.py - similar to get_maintainer script)?

I don't think there is. A good rule of thumb that I use is to go over the git log for the last couple of commits and see if there's a clear pattern. This doesn't work for every subsystem, but drm/panel is very consistent in this regard, on purpose.

Quoted 7 lines

I've used "display: panel" prefix, but I should have used "drm/panel"

Quoted 2 lines

This is also still missing a Reviewed-by or Acked-by from Rob.

Rob has already reviewed this patch. I will send v2 with Rob's Reviewed-by tag.

Okay, I'll apply that v2 then.

Thanks,
Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#12 lore raw

Hi Thierry,

Quoted 20 lines · Lukasz Majewski
Quoted 19 lines

Hi Thierry,

Quoted 16 lines · Lukasz Majewski
Quoted 4 lines

Hi,

Quoted 2 lines

Hi Thierry,

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch?

Please use the proper prefix for the commit subject to increase the chances of this being noticed.

Quoted 8 lines
Quoted 3 lines

Ok. Is there any list of prefixes in the kernel repository, so I could look for them (like get_prefix.py - similar to get_maintainer script)?

I don't think there is. A good rule of thumb that I use is to go over the git log for the last couple of commits and see if there's a clear pattern. This doesn't work for every subsystem, but drm/panel is very consistent in this regard, on purpose.

I see.

Is the DRM/panel tree hosted on git.kernel.org?

The tree maintained by you there seems to be:
kernel/git/thierry.reding/linux-pwm.git

IIRC it is hosted elsewhere. Am I right?

Quoted 10 lines
Quoted 8 lines

I've used "display: panel" prefix, but I should have used "drm/panel"

Quoted 2 lines

This is also still missing a Reviewed-by or Acked-by from Rob.

Rob has already reviewed this patch. I will send v2 with Rob's Reviewed-by tag.

Okay, I'll apply that v2 then.

Thanks.

Quoted 3 lines

Thanks,
Thierry

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#13 lore raw
Quoted 31 lines · Lukasz Majewski

Hi Thierry,

Quoted 20 lines · Lukasz Majewski
Quoted 19 lines

Hi Thierry,

Quoted 16 lines · Lukasz Majewski
Quoted 4 lines

Hi,

Quoted 2 lines

Hi Thierry,

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This commit adds support for KOE's 5.7" display.

Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree?

Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch?

Please use the proper prefix for the commit subject to increase the chances of this being noticed.

Quoted 8 lines
Quoted 3 lines

Ok. Is there any list of prefixes in the kernel repository, so I could look for them (like get_prefix.py - similar to get_maintainer script)?

I don't think there is. A good rule of thumb that I use is to go over the git log for the last couple of commits and see if there's a clear pattern. This doesn't work for every subsystem, but drm/panel is very consistent in this regard, on purpose.

Quoted 8 lines

I see.

Is the DRM/panel tree hosted on git.kernel.org?

The tree maintained by you there seems to be:
kernel/git/thierry.reding/linux-pwm.git

IIRC it is hosted elsewhere. Am I right?

drm/panel is part of drm-misc:

https://cgit.freedesktop.org/drm/drm-misc/

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#14 lore raw

PATCH v2 1/1 display: panel: Add KOE tx14d24vm1bpa display support (320x240)

In reply to Lukasz Majewski

This commit adds support for KOE's 5.7" display.

---
Changes for v2:
- Add Reviewed-by tag

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +42 -0
new file mode 100644
index 000000000000..be7ac666807b
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
drivers/gpu/drm/panel/panel-simple.c +26 -0
index d9984bdb5bb5..103b43ce7dee 100644
@@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = {
 	},
 };
 
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2204,6 +2227,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {
Signature · 1 line
2.11.0
#15 lore raw

Hi Thierry,

Quoted 7 lines

This commit adds support for KOE's 5.7" display.

---
Changes for v2:
- Add Reviewed-by tag

Could you apply this patch to your tree?

Thanks in advance,
Łukasz

Quoted 91 lines
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

(quoted diff) +0 -0
@@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x

240) TFT LCD panel +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +9 -0
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is

conntrolled +via PWM signal.

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +30 -0
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index d9984bdb5bb5..103b43ce7dee 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = { },
};

drivers/gpu/drm/panel/panel-simple.c +23 -0
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2235

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2204,6 +2227,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#16 lore raw

Hi Thierry,

Quoted 11 lines

Hi Thierry,

Quoted 7 lines

This commit adds support for KOE's 5.7" display.

---
Changes for v2:
- Add Reviewed-by tag

Could you apply this patch to your tree?

If I may gentle ping on this patch..... It is quite mature now... :-)

Best regards,
Łukasz

Quoted 111 lines

Thanks in advance,
Łukasz

Quoted 92 lines
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

(quoted diff) +0 -0
@@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x

240) TFT LCD panel +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +9 -0
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is

conntrolled +via PWM signal.

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +14 -0
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint =

<&lcd_display_out>;

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +16 -0
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index d9984bdb5bb5..103b43ce7dee 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = { },
};

drivers/gpu/drm/panel/panel-simple.c +23 -0
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2235

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2204,6 +2227,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {  

Best regards,

Quoted 7 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#17 lore raw

Hi Thierry,

Quoted 12 lines

Hi Thierry,

Quoted 10 lines

Hi Thierry,

Quoted 7 lines

This commit adds support for KOE's 5.7" display.

---
Changes for v2:
- Add Reviewed-by tag

Quoted 3 lines
Quoted 1 line

Could you apply this patch to your tree?

If I may gentle ping on this patch..... It is quite mature now... :-)

If I may gentle ping on this patch...

Thanks in advance,
Łukasz Majewski

Quoted 131 lines

Best regards,
Łukasz

Quoted 113 lines

Thanks in advance,
Łukasz

Quoted 94 lines
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42

++++++++++++++++++++++
drivers/gpu/drm/panel/panel-simple.c | 26
++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b
--- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

(quoted diff) +0 -0
@@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x

240) TFT LCD panel +
+Required properties:

+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the

panel +- power-supply: single regulator to provide the supply voltage +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +4 -0
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is

conntrolled +via PWM signal.

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +5 -0
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based

board +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +8 -0
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint =

<&lcd_display_out>;

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +13 -0
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint =

<&lcd_panel_in>;

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +3 -0
+			};
+		};
+	};
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index d9984bdb5bb5..103b43ce7dee 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = { },
};

drivers/gpu/drm/panel/panel-simple.c +23 -0
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2235

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2204,6 +2227,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {    

Best regards,

Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
[email protected]

Best regards,

Quoted 7 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]

#18 lore raw

PATCH v3 1/2 dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

In reply to Lukasz Majewski

This commit adds documentation entry description for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Changes for v3 :
- New patch

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +42 -0
new file mode 100644
index 000000000000..be7ac666807b
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
Signature · 1 line
2.11.0
#19 lore raw

PATCH v3 2/2 drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

This commit adds support for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

It must have been lost during the development process, so I do resend it now.

Changes for v3 :
- Rebase this patch on top of newest kernel (5.1-rc3):
SHA1: 145f47c7381d43c789cbad55d4dbfd28fc6c46a4
- Split this patch to have separate Documentation entry

---
 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +26 -0
index 9e8218f6a3f2..196c6adf8168 100644
@@ -1549,6 +1549,29 @@ static const struct panel_desc innolux_zj070na_01p = {
 	},
 };
 
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2680,6 +2703,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {
Signature · 1 line
2.11.0
#20 lore raw

Re: [PATCH v3 2/2] drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

Dear All,

Quoted 9 lines

This commit adds support for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Quoted 7 lines

It must have been lost during the development process, so I do resend it now.

Changes for v3 :
- Rebase this patch on top of newest kernel (5.1-rc3):
SHA1: 145f47c7381d43c789cbad55d4dbfd28fc6c46a4
- Split this patch to have separate Documentation entry

Gentle ping on this patch...

Quoted 39 lines
---
 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/panel/panel-simple.c index 9e8218f6a3f2..196c6adf8168 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1549,6 +1549,29 @@ static const struct panel_desc innolux_zj070na_01p = { },
};

drivers/gpu/drm/panel/panel-simple.c +23 -0
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id · line 2711

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -2680,6 +2703,9 @@ static const struct of_device_id
 platform_of_match[] = { .compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]

#21 lore raw

Re: [PATCH v3 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

In reply to Lukasz Majewski

Dear All,

Quoted 11 lines

This commit adds documentation entry description for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Changes for v3 :
- New patch

Gentle ping on this patch...

Quoted 44 lines
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42
++++++++++++++++++++++ 1 file changed, 42 insertions(+)
 create mode 100644

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b --- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

(quoted diff) +0 -0
@@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x

240) TFT LCD panel +

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +9 -0
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is

conntrolled +via PWM signal.

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +20 -0
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+

Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt line 42

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +10 -0
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]

#22 lore raw

PATCH v4 1/2 dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

In reply to Lukasz Majewski

This commit adds documentation entry description for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Changes for v4:
- Rebase on top of newest mainline
SHA1: 5ac94332248ee017964ba368cdda4ce647e3aba7

Changes for v3 :
- New patch

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file +42 -0
new file mode 100644
index 000000000000..be7ac666807b
@@ -0,0 +1,42 @@
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
Signature · 1 line
2.11.0
maintainer Reviewed-by on v4 1/2
#23 lore raw

Re: [PATCH v4 1/2] dt-bindings: display/panel: Add KOE tx14d24vm1bpa display description

Quoted 12 lines · Lukasz Majewski

This commit adds documentation entry description for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

Changes for v4:
- Rebase on top of newest mainline
SHA1: 5ac94332248ee017964ba368cdda4ce647e3aba7

Quoted 7 lines

Changes for v3 :
- New patch

---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
#25 lore raw

PATCH v4 2/2 drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

In reply to Lukasz Majewski

This commit adds support for KOE's 5.7" display.

---
Previous discussion (and Rob's Reviewed-by) about this patch
https://patchwork.kernel.org/patch/10339595/

It must have been lost during the development process, so I do resend it now.

Changes for v4:
- Rebase on top of newest mainline (no functional changes)
SHA1: 5ac94332248ee017964ba368cdda4ce647e3aba7

Changes for v3 :
- Rebase this patch on top of newest kernel (5.1-rc3):
SHA1: 145f47c7381d43c789cbad55d4dbfd28fc6c46a4
- Split this patch to have separate Documentation entry

---
 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +26 -0
index 569be4efd8d1..c3e5900b04fa 100644
@@ -1549,6 +1549,29 @@ static const struct panel_desc innolux_zj070na_01p = {
 	},
 };
 
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.pixelclock = { 39600000, 43200000, 48000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2706,6 +2729,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "koe,tx31d200vm0baa",
 		.data = &koe_tx31d200vm0baa,
 	}, {
Signature · 1 line
2.11.0