Skip to contentSkip to conversation

drm/msm/dpu: Remove duplicate header

PATCH In review Sabyasachi Gupta 2 participants 2 messages May 14, 2019 – May 15, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dpu: Remove duplicate header

Remove dpu_kms.h which is included more than once

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -1
index dbe48e00..d692dee 100644
@@ -16,7 +16,6 @@
 #include "dpu_hw_lm.h"
 #include "dpu_hw_mdss.h"
 #include "dpu_dbg.h"
-#include "dpu_kms.h"
 
 #define LM_OP_MODE                        0x00
 #define LM_OUT_SIZE                       0x04
Signature · 1 line
2.7.4
reviewer
#1 lore raw
Quoted 3 lines · Sabyasachi Gupta

Remove dpu_kms.h which is included more than once

Thanks for your patch, I've applied it to drm-misc-next-fixes.

Note for next time: The patch didn't apply cleanly since dpu_dbg.h has been removed upstream. In future please make sure your patches apply cleanly and at least build against upstream.

Thanks again!

Sean

Quoted 19 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c +0 -1
index dbe48e00..d692dee 100644
@@ -16,7 +16,6 @@
 #include "dpu_hw_lm.h"
 #include "dpu_hw_mdss.h"
 #include "dpu_dbg.h"
-#include "dpu_kms.h"
 
 #define LM_OP_MODE                        0x00
 #define LM_OUT_SIZE                       0x04
Signature · 1 line
2.7.4
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS