Skip to contentSkip to conversation

perf jevents: Remove unused variables

PATCH Applied Zenghui Yu 3 participants 3 messages May 15, 2019 – May 18, 2019 perf events

lore
Share & tools
lore

Zenghui Yu

author
#0 lore raw

PATCH 1/1 perf jevents: Remove unused variables

Fix gcc warning:

pmu-events/jevents.c: In function ‘save_arch_std_events’:
pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]

  struct stat *sb = data;
               ^~
---
 tools/perf/pmu-events/jevents.c | 1 -
 1 file changed, 1 deletion(-)
tools/perf/pmu-events/jevents.c +0 -1
index 68c92bb..92e60fd 100644
@@ -414,7 +414,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
 				char *metric_name, char *metric_group)
 {
 	struct event_struct *es;
-	struct stat *sb = data;
 
 	es = malloc(sizeof(*es));
 	if (!es)
Signature · 1 line
1.8.3.1
#1 lore raw

Em Wed, May 15, 2019 at 11:19:29AM +0000, Zenghui Yu escreveu:

Quoted 1 line

Fix gcc warning:

s/Fix/Address/g

Thanks, applied.

- Arnaldo

Quoted 25 lines

pmu-events/jevents.c: In function ‘save_arch_std_events’:
pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]

  struct stat *sb = data;
               ^~
---
 tools/perf/pmu-events/jevents.c | 1 -
 1 file changed, 1 deletion(-)
tools/perf/pmu-events/jevents.c +0 -1
index 68c92bb..92e60fd 100644
@@ -414,7 +414,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
 				char *metric_name, char *metric_group)
 {
 	struct event_struct *es;
-	struct stat *sb = data;
 
 	es = malloc(sizeof(*es));
 	if (!es)
Signature · 1 line
1.8.3.1
Signature · 1 line
- Arnaldo
#2 lore raw

[tip:perf/core] perf jevents: Remove unused variable

In reply to Zenghui Yu
perf jevents: Remove unused variable
Commit-ID:  8e8f515d567f9ec1d960e9fdb117d39753b7504d
Gitweb:     https://git.kernel.org/tip/8e8f515d567f9ec1d960e9fdb117d39753b7504d
Author:     Zenghui Yu <[email protected]>
AuthorDate: Wed, 15 May 2019 11:19:29 +0000
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 15 May 2019 16:36:49 -0300

perf jevents: Remove unused variable

Address gcc warning:

pmu-events/jevents.c: In function ‘save_arch_std_events’:
pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]

    struct stat *sb = data;
                 ^~
---
 tools/perf/pmu-events/jevents.c | 1 -
 1 file changed, 1 deletion(-)
tools/perf/pmu-events/jevents.c +0 -1
index daaea5003d4a..58f77fd0f59f 100644
@@ -415,7 +415,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
 				char *metric_name, char *metric_group)
 {
 	struct event_struct *es;
-	struct stat *sb = data;
 
 	es = malloc(sizeof(*es));
 	if (!es)