enable syncobj test depending on capability
Subsystems (2)
PATCH 1/1 enable syncobj test depending on capability
Feature is controlled by DRM_CAP_SYNCOBJ_TIMELINE drm capability.
--- include/drm/drm.h | 1 + tests/amdgpu/syncobj_tests.c | 8 ++++++++ 2 files changed, 9 insertions(+)
include/drm/drm.h +1 -0
@@ -643,6 +643,7 @@ struct drm_gem_open {#define DRM_CAP_PAGE_FLIP_TARGET 0x11#define DRM_CAP_CRTC_IN_VBLANK_EVENT 0x12#define DRM_CAP_SYNCOBJ 0x13 +#define DRM_CAP_SYNCOBJ_TIMELINE 0x14/** DRM_IOCTL_GET_CAP ioctl argument type */ struct drm_get_cap {
tests/amdgpu/syncobj_tests.c +8 -0
@@ -22,6 +22,7 @@*/ #include "CUnit/Basic.h" +#include "xf86drm.h" #include "amdgpu_test.h" #include "amdgpu_drm.h"
@@ -36,6 +37,13 @@ static void amdgpu_syncobj_timeline_test(void);CU_BOOL suite_syncobj_timeline_tests_enable (void ) { +int r; +uint64_t cap =0 ; + + r =drmGetCap (drm_amdgpu[0 ],DRM_CAP_SYNCOBJ_TIMELINE , &cap); +if (r || cap ==0 ) +return CU_FALSE ; +return CU_TRUE ; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 16.05.19 um 12:46 schrieb Chunming Zhou:
Quoted 3 lines
Feature is controlled by
DRM_CAP_SYNCOBJ_TIMELINEdrm capability.Signed-off-by Chunming Zhou <[email protected]>
Quoted 33 lines
--- include/drm/drm.h | 1 + tests/amdgpu/syncobj_tests.c | 8 ++++++++ 2 files changed, 9 insertions(+)include/drm/drm.h +1
-0@@ -643,6 +643,7 @@ struct drm_gem_open {#define DRM_CAP_PAGE_FLIP_TARGET 0x11#define DRM_CAP_CRTC_IN_VBLANK_EVENT 0x12#define DRM_CAP_SYNCOBJ 0x13 +#define DRM_CAP_SYNCOBJ_TIMELINE 0x14/** DRM_IOCTL_GET_CAP ioctl argument type */ struct drm_get_cap {tests/amdgpu/syncobj_tests.c +1
-0@@ -22,6 +22,7 @@*/ #include "CUnit/Basic.h" +#include "xf86drm.h" #include "amdgpu_test.h" #include "amdgpu_drm.h" @@ -36,6 +37,13 @@ static void amdgpu_syncobj_timeline_test(void);CU_BOOL suite_syncobj_timeline_tests_enable (void ) {
tests/amdgpu/syncobj_tests.c static void amdgpu_syncobj_timeline_test(void); · line 49
Quoted 10 lines
tests/amdgpu/syncobj_tests.c +7
-0+int r; +uint64_t cap =0 ; + + r =drmGetCap (drm_amdgpu[0 ],DRM_CAP_SYNCOBJ_TIMELINE , &cap); +if (r || cap ==0 ) +return CU_FALSE ; +return CU_TRUE ; }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Zhou, David(ChunMing)
Reviewed-by Christian Königcould you help push this patch as well?
Thanks,
-David
-------- Original Message --------
Subject: Re: [PATCH libdrm] enable syncobj test depending on capability
From: "Koenig, Christian"
To: "Zhou, David(ChunMing)" ,[email protected] CC:
Am 16.05.19 um 12:46 schrieb Chunming Zhou:
Quoted 3 lines
Feature is controlled by
DRM_CAP_SYNCOBJ_TIMELINEdrm capability.Signed-off-by Chunming Zhou <[email protected]>
Quoted 33 lines
--- include/drm/drm.h | 1 + tests/amdgpu/syncobj_tests.c | 8 ++++++++ 2 files changed, 9 insertions(+)include/drm/drm.h +1
-0@@ -643,6 +643,7 @@ struct drm_gem_open {#define DRM_CAP_PAGE_FLIP_TARGET 0x11#define DRM_CAP_CRTC_IN_VBLANK_EVENT 0x12#define DRM_CAP_SYNCOBJ 0x13 +#define DRM_CAP_SYNCOBJ_TIMELINE 0x14/** DRM_IOCTL_GET_CAP ioctl argument type */ struct drm_get_cap {tests/amdgpu/syncobj_tests.c +1
-0@@ -22,6 +22,7 @@*/ #include "CUnit/Basic.h" +#include "xf86drm.h" #include "amdgpu_test.h" #include "amdgpu_drm.h" @@ -36,6 +37,13 @@ static void amdgpu_syncobj_timeline_test(void);CU_BOOL suite_syncobj_timeline_tests_enable (void ) {
tests/amdgpu/syncobj_tests.c static void amdgpu_syncobj_timeline_test(void); · line 49
Quoted 10 lines
tests/amdgpu/syncobj_tests.c +7
-0+int r; +uint64_t cap =0 ; + + r =drmGetCap (drm_amdgpu[0 ],DRM_CAP_SYNCOBJ_TIMELINE , &cap); +if (r || cap ==0 ) +return CU_FALSE ; +return CU_TRUE ; }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ping, Could you help check in patch to gitlab? My connection to gitlab still has problem.
Thanks,
-David
Quoted 49 lines · David(ChunMing)
could you help push this patch as well?
Thanks,
-David-------- Original Message --------
Subject: Re: [PATCH libdrm] enable syncobj test depending on capability
From: "Koenig, Christian"
To: "Zhou, David(ChunMing)" ,[email protected] CC:Am 16.05.19 um 12:46 schrieb Chunming Zhou:
Quoted 3 lines
Feature is controlled by
DRM_CAP_SYNCOBJ_TIMELINEdrm capability.Signed-off-by Chunming Zhou <[email protected]>Reviewed-by Christian König <[email protected]>Quoted 31 lines
---
include/drm/drm.h | 1 +
tests/amdgpu/syncobj_tests.c| 8 ++++++++2 files changed, 9 insertions(+)include/drm/drm.h +1
-0@@ -643,6 +643,7 @@ struct drm_gem_open { #define DRM_CAP_PAGE_FLIP_TARGET 0x11 #define DRM_CAP_CRTC_IN_VBLANK_EVENT 0x12 #define DRM_CAP_SYNCOBJ 0x13 +#define DRM_CAP_SYNCOBJ_TIMELINE 0x14 /** DRM_IOCTL_GET_CAP ioctl argument type */ struct drm_get_cap {tests/amdgpu/syncobj_tests.c +1
-0@@ -22,6 +22,7 @@*/ #include "CUnit/Basic.h" +#include "xf86drm.h" #include "amdgpu_test.h" #include "amdgpu_drm.h"@@ -36,6 +37,13 @@ static void amdgpu_syncobj_timeline_test(void);
Quoted 13 lines
tests/amdgpu/syncobj_tests.c static void amdgpu_syncobj_timeline_test(void); · line 49
Quoted 12 lines
tests/amdgpu/syncobj_tests.c +7
-0CU_BOOL suite_syncobj_timeline_tests_enable(void) { + int r; + uint64_t cap = 0; + + r = drmGetCap(drm_amdgpu[0], DRM_CAP_SYNCOBJ_TIMELINE, &cap); + if (r || cap == 0) + return CU_FALSE; + return CU_TRUE; }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 2 lines · On 2019-05-17 11:47 a.m., zhoucm1 wrote:
ping, Could you help check in patch to gitlab? My connection to gitlab still has problem.
Please follow the process documented in include/drm/README for include/drm/drm.h .
Signature · 6 lines
Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 17.05.19 um 11:55 schrieb Michel Dänzer:
Quoted 7 lines
[CAUTION: External Email]
Quoted 2 lines · On 2019-05-17 11:47 a.m., zhoucm1 wrote:
ping, Could you help check in patch to gitlab? My connection to gitlab still has problem.
Please follow the process documented in
include/drm/READMEforinclude/drm/drm.h.
Yeah, the header should be updated separately to what is currently in drm-next (or drm-misc-next).
And then we can update the fix on top of that,
Christian.
Quoted 5 lines
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Can you guy do that? Otherwise if kernel driver doesn't set that cap, test could fail.
Thanks,
-David
-------- Original Message --------
Subject: Re: [PATCH libdrm] enable syncobj test depending on capability
From: "Koenig, Christian"
To: Michel Dänzer ,"Zhou, David(ChunMing)" ,"Zhou, David(ChunMing)"
CC: [email protected]
Am 17.05.19 um 11:55 schrieb Michel Dänzer:
Quoted 7 lines
[CAUTION: External Email]
Quoted 2 lines · On 2019-05-17 11:47 a.m., zhoucm1 wrote:
ping, Could you help check in patch to gitlab? My connection to gitlab still has problem.
Please follow the process documented in
include/drm/READMEforinclude/drm/drm.h.
Yeah, the header should be updated separately to what is currently in drm-next (or drm-misc-next).
And then we can update the fix on top of that,
Christian.
Quoted 5 lines
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
No, first of all I'm really busy with those TTM problems.
And second I'm actually not very familiar with this either.
Please just split the patch up into two, one updating the headers and one fixing the test case.
Maybe that's enough for Michel,
Christian.
Am 17.05.19 um 14:28 schrieb Zhou, David(ChunMing):
Can you guy do that? Otherwise if kernel driver doesn't set that cap, test could fail.
Thanks,
-David
-------- Original Message --------
Subject: Re: [PATCH libdrm] enable syncobj test depending on capability
From: "Koenig, Christian"
To: Michel Dänzer ,"Zhou, David(ChunMing)" ,"Zhou, David(ChunMing)"
CC: [email protected]<mailto:[email protected]>
Am 17.05.19 um 11:55 schrieb Michel Dänzer:
Quoted 7 lines
[CAUTION: External Email]
Quoted 2 lines · On 2019-05-17 11:47 a.m., zhoucm1 wrote:
ping, Could you help check in patch to gitlab? My connection to gitlab still has problem.
Please follow the process documented in
include/drm/READMEforinclude/drm/drm.h.
Yeah, the header should be updated separately to what is currently in drm-next (or drm-misc-next).
And then we can update the fix on top of that,
Christian.
Quoted 5 lines
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Christian
No, first of all I'm really busy with those TTM problems.
And second I'm actually not very familiar with this either.
Please just split the patch up into two, one updating the headers and one fixing the test case.
Maybe that's enough for Michel,
This is the most important part of include/drm/README:
When and how to update these files
----------------------------------
Note: One should not do _any_ changes to the files apart from the steps below.
In order to update the files do the following:
- Switch to a Linux kernel tree/branch which is not rebased. For example: drm-next (https://cgit.freedesktop.org/drm/drm)
- Install the headers via `make headers_install' to a separate location.
- Copy the drm header[s] + git add + git commit.
- Note: Your commit message must include:
a) Brief summary on the delta. If there's any change that looks like an
API/ABI break one _must_ explicitly state why it's safe to do so.
b) "Generated using make headers_install."
c) "Generated from $tree/branch commit $sha"
Signature · 6 lines
Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel