net: avoid weird emergency message
Subsystems (2)
PATCH 1/1 net: avoid weird emergency message
When host is under high stress, it is very possible thread running netdev_wait_allrefs() returns from msleep(250) 10 seconds late.
This leads to these messages in the syslog :
[...] unregister_netdevice: waiting for syz_tun to become free. Usage count = 0
If the device refcount is zero, the wait is over.
Signed-off-by Eric Dumazet <[email protected]>
Reported-by syzbot <[email protected]>
--- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/dev.c +1 -1
@@ -8927,7 +8927,7 @@ static void netdev_wait_allrefs(struct net_device *dev) refcnt =netdev_refcnt_read (dev); -if (time_after (jiffies, warning_time +10 *HZ )) { +if (refcnt &&time_after (jiffies, warning_time +10 *HZ )) {pr_emerg ("unregister_netdevice: waiting for %s to become free. Usage count = %d\n" , dev->name, refcnt); warning_time = jiffies;
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog
From: Eric Dumazet <[email protected]>
Date: Thu, 16 May 2019 08:09:57 -0700
Quoted 4 lines
When host is under high stress, it is very possible thread running
netdev_wait_allrefs()returns from msleep(250) 10 seconds late.
Quoted 8 lines
This leads to these messages in the syslog :
[...]
unregister_netdevice: waiting forsyz_tunto become free. Usage count = 0If the device refcount is zero, the wait is over.
Signed-off-by Eric Dumazet <[email protected]>Reported-by syzbot <[email protected]>
Applied, thanks.