Skip to contentSkip to conversation

board: friendlyarm: Add initial support for NanoPc T4

PATCH New Shyam Saini 2 participants 4 messages May 16, 2019 – May 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: friendlyarm: Add initial support for NanoPc T4

This initial support includes:
Linux 5.1-rc1
Custom U-Boot
Arm Trusted Firmware v2.0
Buildroot default packages

---
 .gitlab-ci.yml                            |  1 +
 DEVELOPERS                                |  2 ++
 board/friendlyarm/nanopc-t4/extlinux.conf |  4 +++
 board/friendlyarm/nanopc-t4/genimage.cfg  | 22 +++++++++++++
 board/friendlyarm/nanopc-t4/post-build.sh |  8 +++++
 board/friendlyarm/nanopc-t4/readme.txt    | 46 ++++++++++++++++++++++++++
 configs/nanopc_t4_defconfig               | 55 +++++++++++++++++++++++++++++++
 7 files changed, 138 insertions(+)
 create mode 100644 board/friendlyarm/nanopc-t4/extlinux.conf
 create mode 100644 board/friendlyarm/nanopc-t4/genimage.cfg
 create mode 100755 board/friendlyarm/nanopc-t4/post-build.sh
 create mode 100644 board/friendlyarm/nanopc-t4/readme.txt
 create mode 100644 configs/nanopc_t4_defconfig
.gitlab-ci.yml +1 -0
index 5b842762f1..5ed1b8f4d5 100644
@@ -176,6 +176,7 @@ mx53loco_defconfig: { extends: .defconfig }
 mx6cubox_defconfig: { extends: .defconfig }
 mx6sx_udoo_neo_defconfig: { extends: .defconfig }
 mx6udoo_defconfig: { extends: .defconfig }
+nanopc_t4_defconfig: { extends: .defconfig }
 nanopi_m1_defconfig: { extends: .defconfig }
 nanopi_m1_plus_defconfig: { extends: .defconfig }
 nanopi_m4_defconfig: { extends: .defconfig }
DEVELOPERS +2 -0
index e4a089e6f5..ec1dde20e7 100644
@@ -2048,6 +2048,8 @@ F:     board/orangepi/orangepi-rk3399/
 F:     configs/orangepi_rk3399_defconfig
 F:	board/olimex/a33_olinuxino/
 F:	configs/olimex_a33_olinuxino_defconfig
+F:	board/friendlyarm/nanopc-t4/
+F:	configs/nanopc_t4_defconfig
 
 N:	Simon Dawson <[email protected]>
 F:	boot/at91bootstrap3/
board/friendlyarm/nanopc-t4/extlinux.conf new file +4 -0
new file mode 100644
index 0000000000..b09c20db84
@@ -0,0 +1,4 @@
+label NanoPc T4
+  kernel /boot/Image
+  devicetree /boot/rk3399-nanopc-t4.dtb
+  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p1 rootwait
board/friendlyarm/nanopc-t4/genimage.cfg new file +22 -0
new file mode 100644
index 0000000000..6404b0ad3b
@@ -0,0 +1,22 @@
+image sdcard.img {
+	hdimage {
+	}
+
+	partition u-boot-spl-dtb {
+		in-partition-table = "no"
+		image = "u-boot-spl-dtb.img"
+		offset = 32K
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot.itb"
+		offset = 8M
+		size = 30M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
board/friendlyarm/nanopc-t4/post-build.sh new file +8 -0
new file mode 100755
index 0000000000..9b0c4ecc83
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+MKIMAGE=$HOST_DIR/bin/mkimage
+BOARD_DIR="$(dirname $0)"
+
+$MKIMAGE -n rk3399 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/friendlyarm/nanopc-t4/readme.txt new file +46 -0

46 lines not on this page · raw message

configs/nanopc_t4_defconfig new file +55 -0

55 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 board: friendlyarm: Add initial support for NanoPc T4

Hello,

Quoted 2 lines · On Thu, 16 May 2019 13:20:10 +0530 Shyam Saini…

This initial support includes:

	Linux 5.1-rc1

Why not use the final 5.1 release ?

DEVELOPERS F: board/orangepi/orangepi-rk3399/ · line 2052

Quoted 10 lines
DEVELOPERS +2 -0
index e4a089e6f5..ec1dde20e7 100644
@@ -2048,6 +2048,8 @@ F:     board/orangepi/orangepi-rk3399/
 F:     configs/orangepi_rk3399_defconfig
 F:	board/olimex/a33_olinuxino/
 F:	configs/olimex_a33_olinuxino_defconfig
+F:	board/friendlyarm/nanopc-t4/
+F:	configs/nanopc_t4_defconfig

Alphabetic ordering is preferred.

DEVELOPERS F: board/orangepi/orangepi-rk3399/ · line 2055

Quoted 3 lines
DEVELOPERS +3 -0
+Files created in output directory
+=================================
+output/images/

One empty line to separate the section title from the section contents would be nice.

Quoted 14 lines
DEVELOPERS +14 -0
+??? bl31.bin
+??? bl31.elf
+??? Image
+??? rk3399-nanopc-t4.dtb
+??? rootfs.ext2
+??? rootfs.ext4 -> rootfs.ext2
+??? rootfs.tar
+??? sdcard.img
+??? u-boot.bin
+??? u-boot.itb
+??? u-boot-spl-dtb.bin
+??? u-boot-spl-dtb.img
+
+Creating bootable SD card:

DEVELOPERS F: board/orangepi/orangepi-rk3399/

Quoted 10 lines
DEVELOPERS +10 -0
+=========================
+
+Simply invoke (as root)
+
+  # dd if=output/images/sdcard.img of=/dev/sdX && sync
+
+Where X is your SD card device
+
+Serial console
+--------------

Ditto.

configs/nanopc_t4_defconfig line 6

Quoted 12 lines
configs/nanopc_t4_defconfig new file +6 -0
new file mode 100644
index 0000000000..a55b754d0f
@@ -0,0 +1,55 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a72_a53=y
+
+# Linux headers same as kernel, a 5.0 series
+BR2_KERNEL_HEADERS_5_0=y

So 5_1 preferably.

configs/nanopc_t4_defconfig line 8

Quoted 1 line
configs/nanopc_t4_defconfig new file +1 -0
+#Firmware

Space before firmware, for consistency.

Quoted 37 lines
configs/nanopc_t4_defconfig new file +37 -0
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.0"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/amarula/u-boot-amarula.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="980ca75ae0438b4a1847d044605c492f3c844f88"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopc-t4-rk3399"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="v5.1-rc1"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3399-nanopc-t4"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+# Filesystem
+BR2_TARGET_GENERIC_HOSTNAME="NanoPc T4"
+BR2_TARGET_GENERIC_ISSUE="Welcome to NanoPc T4!"

configs/nanopc_t4_defconfig line 55

Quoted 10 lines
configs/nanopc_t4_defconfig new file +10 -0
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="512M"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/friendlyarm/nanopc-t4/genimage.cfg"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/friendlyarm/nanopc-t4/post-build.sh"

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 board: friendlyarm: Add initial support for NanoPc T4

Quoted 1 line

Hello,

Hi Thomas,

Quoted 8 lines
Quoted 2 lines · On Thu, 16 May 2019 13:20:10 +0530 Shyam Saini…

This initial support includes:

      Linux 5.1-rc1

Why not use the final 5.1 release ?

will update this

Quoted 4 lines
Quoted 4 lines
DEVELOPERS +0 -0
index e4a089e6f5..ec1dde20e7 100644
Quoted 8 lines

DEVELOPERS F: board/orangepi/orangepi-rk3399/ · line 2052

Quoted 6 lines
DEVELOPERS +2 -0
@@ -2048,6 +2048,8 @@ F:     board/orangepi/orangepi-rk3399/
 F:     configs/orangepi_rk3399_defconfig
 F:   board/olimex/a33_olinuxino/
 F:   configs/olimex_a33_olinuxino_defconfig
+F:   board/friendlyarm/nanopc-t4/
+F:   configs/nanopc_t4_defconfig

Alphabetic ordering is preferred.

should i resend all the patches again for this ? or I should take care of this thing from this patch onward ?

Quoted 50 lines

DEVELOPERS F: board/orangepi/orangepi-rk3399/ · line 2055

Quoted 4 lines
DEVELOPERS +3 -0
+Files created in output directory
+=================================
+output/images/

One empty line to separate the section title from the section contents would be nice.

Quoted 14 lines
DEVELOPERS +14 -0
+??? bl31.bin
+??? bl31.elf
+??? Image
+??? rk3399-nanopc-t4.dtb
+??? rootfs.ext2
+??? rootfs.ext4 -> rootfs.ext2
+??? rootfs.tar
+??? sdcard.img
+??? u-boot.bin
+??? u-boot.itb
+??? u-boot-spl-dtb.bin
+??? u-boot-spl-dtb.img
+
+Creating bootable SD card:

DEVELOPERS F: board/orangepi/orangepi-rk3399/

Quoted 10 lines
DEVELOPERS +10 -0
+=========================
+
+Simply invoke (as root)
+
+  # dd if=output/images/sdcard.img of=/dev/sdX && sync
+
+Where X is your SD card device
+
+Serial console
+--------------

Ditto.

configs/nanopc_t4_defconfig line 6

Quoted 12 lines
configs/nanopc_t4_defconfig new file +6 -0
new file mode 100644
index 0000000000..a55b754d0f
@@ -0,0 +1,55 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a72_a53=y
+
+# Linux headers same as kernel, a 5.0 series
+BR2_KERNEL_HEADERS_5_0=y

So 5_1 preferably.

Quoted 3 lines

configs/nanopc_t4_defconfig line 8

Quoted 1 line
configs/nanopc_t4_defconfig new file +1 -0
+#Firmware

Space before firmware, for consistency.

I'll fix all these things in next version

Thanks for the review.

#3 lore raw

PATCH 1/1 board: friendlyarm: Add initial support for NanoPc T4

Hello,

Quoted 3 lines · On Mon, 20 May 2019 15:48:42 +0530 Shyam Saini…
Quoted 1 line

Why not use the final 5.1 release ?

will update this

OK, thanks.

Quoted 4 lines
Quoted 1 line

Alphabetic ordering is preferred.

should i resend all the patches again for this ? or I should take care of this thing from this patch onward ?

Since you are going to send a new version to use the final 5.1 release, you can fix the alphabetic ordering at the same time.

If you're talking about other patches than this one, then please don't resend just for the alphabetic ordering.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com