Skip to contentSkip to conversation

Revert "ICL HACK: Disable ACPI idle driver"

PATCH In review Anshuman Gupta 6 participants 8 messages May 16, 2019 – May 21, 2019 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "ICL HACK: Disable ACPI idle driver"

This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver.

This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
But this bug is still reproducible after disabling ACPI idle driver.

It looks "rcu_preempt self-detected stall on CPU" causes to hung kworker and followed by panic resulted this bug.

Hence it make sense to revert this patch.

---
 drivers/acpi/processor_driver.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
drivers/acpi/processor_driver.c +1 -17
index ee842a2f..9d6aff2 100644
@@ -35,12 +35,6 @@
 
 #include <acpi/processor.h>
 
-/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
-#ifdef CONFIG_X86
-#include <asm/cpu_device_id.h>
-#include <asm/intel-family.h>
-#endif
-
 #include "internal.h"
 
 #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -64,13 +58,6 @@ static const struct acpi_device_id processor_device_ids[] = {
 };
 MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
-#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
-static const struct x86_cpu_id intel_cpu_ids[] = {
-	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
-	{}
-};
-MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
-
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -239,7 +226,6 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
 static int __acpi_processor_start(struct acpi_device *device)
 {
 	struct acpi_processor *pr = acpi_driver_data(device);
-	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
 
@@ -253,9 +239,7 @@ static int __acpi_processor_start(struct acpi_device *device)
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	id = x86_match_cpu(intel_cpu_ids);
-	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
-		&acpi_idle_driver))
+	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for Revert "ICL HACK: Disable ACPI idle driver"

== Series Details ==

== Series Details ==

Series: Revert "ICL HACK: Disable ACPI idle driver"
URL : https://patchwork.freedesktop.org/series/60731/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6091 -> Patchwork_13026
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/

Known issues
------------

Here are the changes found in Patchwork_13026 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-blb-e6850/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

* igt@i915_selftest@live_guc:
- fi-apl-guc: [PASS][5] -> [INCOMPLETE][6] ([fdo#103927])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-apl-guc/igt@i915_selftest@live_guc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-apl-guc/igt@i915_selftest@live_guc.html

* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [PASS][7] -> [DMESG-FAIL][8] ([fdo#110620])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-apl-guc/igt@i915_selftest@live_hangcheck.html

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][11] ([fdo#108511]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-skl-6770hq/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [DMESG-FAIL][13] ([fdo#110235]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][15] ([fdo#102614]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-hsw-peppy/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-hsw-peppy/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: [DMESG-WARN][17] ([fdo#106387]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/fi-ilk-650/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/fi-ilk-650/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110620]: https://bugs.freedesktop.org/show_bug.cgi?id=110620

Participating hosts (50 -> 44)
------------------------------

Additional (2): fi-bsw-n3050 fi-pnv-d510
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_6091 -> Patchwork_13026

CI_DRM_6091: 0ad895242a8e957336088625a9a6ba48ab838ec9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4994: 555019f862c35f1619627761d6da21385be40920 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13026: 90b04825a71257cffd83db26c7dfa5af919d046a @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

90b04825a712 Revert "ICL HACK: Disable ACPI idle driver"

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for Revert "ICL HACK: Disable ACPI idle driver"

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Revert "ICL HACK: Disable ACPI idle driver"
URL : https://patchwork.freedesktop.org/series/60731/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6091_full -> Patchwork_13026_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_13026_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@in-flight-suspend:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108] / [fdo#107773])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl3/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-apl3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-apl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
- shard-iclb: [PASS][5] -> [FAIL][6] ([fdo#103167]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#108145] / [fdo#110403])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl6/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103166])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb8/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#108341])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb7/igt@kms_psr@no_drrs.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb1/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb7/igt@kms_psr@psr2_no_drrs.html

* igt@tools_test@tools_test:
- shard-skl: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl6/igt@tools_test@tools_test.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl8/igt@tools_test@tools_test.html

#### Possible fixes ####

* igt@i915_pm_rpm@gem-mmap-gtt:
- shard-iclb: [INCOMPLETE][17] ([fdo#107713] / [fdo#108840]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb8/igt@[email protected]

* igt@i915_pm_rpm@reg-read-ioctl:
- shard-skl: [INCOMPLETE][19] ([fdo#107807]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl9/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][21] ([fdo#104108] / [fdo#107807]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl3/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-skl: [INCOMPLETE][23] ([fdo#104108] / [fdo#107773]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl9/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [FAIL][25] ([fdo#103167]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb5/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-apl1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-apl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-kbl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][31] ([fdo#108145]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-skl5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-skl9/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-primary-size-64:
- shard-iclb: [INCOMPLETE][33] ([fdo#107713]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb1/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][35] ([fdo#109642]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb4/igt@kms_psr2_su@page_flip.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb2/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][37] ([fdo#109441]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb4/igt@kms_psr@psr2_sprite_blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

#### Warnings ####

* igt@gem_mmap_gtt@forked-big-copy:
- shard-iclb: [TIMEOUT][39] ([fdo#109673]) -> [INCOMPLETE][40] ([fdo#107713] / [fdo#109100])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb1/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-after-suspend:
- shard-iclb: [INCOMPLETE][41] ([fdo#107713]) -> [SKIP][42] ([fdo#109284])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6091/shard-iclb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/shard-iclb2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403

Participating hosts (10 -> 9)
------------------------------

Missing (1): pig-skl-6260u

Build changes
-------------

* Linux: CI_DRM_6091 -> Patchwork_13026

CI_DRM_6091: 0ad895242a8e957336088625a9a6ba48ab838ec9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4994: 555019f862c35f1619627761d6da21385be40920 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13026: 90b04825a71257cffd83db26c7dfa5af919d046a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13026/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#3 lore raw
In reply to Anshuman Gupta

The patch looks fine to me.

Quoted 8 lines · Anshuman Gupta

This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver.

This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
But this bug is still reproducible after disabling ACPI idle driver.

Quoted 8 lines

It looks "rcu_preempt self-detected stall on CPU" causes to hung kworker and followed by panic resulted this bug.

Hence it make sense to revert this patch.

Quoted 62 lines
---
 drivers/acpi/processor_driver.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
drivers/acpi/processor_driver.c +1 -17
index ee842a2f..9d6aff2 100644
@@ -35,12 +35,6 @@
 
 #include <acpi/processor.h>
 
-/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
-#ifdef CONFIG_X86
-#include <asm/cpu_device_id.h>
-#include <asm/intel-family.h>
-#endif
-
 #include "internal.h"
 
 #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -64,13 +58,6 @@ static const struct acpi_device_id processor_device_ids[] = {
 };
 MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
-#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
-static const struct x86_cpu_id intel_cpu_ids[] = {
-	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
-	{}
-};
-MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
-
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -239,7 +226,6 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
 static int __acpi_processor_start(struct acpi_device *device)
 {
 	struct acpi_processor *pr = acpi_driver_data(device);
-	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
 
@@ -253,9 +239,7 @@ static int __acpi_processor_start(struct acpi_device *device)
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	id = x86_match_cpu(intel_cpu_ids);
-	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
-		&acpi_idle_driver))
+	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

HI,

Quoted 22 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Aditya Swarup
Sent: lauantai 18. toukokuuta 2019 1.00
To: Gupta, Anshuman <[email protected]>
Cc: Vetter, Daniel <[email protected]>; [email protected]; Syrjala, Ville <[email protected]>; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

The patch looks fine to me.

Quoted 11 lines · Anshuman Gupta

This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver.

This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
But this bug is still reproducible after disabling ACPI idle driver.

It looks "rcu_preempt self-detected stall on CPU" causes to hung kworker and followed by panic resulted this bug.

Quoted 7 lines
Quoted 5 lines

Hence it make sense to revert this patch.

Are we now ok to merge this or? Chris, Ville?

Quoted 58 lines

drivers/acpi/processor_driver.c static int __acpi_processor_start(struct acpi_device

Quoted 43 lines
---
 drivers/acpi/processor_driver.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
(quoted diff) +0 -0

b/drivers/acpi/processor_driver.c index ee842a2f..9d6aff2 100644

drivers/acpi/processor_driver.c +0 -2
@@ -35,12 +35,6 @@
 
 #include <acpi/processor.h>
 
-/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
-#ifdef CONFIG_X86 -#include <asm/cpu_device_id.h> -#include

<asm/intel-family.h> -#endif
-
#include "internal.h"

#define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80 @@ -64,13 +58,6 @@
static const struct acpi_device_id processor_device_ids[] = { }; MODULE_DEVICE_TABLE(acpi, processor_device_ids);

drivers/acpi/processor_driver.c +0 -7
-#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
-static const struct x86_cpu_id intel_cpu_ids[] = {
-	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
-	{}
-};
-MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
-
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -239,7 +226,6 @@ static inline void acpi_pss_perf_exit(struct

acpi_processor *pr, static int __acpi_processor_start(struct acpi_device *device) {

drivers/acpi/processor_driver.c +0 -1
 	struct acpi_processor *pr = acpi_driver_data(device);
-	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
@@ -253,9 +239,7 @@ static int __acpi_processor_start(struct acpi_device

*device)

Quoted 14 lines
drivers/acpi/processor_driver.c +2 -4
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	id = x86_match_cpu(intel_cpu_ids);
-	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
-		&acpi_idle_driver))
+	if (!cpuidle_get_driver() || cpuidle_get_driver() ==
+&acpi_idle_driver)
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
--

2.7.4

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 24 lines · Jani

HI,

Quoted 22 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Aditya Swarup
Sent: lauantai 18. toukokuuta 2019 1.00
To: Gupta, Anshuman <[email protected]>
Cc: Vetter, Daniel <[email protected]>; [email protected]; Syrjala, Ville <[email protected]>; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

The patch looks fine to me.

Quoted 11 lines · Anshuman Gupta

This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver.

This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
But this bug is still reproducible after disabling ACPI idle driver.

It looks "rcu_preempt self-detected stall on CPU" causes to hung kworker and followed by panic resulted this bug.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines

Hence it make sense to revert this patch.

Are we now ok to merge this or? Chris, Ville?

We shouldn't merge this. Instead we just need to go there and remove from topic/core-for-CI and force push with dim to rebuild drm-tip.

If this is the wish from CI perspective, let's do it.

Quoted 67 lines
Quoted 59 lines

drivers/acpi/processor_driver.c static int __acpi_processor_start(struct acpi_device

Quoted 44 lines
---
 drivers/acpi/processor_driver.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
(quoted diff) +0 -0

b/drivers/acpi/processor_driver.c index ee842a2f..9d6aff2 100644

drivers/acpi/processor_driver.c +0 -2
@@ -35,12 +35,6 @@
 
 #include <acpi/processor.h>
 
-/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
-#ifdef CONFIG_X86 -#include <asm/cpu_device_id.h> -#include

<asm/intel-family.h> -#endif
-
#include "internal.h"

#define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80 @@ -64,13 +58,6 @@
static const struct acpi_device_id processor_device_ids[] = { }; MODULE_DEVICE_TABLE(acpi, processor_device_ids);

drivers/acpi/processor_driver.c +0 -7
-#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
-static const struct x86_cpu_id intel_cpu_ids[] = {
-	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
-	{}
-};
-MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
-
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -239,7 +226,6 @@ static inline void acpi_pss_perf_exit(struct

acpi_processor *pr, static int __acpi_processor_start(struct acpi_device *device) {

drivers/acpi/processor_driver.c +0 -1
 	struct acpi_processor *pr = acpi_driver_data(device);
-	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
@@ -253,9 +239,7 @@ static int __acpi_processor_start(struct acpi_device

*device)

Quoted 14 lines
drivers/acpi/processor_driver.c +2 -4
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	id = x86_match_cpu(intel_cpu_ids);
-	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
-		&acpi_idle_driver))
+	if (!cpuidle_get_driver() || cpuidle_get_driver() ==
+&acpi_idle_driver)
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
--

2.7.4

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

HI,

Quoted 38 lines

-----Original Message-----
From: Vivi, Rodrigo
Sent: tiistai 21. toukokuuta 2019 3.12
To: Saarinen, Jani <[email protected]>
Cc: Swarup, Aditya <[email protected]>; Gupta, Anshuman <[email protected]>; Vetter, Daniel <[email protected]>; intel- [email protected]; Syrjala, Ville <[email protected]>; Peres, Martin <[email protected]>; Wilson, Chris P <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

Quoted 27 lines · Jani

HI,

Quoted 25 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Aditya Swarup
Sent: lauantai 18. toukokuuta 2019 1.00
To: Gupta, Anshuman <[email protected]>
Cc: Vetter, Daniel <[email protected]>; [email protected]; Syrjala, Ville <[email protected]>; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

The patch looks fine to me.

Quoted 13 lines · Anshuman Gupta

This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver.

This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
But this bug is still reproducible after disabling ACPI idle driver.

It looks "rcu_preempt self-detected stall on CPU" causes to hung kworker and followed by panic resulted this bug.

Hence it make sense to revert this patch.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

Are we now ok to merge this or? Chris, Ville?

We shouldn't merge this. Instead we just need to go there and remove from topic/core-for-CI and force push with dim to rebuild drm-tip.

Yes, this was my ask here, isnt't this change for reverting that from topic/core-for-CI (so basically remove) or no?

Quoted 2 lines

If this is the wish from CI perspective, let's do it.

If other players agree first. Ville, Chris?

Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
---
 drivers/acpi/processor_driver.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
(quoted diff) +0 -0

b/drivers/acpi/processor_driver.c index ee842a2f..9d6aff2 100644

drivers/acpi/processor_driver.c +0 -2
@@ -35,12 +35,6 @@
 
 #include <acpi/processor.h>
 
-/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
-#ifdef CONFIG_X86 -#include <asm/cpu_device_id.h> -#include

<asm/intel-family.h> -#endif
-
#include "internal.h"

Quoted 53 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

#define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80 @@ -64,13 +58,6

@@

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

static const struct acpi_device_id processor_device_ids[] = { }; MODULE_DEVICE_TABLE(acpi, processor_device_ids);

-#define ICPU(model) { X86_VENDOR_INTEL, 6, model,

X86_FEATURE_ANY, }

Quoted 46 lines
Quoted 34 lines
Quoted 18 lines
drivers/acpi/processor_driver.c +0 -6
-static const struct x86_cpu_id intel_cpu_ids[] = {
-	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
-	{}
-};
-MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
-
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -239,7 +226,6 @@ static inline void acpi_pss_perf_exit(struct

acpi_processor *pr, static int __acpi_processor_start(struct acpi_device *device) {

drivers/acpi/processor_driver.c +0 -1
 	struct acpi_processor *pr = acpi_driver_data(device);
-	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
@@ -253,9 +239,7 @@ static int __acpi_processor_start(struct
Quoted 1 line

acpi_device

*device)

Quoted 14 lines
drivers/acpi/processor_driver.c +2 -4
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	id = x86_match_cpu(intel_cpu_ids);
-	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
-		&acpi_idle_driver))
+	if (!cpuidle_get_driver() || cpuidle_get_driver() ==
+&acpi_idle_driver)
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
--

2.7.4

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 44 lines · Jani

HI,

Quoted 42 lines

-----Original Message-----
From: Vivi, Rodrigo
Sent: tiistai 21. toukokuuta 2019 3.12
To: Saarinen, Jani <[email protected]>
Cc: Swarup, Aditya <[email protected]>; Gupta, Anshuman <[email protected]>; Vetter, Daniel <[email protected]>; intel- [email protected]; Syrjala, Ville <[email protected]>; Peres, Martin <[email protected]>; Wilson, Chris P <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

Quoted 31 lines · Jani

HI,

Quoted 29 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Aditya Swarup
Sent: lauantai 18. toukokuuta 2019 1.00
To: Gupta, Anshuman <[email protected]>
Cc: Vetter, Daniel <[email protected]>; [email protected]; Syrjala, Ville <[email protected]>; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

The patch looks fine to me.

Quoted 16 lines · Anshuman Gupta

This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver.

This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
But this bug is still reproducible after disabling ACPI idle driver.

It looks "rcu_preempt self-detected stall on CPU" causes to hung kworker and followed by panic resulted this bug.

Hence it make sense to revert this patch.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Are we now ok to merge this or? Chris, Ville?

We shouldn't merge this. Instead we just need to go there and remove from topic/core-for-CI and force push with dim to rebuild drm-tip.

Yes, this was my ask here, isnt't this change for reverting that from topic/core-for-CI (so basically remove) or no?

Quoted 2 lines

If this is the wish from CI perspective, let's do it.

If other players agree first. Ville, Chris?

I threw the commit out of topic/core-for-CI.

BR,
Jani.

Quoted 80 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
---
 drivers/acpi/processor_driver.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
(quoted diff) +0 -0

b/drivers/acpi/processor_driver.c index ee842a2f..9d6aff2 100644

drivers/acpi/processor_driver.c +0 -2
@@ -35,12 +35,6 @@
 
 #include <acpi/processor.h>
 
-/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
-#ifdef CONFIG_X86 -#include <asm/cpu_device_id.h> -#include

<asm/intel-family.h> -#endif
-
#include "internal.h"

Quoted 53 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

#define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80 @@ -64,13 +58,6

@@

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

static const struct acpi_device_id processor_device_ids[] = { }; MODULE_DEVICE_TABLE(acpi, processor_device_ids);

-#define ICPU(model) { X86_VENDOR_INTEL, 6, model,

X86_FEATURE_ANY, }

Quoted 46 lines
Quoted 34 lines
Quoted 18 lines
drivers/acpi/processor_driver.c +0 -6
-static const struct x86_cpu_id intel_cpu_ids[] = {
-	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
-	{}
-};
-MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
-
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -239,7 +226,6 @@ static inline void acpi_pss_perf_exit(struct

acpi_processor *pr, static int __acpi_processor_start(struct acpi_device *device) {

drivers/acpi/processor_driver.c +0 -1
 	struct acpi_processor *pr = acpi_driver_data(device);
-	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
@@ -253,9 +239,7 @@ static int __acpi_processor_start(struct
Quoted 1 line

acpi_device

*device)

Quoted 14 lines
drivers/acpi/processor_driver.c +2 -4
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	id = x86_match_cpu(intel_cpu_ids);
-	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
-		&acpi_idle_driver))
+	if (!cpuidle_get_driver() || cpuidle_get_driver() ==
+&acpi_idle_driver)
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
--

2.7.4

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx