selftests: pmtu.sh: Remove quotes around commands in setup_xfrm
Subsystems (3)
PATCH 1/1 selftests: pmtu.sh: Remove quotes around commands in setup_xfrm
From: David Ahern <[email protected]>
The first command in setup_xfrm is failing resulting in the test getting skipped:
+ ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
+ out=RTNETLINK answers: Function not implemented
...
xfrm6 not supported
TEST: vti6: PMTU exceptions [SKIP]
xfrm4 not supported
TEST: vti4: PMTU exceptions [SKIP]
...
The setup command started failing when the run_cmd option was added. Removing the quotes fixes the problem:
...
TEST: vti6: PMTU exceptions [ OK ]
TEST: vti4: PMTU exceptions [ OK ]
...
--- tools/testing/selftests/net/pmtu.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
tools/testing/selftests/net/pmtu.sh +9 -9
@@ -430,15 +430,15 @@ setup_xfrm() { veth_a_addr="${2}" veth_b_addr="${3}" - run_cmd "${ns_a} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel" || return 1 - run_cmd "${ns_a} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel" - run_cmd "${ns_a} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel" - run_cmd "${ns_a} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel" - - run_cmd "${ns_b} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel" - run_cmd "${ns_b} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel" - run_cmd "${ns_b} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel" - run_cmd "${ns_b} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel" + run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel || return 1 + run_cmd ${ns_a} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel + run_cmd ${ns_a} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel + run_cmd ${ns_a} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel + + run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_a_addr} dst ${veth_b_addr} spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel + run_cmd ${ns_b} ip -${proto} xfrm state add src ${veth_b_addr} dst ${veth_a_addr} spi 0x1001 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel + run_cmd ${ns_b} ip -${proto} xfrm policy add dir out mark 10 tmpl src ${veth_b_addr} dst ${veth_a_addr} proto esp mode tunnel + run_cmd ${ns_b} ip -${proto} xfrm policy add dir in mark 10 tmpl src ${veth_a_addr} dst ${veth_b_addr} proto esp mode tunnel } setup_xfrm4() {
Signature · 1 line
2.11.0
Quoted 7 lines · On Thu, 16 May 2019 10:41:31 -0700 David Ahern <[email protected]> wrote:
From: David Ahern <[email protected]>
The first command in
setup_xfrmis failing resulting in the test getting skipped:+ ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi
0x1000proto esp aead 'rfc4106(gcm(aes))'0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f128 mode tunnel
+ out=RTNETLINK answers: Function not implemented
Thanks for fixing this, I ran into this issue right today and I was about to send a patch too. For the record, the quotes went all the way into xfrm_alg_name_match():
name: 'rfc4106(gcm(aes))' entry->name: rfc4106(gcm(aes))
My solution was to remove the single quotes around 'rfc4106(gcm(aes))', but I just checked yours and it also works on bash and dash, so I don't really have a preference.
Quoted 14 lines
...
xfrm6 not supported
TEST: vti6: PMTU exceptions [SKIP]
xfrm4 not supported
TEST: vti4: PMTU exceptions [SKIP]
...The setup command started failing when the
run_cmdoption was added. Removing the quotes fixes the problem:
...
TEST: vti6: PMTU exceptions [ OK ]
TEST: vti4: PMTU exceptions [ OK ]
...
Quoted 2 lines
Fixes 56490b623aa0 ("selftests: Add debugging options to pmtu.sh")Signed-off-by David Ahern <[email protected]>
Signature · 1 line
Stefano
Quoted 15 lines · Stefano Brivio
Quoted 7 lines · On Thu, 16 May 2019 10:41:31 -0700 David Ahern <[email protected]> wrote:
From: David Ahern <[email protected]>
The first command in
setup_xfrmis failing resulting in the test getting skipped:+ ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi
0x1000proto esp aead 'rfc4106(gcm(aes))'0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f128 mode tunnel
+ out=RTNETLINK answers: Function not implementedThanks for fixing this, I ran into this issue right today and I was about to send a patch too. For the record, the quotes went all the way into
xfrm_alg_name_match():
Quoted 7 lines
name: 'rfc4106(gcm(aes))' entry->name: rfc4106(gcm(aes))My solution was to remove the single quotes around 'rfc4106(gcm(aes))', but I just checked yours and it also works on bash and dash, so I don't really have a preference.
None of the other commands have the "" with run_cmd. Not sure why I did not remove the quotes from the xfrm commands.
From: David Ahern <[email protected]>
Date: Thu, 16 May 2019 10:41:31 -0700
Quoted 21 lines
From: David Ahern <[email protected]>
The first command in
setup_xfrmis failing resulting in the test getting skipped:+ ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi
0x1000proto esp aead 'rfc4106(gcm(aes))'0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f128 mode tunnel
+ out=RTNETLINK answers: Function not implemented
...
xfrm6 not supported
TEST: vti6: PMTU exceptions [SKIP]
xfrm4 not supported
TEST: vti4: PMTU exceptions [SKIP]
...The setup command started failing when the
run_cmdoption was added. Removing the quotes fixes the problem:
...
TEST: vti6: PMTU exceptions [ OK ]
TEST: vti4: PMTU exceptions [ OK ]
...
Quoted 2 lines
Fixes 56490b623aa0 ("selftests: Add debugging options to pmtu.sh")Signed-off-by David Ahern <[email protected]>
Applied, thanks David.