package/busybox: select individual libraries when selecting SELinux support.
PATCH 1/1 package/busybox: select individual libraries when selecting SELinux support.
From: Adam Duskett <[email protected]>
From the help test of individual binaries:
With this option enabled, each applet is a separate binary, which is needed for proper operation with SELinux
As such, it only makes sense to select this option when SELinux support is selected as well.
--- package/busybox/Config.in | 1 + 1 file changed, 1 insertion(+)
package/busybox/Config.in +1 -0
@@ -42,6 +42,7 @@ config BR2_PACKAGE_BUSYBOX_SELINUX depends on !BR2_STATIC_LIBS depends on BR2_TOOLCHAIN_USES_GLIBC depends on !BR2_arc + select BR2_PACKAGE_BUSYBOX_INDIVIDUAL_BINARIES select BR2_PACKAGE_LIBSELINUX help Enable SELinux support in BusyBox. Please note that
Signature · 1 line
2.21.0
PATCH 1/1 package/busybox: select individual libraries when selecting SELinux support.
Hello,
Quoted 9 lines · On Thu, 16 May 2019 11:52:00 -0400 aduskett at gmail.com wrote:
From: Adam Duskett <[email protected]>
From the help test of individual binaries:
With this option enabled, each applet is a separate binary, which is needed for proper operation with SELinux
As such, it only makes sense to select this option when SELinux support is selected as well.
The wording here is a bit unfortunate, as one could read this as if you had added a "depends on BR2_PACKAGE_BUSYBOX_SELINUX" to "BR2_PACKAGE_BUSYBOX_INDIVIDUAL_BINARIES", so that "individual binaries" can only be used with SELinux.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Thomas Petazzoni
AppliedPATCH 1/1 package/busybox: select individual libraries when selecting SELinux support.
In reply to aduskett at gmail.comHello Adam,
Quoted 7 lines · On Thu, 16 May 2019 11:52:00 -0400 aduskett at gmail.com wrote:
From: Adam Duskett <[email protected]>
From the help test of individual binaries:
With this option enabled, each applet is a separate binary, which is needed for proper operation with SELinux
Quoted 7 lines
As such, it only makes sense to select this option when SELinux support is selected as well.
Signed-off-by Adam Duskett <[email protected]>--- package/busybox/Config.in | 1 + 1 file changed, 1 insertion(+)
Applied to next, after slightly tweaking the commit log to reduce the confusion it was causing IMO.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com