package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget to add it to wpewebkit
Fixes:
- http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
--- package/wpewebkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +4 -2
@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8 -comment "wpewebkit needs an OpenGL ES w/ EGL backend" +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend" depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS depends on !BR2_BINFMT_FLAT - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \ + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEWEBKIT bool "wpewebkit"
@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT depends on BR2_USE_WCHAR # icu, libsoup depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS select BR2_PACKAGE_CAIRO select BR2_PACKAGE_CAIRO_PNG
Signature · 1 line
2.20.1
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Hello,
Quoted 31 lines · Fabrice Fontaine
Commit
5b3c7a3e7828107eaa9dad49ba2650466277d891added aBR2_PACKAGE_HAS_LIBEGL_WAYLANDdependency to wpebackend-fdo but forget to add it to wpewebkitFixes:
- http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acfSigned-off-by Fabrice Fontaine <[email protected]>--- package/wpewebkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)package/wpewebkit/Config.in +3
-2@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8 -comment "wpewebkit needs an OpenGL ES w/ EGL backend" +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend" depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS depends on !BR2_BINFMT_FLAT - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \ + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEWEBKIT bool "wpewebkit"
package/wpewebkit/Config.in config BR2_PACKAGE_WPEWEBKIT · line 58
Quoted 7 lines
package/wpewebkit/Config.in +1
-0@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT depends on BR2_USE_WCHAR # icu, libsoup depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS select BR2_PACKAGE_CAIRO select BR2_PACKAGE_CAIRO_PNG
This is not correct. The short version of the story is tat WPE WebKit itself does not require Wayland, only wpebackend-fdo uses Wayland.
The long storey: WPE WebKit itself uses generic interfaces from libwpe, and the programs which use WPE WebKit are responsible for instructing libwpe to load a "WPE backend plug-in" which provides a concrete implementation of its interfaces. One such backend is provided by wpebackend-fdo. This "FDO backend" is what actually requires Wayland, but there are others which do not require Wayland. For example the RDK backend [1] can be configured to use dispmanx on the RaspberryPi directly, or the Vivante i.MX6 proprietary driver ? no Wayland involved!
Regards,
?Adri?n
---
[1] https://github.com/WebPlatformForEmbedded/WPEBackend-rdk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190517/6da2781b/attachment.asc>
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Dear Adrian,
Le jeu. 16 mai 2019 ? 23:28, Adrian Perez de Castro <[email protected]> a ?crit :
Quoted 47 lines
Hello,
Quoted 31 lines · Fabrice Fontaine
Commit
5b3c7a3e7828107eaa9dad49ba2650466277d891added aBR2_PACKAGE_HAS_LIBEGL_WAYLANDdependency to wpebackend-fdo but forget to add it to wpewebkitFixes:
- http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acfSigned-off-by Fabrice Fontaine <[email protected]>--- package/wpewebkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)package/wpewebkit/Config.in +3
-2@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8 -comment "wpewebkit needs an OpenGL ES w/ EGL backend" +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend" depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS depends on !BR2_BINFMT_FLAT - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \ + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEWEBKIT bool "wpewebkit"package/wpewebkit/Config.in config BR2_PACKAGE_WPEWEBKIT · line 58
Quoted 7 lines
package/wpewebkit/Config.in +1
-0@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT depends on BR2_USE_WCHAR # icu, libsoup depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS select BR2_PACKAGE_CAIRO select BR2_PACKAGE_CAIRO_PNGThis is not correct. The short version of the story is tat WPE WebKit itself does not require Wayland, only wpebackend-fdo uses Wayland.
Quoted 9 lines
The long storey: WPE WebKit itself uses generic interfaces from libwpe, and the programs which use WPE WebKit are responsible for instructing libwpe to load a "WPE backend plug-in" which provides a concrete implementation of its interfaces. One such backend is provided by wpebackend-fdo. This "FDO backend" is what actually requires Wayland, but there are others which do not require Wayland. For example the RDK backend [1] can be configured to use dispmanx on the RaspberryPi directly, or the Vivante i.MX6 proprietary driver ? no Wayland involved!
Thanks for the feedback however what do you suggest to fix the build failure raised by commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 which allows wpewebkit to select wpebackend-fdo without complying with its new libegl-wayland dependency?
I'm not an expert in wpewebkit but I assume that FDO backend is selected because this is the only available backend in buildroot (I didn't find RDK). So I also assume that we can't drop this select to make FDO backend optional (at least until we have other available backends).
Quoted 6 lines
Regards,
?Adri?n---
[1] https://github.com/WebPlatformForEmbedded/WPEBackend-rdk
Best Regards,
Fabrice
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
In reply to Adrian Perez de CastroHello Adrian,
Quoted 2 lines · On Fri, 17 May 2019 00:28:28 +0300 Adrian Perez de Castro <[email protected]>…
This is not correct. The short version of the story is tat WPE WebKit itself does not require Wayland, only wpebackend-fdo uses Wayland.
That does not matter.
If A selects B, and B depends on C, then A *must* replicate the "depends on C". That's due to how Kconfig work, and it's totally unrelated to the fact that A doesn't use C directly in practice.
If you don't replicate this "depends on", then Kconfig allows you to enable "A" even if the dependencies for "B" are not satisfied, causing the build failure that Fabrice is fixing.
So, Fabrice patch is correct.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Hello Adrian, All,
Il 17/05/2019 09:08, Thomas Petazzoni ha scritto:
Quoted 14 lines
Hello Adrian,
Quoted 2 lines · On Fri, 17 May 2019 00:28:28 +0300 Adrian Perez de Castro <[email protected]>…
This is not correct. The short version of the story is tat WPE WebKit itself does not require Wayland, only wpebackend-fdo uses Wayland.
That does not matter.
If A selects B, and B depends on C, then A *must* replicate the "depends on C". That's due to how
Kconfigwork, and it's totally unrelated to the fact that A doesn't use C directly in practice.
Quoted 5 lines
If you don't replicate this "depends on", then
Kconfigallows you to enable "A" even if the dependencies for "B" are not satisfied, causing the build failure that Fabrice is fixing.So, Fabrice patch is correct.
Thomas and Fabrice are correct because wpewebkit in its Config.in:
"select BR2_PACKAGE_WPEBACKEND_FDO"
Probably that's the problem, wpewebkit should not select that specific Backend, but should let to the user the choice about which Backend to use or even none.
This is why I've got confused too.
So Fabrice's patch fixes build failure, but probably we need another patch to add the Backend choice.
What do you think?
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
In reply to Fabrice FontaineHello Fabrice,
Il 16/05/2019 22:12, Fabrice Fontaine ha scritto:
Quoted 8 lines
Commit
5b3c7a3e7828107eaa9dad49ba2650466277d891added aBR2_PACKAGE_HAS_LIBEGL_WAYLANDdependency to wpebackend-fdo but forget to add it to wpewebkitFixes:
- http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acfSigned-off-by Fabrice Fontaine <[email protected]>
Quoted 31 lines
--- package/wpewebkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)package/wpewebkit/Config.in +4
-2@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8 -comment "wpewebkit needs an OpenGL ES w/ EGL backend" +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend" depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS depends on !BR2_BINFMT_FLAT - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \ + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEWEBKIT bool "wpewebkit"@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT depends on BR2_USE_WCHAR # icu, libsoup depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS select BR2_PACKAGE_CAIRO select BR2_PACKAGE_CAIRO_PNG
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Il 16/05/2019 23:35, Giulio Benetti ha scritto:
Quoted 7 lines
Hello Fabrice,
Il 16/05/2019 22:12, Fabrice Fontaine ha scritto:
Quoted 4 lines
Commit
5b3c7a3e7828107eaa9dad49ba2650466277d891added aBR2_PACKAGE_HAS_LIBEGL_WAYLANDdependency to wpebackend-fdo but forget to add it to wpewebkit
Quoted 8 lines
Quoted 6 lines
Fixes:
? -
http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acfSigned-off-by Fabrice Fontaine <[email protected]>Reviewed-by Giulio Benetti <[email protected]>
Please discard this ^^^^^^^^^
Quoted 35 lines
Quoted 23 lines
---
? package/wpewebkit/Config.in | 6 ++++--
? 1 file changed, 4 insertions(+), 2 deletions(-)package/wpewebkit/Config.in +0
-0@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++,wchar, threads, dynamic library, gc
????????? || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \ ????????? || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 ||!BR2_HOST_GCC_AT_LEAST_4_8
package/wpewebkit/Config.in +1
-1-comment "wpewebkit needs an OpenGL ES w/ EGL backend" +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"????? depends on
BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS????? depends on !BR2_BINFMT_FLAT-??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL +??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \+??????? || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
? configBR2_PACKAGE_WPEWEBKIT
????? bool "wpewebkit"package/wpewebkit/Config.in +0
-0@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKITQuoted 8 lines
????? depends on
BR2_USE_WCHAR# icu, libsoup
????? depends onBR2_PACKAGE_HAS_LIBGLES# libepoxy ????? depends onBR2_PACKAGE_HAS_LIBEGL# libepoxy +??? depends onBR2_PACKAGE_HAS_LIBEGL_WAYLAND# wpebackend-fdo ????? depends onBR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS????? selectBR2_PACKAGE_CAIRO
????? selectBR2_PACKAGE_CAIRO_PNG_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
Il 16/05/2019 23:38, Giulio Benetti ha scritto:
Quoted 13 lines
Il 16/05/2019 23:35, Giulio Benetti ha scritto:
Quoted 12 lines
Hello Fabrice,
Il 16/05/2019 22:12, Fabrice Fontaine ha scritto:
Quoted 9 lines
Commit
5b3c7a3e7828107eaa9dad49ba2650466277d891added aBR2_PACKAGE_HAS_LIBEGL_WAYLANDdependency to wpebackend-fdo but forget to add it to wpewebkitFixes:
? -
http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Fabrice Fontaine <[email protected]>Reviewed-by Giulio Benetti <[email protected]>Please discard this ^^^^^^^^^
Sorry, please keep my Reviewed-by. Thanks
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
Quoted 39 lines
Quoted 27 lines
Quoted 27 lines
---
? package/wpewebkit/Config.in | 6 ++++--
? 1 file changed, 4 insertions(+), 2 deletions(-)package/wpewebkit/Config.in +0
-0@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++,wchar, threads, dynamic library, gc
????????? || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \ ????????? || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 ||!BR2_HOST_GCC_AT_LEAST_4_8
package/wpewebkit/Config.in +1
-1-comment "wpewebkit needs an OpenGL ES w/ EGL backend" +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"????? depends on
BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS????? depends on !BR2_BINFMT_FLAT-??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL +??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \+??????? || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
? configBR2_PACKAGE_WPEWEBKIT
????? bool "wpewebkit"package/wpewebkit/Config.in +0
-0@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT????? depends on
BR2_USE_WCHAR# icu, libsoup
????? depends onBR2_PACKAGE_HAS_LIBGLES# libepoxy ????? depends onBR2_PACKAGE_HAS_LIBEGL# libepoxy +??? depends onBR2_PACKAGE_HAS_LIBEGL_WAYLAND# wpebackend-fdoQuoted 8 lines
Quoted 4 lines
????? depends on
BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS????? selectBR2_PACKAGE_CAIRO
????? selectBR2_PACKAGE_CAIRO_PNG_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni
AppliedPATCH 1/1 package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
In reply to Fabrice FontaineQuoted 11 lines · On Thu, 16 May 2019 22:12:20 +0200 Fabrice Fontaine…
Commit
5b3c7a3e7828107eaa9dad49ba2650466277d891added aBR2_PACKAGE_HAS_LIBEGL_WAYLANDdependency to wpebackend-fdo but forget to add it to wpewebkitFixes:
- http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acfSigned-off-by Fabrice Fontaine <[email protected]>--- package/wpewebkit/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com