Skip to contentSkip to conversation

hw/acpi: ACPI_PCI should depends on both ACPI and PCI

PATCH In review Wei Yang 4 participants 6 messages May 17, 2019 – May 20, 2019

lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH 1/1 hw/acpi: ACPI_PCI should depends on both ACPI and PCI

Pointed out by Philippe Mathieu-Daudé <[email protected]>.

---
 hw/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/acpi/Kconfig +1 -1
index 7265843cc3..7c59cf900b 100644
@@ -25,7 +25,7 @@ config ACPI_NVDIMM
 
 config ACPI_PCI
     bool
-    depends on ACPI
+    depends on ACPI && PCI
 
 config ACPI_VMGENID
     bool
Signature · 1 line
2.19.1
#2 lore raw
In reply to Wei Yang
Quoted 12 lines · On Fri, 17 May 2019 08:51:14 +0800 Wei Yang <[email protected]>…

Pointed out by Philippe Mathieu-Daudé <[email protected]>.

---
 hw/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/acpi/Kconfig +0 -0
index 7265843cc3..7c59cf900b 100644

hw/acpi/Kconfig config ACPI_NVDIMM · line 31

Quoted 8 lines
hw/acpi/Kconfig +1 -1
@@ -25,7 +25,7 @@ config ACPI_NVDIMM
 
 config ACPI_PCI
     bool
-    depends on ACPI
+    depends on ACPI && PCI
 
 config ACPI_VMGENID
     bool

are you sure you didn't miss anything?

On Fri, 17 May 2019 10:37:42 +0200
Philippe Mathieu-Daudé <[email protected]> wrote:

[...]

Quoted 9 lines

config ARM_VIRT

    ...
    select ACPI_PCI

config ACPI_PCI

    bool
    depends on ACPI && PCI
#3 lore raw
Quoted 21 lines · Igor Mammedov
Quoted 18 lines · On Fri, 17 May 2019 08:51:14 +0800 Wei Yang <[email protected]>…

Pointed out by Philippe Mathieu-Daud?? <[email protected]>.

---
 hw/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/acpi/Kconfig +1 -1
index 7265843cc3..7c59cf900b 100644
@@ -25,7 +25,7 @@ config ACPI_NVDIMM
 
 config ACPI_PCI
     bool
-    depends on ACPI
+    depends on ACPI && PCI
 
Quoted 5 lines

hw/acpi/Kconfig config ACPI_NVDIMM · line 31

Quoted 2 lines
hw/acpi/Kconfig +0 -0
 config ACPI_VMGENID
     bool

are you sure you didn't miss anything?

This patch is based on the comment in
http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913

My understanding is not correct?

Quoted 15 lines

On Fri, 17 May 2019 10:37:42 +0200 Philippe Mathieu-Daud?? <[email protected]> wrote:

[...]

Quoted 9 lines

config ARM_VIRT

    ...
    select ACPI_PCI

config ACPI_PCI

    bool
    depends on ACPI && PCI
Signature · 2 lines
Wei Yang
Help you, Help me
#4 lore raw
Quoted 28 lines · On Fri, 17 May 2019 12:59:57 +0000 Wei Yang <[email protected]> wrote:
Quoted 21 lines · Igor Mammedov
Quoted 18 lines · On Fri, 17 May 2019 08:51:14 +0800 Wei Yang <[email protected]>…

Pointed out by Philippe Mathieu-Daud?? <[email protected]>.

---
 hw/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/acpi/Kconfig +1 -1
index 7265843cc3..7c59cf900b 100644
@@ -25,7 +25,7 @@ config ACPI_NVDIMM
 
 config ACPI_PCI
     bool
-    depends on ACPI
+    depends on ACPI && PCI
 
Quoted 5 lines

hw/acpi/Kconfig config ACPI_NVDIMM · line 31

Quoted 2 lines
hw/acpi/Kconfig +0 -0
 config ACPI_VMGENID
     bool

are you sure you didn't miss anything?

Quoted 4 lines

This patch is based on the comment in
http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913

My understanding is not correct?

That wasn't the end of discussion, it continued on until Philippe suggested the below changes

Quoted 17 lines
Quoted 16 lines

On Fri, 17 May 2019 10:37:42 +0200 Philippe Mathieu-Daud?? <[email protected]> wrote:

[...]

Quoted 9 lines

config ARM_VIRT

    ...
    select ACPI_PCI

config ACPI_PCI

    bool
    depends on ACPI && PCI
author
#5 lore raw
Quoted 31 lines · Igor Mammedov
Quoted 28 lines · On Fri, 17 May 2019 12:59:57 +0000 Wei Yang <[email protected]> wrote:
Quoted 26 lines · Igor Mammedov
Quoted 12 lines · On Fri, 17 May 2019 08:51:14 +0800 Wei Yang <[email protected]>…

Pointed out by Philippe Mathieu-Daud?? <[email protected]>.

---
 hw/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/acpi/Kconfig +0 -0
index 7265843cc3..7c59cf900b 100644

hw/acpi/Kconfig config ACPI_NVDIMM · line 31

Quoted 8 lines
hw/acpi/Kconfig +1 -1
@@ -25,7 +25,7 @@ config ACPI_NVDIMM
 
 config ACPI_PCI
     bool
-    depends on ACPI
+    depends on ACPI && PCI
 
 config ACPI_VMGENID
     bool

are you sure you didn't miss anything?

Quoted 8 lines
Quoted 4 lines

This patch is based on the comment in
http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913

My understanding is not correct?

That wasn't the end of discussion, it continued on until Philippe suggested the below changes

Yep, just see the latest reply.

Quoted 17 lines
Quoted 17 lines
Quoted 16 lines

On Fri, 17 May 2019 10:37:42 +0200 Philippe Mathieu-Daud?? <[email protected]> wrote:

[...]

Quoted 9 lines

config ARM_VIRT

    ...
    select ACPI_PCI

config ACPI_PCI

    bool
    depends on ACPI && PCI
Signature · 2 lines
Wei Yang
Help you, Help me