Skip to contentSkip to conversation

ARM: dts: imx: Fix the AR803X phy-mode

PATCH Applied Fabio Estevam 6 participants 10 messages Apr 3, 2019 – May 18, 2019

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v3 1/1 ARM: dts: imx: Fix the AR803X phy-mode

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

 arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 2 +-
 arch/arm/boot/dts/imx6dl-riotboard.dts        | 2 +-
 arch/arm/boot/dts/imx6q-ba16.dtsi             | 2 +-
 arch/arm/boot/dts/imx6q-marsboard.dts         | 2 +-
 arch/arm/boot/dts/imx6q-tbs2910.dts           | 2 +-
 arch/arm/boot/dts/imx6qdl-apf6.dtsi           | 2 +-
 arch/arm/boot/dts/imx6qdl-sabreauto.dtsi      | 2 +-
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi        | 2 +-
 arch/arm/boot/dts/imx6qdl-sr-som.dtsi         | 2 +-
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi      | 2 +-
 arch/arm/boot/dts/imx6sx-sabreauto.dts        | 2 +-
 arch/arm/boot/dts/imx6sx-sdb.dtsi             | 2 +-
 arch/arm/boot/dts/imx7d-pico.dtsi             | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi +1 -1
index fb01fa6e4224..3cae139e6396 100644
@@ -216,7 +216,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <10>;
 	phy-reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
 	phy-supply = <&reg_enet>;
arch/arm/boot/dts/imx6dl-riotboard.dts +1 -1
index 65c184bb8fb0..d9de49efa802 100644
@@ -92,7 +92,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
arch/arm/boot/dts/imx6q-ba16.dtsi +1 -1
index adc9455e42c7..37c63402157b 100644
@@ -171,7 +171,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
 
arch/arm/boot/dts/imx6q-marsboard.dts +1 -1
index d8ccb533b6b7..84b30bd6908f 100644
@@ -110,7 +110,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6q-tbs2910.dts +1 -1
index 2ce8399a10ba..bfff87ce2e1f 100644
@@ -98,7 +98,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6qdl-apf6.dtsi +1 -1
index 1ebf29f43a24..4738c3c1ab50 100644
@@ -51,7 +51,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <10>;
 	phy-reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
 	status = "okay";
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi +1 -1
index 1280de50a984..f3404dd10537 100644
@@ -292,7 +292,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
 	fsl,err006687-workaround-present;
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +1 -1
index a0705066ccba..185fb17a3500 100644
@@ -202,7 +202,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6qdl-sr-som.dtsi +1 -1
index 4ccb7afc4b35..6d7f6b9035bc 100644
@@ -53,7 +53,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <2>;
 	phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
 	status = "okay";
arch/arm/boot/dts/imx6qdl-wandboard.dtsi +1 -1
index b7d5fb421404..50d9a989e06a 100644
@@ -224,7 +224,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio3 29 GPIO_ACTIVE_LOW>;
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
arch/arm/boot/dts/imx6sx-sabreauto.dts +1 -1
index b0ee324afe58..315044ccd65f 100644
@@ -75,7 +75,7 @@
 &fec1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy1>;
 	fsl,magic-packet;
 	status = "okay";
arch/arm/boot/dts/imx6sx-sdb.dtsi +1 -1
index 08ede56c3f10..f6972deb5e39 100644
@@ -191,7 +191,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet1>;
 	phy-supply = <&reg_enet_3v3>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy1>;
 	phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
 	status = "okay";
arch/arm/boot/dts/imx7d-pico.dtsi +1 -1
index 3fd595a71202..6f50ebf31a0a 100644
@@ -92,7 +92,7 @@
 			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
 	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
 	assigned-clock-rates = <0>, <100000000>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
 	fsl,magic-packet;
 	phy-reset-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#1 lore raw
Quoted 26 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

Quoted 8 lines

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
In reply to Fabio Estevam

Hello,

Quoted 34 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

Quoted 6 lines

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

Please add this commit to the v5.1.x stable queue to resolve NFS root breakage in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x stable series as well, it does not cause problems for pre-v5.1 but results in NFS root breakage for v5.1.x.

TIA!

Quoted 185 lines
 arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 2 +-
 arch/arm/boot/dts/imx6dl-riotboard.dts        | 2 +-
 arch/arm/boot/dts/imx6q-ba16.dtsi             | 2 +-
 arch/arm/boot/dts/imx6q-marsboard.dts         | 2 +-
 arch/arm/boot/dts/imx6q-tbs2910.dts           | 2 +-
 arch/arm/boot/dts/imx6qdl-apf6.dtsi           | 2 +-
 arch/arm/boot/dts/imx6qdl-sabreauto.dtsi      | 2 +-
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi        | 2 +-
 arch/arm/boot/dts/imx6qdl-sr-som.dtsi         | 2 +-
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi      | 2 +-
 arch/arm/boot/dts/imx6sx-sabreauto.dts        | 2 +-
 arch/arm/boot/dts/imx6sx-sdb.dtsi             | 2 +-
 arch/arm/boot/dts/imx7d-pico.dtsi             | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi +1 -1
index fb01fa6e4224..3cae139e6396 100644
@@ -216,7 +216,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <10>;
 	phy-reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
 	phy-supply = <&reg_enet>;
arch/arm/boot/dts/imx6dl-riotboard.dts +1 -1
index 65c184bb8fb0..d9de49efa802 100644
@@ -92,7 +92,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
arch/arm/boot/dts/imx6q-ba16.dtsi +1 -1
index adc9455e42c7..37c63402157b 100644
@@ -171,7 +171,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	status = "okay";
 };
 
arch/arm/boot/dts/imx6q-marsboard.dts +1 -1
index d8ccb533b6b7..84b30bd6908f 100644
@@ -110,7 +110,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6q-tbs2910.dts +1 -1
index 2ce8399a10ba..bfff87ce2e1f 100644
@@ -98,7 +98,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6qdl-apf6.dtsi +1 -1
index 1ebf29f43a24..4738c3c1ab50 100644
@@ -51,7 +51,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <10>;
 	phy-reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
 	status = "okay";
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi +1 -1
index 1280de50a984..f3404dd10537 100644
@@ -292,7 +292,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
 	fsl,err006687-workaround-present;
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +1 -1
index a0705066ccba..185fb17a3500 100644
@@ -202,7 +202,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
arch/arm/boot/dts/imx6qdl-sr-som.dtsi +1 -1
index 4ccb7afc4b35..6d7f6b9035bc 100644
@@ -53,7 +53,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <2>;
 	phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
 	status = "okay";
arch/arm/boot/dts/imx6qdl-wandboard.dtsi +1 -1
index b7d5fb421404..50d9a989e06a 100644
@@ -224,7 +224,7 @@
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio3 29 GPIO_ACTIVE_LOW>;
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
arch/arm/boot/dts/imx6sx-sabreauto.dts +1 -1
index b0ee324afe58..315044ccd65f 100644
@@ -75,7 +75,7 @@
 &fec1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet1>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy1>;
 	fsl,magic-packet;
 	status = "okay";
arch/arm/boot/dts/imx6sx-sdb.dtsi +1 -1
index 08ede56c3f10..f6972deb5e39 100644
@@ -191,7 +191,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet1>;
 	phy-supply = <&reg_enet_3v3>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy1>;
 	phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
 	status = "okay";
arch/arm/boot/dts/imx7d-pico.dtsi +1 -1
index 3fd595a71202..6f50ebf31a0a 100644
@@ -92,7 +92,7 @@
 			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
 	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
 	assigned-clock-rates = <0>, <100000000>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy0>;
 	fsl,magic-packet;
 	phy-reset-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
Signature · 7 lines
Regards,
George

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#3 lore raw
Quoted 44 lines · George G. Davis

Hello,

Quoted 34 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

Quoted 6 lines

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

Quoted 6 lines

Please add this commit to the v5.1.x stable queue to resolve NFS root breakage in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x stable series as well, it does not cause problems for pre-v5.1 but results in NFS root breakage for v5.1.x.

What's the commit id in Linus's tree? I don't see it.

--
Thanks,
Sasha

#4 lore raw

Le 5/13/19 à 5:45 PM, Sasha Levin a écrit :

Quoted 60 lines · George G. Davis
Quoted 47 lines

Hello,

Quoted 37 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which
has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should
not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

Quoted 6 lines

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

Quoted 11 lines

Please add this commit to the v5.1.x stable queue to resolve NFS root breakage
in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root
breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts
and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x
stable series as well, it does not cause problems for pre-v5.1 but results in
NFS root breakage for v5.1.x.

Quoted 1 line

What's the commit id in Linus's tree? I don't see it.

That would be 6d4cd041f0af5b4c8fc742b4a68eac22e420e28c ("net: phy:
at803x: disable delay only for RGMII mode").

I would use that as a Fixes: tag BTW.

Signature · 1 line
Florian
#5 lore raw
In reply to Sasha Levin
Quoted 45 lines · Sasha Levin
Quoted 44 lines · George G. Davis

Hello,

Quoted 40 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

Quoted 8 lines
Quoted 6 lines

Please add this commit to the v5.1.x stable queue to resolve NFS root breakage in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x stable series as well, it does not cause problems for pre-v5.1 but results in NFS root breakage for v5.1.x.

What's the commit id in Linus's tree? I don't see it.

Er, um, sorry, it was deferred to linux-next commit 68e9c97161b3 ("serial:
sh-sci: disable DMA for uart_console"), which quite frankly rather annoyed me personally since linux-next commit 68e9c97161b3 is required to fix a regression caused by v5.1 commit 6d4cd041f0af. In my opinion, linux-next commit 68e9c97161b3 really should have been pushed to the v5.1 release, earlier, due to the noted regression, but I'm happy to wait for linux-next commit 68e9c97161b3 to make it to Linus's tree before propagating it to linux-stable. Meanwhile, I wanted to let you know that v5.1.x is rather broken, in this regard, on i.MX6 as-is for now.

Quoted 4 lines

--
Thanks,
Sasha

Signature · 2 lines
Regards,
George
maintainer
#6 lore raw
Quoted 55 lines · George G. Davis
Quoted 45 lines · Sasha Levin
Quoted 44 lines · George G. Davis

Hello,

Quoted 40 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

Quoted 8 lines
Quoted 6 lines

Please add this commit to the v5.1.x stable queue to resolve NFS root breakage in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x stable series as well, it does not cause problems for pre-v5.1 but results in NFS root breakage for v5.1.x.

What's the commit id in Linus's tree? I don't see it.

Quoted 7 lines

Er, um, sorry, it was deferred to linux-next commit 68e9c97161b3 ("serial:
sh-sci: disable DMA for uart_console"), which quite frankly rather annoyed me personally since linux-next commit 68e9c97161b3 is required to fix a regression caused by v5.1 commit 6d4cd041f0af. In my opinion, linux-next commit 68e9c97161b3 really should have been pushed to the v5.1 release, earlier, due to the noted regression, but I'm happy to wait for linux-next commit 68e9c97161b3 to make it to Linus's tree before propagating it to linux-stable.

We'll happily take it once it makes it into Linus's tree and into a release.

Quoted 2 lines

Meanwhile, I wanted to let you know that v5.1.x is rather broken, in this regard, on i.MX6 as-is for now.

This would be something we can't do much about, but given it's an important fix it should make it into Linus's tree very soon, right?

--
Sasha

#7 lore raw

Hello Sasha,

Quoted 64 lines · Sasha Levin
Quoted 55 lines · George G. Davis
Quoted 45 lines · Sasha Levin
Quoted 44 lines · George G. Davis

Hello,

Quoted 40 lines · Fabio Estevam

Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs.

The end result is that the boards can no longer obtain an IP address via UDHCP, for example.

Quoting Andrew Lunn:

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt:

"RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)"

Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking.

Based on the initial submission from Steve Twiss for the imx6qdl-sabresd.

---
Changes since v2:
- Also fixed imx6q-ba16
- Removed stable tag as it does not apply cleanly on older stable trees. I can manually generate versions for stable trees after this one hits mainline.

Quoted 8 lines
Quoted 6 lines

Please add this commit to the v5.1.x stable queue to resolve NFS root breakage in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x stable series as well, it does not cause problems for pre-v5.1 but results in NFS root breakage for v5.1.x.

What's the commit id in Linus's tree? I don't see it.

Quoted 7 lines

Er, um, sorry, it was deferred to linux-next commit 68e9c97161b3 ("serial:
sh-sci: disable DMA for uart_console"), which quite frankly rather annoyed me personally since linux-next commit 68e9c97161b3 is required to fix a regression caused by v5.1 commit 6d4cd041f0af. In my opinion, linux-next commit 68e9c97161b3 really should have been pushed to the v5.1 release, earlier, due to the noted regression, but I'm happy to wait for linux-next commit 68e9c97161b3 to make it to Linus's tree before propagating it to linux-stable.

Quoted 8 lines

We'll happily take it once it makes it into Linus's tree and into a release.

Quoted 2 lines

Meanwhile, I wanted to let you know that v5.1.x is rather broken, in this regard, on i.MX6 as-is for now.

This would be something we can't do much about, but given it's an important fix it should make it into Linus's tree very soon, right?

Yes, it will hopefully reach Linus's tree soon. Apologies for my impatience. :)

Quoted 3 lines

--
Sasha

Signature · 2 lines
Regards,
George
#8 lore raw

Hello Sasha,

Quoted 6 lines · George G. Davis
Quoted 5 lines · Sasha Levin
Quoted 4 lines · George G. Davis
Quoted 3 lines · Sasha Levin
Quoted 1 line · George G. Davis

On Wed, Apr 03, 2019 at 07:12:41PM -0300, Fabio Estevam wrote:

What's the commit id in Linus's tree? I don't see it.

Finally:

commit 0672d22a19244cdb0e5c753125c1a55a120db5d0 upstream.

Quoted 10 lines
Quoted 8 lines

We'll happily take it once it makes it into Linus's tree and into a release.

Quoted 2 lines

Meanwhile, I wanted to let you know that v5.1.x is rather broken, in this regard, on i.MX6 as-is for now.

This would be something we can't do much about, but given it's an important fix it should make it into Linus's tree very soon, right?

Yes, it will hopefully reach Linus's tree soon. Apologies for my impatience. :)

Again, apologies for my impatience!

TIA!

Signature · 2 lines
Regards,
George
maintainer
#9 lore raw
Quoted 5 lines · George G. Davis

Hello Sasha,

Quoted 2 lines · George G. Davis
Quoted 1 line · Sasha Levin

On Mon, May 13, 2019 at 09:16:07PM -0400, George G. Davis wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines · Sasha Levin
Quoted 3 lines · George G. Davis
Quoted 1 line · Fabio Estevam

What's the commit id in Linus's tree? I don't see it.

Finally:

commit 0672d22a19244cdb0e5c753125c1a55a120db5d0 upstream.

Now queued up, thanks.

greg k-h