Skip to contentSkip to conversation

package/wpewebkit: needs gcc >= 6

PATCH New Fabrice Fontaine 3 participants 3 messages May 17, 2019 – May 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wpewebkit: needs gcc >= 6

gcc requirement has been bumped from gcc 5 to gcc 6 since
https://trac.webkit.org/browser/webkit/trunk/CMakeLists.txt?rev=231152

Fixes:
- http://autobuild.buildroot.org/results/304956dda8e580cb39107e57a139cd1ae08ee655

---
 package/wpewebkit/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/wpewebkit/Config.in +3 -3
index 15db924829..39f64c4e54 100644
@@ -28,12 +28,12 @@ config BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT
 	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R2
 	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R5
 
-comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gcc >= 4.8, host gcc >= 4.8"
+comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gcc >= 6, host gcc >= 4.8"
 	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
 	depends on !BR2_BINFMT_FLAT
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
 		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
-		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_6 || !BR2_HOST_GCC_AT_LEAST_4_8
 
 comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
 	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
@@ -47,7 +47,7 @@ config BR2_PACKAGE_WPEWEBKIT
 	depends on !BR2_BINFMT_FLAT # icu
 	depends on BR2_INSTALL_LIBSTDCPP # harfbuzz, icu
 	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, icu, libsoup
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6
 	depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu
 	depends on BR2_USE_WCHAR # icu, libsoup
 	depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/wpewebkit: needs gcc >= 6

Hi,

Quoted 7 lines · Fabrice Fontaine

gcc requirement has been bumped from gcc 5 to gcc 6 since
https://trac.webkit.org/browser/webkit/trunk/CMakeLists.txt?rev=231152

Fixes:
- http://autobuild.buildroot.org/results/304956dda8e580cb39107e57a139cd1ae08ee655

Quoted 10 lines
---
 package/wpewebkit/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/wpewebkit/Config.in +0 -0
index 15db924829..39f64c4e54 100644
@@ -28,12 +28,12 @@ config BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT
 	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R2

package/wpewebkit/Config.in config BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT · line 36

Quoted 10 lines
package/wpewebkit/Config.in +2 -2
 	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R5
 
-comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gcc >= 4.8, host gcc >= 4.8"
+comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gcc >= 6, host gcc >= 4.8"
 	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
 	depends on !BR2_BINFMT_FLAT
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
 		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
-		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_6 || !BR2_HOST_GCC_AT_LEAST_4_8

Good catch, somehow we missed this when the package was first added in upstream Buildroot ? probably because I used as basis for it the files we had in a BR2_EXTERNAL for 2.20.x. O:-)

Quoted 14 lines
package/wpewebkit/Config.in +1 -1
 comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
 	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
@@ -47,7 +47,7 @@ config BR2_PACKAGE_WPEWEBKIT
 	depends on !BR2_BINFMT_FLAT # icu
 	depends on BR2_INSTALL_LIBSTDCPP # harfbuzz, icu
 	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, icu, libsoup
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6
 	depends on BR2_HOST_GCC_AT_LEAST_4_8 # icu
 	depends on BR2_USE_WCHAR # icu, libsoup
 	depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
Signature · 1 line
2.20.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190517/c757c9e1/attachment.asc>

#2 lore raw

PATCH 1/1 package/wpewebkit: needs gcc >= 6

In reply to Fabrice Fontaine
Quoted 10 lines · On Fri, 17 May 2019 15:25:28 +0200 Fabrice Fontaine…

gcc requirement has been bumped from gcc 5 to gcc 6 since
https://trac.webkit.org/browser/webkit/trunk/CMakeLists.txt?rev=231152

Fixes:
- http://autobuild.buildroot.org/results/304956dda8e580cb39107e57a139cd1ae08ee655

---
 package/wpewebkit/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com