staging: rtl8723bs: hal: odm_HWConfig: odm_HWConfig: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS"
PATCH v2 1/1 staging: rtl8723bs: hal: odm_HWConfig: odm_HWConfig: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS"
This patch fixes below warnings reported by coccicheck
drivers/staging/rtl8723bs/hal/odm_HWConfig.c:501:4-10: Unneeded
variable: "result". Return "HAL_STATUS_SUCCESS" on line 526
-----
Changes in v2:
- fixed typo in commit message
---
--- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8723bs/hal/odm_HWConfig.c +1 -3
@@ -498,8 +498,6 @@ HAL_STATUS ODM_ConfigBBWithHeaderFile(HAL_STATUS ODM_ConfigMACWithHeaderFile (PDM_ODM_T pDM_Odm) { -u8 result =HAL_STATUS_SUCCESS ; - ODM_RT_TRACE( pDM_Odm, ODM_COMP_INIT,
@@ -523,5 +521,5 @@ HAL_STATUS ODM_ConfigMACWithHeaderFile(PDM_ODM_T pDM_Odm)READ_AND_CONFIG (8723B , _MAC_REG); -return result; +return HAL_STATUS_SUCCESS ; }
Signature · 1 line
2.7.4
Greg Kroah-Hartman
maintainerQuoted 29 lines · Hariprasad Kelam
This patch fixes below warnings reported by coccicheck
drivers/staging/rtl8723bs/hal/odm_HWConfig.c:501:4-10: Unneeded
variable: "result". Return "HAL_STATUS_SUCCESS" on line 526Signed-off-by Hariprasad Kelam <[email protected]>-----
Changes in v2:
- fixed typo in commit message
------ drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/rtl8723bs/hal/odm_HWConfig.c +0
-2@@ -498,8 +498,6 @@ HAL_STATUS ODM_ConfigBBWithHeaderFile(HAL_STATUS ODM_ConfigMACWithHeaderFile (PDM_ODM_T pDM_Odm) { -u8 result =HAL_STATUS_SUCCESS ; - ODM_RT_TRACE( pDM_Odm, ODM_COMP_INIT,
drivers/staging/rtl8723bs/hal/odm_HWConfig.c HAL_STATUS ODM_ConfigMACWithHeaderFile(PDM_ODM_T pDM_Odm) · line 525
Quoted 6 lines
drivers/staging/rtl8723bs/hal/odm_HWConfig.c +1
-1@@ -523,5 +521,5 @@ HAL_STATUS ODM_ConfigMACWithHeaderFile(PDM_ODM_T pDM_Odm)READ_AND_CONFIG (8723B , _MAC_REG); -return result; +return HAL_STATUS_SUCCESS ; }
This whole function should really be reduced to just one line (the trace stuff is not needed), and as this can not fail, it should not be returning a value.
And if it can be one line, then why is it a function at all? It's only called in one place.
thanks,
greg k-h