Skip to contentSkip to conversation

package/suricata: fix static build with pcap

PATCH New Vadim Kochan 2 participants 3 messages May 19, 2019 – May 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/suricata: fix static build with pcap

Build of suricata fails with BR2_STATIC_LIBS=y because pcap requires libnl which can't be found, so use pkg-config to obtain libpcap dependencies.

Fixes:

	http://autobuild.buildroot.net/results/b5fdf31db6897a9612a0badc7c4bd3e54f031308/
---
 package/suricata/suricata.mk | 2 ++
 1 file changed, 2 insertions(+)
package/suricata/suricata.mk +2 -0
index e5884cdfe4..503d76e6a8 100644
@@ -123,4 +123,6 @@ define SURICATA_INSTALL_INIT_SYSTEMD
 		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/suricata.service
 endef
 
+SURICATA_CONF_OPTS += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libpcap`"
+
 $(eval $(autotools-package))
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 package/suricata: fix static build with pcap

Dear Vadim,

Le dim. 19 mai 2019 ? 22:09, Vadim Kochan <[email protected]> a ?crit :

Quoted 4 lines

Build of suricata fails with BR2_STATIC_LIBS=y because pcap requires libnl which can't be found, so use pkg-config to obtain libpcap dependencies.

Thanks for your patch however I already sent a patch's serie one month ago that also fixed this pcap issue:
https://patchwork.ozlabs.org/project/buildroot/list/?series=104482.
I think it's time to merge it.

Quoted 21 lines

Fixes:

        http://autobuild.buildroot.net/results/b5fdf31db6897a9612a0badc7c4bd3e54f031308/
---
 package/suricata/suricata.mk | 2 ++
 1 file changed, 2 insertions(+)
package/suricata/suricata.mk +2 -1
index e5884cdfe4..503d76e6a8 100644
@@ -123,4 +123,6 @@ define SURICATA_INSTALL_INIT_SYSTEMD
                $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/suricata.service
 endef
 
+SURICATA_CONF_OPTS += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libpcap`"
+
 $(eval $(autotools-package))
--
Quoted 2 lines

2.21.0

Best Regards,

Fabrice

#2 lore raw

PATCH 1/1 package/suricata: fix static build with pcap

Hi Fabrice,

Quoted 4 lines · Fabrice Fontaine

Dear Vadim,

Le dim. 19 mai 2019 ? 22:09, Vadim Kochan <[email protected]> a ?crit :

Quoted 1 line
Quoted 8 lines
Quoted 3 lines

Build of suricata fails with BR2_STATIC_LIBS=y because pcap requires libnl which can't be found, so use pkg-config to obtain libpcap dependencies.

Thanks for your patch however I already sent a patch's serie one month ago that also fixed this pcap issue:
https://patchwork.ozlabs.org/project/buildroot/list/?series=104482.
I think it's time to merge it.

Quoted 1 line

OK, I marked it as 'Superseded' :)

Quoted 24 lines
Quoted 20 lines

Fixes:

        http://autobuild.buildroot.net/results/b5fdf31db6897a9612a0badc7c4bd3e54f031308/
---
 package/suricata/suricata.mk | 2 ++
 1 file changed, 2 insertions(+)
package/suricata/suricata.mk +2 -1
index e5884cdfe4..503d76e6a8 100644
@@ -123,4 +123,6 @@ define SURICATA_INSTALL_INIT_SYSTEMD
                $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/suricata.service
 endef
 
+SURICATA_CONF_OPTS += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libpcap`"
+
 $(eval $(autotools-package))
--
Quoted 2 lines

2.21.0

Best Regards,

Quoted 1 line

Fabrice

Regards,
Vadim Kochan