Skip to contentSkip to conversation

ata: ahci: drop read-only ahci_ioports members

PATCH New Christian Gmeiner 3 participants 3 messages May 14, 2019 – May 19, 2019 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ata: ahci: drop read-only ahci_ioports members

Also get rid of ahci_setup_port(..).

---
 drivers/ata/ahci.c | 12 ------------
 include/ahci.h     |  2 --
 2 files changed, 14 deletions(-)
drivers/ata/ahci.c +0 -12
index 188d843197..e3135bb75f 100644
@@ -55,17 +55,6 @@ __weak void __iomem *ahci_port_base(void __iomem *base, u32 port)
 	return base + 0x100 + (port * 0x80);
 }
 
-
-static void ahci_setup_port(struct ahci_ioports *port, void __iomem *base,
-			    unsigned int port_idx)
-{
-	base = ahci_port_base(base, port_idx);
-
-	port->cmd_addr = base;
-	port->scr_addr = base + PORT_SCR;
-}
-
-
 #define msleep(a) udelay(a * 1000)
 
 static void ahci_dcache_flush_range(unsigned long begin, unsigned long len)
@@ -240,7 +229,6 @@ static int ahci_host_init(struct ahci_uc_priv *uc_priv)
 			continue;
 		uc_priv->port[i].port_mmio = ahci_port_base(mmio, i);
 		port_mmio = (u8 *)uc_priv->port[i].port_mmio;
-		ahci_setup_port(&uc_priv->port[i], mmio, i);
 
 		/* make sure port is not active */
 		tmp = readl(port_mmio + PORT_CMD);
include/ahci.h +0 -2
index b42df6c77e..fb96dd8861 100644
@@ -134,8 +134,6 @@ struct ahci_sg {
 };
 
 struct ahci_ioports {
-	void __iomem	*cmd_addr;
-	void __iomem	*scr_addr;
 	void __iomem	*port_mmio;
 	struct ahci_cmd_hdr	*cmd_slot;
 	struct ahci_sg		*cmd_tbl_sg;
Signature · 1 line
2.21.0
#2 lore raw

PATCH 1/1 ata: ahci: drop read-only ahci_ioports members

In reply to Christian Gmeiner
Quoted 3 lines · Christian Gmeiner

Also get rid of ahci_setup_port(..).

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190519/93fd1616/attachment.sig>