Skip to contentSkip to conversation

dt-bindings: imx-ocotp: Add fusable-node property

RFC In review Peng Fan 3 participants 8 messages May 20, 2019 – Jun 14, 2019

Subsystems (3)
lore
Share & tools
lore

Peng Fan

author
#0 lore raw

RFC 1/2 dt-bindings: imx-ocotp: Add fusable-node property

Introduce fusable-node property for i.MX OCOTP driver. The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,
https://source.codeaurora.org/external/imx/uboot-imx/tree/arch/arm/mach-imx/mx6/module_fuse.c?h=imx_v2018.03_4.14.98_2.0.0_ga#n149
But this approach is will not work if kernel dts node path changed.

There are two approaches to resolve:

1. This patch is to add a fusable-node property, and Firmware will parse the property and read fuse to decide whether to disable or keeep enable the nodes.

2. There is another approach is that add nvmem-cells for all nodes that could be disabled(fused). Then in each linux driver to use nvmem api to detect fused or not, or in linux driver common code to check device functionable or not with nvmem API.

To make it easy to work, we choose [1] here. Please advise whether it is acceptable, because the property is not used by linux driver in approach [1]. Or you prefer [2] or please advise if any better solution.

Thanks.

 Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/nvmem/imx-ocotp.txt +5 -0
index 7a999a135e56..e9a998588dbd 100644
@@ -21,6 +21,8 @@ Required properties:
 
 Optional properties:
 - read-only: disable write access
+- fusable-node: array of phandles with reg base and bit offset, this
+		property is used by Firmware to runtime disable nodes.
 
 Optional Child nodes:
 
@@ -42,4 +44,7 @@ Example:
 		tempmon_temp_grade: temp-grade@20 {
 			reg = <0x20 4>;
 		};
+
+		fusable-node = <&usdhc1 0x10 4
+				&usdhc2 0x10 5>;
 	};
Signature · 1 line
2.16.4
author
#1 lore raw

RFC 2/2 ARM: dts: imx6ull/z: add fusable-node property

Add fusable-node property for OCOTP

---
 arch/arm/boot/dts/imx6ull.dtsi | 7 +++++++
 arch/arm/boot/dts/imx6ulz.dtsi | 6 ++++++
 2 files changed, 13 insertions(+)
arch/arm/boot/dts/imx6ull.dtsi +7 -0
index 22e4a307fa59..b616ed6ee4bf 100644
@@ -32,6 +32,13 @@
 
 &ocotp {
 	compatible = "fsl,imx6ull-ocotp", "syscon";
+
+	fusable-node = <&tsc	0xc 22
+			&can1	0xc 26
+			&can2	0xc 27
+			&usdhc1 0x10 4
+			&usdhc2 0x10 5
+			>;
 };
 
 &usdhc1 {
arch/arm/boot/dts/imx6ulz.dtsi +6 -0
index 0b5f1a763567..8edd9008e38b 100644
@@ -19,6 +19,12 @@
 	};
 };
 
+&ocotp {
+	fusable-node = <&usdhc1 0x10 4
+			&usdhc2 0x10 5
+			>;
+};
+
 /delete-node/ &adc1;
 /delete-node/ &ecspi3;
 /delete-node/ &ecspi4;
Signature · 1 line
2.16.4
#2 lore raw
In reply to Peng Fan
Quoted 30 lines · Peng Fan

Introduce fusable-node property for i.MX OCOTP driver. The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,
https://source.codeaurora.org/external/imx/uboot-imx/tree/arch/arm/mach-imx/mx6/module_fuse.c?h=imx_v2018.03_4.14.98_2.0.0_ga#n149
But this approach is will not work if kernel dts node path changed.

There are two approaches to resolve:

1. This patch is to add a fusable-node property, and Firmware will parse the property and read fuse to decide whether to disable or keeep enable the nodes.

2. There is another approach is that add nvmem-cells for all nodes that could be disabled(fused). Then in each linux driver to use nvmem api to detect fused or not, or in linux driver common code to check device functionable or not with nvmem API.

Quoted 3 lines

To make it easy to work, we choose [1] here. Please advise whether it is acceptable, because the property is not used by linux driver in approach [1]. Or you prefer [2] or please advise if any better solution.

Couldn't firmware parse nvmem-cells? Even without a full nvmem subsystem it would be possible for imx-specific code to walk the entire device tree, parse nvmem-cells and disable nodes which are disabled by fuse.

--
Regards,
Leonard

author
#3 lore raw
Quoted 36 lines

Subject: Re: [RFC 1/2] dt-bindings: imx-ocotp: Add fusable-node property

Quoted 10 lines · Peng Fan

Introduce fusable-node property for i.MX OCOTP driver. The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

Quoted 6 lines

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,

https://source.codeaurora.org/external/imx/uboot-imx/tree/arch/arm/mac

Quoted 7 lines

h-imx/mx6/module_fuse.c?h=imx_v2018.03_4.14.98_2.0.0_ga#n149 But this approach is will not work if kernel dts node path changed.

There are two approaches to resolve:

1. This patch is to add a fusable-node property, and Firmware will parse the property and read fuse to decide whether to disable or keeep

enable

Quoted 8 lines

the nodes.

2. There is another approach is that add nvmem-cells for all nodes that could be disabled(fused). Then in each linux driver to use nvmem api to detect fused or not, or in linux driver common code to check device functionable or not with nvmem API.

Quoted 7 lines
Quoted 3 lines

To make it easy to work, we choose [1] here. Please advise whether it is acceptable, because the property is not used by linux driver in approach [1]. Or you prefer [2] or please advise if any better solution.

Couldn't firmware parse nvmem-cells? Even without a full nvmem subsystem it would be possible for imx-specific code to walk the entire device tree, parse nvmem-cells and disable nodes which are disabled by fuse.

Firmware could parse nvmem-cells, but there are lots of modules that could be fused. If using nvmem-cells, that means need to add nvmem property for all the modules that could be fused. To make is looks cleaner, so introduced a fusable-node property.

Regards,
Peng.

Quoted 4 lines

--
Regards,
Leonard

author
#4 lore raw
In reply to Peng Fan

Hi Rob, Srinivas

Quoted 1 line

Subject: [RFC 1/2] dt-bindings: imx-ocotp: Add fusable-node property

Do you have any comments about this patch?

Thanks,
Peng.

Quoted 65 lines

Introduce fusable-node property for i.MX OCOTP driver.
The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,
https://source.codeaurora.org/external/imx/uboot-imx/tree/arch/arm/mach
-imx/mx6/module_fuse.c?h=imx_v2018.03_4.14.98_2.0.0_ga#n149 But this approach is will not work if kernel dts node path changed.

There are two approaches to resolve:

1. This patch is to add a fusable-node property, and Firmware will parse the property and read fuse to decide whether to disable or keeep enable the nodes.

2. There is another approach is that add nvmem-cells for all nodes that could be disabled(fused). Then in each linux driver to use nvmem api to detect fused or not, or in linux driver common code to check device functionable or not with nvmem API.

To make it easy to work, we choose [1] here. Please advise whether it is acceptable, because the property is not used by linux driver in approach [1]. Or you prefer [2] or please advise if any better solution.

Thanks.

 Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/nvmem/imx-ocotp.txt +5 -1
index 7a999a135e56..e9a998588dbd 100644
@@ -21,6 +21,8 @@ Required properties:
 
 Optional properties:
 - read-only: disable write access
+- fusable-node: array of phandles with reg base and bit offset, this
+		property is used by Firmware to runtime disable nodes.
 
 Optional Child nodes:
 
@@ -42,4 +44,7 @@ Example:
 		tempmon_temp_grade: temp-grade@20 {
 			reg = <0x20 4>;
 		};
+
+		fusable-node = <&usdhc1 0x10 4
+				&usdhc2 0x10 5>;
 	};
--

2.16.4

maintainer
#5 lore raw
In reply to Peng Fan
Quoted 10 lines · Peng Fan

Introduce fusable-node property for i.MX OCOTP driver. The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

Quoted 7 lines

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,
https://source.codeaurora.org/external/imx/uboot-imx/tree/arch/arm/mach-imx/mx6/module_fuse.c?h=imx_v2018.03_4.14.98_2.0.0_ga#n149
But this approach is will not work if kernel dts node path changed.

Why would the path change? The DT should be stable.

Rob

author
#6 lore raw

Hi Rob,

Quoted 29 lines

Subject: Re: [RFC 1/2] dt-bindings: imx-ocotp: Add fusable-node property

Quoted 10 lines · Peng Fan

Introduce fusable-node property for i.MX OCOTP driver. The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

Quoted 7 lines

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour

ce.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Ftree%2Farch%2Far m%2Fm

Quoted 1 line

ach-imx%2Fmx6%2Fmodule_fuse.c%3Fh%3Dimx_v2018.03_4.14.98_2.0.0_g a%23n1

Quoted 1 line

49&amp;data=02%7C01%7Cpeng.fan%40nxp.com%7Ceb74876c943c4471d7f f08d6f05

Quoted 1 line
Quoted 8 lines

2fffb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63696063660 6051306&

Quoted 1 line

amp;sdata=MrjCP0ufBu3uTb1ehTEu2g5eSQuYcho4UxuR9KUFEOA%3D&amp; reserved=

Quoted 1 line

0 But this approach is will not work if kernel dts node path changed.

Why would the path change? The DT should be stable.

It changes sometimes, such as
efb9adb27475 ("ARM: dts: imx6ul: Remove leading zeroes from unit addresses"),

in bootloader, we are using node path, so if the node name changes, the bootloader will fail to disable the node.

Thanks,
Peng.

Quoted 2 lines

Rob

maintainer
#7 lore raw
Quoted 52 lines · Peng Fan

Hi Rob,

Quoted 29 lines

Subject: Re: [RFC 1/2] dt-bindings: imx-ocotp: Add fusable-node property

Quoted 10 lines · Peng Fan

Introduce fusable-node property for i.MX OCOTP driver. The property will only be used by Firmware(eg. U-Boot) to runtime disable the nodes.

Take i.MX6ULL for example, there are several parts that only have limited modules enabled controlled by OCOTP fuse. It is not flexible to provide several dts for the serval parts, instead we could provide one device tree and let Firmware to runtime disable the device tree nodes for those modules that are disable(fused).

Quoted 7 lines

---

Currently NXP vendor use U-Boot to set status to disabled for devices that could not function,
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour

ce.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Ftree%2Farch%2Far m%2Fm

Quoted 1 line

ach-imx%2Fmx6%2Fmodule_fuse.c%3Fh%3Dimx_v2018.03_4.14.98_2.0.0_g a%23n1

Quoted 1 line

49&amp;data=02%7C01%7Cpeng.fan%40nxp.com%7Ceb74876c943c4471d7f f08d6f05

Quoted 1 line
Quoted 8 lines

2fffb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63696063660 6051306&

Quoted 1 line

amp;sdata=MrjCP0ufBu3uTb1ehTEu2g5eSQuYcho4UxuR9KUFEOA%3D&amp; reserved=

Quoted 1 line

0 But this approach is will not work if kernel dts node path changed.

Why would the path change? The DT should be stable.

It changes sometimes, such as
efb9adb27475 ("ARM: dts: imx6ul: Remove leading zeroes from unit addresses"),

in bootloader, we are using node path, so if the node name changes, the bootloader will fail to disable the node.

Thanks,
Peng.

Quoted 2 lines

Rob