Skip to contentSkip to conversation

usb-tablet: fix serial compat property

PATCH In review Gerd Hoffmann 4 participants 4 messages May 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb-tablet: fix serial compat property

s/kbd/tablet/, fixes cut+paste bug.

---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/core/machine.c +1 -1
index 5d046a43e3d2..eb34f53a85b0 100644
@@ -36,7 +36,7 @@ GlobalProperty hw_compat_3_1[] = {
     { "tpm-tis", "ppi", "false" },
     { "usb-kbd", "serial", "42" },
     { "usb-mouse", "serial", "42" },
-    { "usb-kbd", "serial", "42" },
+    { "usb-tablet", "serial", "42" },
     { "virtio-blk-device", "discard", "false" },
     { "virtio-blk-device", "write-zeroes", "false" },
 };
Signature · 1 line
2.18.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · * Gerd Hoffmann ([email protected]) wrote:

s/kbd/tablet/, fixes cut+paste bug.

Quoted 20 lines
---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/core/machine.c +1 -1
index 5d046a43e3d2..eb34f53a85b0 100644
@@ -36,7 +36,7 @@ GlobalProperty hw_compat_3_1[] = {
     { "tpm-tis", "ppi", "false" },
     { "usb-kbd", "serial", "42" },
     { "usb-mouse", "serial", "42" },
-    { "usb-kbd", "serial", "42" },
+    { "usb-tablet", "serial", "42" },
     { "virtio-blk-device", "discard", "false" },
     { "virtio-blk-device", "write-zeroes", "false" },
 };
Signature · 1 line
2.18.1

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

Reviewed-by on v1 1/1
#2 lore raw
In reply to Gerd Hoffmann
Quoted 15 lines · Gerd Hoffmann

s/kbd/tablet/, fixes cut+paste bug.

---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/core/machine.c +0 -0
index 5d046a43e3d2..eb34f53a85b0 100644

hw/core/machine.c GlobalProperty hw_compat_3_1[] = { · line 42

Quoted 8 lines
hw/core/machine.c +1 -1
@@ -36,7 +36,7 @@ GlobalProperty hw_compat_3_1[] = {
     { "tpm-tis", "ppi", "false" },
     { "usb-kbd", "serial", "42" },
     { "usb-mouse", "serial", "42" },
-    { "usb-kbd", "serial", "42" },
+    { "usb-tablet", "serial", "42" },
     { "virtio-blk-device", "discard", "false" },
     { "virtio-blk-device", "write-zeroes", "false" },
 };
Reviewed-by on v1 1/1
#3 lore raw
In reply to Gerd Hoffmann
Quoted 14 lines · Gerd Hoffmann

s/kbd/tablet/, fixes cut+paste bug.

---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/core/machine.c +0 -0
index 5d046a43e3d2..eb34f53a85b0 100644

hw/core/machine.c GlobalProperty hw_compat_3_1[] = { · line 39

Quoted 5 lines
hw/core/machine.c +1 -1
@@ -36,7 +36,7 @@ GlobalProperty hw_compat_3_1[] = {
     { "tpm-tis", "ppi", "false" },
     { "usb-kbd", "serial", "42" },
     { "usb-mouse", "serial", "42" },
-    { "usb-kbd", "serial", "42" },
+    { "usb-tablet", "serial", "42" },

Ah! Now commit b63e10508be makes sense.

Quoted 4 lines
hw/core/machine.c +0 -0
     { "virtio-blk-device", "discard", "false" },
     { "virtio-blk-device", "write-zeroes", "false" },
 };