Skip to contentSkip to conversation

use help instead of ---help--- in Kconfig

PATCH In review Moses Christopher 2 participants 8 messages May 18, 2019 – May 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover use help instead of ---help--- in Kconfig

Resolve the Warning that comes from the Kconfig file, which states, "WARNING: prefer 'help' over '---help---' for new help texts"

Moses Christopher (6):
staging: fsl-dpaa2: use help instead of ---help--- in Kconfig
staging: most: use help instead of ---help--- in Kconfig
staging: unisys: use help instead of ---help--- in Kconfig
staging: rtl8188eu: use help instead of ---help--- in Kconfig
staging: rtl8723bs: use help instead of ---help--- in Kconfig
staging: vt665*: use help instead of ---help--- in Kconfig

 drivers/staging/fsl-dpaa2/Kconfig | 8 ++++----
 drivers/staging/most/Kconfig      | 2 +-
 drivers/staging/rtl8188eu/Kconfig | 4 ++--
 drivers/staging/rtl8723bs/Kconfig | 2 +-
 drivers/staging/unisys/Kconfig    | 4 ++--
 drivers/staging/vt6655/Kconfig    | 5 ++---
 drivers/staging/vt6656/Kconfig    | 5 ++---
 7 files changed, 14 insertions(+), 16 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/6 staging: fsl-dpaa2: use help instead of ---help--- in Kconfig

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts"

---
 drivers/staging/fsl-dpaa2/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/fsl-dpaa2/Kconfig +4 -4
index 368837cdf281..244237bb068a 100644
@@ -6,7 +6,7 @@
 config FSL_DPAA2
 	bool "Freescale DPAA2 devices"
 	depends on FSL_MC_BUS
-	---help---
+	help
 	  Build drivers for Freescale DataPath Acceleration
 	  Architecture (DPAA2) family of SoCs.
 
@@ -14,6 +14,6 @@ config FSL_DPAA2_ETHSW
 	tristate "Freescale DPAA2 Ethernet Switch"
 	depends on FSL_DPAA2
 	depends on NET_SWITCHDEV
-	---help---
-	Driver for Freescale DPAA2 Ethernet Switch. Select
-	BRIDGE to have support for bridge tools.
+	help
+	  Driver for Freescale DPAA2 Ethernet Switch. Select
+	  BRIDGE to have support for bridge tools.
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/6 staging: most: use help instead of ---help--- in Kconfig

In reply to Moses Christopher

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts

---
 drivers/staging/most/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/Kconfig +1 -1
index db32ea7d1743..8948d5246409 100644
@@ -3,7 +3,7 @@ menuconfig MOST
         tristate "MOST support"
 	depends on HAS_DMA && CONFIGFS_FS
         default n
-        ---help---
+        help
 	  Say Y here if you want to enable MOST support.
 	  This driver needs at least one additional component to enable the
 	  desired access from userspace (e.g. character devices) and one that
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/6 staging: unisys: use help instead of ---help--- in Kconfig

In reply to Moses Christopher

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts"

---
 drivers/staging/unisys/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/unisys/Kconfig +2 -2
index dc5e1bddc085..43fe1ce538e1 100644
@@ -4,8 +4,8 @@
 #
 menuconfig UNISYSSPAR
 	bool "Unisys SPAR driver support"
-	---help---
-	Support for the Unisys SPAR drivers
+	help
+	  Support for the Unisys SPAR drivers
 
 if UNISYSSPAR
 
Signature · 1 line
2.17.1
#4 lore raw

PATCH 4/6 staging: rtl8188eu: use help instead of ---help--- in Kconfig

In reply to Moses Christopher

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts"

---
 drivers/staging/rtl8188eu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/Kconfig +2 -2
index 4f7ef287a0f2..970d5abd6336 100644
@@ -8,7 +8,7 @@ config R8188EU
 	select LIB80211
 	select LIB80211_CRYPT_WEP
 	select LIB80211_CRYPT_CCMP
-	---help---
+	help
 	This option adds the Realtek RTL8188EU USB device such as TP-Link TL-WN725N.
 	If built as a module, it will be called r8188eu.
 
@@ -17,7 +17,7 @@ if R8188EU
 config 88EU_AP_MODE
 	bool "Realtek RTL8188EU AP mode"
 	default y
-	---help---
+	help
 	This option enables Access Point mode. Unless you know that your system
 	will never be used as an AP, or the target system has limited memory,
 	"Y" should be selected.
Signature · 1 line
2.17.1
#5 lore raw

PATCH 5/6 staging: rtl8723bs: use help instead of ---help--- in Kconfig

In reply to Moses Christopher

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts"

---
 drivers/staging/rtl8723bs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/Kconfig +1 -1
index 744091d46f4c..a88467334dac 100644
@@ -5,7 +5,7 @@ config RTL8723BS
 	depends on m
 	select WIRELESS_EXT
 	select WEXT_PRIV
-	---help---
+	help
 	This option enables support for RTL8723BS SDIO drivers, such as
 	the wifi found on the 1st gen Intel Compute Stick, the CHIP
 	and many other Intel Atom and ARM based devices.
Signature · 1 line
2.17.1
maintainer
#6 lore raw

Re: [PATCH v1 5/6] staging: rtl8723bs: use help instead of ---help--- in Kconfig

Quoted 13 lines · Moses Christopher

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts"

---
 drivers/staging/rtl8723bs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/Kconfig +0 -0
index 744091d46f4c..a88467334dac 100644

drivers/staging/rtl8723bs/Kconfig config RTL8723BS · line 11

Quoted 8 lines
drivers/staging/rtl8723bs/Kconfig +1 -1
@@ -5,7 +5,7 @@ config RTL8723BS
 	depends on m
 	select WIRELESS_EXT
 	select WEXT_PRIV
-	---help---
+	help
 	This option enables support for RTL8723BS SDIO drivers, such as
 	the wifi found on the 1st gen Intel Compute Stick, the CHIP
 	and many other Intel Atom and ARM based devices.

No indentation here? Why not?

thanks,

greg k-h

#7 lore raw

PATCH 6/6 staging: vt665*: use help instead of ---help--- in Kconfig

In reply to Moses Christopher

- Resolve the following warning from the Kconfig, "WARNING: prefer 'help' over '---help---' for new help texts"

---
 drivers/staging/vt6655/Kconfig | 5 ++---
 drivers/staging/vt6656/Kconfig | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/staging/vt6655/Kconfig +2 -3
index e4b224fedf5b..d1cd5de46dcf 100644
@@ -2,6 +2,5 @@
 config VT6655
    tristate "VIA Technologies VT6655 support"
    depends on PCI && MAC80211 && m
-   ---help---
-   This is a vendor-written driver for VIA VT6655.
-
+   help
+     This is a vendor-written driver for VIA VT6655.
drivers/staging/vt6656/Kconfig +2 -3
index 51e295265ba6..f52a3f1d9a2e 100644
@@ -3,6 +3,5 @@ config VT6656
 	tristate "VIA Technologies VT6656 support"
 	depends on MAC80211 && USB && WLAN && m
 	select FW_LOADER
-	---help---
-	This is a vendor-written driver for VIA VT6656.
-
+	help
+	  This is a vendor-written driver for VIA VT6656.
Signature · 1 line
2.17.1