Skip to contentSkip to conversation

x86: Remove xfail in entry check in enter_guest_with_bad_controls()

PATCH In review Nadav Amit 2 participants 3 messages May 20, 2019 – Jun 7, 2019 KVM

lore
Share & tools
lore

Nadav Amit

author
#0 lore raw

PATCH 1/1 x86: Remove xfail in entry check in enter_guest_with_bad_controls()

The test succeeds in failing entry. This is not an expected failure.

---
 x86/vmx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
x86/vmx.c +1 -2
index f540e15..014bf50 100644
@@ -1833,8 +1833,7 @@ void enter_guest_with_bad_controls(void)
 			"Called enter_guest() after guest returned.");
 
 	ok = vmx_enter_guest(&failure);
-	report_xfail("vmlaunch fails, as expected",
-		     true, ok);
+	report("vmlaunch fails, as expected", !ok);
 	report("failure occurred early", failure.early);
 	report("FLAGS set correctly",
 	       (failure.flags & VMX_ENTRY_FLAGS) == X86_EFLAGS_ZF);
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 14 lines · Nadav Amit

The test succeeds in failing entry. This is not an expected failure.

---
 x86/vmx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
x86/vmx.c +0 -0
index f540e15..014bf50 100644

x86/vmx.c void enter_guest_with_bad_controls(void) · line 1839

Quoted 9 lines
x86/vmx.c +1 -2
@@ -1833,8 +1833,7 @@ void enter_guest_with_bad_controls(void)
 			"Called enter_guest() after guest returned.");
 
 	ok = vmx_enter_guest(&failure);
-	report_xfail("vmlaunch fails, as expected",
-		     true, ok);
+	report("vmlaunch fails, as expected", !ok);
 	report("failure occurred early", failure.early);
 	report("FLAGS set correctly",
 	       (failure.flags & VMX_ENTRY_FLAGS) == X86_EFLAGS_ZF);

Superseded by commit 74f7e9b ("vmx: introduce enter_guest_with_invalid_guest_state", 2019-04-18); thanks anyway!

Paolo

author
#2 lore raw
Quoted 18 lines · Paolo Bonzini
Quoted 15 lines · Nadav Amit

The test succeeds in failing entry. This is not an expected failure.

---
x86/vmx.c | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
x86/vmx.c +0 -0
index f540e15..014bf50 100644
@@ -1833,8 +1833,7 @@ void enter_guest_with_bad_controls(void)
 			"Called enter_guest() after guest returned.");
 
Quoted 10 lines

x86/vmx.c void enter_guest_with_bad_controls(void) · line 1839

Quoted 7 lines
x86/vmx.c +1 -2
 	ok = vmx_enter_guest(&failure);
-	report_xfail("vmlaunch fails, as expected",
-		     true, ok);
+	report("vmlaunch fails, as expected", !ok);
 	report("failure occurred early", failure.early);
 	report("FLAGS set correctly",
 	       (failure.flags & VMX_ENTRY_FLAGS) == X86_EFLAGS_ZF);

Superseded by commit 74f7e9b ("vmx: introduce enter_guest_with_invalid_guest_state", 2019-04-18); thanks anyway!

I have some related fixes for recent commits, so I will be waiting for you to push the updated kvm-unit-tests before I send the next batch of fixes.