Skip to contentSkip to conversation

meson: Remove invalid required argument

PATCH In review Petri Latvala 3 participants 4 messages May 20, 2019 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meson: Remove invalid required argument

declare_dependency doesn't take a 'required' argument.

meson.build:207: WARNING: Passed invalid keyword argument "required".
WARNING: This will become a hard error in the future.

---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -1
index a05e912c..2af08f9a 100644
@@ -210,7 +210,7 @@ if _build_chamelium
 		xmlrpc_client,
 		gsl,
 		alsa,
-	], required : _chamelium_required)
+	])
 	if xmlrpc.found() and xmlrpc_util.found() and xmlrpc_client.found() and gsl.found() and alsa.found() and libcurl.found()
 		config.set('HAVE_CHAMELIUM', 1)
 		chameliuminfo = 'Yes'
Signature · 6 lines
2.19.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Petri Latvala

declare_dependency doesn't take a 'required' argument.

meson.build:207: WARNING: Passed invalid keyword argument "required".
WARNING: This will become a hard error in the future.

Derp. Thanks for spotting this!

Quoted 17 lines
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meson.build +1 -1
index a05e912c..2af08f9a 100644
@@ -210,7 +210,7 @@ if _build_chamelium
 		xmlrpc_client,
 		gsl,
 		alsa,
-	], required : _chamelium_required)
+	])
 	if xmlrpc.found() and xmlrpc_util.found() and

xmlrpc_client.found() and gsl.found() and alsa.found() and libcurl.found()

meson.build if _build_chamelium · line 216

Quoted 2 lines
meson.build +0 -0
 		config.set('HAVE_CHAMELIUM', 1)
 		chameliuminfo = 'Yes'

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for meson: Remove invalid required argument

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: meson: Remove invalid required argument
URL : https://patchwork.freedesktop.org/series/60852/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6098 -> IGTPW_3005
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_3005 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_3005, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/60852/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_3005:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_gttfill@basic:
- fi-whl-u: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3005/fi-whl-u/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_3005 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][2] ([fdo#108511]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6098/fi-skl-6770hq/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3005/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [DMESG-FAIL][4] ([fdo#110235]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6098/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3005/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (49 -> 44)
------------------------------

Additional (2): fi-whl-u fi-icl-u3
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-dsi fi-bdw-samus

Build changes
-------------

* IGT: IGT_4996 -> IGTPW_3005

CI_DRM_6098: 0b584605423c254721629dc8e65e28eaec1f3b5f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3005: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3005/
IGT_4996: 6fe5d254ec1b9b47d61408e1b49a7339876bf1e7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3005/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for meson: Remove invalid required argument

Quoted 30 lines · Patchwork

== Series Details ==

Series: meson: Remove invalid required argument
URL : https://patchwork.freedesktop.org/series/60852/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6098 -> IGTPW_3005
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_3005 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_3005, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/60852/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_3005:

Quoted 8 lines

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_gttfill@basic:
- fi-whl-u: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3005/fi-whl-u/igt@[email protected]

A definite false positive. Off to Martin you go!

Signature · 5 lines
Petri Latvala
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev