crypto: testmgr - fix length truncation with large page size
Subsystems (2)
PATCH 1/1 crypto: testmgr - fix length truncation with large page size
From: Eric Biggers <[email protected]>
On PowerPC with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, there is sometimes a crash in generate_random_aead_testvec(). The problem is that the generated test vectors use data lengths of up to about 2 * PAGE_SIZE, which is 128 KiB on PowerPC; however, the data length fields in the test vectors are 'unsigned short', so the lengths get truncated. Fix this by changing the relevant fields to 'unsigned int'.
--- crypto/testmgr.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
crypto/testmgr.h +5 -5
@@ -43,7 +43,7 @@ struct hash_testvec {const char *key;const char *plaintext;const char *digest; -unsigned short psize; +unsigned int psize;unsigned short ksize;int setkey_error;int digest_error;
@@ -74,7 +74,7 @@ struct cipher_testvec {const char *ctext;unsigned char wk;/* weak key flag */ unsigned short klen; -unsigned short len; +unsigned int len;bool fips_skip;bool generates_iv;int setkey_error;
@@ -110,9 +110,9 @@ struct aead_testvec {unsigned char novrfy;unsigned char wk;unsigned char klen; -unsigned short plen; -unsigned short clen; -unsigned short alen; +unsigned int plen; +unsigned int clen; +unsigned int alen;int setkey_error;int setauthsize_error;int crypt_error;
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog
Herbert Xu
maintainerQuoted 9 lines · Eric Biggers
From: Eric Biggers <[email protected]>
On PowerPC with
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, there is sometimes a crash ingenerate_random_aead_testvec(). The problem is that the generated test vectors use data lengths of up to about 2 *PAGE_SIZE, which is 128 KiB on PowerPC; however, the data length fields in the test vectors are 'unsigned short', so the lengths get truncated. Fix this by changing the relevant fields to 'unsigned int'.
Quoted 5 lines
Fixes 40153b10d91c ("crypto: testmgr - fuzz AEADs against their generic implementation")Signed-off-by Eric Biggers <[email protected]>--- crypto/testmgr.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt