Allow VINDPM to be set in the device tree
Subsystems (2)
cover Allow VINDPM to be set in the device tree
The BQ25890 can control the input voltage limit so allow it to be set.
Angus Ainslie (Purism) (1):
dt-bindings: power: supply: Add documentation for the VINDPM
properties
Eric Kuzmenko (1):
power: supply: bq25890: Add support for setting bq25890 and bq25896's
VINDPM
.../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ drivers/power/supply/bq25890_charger.c | 13 ++++++++++++- 2 files changed, 20 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
PATCH 1/2 power: supply: bq25890: Add support for setting bq25890 and bq25896's VINDPM
From: Eric Kuzmenko <[email protected]>
The bq25890 has low voltage protection on VIN. Allow the register to be set from the device tree.
--- drivers/power/supply/bq25890_charger.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/power/supply/bq25890_charger.c +12 -1
@@ -75,6 +75,8 @@ struct bq25890_init_data {u8 boosti;/* boost current limit */ u8 boostf;/* boost frequency */ u8 ilim_en;/* enable ILIM pin */ +u8 force_vindpm;/* force vinmin threshold */ +u8 vindpm;/* vinmin threshold */ u8 treg;/* thermal regulation threshold */ };
@@ -250,6 +252,7 @@ enum bq25890_table_ids {TBL_VREG ,TBL_BOOSTV ,TBL_SYSVMIN , +TBL_VINDPM ,/* lookup tables */ TBL_TREG,
@@ -289,6 +292,7 @@ static const union { [TBL_VREG] = { .rt = {3840000, 4608000, 16000} }, /* uV */ [TBL_BOOSTV] = { .rt = {4550000, 5510000, 64000} }, /* uV */ [TBL_SYSVMIN] = { .rt = {3000000, 3700000, 100000} }, /* uV */ + [TBL_VINDPM] = { .rt = {2600000, 15300000, 100000} }, /* uV */ /* lookup tables */ [TBL_TREG] = { .lt = {bq25890_treg_tbl, BQ25890_TREG_TBL_SIZE} },
@@ -621,6 +625,8 @@ static int bq25890_hw_init(struct bq25890_device *bq) {F_BOOSTI, bq->init_data.boosti}, {F_BOOSTF, bq->init_data.boostf}, {F_EN_ILIM, bq->init_data.ilim_en}, + {F_FORCE_VINDPM, bq->init_data.force_vindpm}, + {F_VINDPM, bq->init_data.vindpm}, {F_TREG, bq->init_data.treg} };
@@ -783,11 +789,14 @@ static int bq25890_fw_read_u32_props(struct bq25890_device *bq) {"ti,boost-max-current", false, TBL_BOOSTI, &init->boosti},/* optional properties */ - {"ti,thermal-regulation-threshold", true, TBL_TREG, &init->treg} + {"ti,thermal-regulation-threshold", + true, TBL_TREG, &init->treg}, + {"ti,vinmin-threshold", true, TBL_VINDPM, &init->vindpm} };/* initialize data for optional properties */ init->treg =3 ;/* 120 degrees Celsius */ + init->vindpm =0x12 ;/* 4.4V */ for (i =0 ; i <ARRAY_SIZE (props); i++) { ret = device_property_read_u32(bq->dev, props[i].name,
@@ -820,6 +829,8 @@ static int bq25890_fw_probe(struct bq25890_device *bq) init->ilim_en =device_property_read_bool (bq->dev,"ti,use-ilim-pin" ); init->boostf =device_property_read_bool (bq->dev,"ti,boost-low-freq" ); + init->force_vindpm = +device_property_read_bool (bq->dev,"ti,use-vinmin-threshold" );return 0 ; }
Signature · 1 line
2.17.1
PATCH 2/2 dt-bindings: power: supply: Add documentation for the VINDPM properties
In reply to Angus Ainslie (Purism)Add documentation on how to control VINDPM from the devicetree.
--- .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/power/supply/bq25890.txt +8 -0
@@ -26,9 +26,15 @@ Optional properties: - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the input current will be the lower between the resistor setting and the IINLIM register setting; +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set + and the input voltage limit will be configured based on "ti,vinmin-threshold" - ti,thermal-regulation-threshold: integer, temperature above which the charge current is lowered, to avoid overheating (in degrees Celsius). If omitted, the default setting will be used (120 degrees); +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the + voltage falls below this threshold the charge current is reduced until the + input voltage rises above the input voltage limit. If omitted, the default + setting will be used (4.4V); Example:
@@ -46,4 +52,6 @@ bq25890 { ti,use-ilim-pin; ti,thermal-regulation-threshold = <120>; + ti,use-vinmin-threshold; + ti,vinmin-threshold = <3900000>; };
Signature · 1 line
2.17.1
Rob Herring
maintainerRe: [PATCH 2/2] dt-bindings: power: supply: Add documentation for the VINDPM properties
Quoted 12 lines · Angus Ainslie (Purism)
Add documentation on how to control VINDPM from the devicetree.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/power/supply/bq25890.txt +0
-0
Documentation/devicetree/bindings/power/supply/bq25890.txt Optional properties: · line 30
Quoted 5 lines
Documentation/devicetree/bindings/power/supply/bq25890.txt +2
-0@@ -26,9 +26,15 @@ Optional properties: - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the input current will be the lower between the resistor setting and the IINLIM register setting; +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set + and the input voltage limit will be configured based on "ti,vinmin-threshold"
Isn't presence of ti,vinmin-threshold enough to determine whether to set FORCE_VINDPM or not? Just get rid of the default being 4.4V.
Quoted 20 lines
Documentation/devicetree/bindings/power/supply/bq25890.txt +6
-0- ti,thermal-regulation-threshold: integer, temperature above which the charge current is lowered, to avoid overheating (in degrees Celsius). If omitted, the default setting will be used (120 degrees); +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the + voltage falls below this threshold the charge current is reduced until the + input voltage rises above the input voltage limit. If omitted, the default + setting will be used (4.4V); Example:@@ -46,4 +52,6 @@ bq25890 { ti,use-ilim-pin; ti,thermal-regulation-threshold = <120>; + ti,use-vinmin-threshold; + ti,vinmin-threshold = <3900000>; };Signature · 1 line
2.17.1
Re: [PATCH 2/2] dt-bindings: power: supply: Add documentation for the VINDPM properties
Hi,
Quoted 8 lines · Rob Herring
Quoted 7 lines · Angus Ainslie (Purism)
Add documentation on how to control VINDPM from the devicetree.
Signed-off-by Angus Ainslie (Purism) <[email protected]>--- .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Quoted 21 lines
Documentation/devicetree/bindings/power/supply/bq25890.txt Optional properties: · line 30
Quoted 10 lines
Documentation/devicetree/bindings/power/supply/bq25890.txt +2
-0@@ -26,9 +26,15 @@ Optional properties: - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the input current will be the lower between the resistor setting and the IINLIM register setting; +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set + and the input voltage limit will be configured based on "ti,vinmin-threshold"Isn't presence of ti,vinmin-threshold enough to determine whether to set
FORCE_VINDPMor not? Just get rid of the default being 4.4V.Quoted 7 lines
Documentation/devicetree/bindings/power/supply/bq25890.txt +4
-0- ti,thermal-regulation-threshold: integer, temperature above which the charge current is lowered, to avoid overheating (in degrees Celsius). If omitted, the default setting will be used (120 degrees); +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the + voltage falls below this threshold the charge current is reduced until the + input voltage rises above the input voltage limit. If omitted, the default + setting will be used (4.4V);
We already have a "input-voltage-min-microvolt" property used by Maxim chargers, please resuse that for the bq25890 instead of creating a new property name.
-- Sebastian
Quoted 13 lines
Quoted 13 lines
Documentation/devicetree/bindings/power/supply/bq25890.txt +2
-0Example:@@ -46,4 +52,6 @@ bq25890 { ti,use-ilim-pin; ti,thermal-regulation-threshold = <120>; + ti,use-vinmin-threshold; + ti,vinmin-threshold = <3900000>; };Signature · 1 line
2.17.1