dmaengine: xilinx_dma: Remove set but unused ‘tail_desc’
Subsystems (2)
Vinod Koul
maintainerPATCH 1/1 dmaengine: xilinx_dma: Remove set but unused ‘tail_desc’
We get a compiler warn about variable ‘tail_desc’ set but not used
drivers/dma/xilinx/xilinx_dma.c:1102:42: warning:
variable ‘tail_desc’ set but not used [-Wunused-but-set-variable]
struct xilinx_dma_tx_descriptor *desc, *tail_desc;
So remove it.
--- drivers/dma/xilinx/xilinx_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/dma/xilinx/xilinx_dma.c +1 -3
@@ -1099,7 +1099,7 @@ static void xilinx_dma_start(struct xilinx_dma_chan *chan)static void xilinx_vdma_start_transfer (struct xilinx_dma_chan *chan) {struct xilinx_vdma_config *config = &chan->config; -struct xilinx_dma_tx_descriptor *desc, *tail_desc; +struct xilinx_dma_tx_descriptor *desc;u32 reg, j;struct xilinx_vdma_tx_segment *segment, *last =NULL ;int i =0 ;
@@ -1116,8 +1116,6 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan) desc =list_first_entry (&chan->pending_list, struct xilinx_dma_tx_descriptor, node); - tail_desc =list_last_entry (&chan->pending_list, - struct xilinx_dma_tx_descriptor, node);/* Configure the hardware using info in the config structure */ if (chan->has_vflip) {
Signature · 1 line
2.20.1
Quoted 12 lines
-----Original Message-----
From: Vinod Koul <[email protected]>
Sent: Tuesday, May 21, 2019 7:41 PM
To: [email protected]
Cc: Vinod Koul <[email protected]>; Michal Simek <[email protected]>; Radhey Shyam Pandey <[email protected]>; Andrea Merello <[email protected]>; Appana Durga Kedareswara Rao <[email protected]>
Subject: [PATCH] dmaengine:xilinx_dma: Remove set but unused ‘tail_desc’We get a compiler warn about variable ‘tail_desc’ set but not used
Quoted 7 lines
drivers/dma/xilinx/xilinx_dma.c:1102:42: warning:
variable ‘tail_desc’ set but not used [-Wunused-but-set-variable]
structxilinx_dma_tx_descriptor*desc,*tail_desc;So remove it.
Signed-off-by Vinod Koul <[email protected]>
Thanks!
Quoted 30 lines
--- drivers/dma/xilinx/xilinx_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/dma/xilinx/xilinx_dma.c +1
-1@@ -1099,7 +1099,7 @@ static void xilinx_dma_start(struct xilinx_dma_chan *chan)static void xilinx_vdma_start_transfer (struct xilinx_dma_chan *chan) {struct xilinx_vdma_config *config = &chan->config; -struct xilinx_dma_tx_descriptor *desc, *tail_desc; +struct xilinx_dma_tx_descriptor *desc;u32 reg, j;struct xilinx_vdma_tx_segment *segment, *last =NULL ;drivers/dma/xilinx/xilinx_dma.c +0
-2int i =0 ;@@ -1116,8 +1116,6 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan) desc =list_first_entry (&chan->pending_list, struct xilinx_dma_tx_descriptor, node); - tail_desc =list_last_entry (&chan->pending_list, - struct xilinx_dma_tx_descriptor, node);/* Configure the hardware using info in the config structure */ if (
chan->has_vflip) {
--
2.20.1
Quoted 16 lines · Radhey Shyam Pandey
Quoted 16 lines
-----Original Message-----
From: Vinod Koul <[email protected]>
Sent: Tuesday, May 21, 2019 7:41 PM
To: [email protected]
Cc: Vinod Koul <[email protected]>; Michal Simek <[email protected]>; Radhey Shyam Pandey <[email protected]>; Andrea Merello <[email protected]>; Appana Durga Kedareswara Rao <[email protected]>
Subject: [PATCH] dmaengine:xilinx_dma: Remove set but unused ‘tail_desc’We get a compiler warn about variable ‘tail_desc’ set but not used
drivers/dma/xilinx/xilinx_dma.c:1102:42: warning:
variable ‘tail_desc’ set but not used [-Wunused-but-set-variable]
structxilinx_dma_tx_descriptor*desc,*tail_desc;
Quoted 5 lines
Quoted 3 lines
So remove it.
Signed-off-by Vinod Koul <[email protected]>Reviewed-by Radhey Shyam Pandey <[email protected]>
Thanks applied now
Signature · 1 line
~Vinod