Skip to contentSkip to conversation

Implement Fraction Rounded bit in FPSCR for PowerPC

PATCH In review John Arbuckle 2 participants 4 messages May 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Implement Fraction Rounded bit in FPSCR for PowerPC

Implement the PowerPC floating point status and control register flag Fraction Rounded.

---
 fpu/softfloat.c               | 15 ++++++++++++---
 include/fpu/softfloat-types.h |  1 +
 target/ppc/fpu_helper.c       |  4 ++++
 3 files changed, 17 insertions(+), 3 deletions(-)
fpu/softfloat.c +12 -3
index 2ba36ec370..ac34f6a2de 100644
@@ -702,7 +702,7 @@ static FloatParts round_canonical(FloatParts p, float_status *s,
     const uint64_t roundeven_mask = parm->roundeven_mask;
     const int exp_max = parm->exp_max;
     const int frac_shift = parm->frac_shift;
-    uint64_t frac, inc;
+    uint64_t frac, inc, rounded;
     int exp, flags = 0;
     bool overflow_norm;
 
@@ -744,7 +744,12 @@ static FloatParts round_canonical(FloatParts p, float_status *s,
         if (likely(exp > 0)) {
             if (frac & round_mask) {
                 flags |= float_flag_inexact;
-                frac += inc;
+                rounded = frac + inc;
+                if ((rounded ^ frac) & frac_lsb) {
+                    flags |= float_flag_rounded;
+                }
+                frac = rounded;
+
                 if (frac & DECOMPOSED_OVERFLOW_BIT) {
                     frac >>= 1;
                     exp++;
@@ -793,7 +798,11 @@ static FloatParts round_canonical(FloatParts p, float_status *s,
                     break;
                 }
                 flags |= float_flag_inexact;
-                frac += inc;
+                rounded = frac + inc;
+                if ((rounded ^ frac) & frac_lsb) {
+                    flags |= float_flag_rounded;
+                }
+                frac = rounded;
             }
 
             exp = (frac & DECOMPOSED_IMPLICIT_BIT ? 1 : 0);
include/fpu/softfloat-types.h +1 -0
index 2aae6a89b1..bee576e0fd 100644
@@ -147,6 +147,7 @@ enum {
 
 enum {
     float_flag_invalid   =  1,
+    float_flag_rounded   =  2,
     float_flag_divbyzero =  4,
     float_flag_overflow  =  8,
     float_flag_underflow = 16,
target/ppc/fpu_helper.c +4 -0
index 0b7308f539..0baf1ce8e4 100644
@@ -630,6 +630,10 @@ static void do_float_check_status(CPUPPCState *env, uintptr_t raddr)
         env->fpscr &= ~(1 << FPSCR_FI); /* clear the FPSCR[FI] bit */
     }
 
+    /* Set or clear the Fraction Rounded bit */
+    env->fpscr = deposit32(env->fpscr, FPSCR_FR, 1,
+                           (status & float_flag_rounded) != 0);
+
     if (cs->exception_index == POWERPC_EXCP_PROGRAM &&
         (env->error_code & POWERPC_EXCP_FP)) {
         /* Differred floating-point exception after target FPR update */
Signature · 1 line
2.14.3 (Apple Git-98)
#1 lore raw
Quoted 8 lines · John Arbuckle

Implement the PowerPC floating point status and control register flag Fraction Rounded.

---
 fpu/softfloat.c               | 15 ++++++++++++---
 include/fpu/softfloat-types.h |  1 +
 target/ppc/fpu_helper.c       |  4 ++++
 3 files changed, 17 insertions(+), 3 deletions(-)

Please split the target/ppc part away from the softfloat part.

Also, we should note that there are more places within softfloat that need to be adjusted so that float_float_rounded is fully supported.

r~

author
#2 lore raw

Thank you for the suggestion.

For the added note, did you want specific places listed? If so please let me know these places.

Thank you.

Quoted 20 lines · Richard Henderson
Quoted 1 line · John Arbuckle

Implement the PowerPC floating point status and control register flag

Fraction Rounded.

Quoted 7 lines
---
 fpu/softfloat.c               | 15 ++++++++++++---
 include/fpu/softfloat-types.h |  1 +
 target/ppc/fpu_helper.c       |  4 ++++
 3 files changed, 17 insertions(+), 3 deletions(-)

Please split the target/ppc part away from the softfloat part.

Also, we should note that there are more places within softfloat that need to
be adjusted so that float_float_rounded is fully supported.

r~

#3 lore raw
Quoted 5 lines · On 5/22/19 11:25 AM, G 3 wrote:

Thank you for the suggestion.

For the added note, did you want specific places listed? If so please let me know these places.

They are round_to_int, and all of the legacy roundAndPack* routines. Basically anywhere that currently sets float_flag_inexact.

r~