qcom: Add cpuidle to some platforms
Subsystems (4)
v2 cover qcom: Add cpuidle to some platforms
Changes since v1:
- Reworded changes to the idle-state documentation on Sudeep's feedback.
- Renamed several idle-state node names to be homogeneous across qcom platforms. We now use cpu_sleep_0_0 format for the node name while using LITTLE_CPU_SLEEP_0 format for labels to help differentiate the different states for different CPU types.
- Add a new patch to add capacity-dmips-mhz property for msm8996 to allow topology code to find its true capacity.
- Add power-collapse state to msm8998 in additon to the retention state.
- Added acks
MSM8998 changes are untested for v2 because I couldn't access the mtp I usually have access to. Hopefully Marc and Sibi can help with testing.
Description
-----------
Fix up a few entry-method="psci" issues and then add cpuidle low power states for msm8996, msm8998, qcs404, sdm845. All these have been tested to only make sure that the C-states are entered from Linux point-of-view.
We will continue to add more states and make power measurements to tweak some of these numbers, but getting these merged will allow other people to use these platforms to work on cpuidle, eas and related topics.
Amit Kucheria (7):
arm64: dts: fsl: ls1028a: Fix entry-method property to reflect
documentation
Documentation: arm: Link idle-states binding to "enable-method"
property
arm64: dts: qcom: msm8916: Add entry-method property for the
idle-states node
arm64: dts: qcom: msm8916: Use more generic idle state names
arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states
arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
arm64: dts: msm8996: Add proper capacity scaling for the cpus
Niklas Cassel (1):
arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states
Raju P.L.S.S.S.N (1):
arm64: dts: qcom: sdm845: Add PSCI cpuidle low power states
.../devicetree/bindings/arm/idle-states.txt | 13 +++- .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8916.dtsi | 13 ++-- arch/arm64/boot/dts/qcom/msm8996.dtsi | 21 ++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 ++++++++++++++ arch/arm64/boot/dts/qcom/qcs404.dtsi | 18 +++++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 69 +++++++++++++++++++ 7 files changed, 177 insertions(+), 9 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/9 arm64: dts: fsl: ls1028a: Fix entry-method property to reflect documentation
The idle-states binding documentation[1] mentions that the 'entry-method' property is required on 64-bit platforms and must be set to "psci".
We fixed up all uses of the entry-method property in
commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation"). But a new one has appeared. Fix it up.
[1] Documentation/devicetree/bindings/arm/idle-states.txt (see idle-states node)
--- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -1
@@ -51,7 +51,7 @@ * PSCI node is not added default, U-boot will add missing * parts if it determines to use PSCI. */ - entry-method = "arm,psci"; + entry-method = "psci"; CPU_PH20: cpu-ph20 { compatible = "arm,idle-state";
Signature · 1 line
2.17.1
PATCH v2 2/9 Documentation: arm: Link idle-states binding to "enable-method" property
In reply to Amit KucheriaThe "enable-method" property for cpu nodes needs to be "psci" for CPU idle management to be setup correctly.
Add a note to the binding documentation to this effect to make it obvious.
--- .../devicetree/bindings/arm/idle-states.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/arm/idle-states.txt +10 -3
@@ -241,9 +241,13 @@ processor idle states, defined as device tree nodes, are listed. - "psci" # On ARM 32-bit systems this property is optional -The nodes describing the idle states (state) can only be defined within the -idle-states node, any other configuration is considered invalid and therefore -must be ignored. +This assumes that the "enable-method" property is set to "psci" in the cpu +node[6] that is responsible for setting up CPU idle management in the OS +implementation. + +The nodes describing the idle states (state) can only be defined +within the idle-states node, any other configuration is considered invalid +and therefore must be ignored. =========================================== 4 - state node
@@ -697,3 +701,6 @@ cpus { [5] Devicetree Specification https://www.devicetree.org/specifications/ + +[6] ARM Linux Kernel documentation - Booting AArch64 Linux + Documentation/arm64/booting.txt
Signature · 1 line
2.17.1
Re: [PATCH v2 2/9] Documentation: arm: Link idle-states binding to "enable-method" property
Quoted 20 lines · Amit Kucheria
The "enable-method" property for cpu nodes needs to be "psci" for CPU idle management to be setup correctly.
Add a note to the binding documentation to this effect to make it obvious.
Signed-off-by Amit Kucheria <[email protected]>Acked-by Sudeep Holla <[email protected]>--- .../devicetree/bindings/arm/idle-states.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/arm/idle-states.txt +0
-0@@ -241,9 +241,13 @@ processor idle states, defined as device tree nodes, are listed. - "psci" # On ARM 32-bit systems this property is optional
Documentation/devicetree/bindings/arm/idle-states.txt processor idle states, defined as device tree nodes, are listed. · line 250
Quoted 10 lines
Documentation/devicetree/bindings/arm/idle-states.txt +7
-3-The nodes describing the idle states (state) can only be defined within the -idle-states node, any other configuration is considered invalid and therefore -must be ignored. +This assumes that the "enable-method" property is set to "psci" in the cpu +node[6] that is responsible for setting up CPU idle management in the OS +implementation. + +The nodes describing the idle states (state) can only be defined +within the idle-states node, any other configuration is considered invalid +and therefore must be ignored.
Nit: I suppose your text editor automatically "reflowed" this last paragraph? I would leave it as-is, to minimize the diff, and avoid cosmetic changes.
Regards.
Re: [PATCH v2 2/9] Documentation: arm: Link idle-states binding to "enable-method" property
In reply to Amit KucheriaQuoted 12 lines · Amit Kucheria
The "enable-method" property for cpu nodes needs to be "psci" for CPU idle management to be setup correctly.
Add a note to the binding documentation to this effect to make it obvious.
Signed-off-by Amit Kucheria <[email protected]>Acked-by Sudeep Holla <[email protected]>--- .../devicetree/bindings/arm/idle-states.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
Applied, thanks.
Rob
PATCH v2 3/9 arm64: dts: qcom: msm8916: Add entry-method property for the idle-states node
In reply to Amit KucheriaThe idle-states binding documentation[1] mentions that the 'entry-method' property is required on 64-bit platforms and must be set to "psci".
[1] Documentation/devicetree/bindings/arm/idle-states.txt (see idle-states node)
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/qcom/msm8916.dtsi +2 -0
@@ -158,6 +158,8 @@ }; idle-states { + entry-method = "psci"; + CPU_SPC: spc { compatible = "arm,idle-state"; arm,psci-suspend-param = <0x40000002>;
Signature · 1 line
2.17.1
Re: [PATCH v2 3/9] arm64: dts: qcom: msm8916: Add entry-method property for the idle-states node
Quoted 10 lines · Amit Kucheria
The idle-states binding documentation[1] mentions that the 'entry-method' property is required on 64-bit platforms and must be set to "psci".
[1]
Documentation/devicetree/bindings/arm/idle-states.txt(see idle-states node)Signed-off-by Amit Kucheria <[email protected]>Reviewed-by Niklas Cassel <[email protected]>Acked-by Daniel Lezcano <[email protected]>
Picked up
Regards,
Bjorn
Quoted 20 lines
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/qcom/msm8916.dtsi +2
-0@@ -158,6 +158,8 @@ }; idle-states { + entry-method = "psci"; + CPU_SPC: spc { compatible = "arm,idle-state"; arm,psci-suspend-param = <0x40000002>;Signature · 1 line
2.17.1
PATCH v2 4/9 arm64: dts: qcom: msm8916: Use more generic idle state names
In reply to Amit KucheriaInstead of using Qualcomm-specific terminology, use generic node names for the idle states that are easier to understand. Move the description into the "idle-state-name" property.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/qcom/msm8916.dtsi +6 -5
@@ -110,7 +110,7 @@ reg = <0x0>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;
@@ -122,7 +122,7 @@ reg = <0x1>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;
@@ -134,7 +134,7 @@ reg = <0x2>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;
@@ -146,7 +146,7 @@ reg = <0x3>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;
@@ -160,8 +160,9 @@ idle-states { entry-method = "psci"; - CPU_SPC: spc { + CPU_SLEEP_0: cpu-sleep-0 { compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; arm,psci-suspend-param = <0x40000002>; entry-latency-us = <130>; exit-latency-us = <150>;
Signature · 1 line
2.17.1
Re: [PATCH v2 4/9] arm64: dts: qcom: msm8916: Use more generic idle state names
Quoted 8 lines · Amit Kucheria
Instead of using Qualcomm-specific terminology, use generic node names for the idle states that are easier to understand. Move the description into the "idle-state-name" property.
Signed-off-by Amit Kucheria <[email protected]>Reviewed-by Niklas Cassel <[email protected]>Acked-by Daniel Lezcano <[email protected]>---
Picked up
Regards,
Bjorn
Quoted 57 lines
arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)arch/arm64/boot/dts/qcom/msm8916.dtsi +6
-5@@ -110,7 +110,7 @@ reg = <0x0>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;@@ -122,7 +122,7 @@ reg = <0x1>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;@@ -134,7 +134,7 @@ reg = <0x2>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;@@ -146,7 +146,7 @@ reg = <0x3>; next-level-cache = <&L2_0>; enable-method = "psci"; - cpu-idle-states = <&CPU_SPC>; + cpu-idle-states = <&CPU_SLEEP_0>; clocks = <&apcs>; operating-points-v2 = <&cpu_opp_table>; #cooling-cells = <2>;@@ -160,8 +160,9 @@ idle-states { entry-method = "psci"; - CPU_SPC: spc { + CPU_SLEEP_0: cpu-sleep-0 { compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; arm,psci-suspend-param = <0x40000002>; entry-latency-us = <130>; exit-latency-us = <150>;Signature · 1 line
2.17.1
PATCH v2 5/9 arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states
In reply to Amit KucheriaFrom: Niklas Cassel <[email protected]>
Add device bindings for cpuidle states for cpu devices.
--- arch/arm64/boot/dts/qcom/qcs404.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/qcom/qcs404.dtsi +18 -0
@@ -30,6 +30,7 @@ compatible = "arm,cortex-a53"; reg = <0x100>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };
@@ -38,6 +39,7 @@ compatible = "arm,cortex-a53"; reg = <0x101>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };
@@ -46,6 +48,7 @@ compatible = "arm,cortex-a53"; reg = <0x102>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };
@@ -54,6 +57,7 @@ compatible = "arm,cortex-a53"; reg = <0x103>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };
@@ -61,6 +65,20 @@ compatible = "cache"; cache-level = <2>; }; + + idle-states { + entry-method = "psci"; + + CPU_SLEEP_0: cpu-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <125>; + exit-latency-us = <180>; + min-residency-us = <595>; + local-timer-stop; + }; + }; }; firmware {
Signature · 1 line
2.17.1
Bjorn Andersson
AppliedRe: [PATCH v2 5/9] arm64: dts: qcom: qcs404: Add PSCI cpuidle low power states
Quoted 10 lines · Amit Kucheria
From: Niklas Cassel <[email protected]>
Add device bindings for cpuidle states for cpu devices.
Signed-off-by Niklas Cassel <[email protected]>Reviewed-by Vinod Koul <[email protected]>[rename the idle-states to more generic names and fixups]Signed-off-by Amit Kucheria <[email protected]>Acked-by Daniel Lezcano <[email protected]>---
Applied
Regards,
Bjorn
Quoted 63 lines
arch/arm64/boot/dts/qcom/qcs404.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)arch/arm64/boot/dts/qcom/qcs404.dtsi +18
-0@@ -30,6 +30,7 @@ compatible = "arm,cortex-a53"; reg = <0x100>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -38,6 +39,7 @@ compatible = "arm,cortex-a53"; reg = <0x101>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -46,6 +48,7 @@ compatible = "arm,cortex-a53"; reg = <0x102>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -54,6 +57,7 @@ compatible = "arm,cortex-a53"; reg = <0x103>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -61,6 +65,20 @@ compatible = "cache"; cache-level = <2>; }; + + idle-states { + entry-method = "psci"; + + CPU_SLEEP_0: cpu-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <125>; + exit-latency-us = <180>; + min-residency-us = <595>; + local-timer-stop; + }; + }; }; firmware {Signature · 1 line
2.17.1
PATCH v2 6/9 arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states
In reply to Amit KucheriaAdd device bindings for cpuidle states for cpu devices.
msm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/qcom/msm8996.dtsi +17 -0
@@ -95,6 +95,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";
@@ -107,6 +108,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };
@@ -115,6 +117,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";
@@ -127,6 +130,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; };
@@ -151,6 +155,19 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + CPU_SLEEP_0: cpu-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; + arm,psci-suspend-param = <0x00000004>; + entry-latency-us = <40>; + exit-latency-us = <80>; + min-residency-us = <300>; + }; + }; }; thermal-zones {
Signature · 1 line
2.17.1
Re: [PATCH v2 6/9] arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states
Quoted 7 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
msm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
Signed-off-by Amit Kucheria <[email protected]>
Quoted 61 lines
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)arch/arm64/boot/dts/qcom/msm8996.dtsi +17
-0@@ -95,6 +95,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";@@ -107,6 +108,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -115,6 +117,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";@@ -127,6 +130,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; };@@ -151,6 +155,19 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + CPU_SLEEP_0: cpu-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; + arm,psci-suspend-param = <0x00000004>; + entry-latency-us = <40>; + exit-latency-us = <80>; + min-residency-us = <300>; + }; + }; }; thermal-zones {
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Bjorn Andersson
AppliedRe: [PATCH v2 6/9] arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states
In reply to Amit KucheriaQuoted 7 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
msm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
Signed-off-by Amit Kucheria <[email protected]>
Applied
Regards,
Bjorn
Quoted 63 lines
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)arch/arm64/boot/dts/qcom/msm8996.dtsi +17
-0@@ -95,6 +95,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";@@ -107,6 +108,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -115,6 +117,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";@@ -127,6 +130,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; };@@ -151,6 +155,19 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + CPU_SLEEP_0: cpu-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; + arm,psci-suspend-param = <0x00000004>; + entry-latency-us = <40>; + exit-latency-us = <80>; + min-residency-us = <300>; + }; + }; }; thermal-zones {Signature · 1 line
2.17.1
Re: [PATCH v2 6/9] arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states
In reply to Amit KucheriaQuoted 51 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
msm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
Signed-off-by Amit Kucheria <[email protected]>--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)arch/arm64/boot/dts/qcom/msm8996.dtsi +4
-0@@ -95,6 +95,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";@@ -107,6 +108,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_0>; };@@ -115,6 +117,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";@@ -127,6 +130,7 @@ compatible = "qcom,kryo"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&CPU_SLEEP_0>; next-level-cache = <&L2_1>; };@@ -151,6 +155,19 @@ }; }; };
arch/arm64/boot/dts/qcom/msm8996.dtsi line 167
Quoted 10 lines
arch/arm64/boot/dts/qcom/msm8996.dtsi +10
-0+ + idle-states { + entry-method = "psci"; + + CPU_SLEEP_0: cpu-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "standalone-power-collapse"; + arm,psci-suspend-param = <0x00000004>; + entry-latency-us = <40>; + exit-latency-us = <80>;
Hello Amit,
Looking at this line of code in msm-4.14:
https://source.codeaurora.org/quic/la/kernel/msm-4.14/tree/drivers/cpuidle/lpm-levels.c?h=LA.UM.7.1.r1-14000-sm8150.0#n993
And seeing the equivalent in msm-4.4:
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/drivers/cpuidle/lpm-levels.c?h=msm-4.4#n1080
It becomes obvious that
qcom,time-overhead == entry-latency-us + exit-latency-us and
qcom,latency-us == exit-latency-us
which means that
entry-latency-us == qcom,time-overhead - qcom,latency-us
Using this formula, with the numbers from downstream SDM845:
https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/arch/arm64/boot/dts/qcom/sdm845-pm.dtsi?h=msm-4.9#n123
qcom,latency-us = <621>;
qcom,time-overhead = <885>;
885 - 621 = 264
we end up with the same values that Raju
has in his submission for upstream SDM845:
https://patchwork.kernel.org/patch/10953253/
entry-latency-us = <264>;
exit-latency-us = <621>;
Which for msm8996:
qcom,latency-us = <80>;
qcom,time-overhead = <210>;
gives:
entry-latency-us = <130>
exit-latency-us = <80>;
Quoted 9 lines
arch/arm64/boot/dts/qcom/msm8996.dtsi +3
-0+ min-residency-us = <300>; + }; + }; }; thermal-zones {Signature · 1 line
2.17.1
PATCH v2 7/9 arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
In reply to Amit KucheriaAdd device bindings for cpuidle states for cpu devices.
--- arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++ 1 file changed, 50 insertions(+)
arch/arm64/boot/dts/qcom/msm8998.dtsi +50 -0
@@ -78,6 +78,7 @@ compatible = "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache {
@@ -97,6 +98,7 @@ compatible = "arm,armv8"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_1: l1-icache {
@@ -112,6 +114,7 @@ compatible = "arm,armv8"; reg = <0x0 0x2>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_2: l1-icache {
@@ -127,6 +130,7 @@ compatible = "arm,armv8"; reg = <0x0 0x3>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_3: l1-icache {
@@ -142,6 +146,7 @@ compatible = "arm,armv8"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L2_1: l2-cache {
@@ -161,6 +166,7 @@ compatible = "arm,armv8"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_101: l1-icache {
@@ -176,6 +182,7 @@ compatible = "arm,armv8"; reg = <0x0 0x102>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_102: l1-icache {
@@ -191,6 +198,7 @@ compatible = "arm,armv8"; reg = <0x0 0x103>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_103: l1-icache {
@@ -238,6 +246,48 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <43>; + exit-latency-us = <86>; + min-residency-us = <200>; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <612>; + min-residency-us = <1000>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <41>; + exit-latency-us = <82>; + min-residency-us = <200>; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <525>; + min-residency-us = <1000>; + local-timer-stop; + }; + }; }; firmware {
Signature · 1 line
2.17.1
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 14 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
Cc Marc Gonzalez <[email protected]>Signed-off-by Amit Kucheria <[email protected]>Acked-by Daniel Lezcano <[email protected]>--- arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++ 1 file changed, 50 insertions(+)arch/arm64/boot/dts/qcom/msm8998.dtsi +0
-0
arch/arm64/boot/dts/qcom/msm8998.dtsi line 84
Quoted 7 lines
arch/arm64/boot/dts/qcom/msm8998.dtsi +1
-0@@ -78,6 +78,7 @@ compatible = "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache {
NB: this patch does not apply cleanly to v5.2-rc1 ;-)
86f93c93dd50 arm64: dts: msm8998: efficiency is not valid property
commit 86f93c93dd5005f0aeb8ce84c2113e21a6006c7d
Author: Amit Kucheria <[email protected]> AuthorDate: Fri Mar 29 15:42:08 2019 +0530 Commit: Andy Gross <[email protected]> CommitDate: Tue Apr 9 23:08:17 2019 -0500
After manually fixing up the trivial conflict, the DTB builds without errors.
I then enable
+CONFIG_CPU_IDLE=y
+CONFIG_ARM_CPUIDLE=y
(because I'm using a board-specific tiny defconfig)
And... the system starts to boot, hangs a few seconds, then silently reboots:
scsi 0:0:0:3: Direct-Access SAMSUNG KLUBG4G1CE-B0B1 0800 PQ: 0 ANSI: 6
sd 0:0:0:1: [sdb] 16384-byte physical blocks
sd 0:0:0:2: [sdc] 2048 4096-byte logical blocks: (8.39 MB/8.00 MiB) sd 0:0:0:2: [sdc] 16384-byte physical blocks
Format: Log Type - Time(microsec) - Message - Optional Info Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic S - QC_IMAGE_VERSION_STRING=BOOT.XF.1.2.2-00157-M8998LZB-1 S - IMAGE_VARIANT_STRING=Msm8998LA
Looks like the "helpful" behavior of the secure OS...
Regards.
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 1 line · Marc Gonzalez
the system starts to boot, hangs a few seconds, then silently reboots
Using extremely high-tech debugging tools (i.e. spraying printk left and right) I traced this one down to:
psci_cpu_suspend_enter: 435psci_cpu_suspend: 171psci_cpu_suspend: __invoke_psci_fn_smc c4000001__invoke_psci_fn_smc: id=c4000001 3 0 0
/*** we never return from arm_smccc_smc() ***/
The following dmesg log caught my eye, and might be relevant:
ARM_SMCCC_ARCH_WORKAROUND_1 missing from firmware
If I revert your patch, psci_cpu_suspend_enter() is never called, so we don't tickle the arm_smccc_smc() monster.
Could it be that my FW doesn't support PSCI?
Regards.
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
In reply to Marc Gonzalez[ Re-sending to a wider audience, hoping to catch someone's eye ]
https://patchwork.kernel.org/patch/10953257/
Quoted 2 lines · Marc Gonzalez
With CPUIDLE enabled, my system starts to boot, hangs a few seconds, then silently reboots (killed by FW)
Using extremely high-tech debugging tools (i.e. spraying printk left and right) I traced this crash down to:
psci_cpu_suspend_enter: 435psci_cpu_suspend: 171psci_cpu_suspend: __invoke_psci_fn_smc c4000001 __invoke_psci_fn_smc: id=c4000001 3 0 0
/*** execution never returns from arm_smccc_smc() ***/
The following dmesg log caught my eye, and might be relevant:
ARM_SMCCC_ARCH_WORKAROUND_1 missing from firmware
Is that bad, doctor? I don't think it would explain the crash though...
If I revert the patch, psci_cpu_suspend_enter() is never called, so we don't tickle the arm_smccc_smc() monster.
Could it be that this FW doesn't support PSCI?
Regards.
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 19 lines · Marc Gonzalez
[ Re-sending to a wider audience, hoping to catch someone's eye ]
https://patchwork.kernel.org/patch/10953257/
Quoted 2 lines · Marc Gonzalez
With CPUIDLE enabled, my system starts to boot, hangs a few seconds, then silently reboots (killed by FW)
Using extremely high-tech debugging tools (i.e. spraying printk left and right) I traced this crash down to:
psci_cpu_suspend_enter: 435psci_cpu_suspend: 171psci_cpu_suspend:__invoke_psci_fn_smcc4000001__invoke_psci_fn_smc: id=c4000001 3 0 0
/*** execution never returns fromarm_smccc_smc()***/
Quoted 5 lines
The following dmesg log caught my eye, and might be relevant:
ARM_SMCCC_ARCH_WORKAROUND_1missing from firmwareIs that bad, doctor? I don't think it would explain the crash though...
It doesn't explain it.
It is bad though: your vendor doesn't tell the kernel about the HW being free of Spectre-v2, and doesn't provide a mitigation either. Hopefully, this is a responsible vendor that will provide you with a firmware update that fixes it.
Quoted 6 lines
If I revert the patch,
psci_cpu_suspend_enter()is never called, so we don't tickle thearm_smccc_smc()monster.Could it be that this FW doesn't support PSCI?
Probably not in as well as it could, at least for CPU suspend.
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 6 lines · Marc Zyngier
Quoted 4 lines · Marc Gonzalez
The following dmesg log caught my eye, and might be relevant:
ARM_SMCCC_ARCH_WORKAROUND_1missing from firmware
Quoted 8 lines
Quoted 1 line
Is that bad, doctor? I don't think it would explain the crash though...
It doesn't explain it.
It is bad though: your vendor doesn't tell the kernel about the HW being free of Spectre-v2, and doesn't provide a mitigation either. Hopefully, this is a responsible vendor that will provide you with a firmware update that fixes it.
# cd /sys/devices/system/cpu/vulnerabilities/ # grep "" * l1tf:Not affected mds:Not affected meltdown:Mitigation: PTI spec_store_bypass:Vulnerable spectre_v1:Mitigation: __user pointer sanitization spectre_v2:Vulnerable
OK, so there are apparently two unmitigated vulns, spec_store_bypass and spectre_v2.
These vulns need to be mitigated in FW because otherwise some secure property of the secure OS could be violated? Or because disabling the faulty optimization requires secure privileges?
Some documentation, for my own reference:
https://elixir.bootlin.com/linux/latest/source/Documentation/ABI/testing/sysfs-devices-system-cpu
https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability
Regards.
Marc Gonzalez
Tested-byRe: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
In reply to Marc GonzalezQuoted 1 line · Marc Gonzalez
Could it be that this FW doesn't support PSCI?
I believe it works now.
As pointed out by Niklas in v1:
arm,psci-suspend-param needs to be 0x40000003 not 0x3
(If either local-timer-stop is removed, bad things happen.)
Below is the diff with next-20190521.
arch/arm64/boot/dts/qcom/msm8998.dtsi +50 -0
@@ -78,6 +78,7 @@ compatible = "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "arm,arch-cache";
@@ -96,6 +97,7 @@ compatible = "arm,armv8"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; next-level-cache = <&L2_0>; L1_I_1: l1-icache { compatible = "arm,arch-cache";
@@ -110,6 +112,7 @@ compatible = "arm,armv8"; reg = <0x0 0x2>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; next-level-cache = <&L2_0>; L1_I_2: l1-icache { compatible = "arm,arch-cache";
@@ -124,6 +127,7 @@ compatible = "arm,armv8"; reg = <0x0 0x3>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; next-level-cache = <&L2_0>; L1_I_3: l1-icache { compatible = "arm,arch-cache";
@@ -138,6 +142,7 @@ compatible = "arm,armv8"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "arm,arch-cache";
@@ -156,6 +161,7 @@ compatible = "arm,armv8"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; next-level-cache = <&L2_1>; L1_I_101: l1-icache { compatible = "arm,arch-cache";
@@ -170,6 +176,7 @@ compatible = "arm,armv8"; reg = <0x0 0x102>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; next-level-cache = <&L2_1>; L1_I_102: l1-icache { compatible = "arm,arch-cache";
@@ -184,6 +191,7 @@ compatible = "arm,armv8"; reg = <0x0 0x103>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; next-level-cache = <&L2_1>; L1_I_103: l1-icache { compatible = "arm,arch-cache";
@@ -230,6 +238,48 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <43>; + exit-latency-us = <86>; + min-residency-us = <200>; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-collapse"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <100>; + exit-latency-us = <612>; + min-residency-us = <1000>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <41>; + exit-latency-us = <82>; + min-residency-us = <200>; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-collapse"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <100>; + exit-latency-us = <525>; + min-residency-us = <1000>; + local-timer-stop; + }; + }; }; firmware {
# for F in $(find /sys/devices/system/cpu -type f); do echo $F; cat $F; done /sys/devices/system/cpu/cpuidle/current_governor_ro menu /sys/devices/system/cpu/cpuidle/current_driver arm_idle /sys/devices/system/cpu/uevent /sys/devices/system/cpu/cpu7/cpuidle/state1/disable 0 /sys/devices/system/cpu/cpu7/cpuidle/state1/above 1 /sys/devices/system/cpu/cpu7/cpuidle/state1/time 15749 /sys/devices/system/cpu/cpu7/cpuidle/state1/power 0 /sys/devices/system/cpu/cpu7/cpuidle/state1/residency 200 /sys/devices/system/cpu/cpu7/cpuidle/state1/latency 123 /sys/devices/system/cpu/cpu7/cpuidle/state1/usage 19 /sys/devices/system/cpu/cpu7/cpuidle/state1/desc big-retention /sys/devices/system/cpu/cpu7/cpuidle/state1/below 6 /sys/devices/system/cpu/cpu7/cpuidle/state1/name cpu-sleep-1-0 /sys/devices/system/cpu/cpu7/cpuidle/driver/name arm_idle /sys/devices/system/cpu/cpu7/cpuidle/state2/disable 0 /sys/devices/system/cpu/cpu7/cpuidle/state2/above 8 /sys/devices/system/cpu/cpu7/cpuidle/state2/time 616012492 /sys/devices/system/cpu/cpu7/cpuidle/state2/power 0 /sys/devices/system/cpu/cpu7/cpuidle/state2/residency 1000 /sys/devices/system/cpu/cpu7/cpuidle/state2/latency 625 /sys/devices/system/cpu/cpu7/cpuidle/state2/usage 120 /sys/devices/system/cpu/cpu7/cpuidle/state2/desc big-power-collapse /sys/devices/system/cpu/cpu7/cpuidle/state2/below 0 /sys/devices/system/cpu/cpu7/cpuidle/state2/name cpu-sleep-1-1 /sys/devices/system/cpu/cpu7/cpuidle/state0/disable 0 /sys/devices/system/cpu/cpu7/cpuidle/state0/above 0 /sys/devices/system/cpu/cpu7/cpuidle/state0/time 29077 /sys/devices/system/cpu/cpu7/cpuidle/state0/power 4294967295 /sys/devices/system/cpu/cpu7/cpuidle/state0/residency 1 /sys/devices/system/cpu/cpu7/cpuidle/state0/latency 1 /sys/devices/system/cpu/cpu7/cpuidle/state0/usage 11 /sys/devices/system/cpu/cpu7/cpuidle/state0/desc ARM WFI /sys/devices/system/cpu/cpu7/cpuidle/state0/below 8 /sys/devices/system/cpu/cpu7/cpuidle/state0/name WFI /sys/devices/system/cpu/cpu7/uevent OF_NAME=cpu OF_FULLNAME=/cpus/cpu@103 OF_TYPE=cpu OF_COMPATIBLE_0=arm,armv8 OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu7/power/runtime_active_time
0/sys/devices/system/cpu/cpu7/power/pm_qos_resume_latency_us
0/sys/devices/system/cpu/cpu7/power/runtime_status
unsupported /sys/devices/system/cpu/cpu7/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu7/power/runtime_suspended_time
0/sys/devices/system/cpu/cpu7/power/control
auto/sys/devices/system/cpu/cpu7/topology/physical_package_id
1/sys/devices/system/cpu/cpu7/topology/core_siblings
f0/sys/devices/system/cpu/cpu7/topology/core_siblings_list
4-7/sys/devices/system/cpu/cpu7/topology/thread_siblings_list
7/sys/devices/system/cpu/cpu7/topology/core_id
3/sys/devices/system/cpu/cpu7/topology/thread_siblings
80/sys/devices/system/cpu/cpu7/cpu_capacity
1024/sys/devices/system/cpu/cpu7/cache/uevent /sys/devices/system/cpu/cpu7/cache/index2/uevent /sys/devices/system/cpu/cpu7/cache/index2/shared_cpu_list
4-7/sys/devices/system/cpu/cpu7/cache/index2/type
Unified/sys/devices/system/cpu/cpu7/cache/index2/level
2/sys/devices/system/cpu/cpu7/cache/index2/shared_cpu_map
f0/sys/devices/system/cpu/cpu7/cache/index0/uevent /sys/devices/system/cpu/cpu7/cache/index0/shared_cpu_list
7/sys/devices/system/cpu/cpu7/cache/index0/type
Data/sys/devices/system/cpu/cpu7/cache/index0/level
1/sys/devices/system/cpu/cpu7/cache/index0/shared_cpu_map
80/sys/devices/system/cpu/cpu7/cache/index1/uevent /sys/devices/system/cpu/cpu7/cache/index1/shared_cpu_list
7/sys/devices/system/cpu/cpu7/cache/index1/type
Instruction/sys/devices/system/cpu/cpu7/cache/index1/level
1/sys/devices/system/cpu/cpu7/cache/index1/shared_cpu_map
80/sys/devices/system/cpu/cpu7/regs/identification/revidr_el1 0x0000000000000001 /sys/devices/system/cpu/cpu7/regs/identification/midr_el1 0x0000000051af8001 /sys/devices/system/cpu/cpu5/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu5/cpuidle/state1/above
0/sys/devices/system/cpu/cpu5/cpuidle/state1/time
19922/sys/devices/system/cpu/cpu5/cpuidle/state1/power
0/sys/devices/system/cpu/cpu5/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu5/cpuidle/state1/latency
123/sys/devices/system/cpu/cpu5/cpuidle/state1/usage
28/sys/devices/system/cpu/cpu5/cpuidle/state1/desc
big-retention/sys/devices/system/cpu/cpu5/cpuidle/state1/below
5/sys/devices/system/cpu/cpu5/cpuidle/state1/name
cpu-sleep-1-0/sys/devices/system/cpu/cpu5/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu5/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu5/cpuidle/state2/above
12/sys/devices/system/cpu/cpu5/cpuidle/state2/time
616088023/sys/devices/system/cpu/cpu5/cpuidle/state2/power
0/sys/devices/system/cpu/cpu5/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu5/cpuidle/state2/latency
625/sys/devices/system/cpu/cpu5/cpuidle/state2/usage
248/sys/devices/system/cpu/cpu5/cpuidle/state2/desc big-power-collapse /sys/devices/system/cpu/cpu5/cpuidle/state2/below
0/sys/devices/system/cpu/cpu5/cpuidle/state2/name
cpu-sleep-1-1/sys/devices/system/cpu/cpu5/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu5/cpuidle/state0/above
0/sys/devices/system/cpu/cpu5/cpuidle/state0/time
30023/sys/devices/system/cpu/cpu5/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu5/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu5/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu5/cpuidle/state0/usage
16/sys/devices/system/cpu/cpu5/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu5/cpuidle/state0/below
10/sys/devices/system/cpu/cpu5/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu5/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@101
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu5/power/runtime_active_time 0 /sys/devices/system/cpu/cpu5/power/pm_qos_resume_latency_us 0 /sys/devices/system/cpu/cpu5/power/runtime_status unsupported /sys/devices/system/cpu/cpu5/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu5/power/runtime_suspended_time 0/sys/devices/system/cpu/cpu5/power/control
auto /sys/devices/system/cpu/cpu5/topology/physical_package_id 1 /sys/devices/system/cpu/cpu5/topology/core_siblings f0 /sys/devices/system/cpu/cpu5/topology/core_siblings_list 4-7 /sys/devices/system/cpu/cpu5/topology/thread_siblings_list 5/sys/devices/system/cpu/cpu5/topology/core_id
1 /sys/devices/system/cpu/cpu5/topology/thread_siblings 20/sys/devices/system/cpu/cpu5/cpu_capacity
1024/sys/devices/system/cpu/cpu5/cache/uevent /sys/devices/system/cpu/cpu5/cache/index2/uevent /sys/devices/system/cpu/cpu5/cache/index2/shared_cpu_list 4-7/sys/devices/system/cpu/cpu5/cache/index2/type Unified /sys/devices/system/cpu/cpu5/cache/index2/level
2 /sys/devices/system/cpu/cpu5/cache/index2/shared_cpu_map f0 /sys/devices/system/cpu/cpu5/cache/index0/uevent /sys/devices/system/cpu/cpu5/cache/index0/shared_cpu_list 5/sys/devices/system/cpu/cpu5/cache/index0/type Data /sys/devices/system/cpu/cpu5/cache/index0/level
1 /sys/devices/system/cpu/cpu5/cache/index0/shared_cpu_map 20 /sys/devices/system/cpu/cpu5/cache/index1/uevent /sys/devices/system/cpu/cpu5/cache/index1/shared_cpu_list 5/sys/devices/system/cpu/cpu5/cache/index1/type Instruction /sys/devices/system/cpu/cpu5/cache/index1/level
1 /sys/devices/system/cpu/cpu5/cache/index1/shared_cpu_map 20 /sys/devices/system/cpu/cpu5/regs/identification/revidr_el1 0x0000000000000001 /sys/devices/system/cpu/cpu5/regs/identification/midr_el1 0x0000000051af8001 /sys/devices/system/cpu/possible
0-7/sys/devices/system/cpu/offline
/sys/devices/system/cpu/present
0-7/sys/devices/system/cpu/power/runtime_active_time
0/sys/devices/system/cpu/power/runtime_status
unsupported/sys/devices/system/cpu/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/power/runtime_suspended_time
0/sys/devices/system/cpu/power/control
auto/sys/devices/system/cpu/cpu3/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu3/cpuidle/state1/above
0/sys/devices/system/cpu/cpu3/cpuidle/state1/time
7453/sys/devices/system/cpu/cpu3/cpuidle/state1/power
0/sys/devices/system/cpu/cpu3/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu3/cpuidle/state1/latency
129/sys/devices/system/cpu/cpu3/cpuidle/state1/usage
10/sys/devices/system/cpu/cpu3/cpuidle/state1/desc
little-retention/sys/devices/system/cpu/cpu3/cpuidle/state1/below
2/sys/devices/system/cpu/cpu3/cpuidle/state1/name
cpu-sleep-0-0/sys/devices/system/cpu/cpu3/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu3/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu3/cpuidle/state2/above
8/sys/devices/system/cpu/cpu3/cpuidle/state2/time
616684999/sys/devices/system/cpu/cpu3/cpuidle/state2/power
0/sys/devices/system/cpu/cpu3/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu3/cpuidle/state2/latency
712/sys/devices/system/cpu/cpu3/cpuidle/state2/usage
298/sys/devices/system/cpu/cpu3/cpuidle/state2/desc little-power-collapse /sys/devices/system/cpu/cpu3/cpuidle/state2/below
0/sys/devices/system/cpu/cpu3/cpuidle/state2/name
cpu-sleep-0-1/sys/devices/system/cpu/cpu3/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu3/cpuidle/state0/above
0/sys/devices/system/cpu/cpu3/cpuidle/state0/time
29256/sys/devices/system/cpu/cpu3/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu3/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu3/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu3/cpuidle/state0/usage
11/sys/devices/system/cpu/cpu3/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu3/cpuidle/state0/below
8/sys/devices/system/cpu/cpu3/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu3/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@3
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu3/power/runtime_active_time
0/sys/devices/system/cpu/cpu3/power/pm_qos_resume_latency_us
0/sys/devices/system/cpu/cpu3/power/runtime_status
unsupported /sys/devices/system/cpu/cpu3/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu3/power/runtime_suspended_time
0/sys/devices/system/cpu/cpu3/power/control
auto/sys/devices/system/cpu/cpu3/topology/physical_package_id
0/sys/devices/system/cpu/cpu3/topology/core_siblings
0f/sys/devices/system/cpu/cpu3/topology/core_siblings_list
0-3/sys/devices/system/cpu/cpu3/topology/thread_siblings_list
3/sys/devices/system/cpu/cpu3/topology/core_id
3/sys/devices/system/cpu/cpu3/topology/thread_siblings
08/sys/devices/system/cpu/cpu3/cpu_capacity
1024/sys/devices/system/cpu/cpu3/cache/uevent /sys/devices/system/cpu/cpu3/cache/index2/uevent /sys/devices/system/cpu/cpu3/cache/index2/shared_cpu_list
0-3/sys/devices/system/cpu/cpu3/cache/index2/type
Unified/sys/devices/system/cpu/cpu3/cache/index2/level
2/sys/devices/system/cpu/cpu3/cache/index2/shared_cpu_map
0f/sys/devices/system/cpu/cpu3/cache/index0/uevent /sys/devices/system/cpu/cpu3/cache/index0/shared_cpu_list
3/sys/devices/system/cpu/cpu3/cache/index0/type
Data/sys/devices/system/cpu/cpu3/cache/index0/level
1/sys/devices/system/cpu/cpu3/cache/index0/shared_cpu_map
08/sys/devices/system/cpu/cpu3/cache/index1/uevent /sys/devices/system/cpu/cpu3/cache/index1/shared_cpu_list
3/sys/devices/system/cpu/cpu3/cache/index1/type
Instruction/sys/devices/system/cpu/cpu3/cache/index1/level
1/sys/devices/system/cpu/cpu3/cache/index1/shared_cpu_map
08/sys/devices/system/cpu/cpu3/regs/identification/revidr_el1 0x0000000000000180 /sys/devices/system/cpu/cpu3/regs/identification/midr_el1 0x0000000051af8014/sys/devices/system/cpu/online
0-7/sys/devices/system/cpu/cpu1/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu1/cpuidle/state1/above
3/sys/devices/system/cpu/cpu1/cpuidle/state1/time
8494/sys/devices/system/cpu/cpu1/cpuidle/state1/power
0/sys/devices/system/cpu/cpu1/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu1/cpuidle/state1/latency
129/sys/devices/system/cpu/cpu1/cpuidle/state1/usage
15/sys/devices/system/cpu/cpu1/cpuidle/state1/desc
little-retention/sys/devices/system/cpu/cpu1/cpuidle/state1/below
0/sys/devices/system/cpu/cpu1/cpuidle/state1/name
cpu-sleep-0-0/sys/devices/system/cpu/cpu1/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu1/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu1/cpuidle/state2/above
6/sys/devices/system/cpu/cpu1/cpuidle/state2/time
617122679/sys/devices/system/cpu/cpu1/cpuidle/state2/power
0/sys/devices/system/cpu/cpu1/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu1/cpuidle/state2/latency
712/sys/devices/system/cpu/cpu1/cpuidle/state2/usage
394/sys/devices/system/cpu/cpu1/cpuidle/state2/desc little-power-collapse /sys/devices/system/cpu/cpu1/cpuidle/state2/below
0/sys/devices/system/cpu/cpu1/cpuidle/state2/name
cpu-sleep-0-1/sys/devices/system/cpu/cpu1/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu1/cpuidle/state0/above
0/sys/devices/system/cpu/cpu1/cpuidle/state0/time
4704/sys/devices/system/cpu/cpu1/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu1/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu1/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu1/cpuidle/state0/usage
8/sys/devices/system/cpu/cpu1/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu1/cpuidle/state0/below
4/sys/devices/system/cpu/cpu1/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu1/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@1
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu1/power/runtime_active_time
0/sys/devices/system/cpu/cpu1/power/pm_qos_resume_latency_us
0/sys/devices/system/cpu/cpu1/power/runtime_status
unsupported /sys/devices/system/cpu/cpu1/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu1/power/runtime_suspended_time
0/sys/devices/system/cpu/cpu1/power/control
auto/sys/devices/system/cpu/cpu1/topology/physical_package_id
0/sys/devices/system/cpu/cpu1/topology/core_siblings
0f/sys/devices/system/cpu/cpu1/topology/core_siblings_list
0-3/sys/devices/system/cpu/cpu1/topology/thread_siblings_list
1/sys/devices/system/cpu/cpu1/topology/core_id
1/sys/devices/system/cpu/cpu1/topology/thread_siblings
02/sys/devices/system/cpu/cpu1/cpu_capacity
1024/sys/devices/system/cpu/cpu1/cache/uevent /sys/devices/system/cpu/cpu1/cache/index2/uevent /sys/devices/system/cpu/cpu1/cache/index2/shared_cpu_list
0-3/sys/devices/system/cpu/cpu1/cache/index2/type
Unified/sys/devices/system/cpu/cpu1/cache/index2/level
2/sys/devices/system/cpu/cpu1/cache/index2/shared_cpu_map
0f/sys/devices/system/cpu/cpu1/cache/index0/uevent /sys/devices/system/cpu/cpu1/cache/index0/shared_cpu_list
1/sys/devices/system/cpu/cpu1/cache/index0/type
Data/sys/devices/system/cpu/cpu1/cache/index0/level
1/sys/devices/system/cpu/cpu1/cache/index0/shared_cpu_map
02/sys/devices/system/cpu/cpu1/cache/index1/uevent /sys/devices/system/cpu/cpu1/cache/index1/shared_cpu_list
1/sys/devices/system/cpu/cpu1/cache/index1/type
Instruction/sys/devices/system/cpu/cpu1/cache/index1/level
1/sys/devices/system/cpu/cpu1/cache/index1/shared_cpu_map
02/sys/devices/system/cpu/cpu1/regs/identification/revidr_el1 0x0000000000000180 /sys/devices/system/cpu/cpu1/regs/identification/midr_el1 0x0000000051af8014 /sys/devices/system/cpu/vulnerabilities/spectre_v2
Vulnerable/sys/devices/system/cpu/vulnerabilities/mds
Not affected/sys/devices/system/cpu/vulnerabilities/l1tf
Not affected /sys/devices/system/cpu/vulnerabilities/spec_store_bypass Vulnerable/sys/devices/system/cpu/vulnerabilities/spectre_v1
Mitigation: __user pointer sanitization /sys/devices/system/cpu/vulnerabilities/meltdown
Mitigation: PTI /sys/devices/system/cpu/cpu6/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu6/cpuidle/state1/above
0/sys/devices/system/cpu/cpu6/cpuidle/state1/time
7186/sys/devices/system/cpu/cpu6/cpuidle/state1/power
0/sys/devices/system/cpu/cpu6/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu6/cpuidle/state1/latency
123/sys/devices/system/cpu/cpu6/cpuidle/state1/usage
9/sys/devices/system/cpu/cpu6/cpuidle/state1/desc
big-retention/sys/devices/system/cpu/cpu6/cpuidle/state1/below
2/sys/devices/system/cpu/cpu6/cpuidle/state1/name
cpu-sleep-1-0/sys/devices/system/cpu/cpu6/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu6/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu6/cpuidle/state2/above
4/sys/devices/system/cpu/cpu6/cpuidle/state2/time
617440536/sys/devices/system/cpu/cpu6/cpuidle/state2/power
0/sys/devices/system/cpu/cpu6/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu6/cpuidle/state2/latency
625/sys/devices/system/cpu/cpu6/cpuidle/state2/usage
385/sys/devices/system/cpu/cpu6/cpuidle/state2/desc big-power-collapse /sys/devices/system/cpu/cpu6/cpuidle/state2/below
0/sys/devices/system/cpu/cpu6/cpuidle/state2/name
cpu-sleep-1-1/sys/devices/system/cpu/cpu6/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu6/cpuidle/state0/above
0/sys/devices/system/cpu/cpu6/cpuidle/state0/time
28990/sys/devices/system/cpu/cpu6/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu6/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu6/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu6/cpuidle/state0/usage
10/sys/devices/system/cpu/cpu6/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu6/cpuidle/state0/below
8/sys/devices/system/cpu/cpu6/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu6/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@102
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu6/power/runtime_active_time
0/sys/devices/system/cpu/cpu6/power/pm_qos_resume_latency_us
0/sys/devices/system/cpu/cpu6/power/runtime_status
unsupported /sys/devices/system/cpu/cpu6/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu6/power/runtime_suspended_time
0/sys/devices/system/cpu/cpu6/power/control
auto/sys/devices/system/cpu/cpu6/topology/physical_package_id
1/sys/devices/system/cpu/cpu6/topology/core_siblings
f0/sys/devices/system/cpu/cpu6/topology/core_siblings_list
4-7/sys/devices/system/cpu/cpu6/topology/thread_siblings_list
6/sys/devices/system/cpu/cpu6/topology/core_id
2/sys/devices/system/cpu/cpu6/topology/thread_siblings
40/sys/devices/system/cpu/cpu6/cpu_capacity
1024/sys/devices/system/cpu/cpu6/cache/uevent /sys/devices/system/cpu/cpu6/cache/index2/uevent /sys/devices/system/cpu/cpu6/cache/index2/shared_cpu_list
4-7/sys/devices/system/cpu/cpu6/cache/index2/type
Unified/sys/devices/system/cpu/cpu6/cache/index2/level
2/sys/devices/system/cpu/cpu6/cache/index2/shared_cpu_map
f0/sys/devices/system/cpu/cpu6/cache/index0/uevent /sys/devices/system/cpu/cpu6/cache/index0/shared_cpu_list
6/sys/devices/system/cpu/cpu6/cache/index0/type
Data/sys/devices/system/cpu/cpu6/cache/index0/level
1/sys/devices/system/cpu/cpu6/cache/index0/shared_cpu_map
40/sys/devices/system/cpu/cpu6/cache/index1/uevent /sys/devices/system/cpu/cpu6/cache/index1/shared_cpu_list
6/sys/devices/system/cpu/cpu6/cache/index1/type
Instruction/sys/devices/system/cpu/cpu6/cache/index1/level
1/sys/devices/system/cpu/cpu6/cache/index1/shared_cpu_map
40/sys/devices/system/cpu/cpu6/regs/identification/revidr_el1 0x0000000000000001 /sys/devices/system/cpu/cpu6/regs/identification/midr_el1 0x0000000051af8001 /sys/devices/system/cpu/cpu4/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu4/cpuidle/state1/above
4/sys/devices/system/cpu/cpu4/cpuidle/state1/time
48576/sys/devices/system/cpu/cpu4/cpuidle/state1/power
0/sys/devices/system/cpu/cpu4/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu4/cpuidle/state1/latency
123/sys/devices/system/cpu/cpu4/cpuidle/state1/usage
58/sys/devices/system/cpu/cpu4/cpuidle/state1/desc
big-retention/sys/devices/system/cpu/cpu4/cpuidle/state1/below
15/sys/devices/system/cpu/cpu4/cpuidle/state1/name
cpu-sleep-1-0/sys/devices/system/cpu/cpu4/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu4/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu4/cpuidle/state2/above
19/sys/devices/system/cpu/cpu4/cpuidle/state2/time
617566283/sys/devices/system/cpu/cpu4/cpuidle/state2/power
0/sys/devices/system/cpu/cpu4/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu4/cpuidle/state2/latency
625/sys/devices/system/cpu/cpu4/cpuidle/state2/usage
515/sys/devices/system/cpu/cpu4/cpuidle/state2/desc big-power-collapse /sys/devices/system/cpu/cpu4/cpuidle/state2/below
0/sys/devices/system/cpu/cpu4/cpuidle/state2/name
cpu-sleep-1-1/sys/devices/system/cpu/cpu4/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu4/cpuidle/state0/above
0/sys/devices/system/cpu/cpu4/cpuidle/state0/time
33524/sys/devices/system/cpu/cpu4/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu4/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu4/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu4/cpuidle/state0/usage
19/sys/devices/system/cpu/cpu4/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu4/cpuidle/state0/below
9/sys/devices/system/cpu/cpu4/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu4/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@100
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu4/power/runtime_active_time 0 /sys/devices/system/cpu/cpu4/power/pm_qos_resume_latency_us 0 /sys/devices/system/cpu/cpu4/power/runtime_status unsupported /sys/devices/system/cpu/cpu4/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu4/power/runtime_suspended_time 0/sys/devices/system/cpu/cpu4/power/control
auto /sys/devices/system/cpu/cpu4/topology/physical_package_id 1 /sys/devices/system/cpu/cpu4/topology/core_siblings f0 /sys/devices/system/cpu/cpu4/topology/core_siblings_list 4-7 /sys/devices/system/cpu/cpu4/topology/thread_siblings_list 4/sys/devices/system/cpu/cpu4/topology/core_id
0 /sys/devices/system/cpu/cpu4/topology/thread_siblings 10/sys/devices/system/cpu/cpu4/cpu_capacity
1024/sys/devices/system/cpu/cpu4/cache/uevent /sys/devices/system/cpu/cpu4/cache/index2/uevent /sys/devices/system/cpu/cpu4/cache/index2/shared_cpu_list 4-7/sys/devices/system/cpu/cpu4/cache/index2/type Unified /sys/devices/system/cpu/cpu4/cache/index2/level
2 /sys/devices/system/cpu/cpu4/cache/index2/shared_cpu_map f0 /sys/devices/system/cpu/cpu4/cache/index0/uevent /sys/devices/system/cpu/cpu4/cache/index0/shared_cpu_list 4/sys/devices/system/cpu/cpu4/cache/index0/type Data /sys/devices/system/cpu/cpu4/cache/index0/level
1 /sys/devices/system/cpu/cpu4/cache/index0/shared_cpu_map 10 /sys/devices/system/cpu/cpu4/cache/index1/uevent /sys/devices/system/cpu/cpu4/cache/index1/shared_cpu_list 4/sys/devices/system/cpu/cpu4/cache/index1/type Instruction /sys/devices/system/cpu/cpu4/cache/index1/level
1 /sys/devices/system/cpu/cpu4/cache/index1/shared_cpu_map 10 /sys/devices/system/cpu/cpu4/regs/identification/revidr_el1 0x0000000000000001 /sys/devices/system/cpu/cpu4/regs/identification/midr_el1 0x0000000051af8001 /sys/devices/system/cpu/isolated
/sys/devices/system/cpu/kernel_max
255/sys/devices/system/cpu/cpu2/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu2/cpuidle/state1/above
27/sys/devices/system/cpu/cpu2/cpuidle/state1/time
80485/sys/devices/system/cpu/cpu2/cpuidle/state1/power
0/sys/devices/system/cpu/cpu2/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu2/cpuidle/state1/latency
129/sys/devices/system/cpu/cpu2/cpuidle/state1/usage
142/sys/devices/system/cpu/cpu2/cpuidle/state1/desc
little-retention/sys/devices/system/cpu/cpu2/cpuidle/state1/below
6/sys/devices/system/cpu/cpu2/cpuidle/state1/name
cpu-sleep-0-0/sys/devices/system/cpu/cpu2/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu2/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu2/cpuidle/state2/above
14/sys/devices/system/cpu/cpu2/cpuidle/state2/time
617916929/sys/devices/system/cpu/cpu2/cpuidle/state2/power
0/sys/devices/system/cpu/cpu2/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu2/cpuidle/state2/latency
712/sys/devices/system/cpu/cpu2/cpuidle/state2/usage
614/sys/devices/system/cpu/cpu2/cpuidle/state2/desc little-power-collapse /sys/devices/system/cpu/cpu2/cpuidle/state2/below
0/sys/devices/system/cpu/cpu2/cpuidle/state2/name
cpu-sleep-0-1/sys/devices/system/cpu/cpu2/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu2/cpuidle/state0/above
0/sys/devices/system/cpu/cpu2/cpuidle/state0/time
36601/sys/devices/system/cpu/cpu2/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu2/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu2/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu2/cpuidle/state0/usage
49/sys/devices/system/cpu/cpu2/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu2/cpuidle/state0/below
20/sys/devices/system/cpu/cpu2/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu2/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@2
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu2/power/runtime_active_time
0/sys/devices/system/cpu/cpu2/power/pm_qos_resume_latency_us
0/sys/devices/system/cpu/cpu2/power/runtime_status
unsupported /sys/devices/system/cpu/cpu2/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu2/power/runtime_suspended_time
0/sys/devices/system/cpu/cpu2/power/control
auto/sys/devices/system/cpu/cpu2/topology/physical_package_id
0/sys/devices/system/cpu/cpu2/topology/core_siblings
0f/sys/devices/system/cpu/cpu2/topology/core_siblings_list
0-3/sys/devices/system/cpu/cpu2/topology/thread_siblings_list
2/sys/devices/system/cpu/cpu2/topology/core_id
2/sys/devices/system/cpu/cpu2/topology/thread_siblings
04/sys/devices/system/cpu/cpu2/cpu_capacity
1024/sys/devices/system/cpu/cpu2/cache/uevent /sys/devices/system/cpu/cpu2/cache/index2/uevent /sys/devices/system/cpu/cpu2/cache/index2/shared_cpu_list
0-3/sys/devices/system/cpu/cpu2/cache/index2/type
Unified/sys/devices/system/cpu/cpu2/cache/index2/level
2/sys/devices/system/cpu/cpu2/cache/index2/shared_cpu_map
0f/sys/devices/system/cpu/cpu2/cache/index0/uevent /sys/devices/system/cpu/cpu2/cache/index0/shared_cpu_list
2/sys/devices/system/cpu/cpu2/cache/index0/type
Data/sys/devices/system/cpu/cpu2/cache/index0/level
1/sys/devices/system/cpu/cpu2/cache/index0/shared_cpu_map
04/sys/devices/system/cpu/cpu2/cache/index1/uevent /sys/devices/system/cpu/cpu2/cache/index1/shared_cpu_list
2/sys/devices/system/cpu/cpu2/cache/index1/type
Instruction/sys/devices/system/cpu/cpu2/cache/index1/level
1/sys/devices/system/cpu/cpu2/cache/index1/shared_cpu_map
04/sys/devices/system/cpu/cpu2/regs/identification/revidr_el1 0x0000000000000180 /sys/devices/system/cpu/cpu2/regs/identification/midr_el1 0x0000000051af8014 /sys/devices/system/cpu/cpu0/cpuidle/state1/disable
0/sys/devices/system/cpu/cpu0/cpuidle/state1/above
42/sys/devices/system/cpu/cpu0/cpuidle/state1/time
363386/sys/devices/system/cpu/cpu0/cpuidle/state1/power
0/sys/devices/system/cpu/cpu0/cpuidle/state1/residency
200/sys/devices/system/cpu/cpu0/cpuidle/state1/latency
129/sys/devices/system/cpu/cpu0/cpuidle/state1/usage
416/sys/devices/system/cpu/cpu0/cpuidle/state1/desc
little-retention/sys/devices/system/cpu/cpu0/cpuidle/state1/below
117/sys/devices/system/cpu/cpu0/cpuidle/state1/name
cpu-sleep-0-0/sys/devices/system/cpu/cpu0/cpuidle/driver/namearm_idle/sys/devices/system/cpu/cpu0/cpuidle/state2/disable
0/sys/devices/system/cpu/cpu0/cpuidle/state2/above
189/sys/devices/system/cpu/cpu0/cpuidle/state2/time
616567065/sys/devices/system/cpu/cpu0/cpuidle/state2/power
0/sys/devices/system/cpu/cpu0/cpuidle/state2/residency
1000/sys/devices/system/cpu/cpu0/cpuidle/state2/latency
712/sys/devices/system/cpu/cpu0/cpuidle/state2/usage
1661/sys/devices/system/cpu/cpu0/cpuidle/state2/desc little-power-collapse /sys/devices/system/cpu/cpu0/cpuidle/state2/below
0/sys/devices/system/cpu/cpu0/cpuidle/state2/name
cpu-sleep-0-1/sys/devices/system/cpu/cpu0/cpuidle/state0/disable
0/sys/devices/system/cpu/cpu0/cpuidle/state0/above
0/sys/devices/system/cpu/cpu0/cpuidle/state0/time
7123/sys/devices/system/cpu/cpu0/cpuidle/state0/power
4294967295/sys/devices/system/cpu/cpu0/cpuidle/state0/residency
1/sys/devices/system/cpu/cpu0/cpuidle/state0/latency
1/sys/devices/system/cpu/cpu0/cpuidle/state0/usage
53/sys/devices/system/cpu/cpu0/cpuidle/state0/desc
ARM WFI/sys/devices/system/cpu/cpu0/cpuidle/state0/below
14/sys/devices/system/cpu/cpu0/cpuidle/state0/name
WFI/sys/devices/system/cpu/cpu0/uevent
OF_NAME=cpu
OF_FULLNAME=/cpus/cpu@0
OF_TYPE=cpu
OF_COMPATIBLE_0=arm,armv8
OF_COMPATIBLE_N=1 MODALIAS=cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
/sys/devices/system/cpu/cpu0/power/runtime_active_time
0 /sys/devices/system/cpu/cpu0/power/pm_qos_resume_latency_us 0/sys/devices/system/cpu/cpu0/power/runtime_status unsupported /sys/devices/system/cpu/cpu0/power/autosuspend_delay_ms
cat: read error: Input/output error /sys/devices/system/cpu/cpu0/power/runtime_suspended_time
0/sys/devices/system/cpu/cpu0/power/control
auto /sys/devices/system/cpu/cpu0/topology/physical_package_id
0/sys/devices/system/cpu/cpu0/topology/core_siblings
0f/sys/devices/system/cpu/cpu0/topology/core_siblings_list 0-3 /sys/devices/system/cpu/cpu0/topology/thread_siblings_list 0/sys/devices/system/cpu/cpu0/topology/core_id
0/sys/devices/system/cpu/cpu0/topology/thread_siblings
01/sys/devices/system/cpu/cpu0/cpu_capacity
1024/sys/devices/system/cpu/cpu0/cache/uevent /sys/devices/system/cpu/cpu0/cache/index2/uevent /sys/devices/system/cpu/cpu0/cache/index2/shared_cpu_list 0-3/sys/devices/system/cpu/cpu0/cache/index2/type
Unified/sys/devices/system/cpu/cpu0/cache/index2/level
2/sys/devices/system/cpu/cpu0/cache/index2/shared_cpu_map
0f/sys/devices/system/cpu/cpu0/cache/index0/uevent /sys/devices/system/cpu/cpu0/cache/index0/shared_cpu_list
0/sys/devices/system/cpu/cpu0/cache/index0/type
Data/sys/devices/system/cpu/cpu0/cache/index0/level
1/sys/devices/system/cpu/cpu0/cache/index0/shared_cpu_map
01/sys/devices/system/cpu/cpu0/cache/index1/uevent /sys/devices/system/cpu/cpu0/cache/index1/shared_cpu_list
0/sys/devices/system/cpu/cpu0/cache/index1/type
Instruction/sys/devices/system/cpu/cpu0/cache/index1/level
1/sys/devices/system/cpu/cpu0/cache/index1/shared_cpu_map
01 /sys/devices/system/cpu/cpu0/regs/identification/revidr_el1 0x0000000000000180 /sys/devices/system/cpu/cpu0/regs/identification/midr_el1 0x0000000051af8014/sys/devices/system/cpu/modalias cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
In reply to Amit KucheriaAmit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Do you have any suggestions on how we might debug this?
Quoted 130 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
Cc Marc Gonzalez <[email protected]>Signed-off-by Amit Kucheria <[email protected]>Acked-by Daniel Lezcano <[email protected]>--- arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++ 1 file changed, 50 insertions(+)arch/arm64/boot/dts/qcom/msm8998.dtsi +50
-1@@ -78,6 +78,7 @@ compatible = "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache {@@ -97,6 +98,7 @@ compatible = "arm,armv8"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_1: l1-icache {@@ -112,6 +114,7 @@ compatible = "arm,armv8"; reg = <0x0 0x2>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_2: l1-icache {@@ -127,6 +130,7 @@ compatible = "arm,armv8"; reg = <0x0 0x3>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_3: l1-icache {@@ -142,6 +146,7 @@ compatible = "arm,armv8"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L2_1: l2-cache {@@ -161,6 +166,7 @@ compatible = "arm,armv8"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_101: l1-icache {@@ -176,6 +182,7 @@ compatible = "arm,armv8"; reg = <0x0 0x102>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_102: l1-icache {@@ -191,6 +198,7 @@ compatible = "arm,armv8"; reg = <0x0 0x103>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_103: l1-icache {@@ -238,6 +246,48 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <43>; + exit-latency-us = <86>; + min-residency-us = <200>; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <612>; + min-residency-us = <1000>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <41>; + exit-latency-us = <82>; + min-residency-us = <200>; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <525>; + min-residency-us = <1000>; + local-timer-stop; + }; + }; }; firmware { --2.17.1
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Can you try removing just the *SLEEP_1 states from the cpu-idle-states property? I want to understand if this is triggered just by the deeper C-state.
Quoted 141 lines · Jeffrey Hugo
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Do you have any suggestions on how we might debug this?
Quoted 130 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
Cc Marc Gonzalez <[email protected]>Signed-off-by Amit Kucheria <[email protected]>Acked-by Daniel Lezcano <[email protected]>--- arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++ 1 file changed, 50 insertions(+)arch/arm64/boot/dts/qcom/msm8998.dtsi +50
-1@@ -78,6 +78,7 @@ compatible = "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache {@@ -97,6 +98,7 @@ compatible = "arm,armv8"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_1: l1-icache {@@ -112,6 +114,7 @@ compatible = "arm,armv8"; reg = <0x0 0x2>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_2: l1-icache {@@ -127,6 +130,7 @@ compatible = "arm,armv8"; reg = <0x0 0x3>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_3: l1-icache {@@ -142,6 +146,7 @@ compatible = "arm,armv8"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L2_1: l2-cache {@@ -161,6 +166,7 @@ compatible = "arm,armv8"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_101: l1-icache {@@ -176,6 +182,7 @@ compatible = "arm,armv8"; reg = <0x0 0x102>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_102: l1-icache {@@ -191,6 +198,7 @@ compatible = "arm,armv8"; reg = <0x0 0x103>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_103: l1-icache {@@ -238,6 +246,48 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <43>; + exit-latency-us = <86>; + min-residency-us = <200>; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <612>; + min-residency-us = <1000>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <41>; + exit-latency-us = <82>; + min-residency-us = <200>; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <525>; + min-residency-us = <1000>; + local-timer-stop; + }; + }; }; firmware { --2.17.1
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 4 lines · Amit Kucheria
Can you try removing just the
*SLEEP_1states from the cpu-idle-states property? I want to understand if this is triggered just by the deeper C-state.
Still seeing the issue with just the SLEEP_0 states. For reference, Bjorn suggested adding kpti=no to the command line, which also appeared to have no effect on the issue.
Quoted 143 lines · Jeffrey Hugo
Quoted 141 lines
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Do you have any suggestions on how we might debug this?
Quoted 130 lines · Amit Kucheria
Add device bindings for cpuidle states for cpu devices.
Cc Marc Gonzalez <[email protected]>Signed-off-by Amit Kucheria <[email protected]>Acked-by Daniel Lezcano <[email protected]>--- arch/arm64/boot/dts/qcom/msm8998.dtsi | 50 +++++++++++++++++++++++++++ 1 file changed, 50 insertions(+)arch/arm64/boot/dts/qcom/msm8998.dtsi +50
-1@@ -78,6 +78,7 @@ compatible = "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache {@@ -97,6 +98,7 @@ compatible = "arm,armv8"; reg = <0x0 0x1>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_1: l1-icache {@@ -112,6 +114,7 @@ compatible = "arm,armv8"; reg = <0x0 0x2>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_2: l1-icache {@@ -127,6 +130,7 @@ compatible = "arm,armv8"; reg = <0x0 0x3>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1>; efficiency = <1024>; next-level-cache = <&L2_0>; L1_I_3: l1-icache {@@ -142,6 +146,7 @@ compatible = "arm,armv8"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L2_1: l2-cache {@@ -161,6 +166,7 @@ compatible = "arm,armv8"; reg = <0x0 0x101>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_101: l1-icache {@@ -176,6 +182,7 @@ compatible = "arm,armv8"; reg = <0x0 0x102>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_102: l1-icache {@@ -191,6 +198,7 @@ compatible = "arm,armv8"; reg = <0x0 0x103>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1>; efficiency = <1536>; next-level-cache = <&L2_1>; L1_I_103: l1-icache {@@ -238,6 +246,48 @@ }; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <43>; + exit-latency-us = <86>; + min-residency-us = <200>; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <612>; + min-residency-us = <1000>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-retention"; + arm,psci-suspend-param = <0x00000002>; + entry-latency-us = <41>; + exit-latency-us = <82>; + min-residency-us = <200>; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-collapse"; + arm,psci-suspend-param = <0x00000003>; + entry-latency-us = <100>; + exit-latency-us = <525>; + min-residency-us = <1000>; + local-timer-stop; + }; + }; }; firmware { --2.17.1
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
In reply to Jeffrey HugoQuoted 6 lines · Jeffrey Hugo
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Hello Jeffrey, Amit,
If the PSCI idle states work properly on the msm8998 devboard (MTP), but causes crashes on msm8998 laptops, the only logical change is that the PSCI firmware is different between the two devices.
Kind regards,
Niklas
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 6 lines · Niklas Cassel
Quoted 5 lines · Jeffrey Hugo
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
Quoted 7 lines
Quoted 1 line
I see no issues with the msm8998 MTP.
Hello Jeffrey, Amit,
If the PSCI idle states work properly on the msm8998 devboard (MTP), but causes crashes on msm8998 laptops, the only logical change is that the PSCI firmware is different between the two devices.
Since the msm8998 laptops boot using ACPI, perhaps these laptops doesn't support PSCI/have any PSCI firmware at all.
Kind regards,
Niklas
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 10 lines · Niklas Cassel
Quoted 8 lines · Niklas Cassel
Quoted 6 lines · Jeffrey Hugo
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Quoted 8 lines
Quoted 5 lines
Hello Jeffrey, Amit,
If the PSCI idle states work properly on the msm8998 devboard (MTP), but causes crashes on msm8998 laptops, the only logical change is that the PSCI firmware is different between the two devices.
Since the msm8998 laptops boot using ACPI, perhaps these laptops doesn't support PSCI/have any PSCI firmware at all.
They have PSCI. If there was no PSCI, I would expect the PSCI get_version request from Linux to fail, and all PSCI functionality to be disabled.
However, your mention about ACPI sparked a thought. ACPI describes the idle states, along with the PSCI info, in the ACPI0007 devices. Those exist on the laptops, and the info mostly correlates with Amit's patch (ACPI seems to be a bit more conservative about the latencies, and describes one additional deeper state). However, upon a detailed analysis of the ACPI description, I did find something relevant - the retention state is not enabled.
So, I hacked out the retention state from Amit's patch, and I did not observe a hang. I used sysfs, and appeared able to validate that the power collapse state was being used successfully.
I'm guessing that something is weird with the laptops, where the CPUs can go into retention, but not come out, thus causing issues.
I'll post a patch to fix up the laptops. Thanks for all the help.
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 33 lines · Jeffrey Hugo
Quoted 10 lines · Niklas Cassel
Quoted 8 lines · Niklas Cassel
Quoted 6 lines · Jeffrey Hugo
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Quoted 8 lines
Quoted 5 lines
Hello Jeffrey, Amit,
If the PSCI idle states work properly on the msm8998 devboard (MTP), but causes crashes on msm8998 laptops, the only logical change is that the PSCI firmware is different between the two devices.
Since the msm8998 laptops boot using ACPI, perhaps these laptops doesn't support PSCI/have any PSCI firmware at all.
They have PSCI. If there was no PSCI, I would expect the PSCI
get_versionrequest from Linux to fail, and all PSCI functionality to be disabled.However, your mention about ACPI sparked a thought. ACPI describes the idle states, along with the PSCI info, in the ACPI0007 devices. Those exist on the laptops, and the info mostly correlates with Amit's patch (ACPI seems to be a bit more conservative about the latencies, and describes one additional deeper state). However, upon a detailed analysis of the ACPI description, I did find something relevant - the retention state is not enabled.
Quoted 3 lines
So, I hacked out the retention state from Amit's patch, and I did not observe a hang. I used sysfs, and appeared able to validate that the power collapse state was being used successfully.
Interesting that the shallower sleep state was causing problems. Usually, it is the deeper states that cause problems. So you plan to override the idle states table in the board-specific DT?
Why does the platform even rely on DT? Shouldn't we use the ACPI tables instead?
Quoted 4 lines
I'm guessing that something is weird with the laptops, where the CPUs can go into retention, but not come out, thus causing issues.
I'll post a patch to fix up the laptops. Thanks for all the help.
Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states
Quoted 35 lines · Amit Kucheria
Quoted 33 lines · Jeffrey Hugo
Quoted 10 lines · Niklas Cassel
Quoted 8 lines · Niklas Cassel
Quoted 6 lines · Jeffrey Hugo
Amit, the merged version of the below change causes a boot failure (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly enough, it seems to be resolved if I remove the cpu-idle-states property from one of the cpu nodes.
I see no issues with the msm8998 MTP.
Quoted 8 lines
Quoted 5 lines
Hello Jeffrey, Amit,
If the PSCI idle states work properly on the msm8998 devboard (MTP), but causes crashes on msm8998 laptops, the only logical change is that the PSCI firmware is different between the two devices.
Since the msm8998 laptops boot using ACPI, perhaps these laptops doesn't support PSCI/have any PSCI firmware at all.
They have PSCI. If there was no PSCI, I would expect the PSCI
get_versionrequest from Linux to fail, and all PSCI functionality to be disabled.However, your mention about ACPI sparked a thought. ACPI describes the idle states, along with the PSCI info, in the ACPI0007 devices. Those exist on the laptops, and the info mostly correlates with Amit's patch (ACPI seems to be a bit more conservative about the latencies, and describes one additional deeper state). However, upon a detailed analysis of the ACPI description, I did find something relevant - the retention state is not enabled.
Quoted 7 lines
Quoted 3 lines
So, I hacked out the retention state from Amit's patch, and I did not observe a hang. I used sysfs, and appeared able to validate that the power collapse state was being used successfully.
Interesting that the shallower sleep state was causing problems. Usually, it is the deeper states that cause problems. So you plan to override the idle states table in the board-specific DT?
Yes. Already posted.
Quoted 2 lines
Why does the platform even rely on DT? Shouldn't we use the ACPI tables instead?
In theory, yes. However the ACPI seems to be incomplete (assumes things are just hardcoded in the driver maybe?) and has tons of non-standard things in it. DT seems to be the easy path to enablement.
Quoted 5 lines
Quoted 5 lines
I'm guessing that something is weird with the laptops, where the CPUs can go into retention, but not come out, thus causing issues.
I'll post a patch to fix up the laptops. Thanks for all the help.
PATCH v2 8/9 arm64: dts: qcom: sdm845: Add PSCI cpuidle low power states
In reply to Amit KucheriaFrom: "Raju P.L.S.S.S.N" <[email protected]>
Add device bindings for cpuidle states for cpu devices.
--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 69 ++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +69 -0
@@ -119,6 +119,7 @@ compatible = "qcom,kryo385"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_0>;
@@ -136,6 +137,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_100>;
@@ -150,6 +153,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x200>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_200>;
@@ -164,6 +169,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x300>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_300>;
@@ -178,6 +185,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x400>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_400>;
@@ -192,6 +201,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x500>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_500>;
@@ -206,6 +217,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x600>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_600>;
@@ -220,6 +233,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x700>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_700>;
@@ -228,6 +243,60 @@ next-level-cache = <&L3_0>; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-down"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <350>; + exit-latency-us = <461>; + min-residency-us = <1890>; + local-timer-stop; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-rail-power-down"; + arm,psci-suspend-param = <0x40000004>; + entry-latency-us = <360>; + exit-latency-us = <531>; + min-residency-us = <3934>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-down"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <264>; + exit-latency-us = <621>; + min-residency-us = <952>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-rail-power-down"; + arm,psci-suspend-param = <0x40000004>; + entry-latency-us = <702>; + exit-latency-us = <1061>; + min-residency-us = <4488>; + local-timer-stop; + }; + + CLUSTER_SLEEP_0: cluster-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "cluster-power-down"; + arm,psci-suspend-param = <0x400000F4>; + entry-latency-us = <3263>; + exit-latency-us = <6562>; + min-residency-us = <9987>; + local-timer-stop; + }; + }; }; pmu {
Signature · 1 line
2.17.1
Bjorn Andersson
AppliedRe: [PATCH v2 8/9] arm64: dts: qcom: sdm845: Add PSCI cpuidle low power states
Quoted 11 lines · Amit Kucheria
From: "Raju P.L.S.S.S.N" <[email protected]>
Add device bindings for cpuidle states for cpu devices.
Cc <[email protected]>Signed-off-by Raju P.L.S.S.S.N <[email protected]>Reviewed-by Evan Green <[email protected]>[amit: rename the idle-states to more generic names and fixups]Signed-off-by Amit Kucheria <[email protected]>Acked-by Daniel Lezcano <[email protected]>---
Applied
Thanks,
Bjorn
Quoted 142 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi | 69 ++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+)arch/arm64/boot/dts/qcom/sdm845.dtsi +69
-0@@ -119,6 +119,7 @@ compatible = "qcom,kryo385"; reg = <0x0 0x0>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_0>;@@ -136,6 +137,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x100>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_100>;@@ -150,6 +153,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x200>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_200>;@@ -164,6 +169,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x300>; enable-method = "psci"; + cpu-idle-states = <&LITTLE_CPU_SLEEP_0 &LITTLE_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 0>; #cooling-cells = <2>; next-level-cache = <&L2_300>;@@ -178,6 +185,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x400>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_400>;@@ -192,6 +201,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x500>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_500>;@@ -206,6 +217,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x600>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_600>;@@ -220,6 +233,8 @@ compatible = "qcom,kryo385"; reg = <0x0 0x700>; enable-method = "psci"; + cpu-idle-states = <&BIG_CPU_SLEEP_0 &BIG_CPU_SLEEP_1 + &CLUSTER_SLEEP_0>; qcom,freq-domain = <&cpufreq_hw 1>; #cooling-cells = <2>; next-level-cache = <&L2_700>;@@ -228,6 +243,60 @@ next-level-cache = <&L3_0>; }; }; + + idle-states { + entry-method = "psci"; + + LITTLE_CPU_SLEEP_0: cpu-sleep-0-0 { + compatible = "arm,idle-state"; + idle-state-name = "little-power-down"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <350>; + exit-latency-us = <461>; + min-residency-us = <1890>; + local-timer-stop; + }; + + LITTLE_CPU_SLEEP_1: cpu-sleep-0-1 { + compatible = "arm,idle-state"; + idle-state-name = "little-rail-power-down"; + arm,psci-suspend-param = <0x40000004>; + entry-latency-us = <360>; + exit-latency-us = <531>; + min-residency-us = <3934>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_0: cpu-sleep-1-0 { + compatible = "arm,idle-state"; + idle-state-name = "big-power-down"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <264>; + exit-latency-us = <621>; + min-residency-us = <952>; + local-timer-stop; + }; + + BIG_CPU_SLEEP_1: cpu-sleep-1-1 { + compatible = "arm,idle-state"; + idle-state-name = "big-rail-power-down"; + arm,psci-suspend-param = <0x40000004>; + entry-latency-us = <702>; + exit-latency-us = <1061>; + min-residency-us = <4488>; + local-timer-stop; + }; + + CLUSTER_SLEEP_0: cluster-sleep-0 { + compatible = "arm,idle-state"; + idle-state-name = "cluster-power-down"; + arm,psci-suspend-param = <0x400000F4>; + entry-latency-us = <3263>; + exit-latency-us = <6562>; + min-residency-us = <9987>; + local-timer-stop; + }; + }; }; pmu {Signature · 1 line
2.17.1
PATCH v2 9/9 arm64: dts: msm8996: Add proper capacity scaling for the cpus
In reply to Amit Kucheriamsm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
Add capacity-dmips-mhz property to allow the topology code to determine the actual capacity by taking into account the highest frequency for each CPU.
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/msm8996.dtsi +4 -0
@@ -96,6 +96,7 @@ reg = <0x0 0x0>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";
@@ -109,6 +110,7 @@ reg = <0x0 0x1>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_0>; };
@@ -118,6 +120,7 @@ reg = <0x0 0x100>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";
@@ -131,6 +134,7 @@ reg = <0x0 0x101>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_1>; };
Signature · 1 line
2.17.1
Re: [PATCH v2 9/9] arm64: dts: msm8996: Add proper capacity scaling for the cpus
Quoted 10 lines · Amit Kucheria
msm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
Add capacity-dmips-mhz property to allow the topology code to determine the actual capacity by taking into account the highest frequency for each CPU.
Signed-off-by Amit Kucheria <[email protected]>Suggested-by Daniel Lezcano <[email protected]>
Quoted 41 lines
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm64/boot/dts/qcom/msm8996.dtsi +4
-0@@ -96,6 +96,7 @@ reg = <0x0 0x0>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";@@ -109,6 +110,7 @@ reg = <0x0 0x1>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_0>; };@@ -118,6 +120,7 @@ reg = <0x0 0x100>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";@@ -131,6 +134,7 @@ reg = <0x0 0x101>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_1>; };
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Bjorn Andersson
AppliedRe: [PATCH v2 9/9] arm64: dts: msm8996: Add proper capacity scaling for the cpus
In reply to Amit KucheriaQuoted 10 lines · Amit Kucheria
msm8996 features 4 cpus - 2 in each cluster. However, all cpus implement the same microarchitecture and the two clusters only differ in the maximum frequency attainable by the CPUs.
Add capacity-dmips-mhz property to allow the topology code to determine the actual capacity by taking into account the highest frequency for each CPU.
Signed-off-by Amit Kucheria <[email protected]>Suggested-by Daniel Lezcano <[email protected]>
Applied
Regards,
Bjorn
Quoted 43 lines
--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm64/boot/dts/qcom/msm8996.dtsi +4
-0@@ -96,6 +96,7 @@ reg = <0x0 0x0>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_0>; L2_0: l2-cache { compatible = "cache";@@ -109,6 +110,7 @@ reg = <0x0 0x1>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_0>; };@@ -118,6 +120,7 @@ reg = <0x0 0x100>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_1>; L2_1: l2-cache { compatible = "cache";@@ -131,6 +134,7 @@ reg = <0x0 0x101>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + capacity-dmips-mhz = <1024>; next-level-cache = <&L2_1>; };Signature · 1 line
2.17.1